<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211022] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211022">211022</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-01-21 18:29:15 -0800 (Sat, 21 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification coalescing
https://bugs.webkit.org/show_bug.cgi?id=167286
<rdar://problem/30133211>
Reviewed by Ryosuke Niwa.
Source/WebCore:
AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification
coalescing. This patch fixes the issue.
No new tests, updated existing test.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textChanged):
LayoutTests:
Update test to use a longer timer delay. When using this longer delay, we were getting 4
AXLiveRegionChanged notifications instead of the expected 2 because
AccessibilityRenderObject::textChanged() was bypassing AXLiveRegionChanged notification
coalescing.
* accessibility/mac/aria-multiple-liveregions-notification-expected.txt:
* accessibility/mac/aria-multiple-liveregions-notification.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilitymacariamultipleliveregionsnotificationexpectedtxt">trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitymacariamultipleliveregionsnotificationhtml">trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (211021 => 211022)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-22 02:16:33 UTC (rev 211021)
+++ trunk/LayoutTests/ChangeLog 2017-01-22 02:29:15 UTC (rev 211022)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-01-21 Chris Dumez <cdumez@apple.com>
+
+ AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification coalescing
+ https://bugs.webkit.org/show_bug.cgi?id=167286
+ <rdar://problem/30133211>
+
+ Reviewed by Ryosuke Niwa.
+
+ Update test to use a longer timer delay. When using this longer delay, we were getting 4
+ AXLiveRegionChanged notifications instead of the expected 2 because
+ AccessibilityRenderObject::textChanged() was bypassing AXLiveRegionChanged notification
+ coalescing.
+
+ * accessibility/mac/aria-multiple-liveregions-notification-expected.txt:
+ * accessibility/mac/aria-multiple-liveregions-notification.html:
+
</ins><span class="cx"> 2017-01-21 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r210959): LayoutTest inspector/css/pseudo-element-matches.html timing out
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitymacariamultipleliveregionsnotificationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification-expected.txt (211021 => 211022)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification-expected.txt 2017-01-22 02:16:33 UTC (rev 211021)
+++ trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification-expected.txt 2017-01-22 02:29:15 UTC (rev 211022)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx">
</span><span class="cx"> PASS addedNotification1 is true
</span><span class="cx"> PASS addedNotification2 is true
</span><del>-PASS liveRegionChangeCount == 2 is true
</del><ins>+PASS liveRegionChangeCount is 2
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitymacariamultipleliveregionsnotificationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html (211021 => 211022)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html 2017-01-22 02:16:33 UTC (rev 211021)
+++ trunk/LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html 2017-01-22 02:29:15 UTC (rev 211022)
</span><span class="lines">@@ -34,11 +34,11 @@
</span><span class="cx">
</span><span class="cx"> liveRegion1 = accessibilityController.accessibleElementById("liveregion1");
</span><span class="cx"> var addedNotification1 = liveRegion1.addNotificationListener(ariaCallback);
</span><del>- shouldBe("addedNotification1", "true");
</del><ins>+ shouldBeTrue("addedNotification1");
</ins><span class="cx">
</span><span class="cx"> liveRegion2 = accessibilityController.accessibleElementById("liveregion2");
</span><span class="cx"> var addedNotification2 = liveRegion2.addNotificationListener(ariaCallback);
</span><del>- shouldBe("addedNotification2", "true");
</del><ins>+ shouldBeTrue("addedNotification2");
</ins><span class="cx">
</span><span class="cx"> // perform operations on both live regions.
</span><span class="cx"> textChangeOperation();
</span><span class="lines">@@ -46,8 +46,8 @@
</span><span class="cx"> alternativeChangeOperation();
</span><span class="cx"> removeElementOperation();
</span><span class="cx">
</span><del>- // add a short delay to check after all the operations if we have exactly two notificaitons
- setTimeout("finishTest()", 10);
</del><ins>+ // add a short delay to check after all the operations if we have exactly two notifications
+ setTimeout("finishTest()", 50);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function textChangeOperation() {
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx"> // We should get a total of two live region changes.
</span><span class="cx"> liveRegion1.removeNotificationListener();
</span><span class="cx"> liveRegion2.removeNotificationListener();
</span><del>- shouldBeTrue("liveRegionChangeCount == 2");
</del><ins>+ shouldBe("liveRegionChangeCount", "2");
</ins><span class="cx"> finishJSTest();
</span><span class="cx"> }
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211021 => 211022)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-22 02:16:33 UTC (rev 211021)
+++ trunk/Source/WebCore/ChangeLog 2017-01-22 02:29:15 UTC (rev 211022)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-01-21 Chris Dumez <cdumez@apple.com>
+
+ AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification coalescing
+ https://bugs.webkit.org/show_bug.cgi?id=167286
+ <rdar://problem/30133211>
+
+ Reviewed by Ryosuke Niwa.
+
+ AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification
+ coalescing. This patch fixes the issue.
+
+ No new tests, updated existing test.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::textChanged):
+
</ins><span class="cx"> 2017-01-21 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r211012.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (211021 => 211022)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2017-01-22 02:16:33 UTC (rev 211021)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2017-01-22 02:29:15 UTC (rev 211022)
</span><span class="lines">@@ -2943,7 +2943,7 @@
</span><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> if (parent->supportsARIALiveRegion())
</span><del>- cache->postNotification(renderParent, AXObjectCache::AXLiveRegionChanged);
</del><ins>+ cache->postLiveRegionChangeNotification(parent);
</ins><span class="cx">
</span><span class="cx"> if (parent->isNonNativeTextControl())
</span><span class="cx"> cache->postNotification(renderParent, AXObjectCache::AXValueChanged);
</span></span></pre>
</div>
</div>
</body>
</html>