<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[211024] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/211024">211024</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-01-21 21:48:28 -0800 (Sat, 21 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>JavaScript for-of does not work on a lot of collection types (e.g. HTMLCollection)
https://bugs.webkit.org/show_bug.cgi?id=167091
Reviewed by Darin Adler.
Source/JavaScriptCore:
Update Array methods to throw a TypeError when (this === null || this === undefined)
instead of when (this == null). This is because (this == null) returns true for types
that masquerades as undefined (such as document.all) and this prevented use of the
Array API on such types. The specification only stays to use ToObject(), which throws
when the input is undefined or null.
The corresponding specification is at:
- https://www.ecma-international.org/ecma-262/7.0/index.html#sec-array.prototype.values
- https://www.ecma-international.org/ecma-262/7.0/index.html#sec-toobject
* builtins/ArrayPrototype.js:
(values):
(keys):
(entries):
(reduce):
(reduceRight):
(every):
(forEach):
(filter):
(map):
(some):
(fill):
(find):
(findIndex):
(includes):
(sort):
(concatSlowPath):
(copyWithin):
Source/WebCore:
As per the Web IDL specification [1], https://heycam.github.io/webidl/#es-iterator
an interface should get an iterator if it has:
- an indexed property getter and an integer-typed attribute named "length".
We now comply with this part of the Web IDL specification. This adds an iterator
to the following interfaces:
- AudioTrackList, ClientRectList, CSSRuleList, CSSStyleDeclaration, CSSValueList,
MimeTypeArray, WebKitNamedFlowCollection, Plugin, PluginArray, DOMStringList,
FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement, HTMLOptionsCollection,
HTMLSelectElement, MediaList, NamedNodeMap, SourceBufferList, StyleSheetList,
TextTrackCueList, TextTrackList, TouchList, VideoTrackList, VTTRegionList.
As a result, it is now possible to use `for ... of` for those types.
Tests: fast/dom/FileList-iterator.html
fast/dom/collection-iterators.html
fast/dom/document-all-undefined.html
fast/events/touch/ios/touchlist-iterator.html
* bindings/scripts/CodeGeneratorJS.pm:
(GetAttributeWithName):
(InterfaceNeedsIterator):
(GenerateImplementation):
(addIterableProperties):
LayoutTests:
* fast/dom/FileList-iterator-expected.txt: Added.
* fast/dom/FileList-iterator.html: Added.
* fast/dom/collection-iterators-expected.txt: Added.
* fast/dom/collection-iterators.html: Added.
* fast/events/touch/ios/touchlist-iterator-expected.txt: Added.
* fast/events/touch/ios/touchlist-iterator.html: Added.
Add layout test coverage for all types that gained an iterator.
* fast/dom/document-all-undefined-expected.txt: Added.
* fast/dom/document-all-undefined.html: Added.
Add layout test to cover the fact that HTMLAllCollection masquerades as
undefined, as per:
- https://html.spec.whatwg.org/multipage/obsolete.html#dom-document-all
* inspector/model/remote-object-get-properties-expected.txt:
Rebaseline now that there is an extra Symbol.iterator property.
* platform/wk2/TestExpectations:
Skip that requires beginDragWithFiles() as this is unimplemented in
WebKitTestRunner.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectormodelremoteobjectgetpropertiesexpectedtxt">trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwk2TestExpectations">trunk/LayoutTests/platform/wk2/TestExpectations</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsArrayPrototypejs">trunk/Source/JavaScriptCore/builtins/ArrayPrototype.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestNodecpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomFileListiteratorexpectedtxt">trunk/LayoutTests/fast/dom/FileList-iterator-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomFileListiteratorhtml">trunk/LayoutTests/fast/dom/FileList-iterator.html</a></li>
<li><a href="#trunkLayoutTestsfastdomcollectioniteratorsexpectedtxt">trunk/LayoutTests/fast/dom/collection-iterators-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomcollectioniteratorshtml">trunk/LayoutTests/fast/dom/collection-iterators.html</a></li>
<li><a href="#trunkLayoutTestsfastdomdocumentallundefinedexpectedtxt">trunk/LayoutTests/fast/dom/document-all-undefined-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomdocumentallundefinedhtml">trunk/LayoutTests/fast/dom/document-all-undefined.html</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchiostouchlistiteratorexpectedtxt">trunk/LayoutTests/fast/events/touch/ios/touchlist-iterator-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchiostouchlistiteratorhtml">trunk/LayoutTests/fast/events/touch/ios/touchlist-iterator.html</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorfastdomcollectioniteratorsexpectedtxt">trunk/LayoutTests/platform/ios-simulator/fast/dom/collection-iterators-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (211023 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-22 05:19:17 UTC (rev 211023)
+++ trunk/LayoutTests/ChangeLog 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -1,5 +1,33 @@
</span><span class="cx"> 2017-01-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ JavaScript for-of does not work on a lot of collection types (e.g. HTMLCollection)
+ https://bugs.webkit.org/show_bug.cgi?id=167091
+
+ Reviewed by Darin Adler.
+
+ * fast/dom/FileList-iterator-expected.txt: Added.
+ * fast/dom/FileList-iterator.html: Added.
+ * fast/dom/collection-iterators-expected.txt: Added.
+ * fast/dom/collection-iterators.html: Added.
+ * fast/events/touch/ios/touchlist-iterator-expected.txt: Added.
+ * fast/events/touch/ios/touchlist-iterator.html: Added.
+ Add layout test coverage for all types that gained an iterator.
+
+ * fast/dom/document-all-undefined-expected.txt: Added.
+ * fast/dom/document-all-undefined.html: Added.
+ Add layout test to cover the fact that HTMLAllCollection masquerades as
+ undefined, as per:
+ - https://html.spec.whatwg.org/multipage/obsolete.html#dom-document-all
+
+ * inspector/model/remote-object-get-properties-expected.txt:
+ Rebaseline now that there is an extra Symbol.iterator property.
+
+ * platform/wk2/TestExpectations:
+ Skip that requires beginDragWithFiles() as this is unimplemented in
+ WebKitTestRunner.
+
+2017-01-21 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> innerText should replace existing text node
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=167116
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomFileListiteratorexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/FileList-iterator-expected.txt (0 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/FileList-iterator-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/FileList-iterator-expected.txt 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+
+Tests that FileList objects have an iterator.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS fileList.__proto__ is FileList.prototype
+PASS Symbol.iterator in fileList is true
+PASS forOfSucceeded is true
+PASS 'entries' in fileList is false
+PASS 'keys' in fileList is false
+PASS 'forEach' in fileList is false
+PASS 'values' in fileList is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomFileListiteratorhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/FileList-iterator.html (0 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/FileList-iterator.html (rev 0)
+++ trunk/LayoutTests/fast/dom/FileList-iterator.html 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -0,0 +1,50 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<input type="file" ondrop="dropped(event)"></input>
+<div id="console"></div>
+<script>
+description("Tests that FileList objects have an iterator.");
+jsTestIsAsync = true;
+
+function runTest()
+{
+ var inputElement = document.getElementsByTagName('input')[0];
+ eventSender.beginDragWithFiles(['test.txt']);
+ eventSender.mouseMoveTo(inputElement.offsetLeft + inputElement.offsetWidth / 2,
+ inputElement.offsetTop + inputElement.offsetHeight / 2);
+ eventSender.mouseUp();
+}
+
+function dropped(event)
+{
+ fileList = event.dataTransfer.files;
+ shouldBe("fileList.__proto__", "FileList.prototype");
+ shouldBeTrue("Symbol.iterator in fileList");
+ forOfSucceeded = false;
+ try {
+ for (var file of fileList) { }
+ forOfSucceeded = true;
+ } catch (e) {
+ forOfSucceeded = false;
+ }
+ shouldBeTrue("forOfSucceeded");
+
+ shouldBeFalse("'entries' in fileList");
+ shouldBeFalse("'keys' in fileList");
+ shouldBeFalse("'forEach' in fileList");
+ shouldBeFalse("'values' in fileList");
+
+ finishJSTest();
+}
+
+runTest();
+
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomcollectioniteratorsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/collection-iterators-expected.txt (0 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/collection-iterators-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/collection-iterators-expected.txt 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -0,0 +1,214 @@
</span><ins>+Tests that interfaces with an indexed getter and an integer-type length attribute get an iterator.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+* AudioTrackList
+PASS obj.__proto__ is AudioTrackList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* ClientRectList
+PASS obj.__proto__ is ClientRectList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* CSSRuleList
+PASS obj.__proto__ is CSSRuleList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* CSSStyleDeclaration
+PASS obj.__proto__ is CSSStyleDeclaration.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* CSSValueList
+PASS obj.__proto__ is CSSValueList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* MimeTypeArray
+PASS obj.__proto__ is MimeTypeArray.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* WebKitNamedFlowCollection
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* Plugin
+PASS obj.__proto__ is Plugin.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* PluginArray
+PASS obj.__proto__ is PluginArray.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* DOMStringList
+PASS obj.__proto__ is DOMStringList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* HTMLAllCollection
+PASS obj.__proto__ is HTMLAllCollection.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* HTMLCollection
+PASS obj.__proto__ is HTMLCollection.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* HTMLFormElement
+PASS obj.__proto__ is HTMLFormElement.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* HTMLOptionsCollection
+PASS obj.__proto__ is HTMLOptionsCollection.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* HTMLSelectElement
+PASS obj.__proto__ is HTMLSelectElement.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* MediaList
+PASS obj.__proto__ is MediaList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* NamedNodeMap
+PASS obj.__proto__ is NamedNodeMap.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* SourceBufferList
+PASS obj.__proto__ is SourceBufferList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* StyleSheetList
+PASS obj.__proto__ is StyleSheetList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* TextTrackCueList
+PASS obj.__proto__ is TextTrackCueList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* TextTrackList
+PASS obj.__proto__ is TextTrackList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* VideoTrackList
+PASS obj.__proto__ is VideoTrackList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* VTTRegionList
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomcollectioniteratorshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/collection-iterators.html (0 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/collection-iterators.html (rev 0)
+++ trunk/LayoutTests/fast/dom/collection-iterators.html 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -0,0 +1,71 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style media="screen and (min-width: 480px)">
+body {
+ background-position: 10px 20px;
+}
+</style>
+</head>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that interfaces with an indexed getter and an integer-type length attribute get an iterator.");
+
+function checkHasIterator(interfaceName, _obj)
+{
+ obj = _obj;
+ debug("* " + interfaceName);
+ if (interfaceName in window)
+ shouldBe("obj.__proto__", "" + interfaceName + ".prototype");
+ shouldBeTrue("Symbol.iterator in obj");
+ forOfSuccess = true;
+ try {
+ for (var p of obj) { }
+ } catch (e) {
+ debug("Exception: " + e);
+ forOfSuccess = false;
+ }
+ if (forOfSuccess)
+ testPassed("for..of did not throw an exception");
+ else
+ testFailed("for..of threw an exception");
+
+ shouldBeFalse("'entries' in obj");
+ shouldBeFalse("'keys' in obj");
+ shouldBeFalse("'forEach' in obj");
+ shouldBeFalse("'values' in obj");
+
+ debug("");
+}
+
+var media = document.createElement("video");
+checkHasIterator("AudioTrackList", media.audioTracks);
+checkHasIterator("ClientRectList", document.body.getClientRects());
+checkHasIterator("CSSRuleList", window.getMatchedCSSRules(document.body));
+checkHasIterator("CSSStyleDeclaration", window.getComputedStyle(document.body));
+checkHasIterator("CSSValueList", window.getComputedStyle(document.body).getPropertyCSSValue('background-position'));
+checkHasIterator("MimeTypeArray", navigator.mimeTypes);
+checkHasIterator("WebKitNamedFlowCollection", document.webkitGetNamedFlows());
+if (navigator.plugins.length)
+ checkHasIterator("Plugin", navigator.plugins[0]);
+checkHasIterator("PluginArray", navigator.plugins);
+checkHasIterator("DOMStringList", location.ancestorOrigins);
+checkHasIterator("HTMLAllCollection", document.all);
+checkHasIterator("HTMLCollection", document.getElementsByTagName("body"));
+checkHasIterator("HTMLFormElement", document.createElement("form"));
+checkHasIterator("HTMLOptionsCollection", document.createElement("select").options);
+checkHasIterator("HTMLSelectElement", document.createElement("select"));
+checkHasIterator("MediaList", document.getElementsByTagName("style")[0].sheet.media);
+checkHasIterator("NamedNodeMap", document.body.attributes);
+if ('SourceBufferList' in window)
+ checkHasIterator("SourceBufferList", (new MediaSource()).sourceBuffers);
+checkHasIterator("StyleSheetList", document.styleSheets);
+checkHasIterator("TextTrackCueList", document.createElement("video").addTextTrack("subtitles").cues);
+checkHasIterator("TextTrackList", media.textTracks);
+checkHasIterator("VideoTrackList", media.videoTracks);
+checkHasIterator("VTTRegionList", document.createElement("video").addTextTrack("subtitles").regions);
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomdocumentallundefinedexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/document-all-undefined-expected.txt (0 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/document-all-undefined-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/document-all-undefined-expected.txt 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+Tests that document.all masquerades as undefined.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS ToBoolean() returned false for document.all
+PASS document.all == undefined is true
+PASS document.all === undefined is false
+PASS document.all == null is true
+PASS document.all === null is false
+PASS typeof document.all is "undefined"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomdocumentallundefinedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/document-all-undefined.html (0 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/document-all-undefined.html (rev 0)
+++ trunk/LayoutTests/fast/dom/document-all-undefined.html 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that document.all masquerades as undefined.");
+
+if (document.all)
+ testFailed("ToBoolean() should return false for document.all");
+else
+ testPassed("ToBoolean() returned false for document.all");
+
+shouldBeTrue("document.all == undefined");
+shouldBeFalse("document.all === undefined");
+shouldBeTrue("document.all == null");
+shouldBeFalse("document.all === null");
+shouldBeEqualToString("typeof document.all", "undefined");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiostouchlistiteratorexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/touch/ios/touchlist-iterator-expected.txt (0 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/touchlist-iterator-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/touchlist-iterator-expected.txt 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+Tests that TouchList objects have an iterator
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Symbol.iterator in touchList is true
+PASS touch is touch1
+PASS 'entries' in touchList is false
+PASS 'keys' in touchList is false
+PASS 'forEach' in touchList is false
+PASS 'values' in touchList is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiostouchlistiteratorhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/touch/ios/touchlist-iterator.html (0 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/touchlist-iterator.html (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/touchlist-iterator.html 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -0,0 +1,22 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that TouchList objects have an iterator");
+
+var touch1 = new Touch(window, document.body, 1, 2, 3, 4);
+var touchList = new TouchList(touch1);
+shouldBeTrue("Symbol.iterator in touchList");
+for (var touch of touchList) {
+ shouldBe("touch", "touch1");
+}
+
+shouldBeFalse("'entries' in touchList");
+shouldBeFalse("'keys' in touchList");
+shouldBeFalse("'forEach' in touchList");
+shouldBeFalse("'values' in touchList");
+</script>
+<script src="../../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsinspectormodelremoteobjectgetpropertiesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (211023 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2017-01-22 05:19:17 UTC (rev 211023)
+++ trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -529,6 +529,7 @@
</span><span class="cx"> remove
</span><span class="cx"> item
</span><span class="cx"> namedItem
</span><ins>+ Symbol(Symbol.iterator)
</ins><span class="cx"> toString
</span><span class="cx"> toLocaleString
</span><span class="cx"> valueOf
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorfastdomcollectioniteratorsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/ios-simulator/fast/dom/collection-iterators-expected.txt (0 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/fast/dom/collection-iterators-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/fast/dom/collection-iterators-expected.txt 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -0,0 +1,196 @@
</span><ins>+Tests that interfaces with an indexed getter and an integer-type length attribute get an iterator.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+* AudioTrackList
+PASS obj.__proto__ is AudioTrackList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* ClientRectList
+PASS obj.__proto__ is ClientRectList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* CSSRuleList
+PASS obj.__proto__ is CSSRuleList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* CSSStyleDeclaration
+PASS obj.__proto__ is CSSStyleDeclaration.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* CSSValueList
+PASS obj.__proto__ is CSSValueList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* MimeTypeArray
+PASS obj.__proto__ is MimeTypeArray.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* WebKitNamedFlowCollection
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* PluginArray
+PASS obj.__proto__ is PluginArray.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* DOMStringList
+PASS obj.__proto__ is DOMStringList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* HTMLAllCollection
+PASS obj.__proto__ is HTMLAllCollection.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* HTMLCollection
+PASS obj.__proto__ is HTMLCollection.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* HTMLFormElement
+PASS obj.__proto__ is HTMLFormElement.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* HTMLOptionsCollection
+PASS obj.__proto__ is HTMLOptionsCollection.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* HTMLSelectElement
+PASS obj.__proto__ is HTMLSelectElement.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* MediaList
+PASS obj.__proto__ is MediaList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* NamedNodeMap
+PASS obj.__proto__ is NamedNodeMap.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* StyleSheetList
+PASS obj.__proto__ is StyleSheetList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* TextTrackCueList
+PASS obj.__proto__ is TextTrackCueList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* TextTrackList
+PASS obj.__proto__ is TextTrackList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* VideoTrackList
+PASS obj.__proto__ is VideoTrackList.prototype
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+* VTTRegionList
+PASS Symbol.iterator in obj is true
+PASS for..of did not throw an exception
+PASS 'entries' in obj is false
+PASS 'keys' in obj is false
+PASS 'forEach' in obj is false
+PASS 'values' in obj is false
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/wk2/TestExpectations (211023 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/wk2/TestExpectations 2017-01-22 05:19:17 UTC (rev 211023)
+++ trunk/LayoutTests/platform/wk2/TestExpectations 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -599,6 +599,7 @@
</span><span class="cx"> # https://bugs.webkit.org/show_bug.cgi?id=64285
</span><span class="cx"> editing/pasteboard/file-drag-to-editable.html
</span><span class="cx"> editing/pasteboard/file-input-files-access.html
</span><ins>+fast/dom/FileList-iterator.html
</ins><span class="cx"> fast/dom/Window/window-postmessage-clone-frames.html
</span><span class="cx"> fast/dom/Window/window-postmessage-clone.html
</span><span class="cx"> fast/events/data-transfer-files-attribute-identity.html
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (211023 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2017-01-22 05:19:17 UTC (rev 211023)
+++ trunk/Source/JavaScriptCore/ChangeLog 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -1,3 +1,39 @@
</span><ins>+2017-01-21 Chris Dumez <cdumez@apple.com>
+
+ JavaScript for-of does not work on a lot of collection types (e.g. HTMLCollection)
+ https://bugs.webkit.org/show_bug.cgi?id=167091
+
+ Reviewed by Darin Adler.
+
+ Update Array methods to throw a TypeError when (this === null || this === undefined)
+ instead of when (this == null). This is because (this == null) returns true for types
+ that masquerades as undefined (such as document.all) and this prevented use of the
+ Array API on such types. The specification only stays to use ToObject(), which throws
+ when the input is undefined or null.
+
+ The corresponding specification is at:
+ - https://www.ecma-international.org/ecma-262/7.0/index.html#sec-array.prototype.values
+ - https://www.ecma-international.org/ecma-262/7.0/index.html#sec-toobject
+
+ * builtins/ArrayPrototype.js:
+ (values):
+ (keys):
+ (entries):
+ (reduce):
+ (reduceRight):
+ (every):
+ (forEach):
+ (filter):
+ (map):
+ (some):
+ (fill):
+ (find):
+ (findIndex):
+ (includes):
+ (sort):
+ (concatSlowPath):
+ (copyWithin):
+
</ins><span class="cx"> 2017-01-21 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [JSC] export JSC::importModule API for WebCore dynamic import
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsArrayPrototypejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/ArrayPrototype.js (211023 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/ArrayPrototype.js 2017-01-22 05:19:17 UTC (rev 211023)
+++ trunk/Source/JavaScriptCore/builtins/ArrayPrototype.js 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.values requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> return new @createArrayIterator(@Object(this), "value", @arrayIteratorValueNext);
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.keys requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> return new @createArrayIterator(@Object(this), "key", @arrayIteratorKeyNext);
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.entries requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> return new @createArrayIterator(@Object(this), "key+value", @arrayIteratorKeyValueNext);
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.reduce requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -105,7 +105,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.reduceRight requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -141,7 +141,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.every requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -166,7 +166,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.forEach requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -187,7 +187,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.filter requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -236,7 +236,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.map requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -282,7 +282,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.some requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -305,7 +305,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.fill requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -345,7 +345,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.find requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -367,7 +367,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.findIndex requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -388,7 +388,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.includes requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -625,7 +625,7 @@
</span><span class="cx"> bucketSort(array, 0, strings, 0);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.sort requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span><span class="lines">@@ -651,7 +651,7 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.prototype.concat requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var currentElement = @Object(this);
</span><span class="lines">@@ -741,7 +741,7 @@
</span><span class="cx"> return (maybeNegativeZero < positive) ? maybeNegativeZero : positive;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (this == null)
</del><ins>+ if (this === null || this === @undefined)
</ins><span class="cx"> @throwTypeError("Array.copyWithin requires that |this| not be null or undefined");
</span><span class="cx">
</span><span class="cx"> var array = @Object(this);
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (211023 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-22 05:19:17 UTC (rev 211023)
+++ trunk/Source/WebCore/ChangeLog 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -1,5 +1,37 @@
</span><span class="cx"> 2017-01-21 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ JavaScript for-of does not work on a lot of collection types (e.g. HTMLCollection)
+ https://bugs.webkit.org/show_bug.cgi?id=167091
+
+ Reviewed by Darin Adler.
+
+ As per the Web IDL specification [1], https://heycam.github.io/webidl/#es-iterator
+ an interface should get an iterator if it has:
+ - an indexed property getter and an integer-typed attribute named "length".
+
+ We now comply with this part of the Web IDL specification. This adds an iterator
+ to the following interfaces:
+ - AudioTrackList, ClientRectList, CSSRuleList, CSSStyleDeclaration, CSSValueList,
+ MimeTypeArray, WebKitNamedFlowCollection, Plugin, PluginArray, DOMStringList,
+ FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement, HTMLOptionsCollection,
+ HTMLSelectElement, MediaList, NamedNodeMap, SourceBufferList, StyleSheetList,
+ TextTrackCueList, TextTrackList, TouchList, VideoTrackList, VTTRegionList.
+
+ As a result, it is now possible to use `for ... of` for those types.
+
+ Tests: fast/dom/FileList-iterator.html
+ fast/dom/collection-iterators.html
+ fast/dom/document-all-undefined.html
+ fast/events/touch/ios/touchlist-iterator.html
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GetAttributeWithName):
+ (InterfaceNeedsIterator):
+ (GenerateImplementation):
+ (addIterableProperties):
+
+2017-01-21 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> innerText should replace existing text node
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=167116
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (211023 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2017-01-22 05:19:17 UTC (rev 211023)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -2967,6 +2967,29 @@
</span><span class="cx"> return "DOMJIT::IDLResultTypeFilter<${IDLType}>::value";
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+sub GetAttributeWithName
+{
+ my ($interface, $attributeName) = @_;
+
+ foreach my $attribute (@{$interface->attributes}) {
+ return $attribute if $attribute->name eq $attributeName;
+ }
+}
+
+# https://heycam.github.io/webidl/#es-iterator
+sub InterfaceNeedsIterator
+{
+ my ($interface) = @_;
+
+ return 1 if $interface->iterable;
+ if (GetIndexedGetterFunction($interface)) {
+ my $lengthAttribute = GetAttributeWithName($interface, "length");
+ return 1 if $lengthAttribute and $codeGenerator->IsIntegerType($lengthAttribute->type);
+ }
+ # FIXME: This should return 1 for maplike and setlike once we support them.
+ return 0;
+}
+
</ins><span class="cx"> sub GenerateImplementation
</span><span class="cx"> {
</span><span class="cx"> my ($object, $interface, $enumerations, $dictionaries) = @_;
</span><span class="lines">@@ -3320,9 +3343,16 @@
</span><span class="cx"> push(@implContent, "#endif\n") if $conditionalString;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ($interface->iterable) {
- addIterableProperties($interface, $className);
</del><ins>+ if (InterfaceNeedsIterator($interface)) {
+ if (IsKeyValueIterableInterface($interface)) {
+ my $functionName = GetFunctionName($interface, $className, @{$interface->iterable->functions}[0]);
+ push(@implContent, " putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral(\"[Symbol.Iterator]\"), $functionName), DontEnum);\n");
+ } else {
+ AddToImplIncludes("<builtins/BuiltinNames.h>");
+ push(@implContent, " putDirect(vm, vm.propertyNames->iteratorSymbol, globalObject()->arrayPrototype()->getDirect(vm, vm.propertyNames->builtinNames().valuesPrivateName()), DontEnum);\n");
+ }
</ins><span class="cx"> }
</span><ins>+ push(@implContent, " addValueIterableMethods(*globalObject(), *this);\n") if $interface->iterable and !IsKeyValueIterableInterface($interface);
</ins><span class="cx">
</span><span class="cx"> addUnscopableProperties($interface);
</span><span class="cx">
</span><span class="lines">@@ -5158,24 +5188,6 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-sub addIterableProperties()
-{
- my $interface = shift;
- my $className = shift;
-
- if (NeedsRuntimeCheck($interface->iterable)) {
- my $enable_function = GetRuntimeEnableFunctionName($interface->iterable);
- push(@implContent, " if (${enable_function}())\n ");
- }
-
- if (IsKeyValueIterableInterface($interface)) {
- my $functionName = GetFunctionName($interface, $className, @{$interface->iterable->functions}[0]);
- push(@implContent, " putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral(\"[Symbol.Iterator]\"), $functionName), DontEnum);\n");
- } else {
- push(@implContent, " addValueIterableMethods(*globalObject(), *this);\n");
- }
-}
-
</del><span class="cx"> my %nativeType = (
</span><span class="cx"> "ByteString" => "String",
</span><span class="cx"> "DOMString" => "String",
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp (211023 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2017-01-22 05:19:17 UTC (rev 211023)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -144,8 +144,7 @@
</span><span class="cx"> VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
</span><span class="cx"> JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
</span><span class="cx"> }
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled())
- putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral("[Symbol.Iterator]"), jsTestNodePrototypeFunctionSymbolIterator), DontEnum);
</del><ins>+ putDirect(vm, vm.propertyNames->iteratorSymbol, JSFunction::create(vm, globalObject(), 0, ASCIILiteral("[Symbol.Iterator]"), jsTestNodePrototypeFunctionSymbolIterator), DontEnum);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const ClassInfo JSTestNode::s_info = { "TestNode", &Base::s_info, 0, CREATE_METHOD_TABLE(JSTestNode) };
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (211023 => 211024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2017-01-22 05:19:17 UTC (rev 211023)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2017-01-22 05:48:28 UTC (rev 211024)
</span><span class="lines">@@ -54,6 +54,7 @@
</span><span class="cx"> #include "Settings.h"
</span><span class="cx"> #include "URL.h"
</span><span class="cx"> #include "WebCoreJSClientData.h"
</span><ins>+#include <builtins/BuiltinNames.h>
</ins><span class="cx"> #include <inspector/ScriptArguments.h>
</span><span class="cx"> #include <inspector/ScriptCallStackFactory.h>
</span><span class="cx"> #include <runtime/Error.h>
</span><span class="lines">@@ -1897,6 +1898,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> putDirect(vm, static_cast<JSVMClientData*>(vm.clientData)->builtinNames().privateMethodPrivateName(), JSFunction::create(vm, globalObject(), 0, String(), jsTestObjPrototypeFunctionPrivateMethod), ReadOnly | DontEnum);
</span><span class="cx"> putDirect(vm, static_cast<JSVMClientData*>(vm.clientData)->builtinNames().publicAndPrivateMethodPrivateName(), JSFunction::create(vm, globalObject(), 0, String(), jsTestObjPrototypeFunctionPublicAndPrivateMethod), ReadOnly | DontEnum);
</span><ins>+ putDirect(vm, vm.propertyNames->iteratorSymbol, globalObject()->arrayPrototype()->getDirect(vm, vm.propertyNames->builtinNames().valuesPrivateName()), DontEnum);
</ins><span class="cx"> addValueIterableMethods(*globalObject(), *this);
</span><span class="cx"> JSObject& unscopables = *constructEmptyObject(globalObject()->globalExec(), globalObject()->nullPrototypeObjectStructure());
</span><span class="cx"> unscopables.putDirect(vm, Identifier::fromString(&vm, "voidMethod"), jsBoolean(true));
</span></span></pre>
</div>
</div>
</body>
</html>