<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210853] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210853">210853</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-01-18 10:37:30 -0800 (Wed, 18 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Fetch API] Update content-type in case of form data
https://bugs.webkit.org/show_bug.cgi?id=167143
Patch by Youenn Fablet <youenn@apple.com> on 2017-01-18
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
* web-platform-tests/fetch/api/basic/request-headers-expected.txt:
Source/WebCore:
Covered by rebased test.
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::extract): Adding a space to the content-type in case of form data.
LayoutTests:
* TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsfetchapibasicrequestheadersexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesfetchFetchBodycpp">trunk/Source/WebCore/Modules/fetch/FetchBody.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210852 => 210853)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-18 17:55:06 UTC (rev 210852)
+++ trunk/LayoutTests/ChangeLog 2017-01-18 18:37:30 UTC (rev 210853)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2017-01-18 Youenn Fablet <youenn@apple.com>
+
+ [Fetch API] Update content-type in case of form data
+ https://bugs.webkit.org/show_bug.cgi?id=167143
+
+ Reviewed by Alex Christensen.
+
+ * TestExpectations:
+
</ins><span class="cx"> 2017-01-18 Antoine Quint <graouts@apple.com>
</span><span class="cx">
</span><span class="cx"> [Modern Media Controls] Turn modern media controls on by default
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (210852 => 210853)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2017-01-18 17:55:06 UTC (rev 210852)
+++ trunk/LayoutTests/TestExpectations 2017-01-18 18:37:30 UTC (rev 210853)
</span><span class="lines">@@ -311,10 +311,6 @@
</span><span class="cx"> webkit.org/b/157145 imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html [ Failure Pass ]
</span><span class="cx"> webkit.org/b/161312 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context.html [ Failure Pass ]
</span><span class="cx">
</span><del>-# Flaky tests due to always changing assertion error message
-imported/w3c/web-platform-tests/fetch/api/basic/request-headers.html [ Failure ]
-imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/url-encoded.html [ Failure ]
-
</del><span class="cx"> [ Debug ] imported/w3c/web-platform-tests/fetch/api/basic/request-upload.html [ Skip ]
</span><span class="cx"> [ Debug ] imported/w3c/web-platform-tests/fetch/api/basic/request-upload-worker.html [ Skip ]
</span><span class="cx">
</span><span class="lines">@@ -326,6 +322,9 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/159724 imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm [ Failure Pass ]
</span><span class="cx">
</span><ins>+# Flaky tests due to always changing assertion error message
+imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/url-encoded.html [ Failure ]
+
</ins><span class="cx"> # New W3C ref tests that are failing.
</span><span class="cx"> webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFailure ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (210852 => 210853)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-18 17:55:06 UTC (rev 210852)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-18 18:37:30 UTC (rev 210853)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2017-01-18 Youenn Fablet <youenn@apple.com>
+
+ [Fetch API] Update content-type in case of form data
+ https://bugs.webkit.org/show_bug.cgi?id=167143
+
+ Reviewed by Alex Christensen.
+
+ * web-platform-tests/fetch/api/basic/request-headers-expected.txt:
+
</ins><span class="cx"> 2017-01-17 Youenn Fablet <youennf@gmail.com>
</span><span class="cx">
</span><span class="cx"> Refresh WPT tests up to 73f4ad361ca56d890b5f46d62c3bc84371a77e10
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsfetchapibasicrequestheadersexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt (210852 => 210853)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt 2017-01-18 17:55:06 UTC (rev 210852)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt 2017-01-18 18:37:30 UTC (rev 210853)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx"> PASS Fetch with PUT with body
</span><span class="cx"> PASS Fetch with POST without body
</span><span class="cx"> PASS Fetch with POST with text body
</span><del>-FAIL Fetch with POST with FormData body assert_true: Request should have header content-type starting with multipart/form-data; boundary=, but got multipart/form-data;boundary=----WebKitFormBoundary7HBc13pIcNoBV6R5 expected true got false
</del><ins>+PASS Fetch with POST with FormData body
</ins><span class="cx"> PASS Fetch with POST with URLSearchParams body
</span><span class="cx"> FAIL Fetch with POST with Blob body assert_equals: Request should have header content-type: null expected (object) null but got (string) ""
</span><span class="cx"> FAIL Fetch with POST with ArrayBuffer body assert_equals: Request should have header content-type: null expected (object) null but got (string) "application/x-www-form-urlencoded"
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210852 => 210853)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-18 17:55:06 UTC (rev 210852)
+++ trunk/Source/WebCore/ChangeLog 2017-01-18 18:37:30 UTC (rev 210853)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-01-18 Youenn Fablet <youenn@apple.com>
+
+ [Fetch API] Update content-type in case of form data
+ https://bugs.webkit.org/show_bug.cgi?id=167143
+
+ Reviewed by Alex Christensen.
+
+ Covered by rebased test.
+
+ * Modules/fetch/FetchBody.cpp:
+ (WebCore::FetchBody::extract): Adding a space to the content-type in case of form data.
+
</ins><span class="cx"> 2017-01-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
</span><span class="cx">
</span><span class="cx"> [GStreamer] media source tests crashing
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesfetchFetchBodycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/fetch/FetchBody.cpp (210852 => 210853)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/fetch/FetchBody.cpp 2017-01-18 17:55:06 UTC (rev 210852)
+++ trunk/Source/WebCore/Modules/fetch/FetchBody.cpp 2017-01-18 18:37:30 UTC (rev 210853)
</span><span class="lines">@@ -57,7 +57,7 @@
</span><span class="cx"> ASSERT(!context.isWorkerGlobalScope());
</span><span class="cx"> auto& domFormData = *JSDOMFormData::toWrapped(value);
</span><span class="cx"> auto formData = FormData::createMultiPart(domFormData, domFormData.encoding(), &static_cast<Document&>(context));
</span><del>- contentType = makeString("multipart/form-data;boundary=", formData->boundary().data());
</del><ins>+ contentType = makeString("multipart/form-data; boundary=", formData->boundary().data());
</ins><span class="cx"> return FetchBody(WTFMove(formData));
</span><span class="cx"> }
</span><span class="cx"> if (value.isString()) {
</span></span></pre>
</div>
</div>
</body>
</html>