<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210882] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210882">210882</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2017-01-18 13:35:30 -0800 (Wed, 18 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>background-repeat-x doesn't work
https://bugs.webkit.org/show_bug.cgi?id=166997
Reviewed by Simon Fraser.
Source/WebCore:
During the creation of the new CSS parser, we accidentally forgot
to hook up background-repeat-x and background-repeat-y.
Tests: fast/backgrounds/background-repeat-x-y-parse.html
fast/backgrounds/background-repeat-x-y.html
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
LayoutTests:
* fast/backgrounds/background-repeat-x-y-expected.html: Added.
* fast/backgrounds/background-repeat-x-y-parse-expected.txt: Added.
* fast/backgrounds/background-repeat-x-y-parse.html: Added.
* fast/backgrounds/background-repeat-x-y.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssparserCSSParserFastPathscpp">trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastbackgroundsbackgroundrepeatxyexpectedhtml">trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastbackgroundsbackgroundrepeatxyparseexpectedtxt">trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastbackgroundsbackgroundrepeatxyparsehtml">trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html</a></li>
<li><a href="#trunkLayoutTestsfastbackgroundsbackgroundrepeatxyhtml">trunk/LayoutTests/fast/backgrounds/background-repeat-x-y.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210881 => 210882)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-18 21:26:07 UTC (rev 210881)
+++ trunk/LayoutTests/ChangeLog 2017-01-18 21:35:30 UTC (rev 210882)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-01-18 Myles C. Maxfield <mmaxfield@apple.com>
+
+ background-repeat-x doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=166997
+
+ Reviewed by Simon Fraser.
+
+ * fast/backgrounds/background-repeat-x-y-expected.html: Added.
+ * fast/backgrounds/background-repeat-x-y-parse-expected.txt: Added.
+ * fast/backgrounds/background-repeat-x-y-parse.html: Added.
+ * fast/backgrounds/background-repeat-x-y.html: Added.
+
</ins><span class="cx"> 2017-01-18 Yoav Weiss <yoav@yoav.ws>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r203110): LayoutTest http/tests/preload/single_download_preload_runner.html timing out
</span></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsbackgroundrepeatxyexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-expected.html (0 => 210882)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-expected.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-expected.html 2017-01-18 21:35:30 UTC (rev 210882)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style>
+div {
+ display: inline-block;
+ width: 150px;
+ height: 150px;
+ background-image: url('resources/map.jpg');
+ background-position: top left;
+}
+</style>
+</head>
+<body>
+<p>This makes sure that background-repeat-x and background-repeat-y are rendered as expected.</p>
+<div style="background-repeat: repeat; border: 1px solid black;"></div>
+<div style="background-repeat: repeat-y; border: 1px solid black;"></div>
+<div style="background-repeat: repeat; border: 1px solid black;"></div>
+<div style="background-repeat: repeat-x; border: 1px solid black;"></div>
+<div style="background-repeat: no-repeat; border: 1px solid black;"></div>
+<div style="background-repeat: no-repeat; border: 1px solid black;"></div>
+<div style="background-repeat: no-repeat;border: 1px solid black;"></div>
+<div style="background-repeat: repeat-x; border: 1px solid black;"></div>
+<div style="background-repeat: repeat-y; border: 1px solid black;"></div>
+<div style="background-repeat: repeat; border: 1px solid black;"></div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsbackgroundrepeatxyparseexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse-expected.txt (0 => 210882)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse-expected.txt 2017-01-18 21:35:30 UTC (rev 210882)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+PASS window.getComputedStyle(document.getElementById('test1')).getPropertyValue('background-repeat') is "repeat"
+PASS window.getComputedStyle(document.getElementById('test2')).getPropertyValue('background-repeat') is "repeat-y"
+PASS window.getComputedStyle(document.getElementById('test3')).getPropertyValue('background-repeat') is "repeat"
+PASS window.getComputedStyle(document.getElementById('test4')).getPropertyValue('background-repeat') is "repeat-x"
+PASS window.getComputedStyle(document.getElementById('test5')).getPropertyValue('background-repeat') is "no-repeat"
+PASS window.getComputedStyle(document.getElementById('test6')).getPropertyValue('background-repeat') is "no-repeat"
+PASS window.getComputedStyle(document.getElementById('test7')).getPropertyValue('background-repeat') is "no-repeat"
+PASS window.getComputedStyle(document.getElementById('test8')).getPropertyValue('background-repeat') is "repeat-x"
+PASS window.getComputedStyle(document.getElementById('test9')).getPropertyValue('background-repeat') is "repeat-y"
+PASS window.getComputedStyle(document.getElementById('test10')).getPropertyValue('background-repeat') is "repeat"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<ins>+native
</ins><span class="cx">\ No newline at end of property
</span><a id="svnkeywords"></a>
<div class="addfile"><h4>Added: svn:keywords</h4></div>
<ins>+Author Date Id Rev URL
</ins><span class="cx">\ No newline at end of property
</span><a id="trunkLayoutTestsfastbackgroundsbackgroundrepeatxyparsehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html (0 => 210882)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html 2017-01-18 21:35:30 UTC (rev 210882)
</span><span class="lines">@@ -0,0 +1,40 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style>
+.test {
+ display: inline-block;
+ width: 150px;
+ height: 150px;
+ background-image: url('resources/map.jpg');
+ background-position: top left;
+}
+</style>
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<div id="test1" class="test" style="background-repeat-x: repeat; border: 1px solid black;"></div>
+<div id="test2" class="test" style="background-repeat-x: no-repeat; border: 1px solid black;"></div>
+<div id="test3" class="test" style="background-repeat-y: repeat; border: 1px solid black;"></div>
+<div id="test4" class="test" style="background-repeat-y: no-repeat; border: 1px solid black;"></div>
+<div id="test5" class="test" style="background-repeat-x: no-repeat; background-repeat-y: no-repeat; border: 1px solid black;"></div>
+<div id="test6" class="test" style="background-repeat: repeat-y; background-repeat-y: no-repeat; border: 1px solid black;"></div>
+<div id="test7" class="test" style="background-repeat: repeat-x; background-repeat-x: no-repeat; border: 1px solid black;"></div>
+<div id="test8" class="test" style="background-repeat-x: no-repeat; background-repeat: repeat-x; border: 1px solid black;"></div>
+<div id="test9" class="test" style="background-repeat-y: no-repeat; background-repeat: repeat-y; border: 1px solid black;"></div>
+<div id="test10" class="test" style="background-repeat-x: garbage; border: 1px solid black;"></div>
+<script>
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test1')).getPropertyValue('background-repeat')", "repeat");
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test2')).getPropertyValue('background-repeat')", "repeat-y");
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test3')).getPropertyValue('background-repeat')", "repeat");
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test4')).getPropertyValue('background-repeat')", "repeat-x");
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test5')).getPropertyValue('background-repeat')", "no-repeat");
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test6')).getPropertyValue('background-repeat')", "no-repeat");
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test7')).getPropertyValue('background-repeat')", "no-repeat");
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test8')).getPropertyValue('background-repeat')", "repeat-x");
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test9')).getPropertyValue('background-repeat')", "repeat-y");
+shouldBeEqualToString("window.getComputedStyle(document.getElementById('test10')).getPropertyValue('background-repeat')", "repeat");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsbackgroundrepeatxyhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/backgrounds/background-repeat-x-y.html (0 => 210882)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/background-repeat-x-y.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/background-repeat-x-y.html 2017-01-18 21:35:30 UTC (rev 210882)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style>
+div {
+ display: inline-block;
+ width: 150px;
+ height: 150px;
+ background-image: url('resources/map.jpg');
+ background-position: top left;
+}
+</style>
+</head>
+<body>
+<p>This makes sure that background-repeat-x and background-repeat-y are rendered as expected.</p>
+<div style="background-repeat-x: repeat; border: 1px solid black;"></div>
+<div style="background-repeat-x: no-repeat; border: 1px solid black;"></div>
+<div style="background-repeat-y: repeat; border: 1px solid black;"></div>
+<div style="background-repeat-y: no-repeat; border: 1px solid black;"></div>
+<div style="background-repeat-x: no-repeat; background-repeat-y: no-repeat; border: 1px solid black;"></div>
+<div style="background-repeat: repeat-x; background-repeat-x: no-repeat; border: 1px solid black;"></div>
+<div style="background-repeat: repeat-y; background-repeat-y: no-repeat; border: 1px solid black;"></div>
+<div style="background-repeat-x: no-repeat; background-repeat: repeat-x; border: 1px solid black;"></div>
+<div style="background-repeat-y: no-repeat; background-repeat: repeat-y; border: 1px solid black;"></div>
+<div style="background-repeat-x: garbage; border: 1px solid black;"></div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210881 => 210882)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-18 21:26:07 UTC (rev 210881)
+++ trunk/Source/WebCore/ChangeLog 2017-01-18 21:35:30 UTC (rev 210882)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-01-18 Myles C. Maxfield <mmaxfield@apple.com>
+
+ background-repeat-x doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=166997
+
+ Reviewed by Simon Fraser.
+
+ During the creation of the new CSS parser, we accidentally forgot
+ to hook up background-repeat-x and background-repeat-y.
+
+ Tests: fast/backgrounds/background-repeat-x-y-parse.html
+ fast/backgrounds/background-repeat-x-y.html
+
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+
</ins><span class="cx"> 2017-01-18 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> [QuickLook] Support password-protected documents
</span></span></pre></div>
<a id="trunkSourceWebCorecssparserCSSParserFastPathscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (210881 => 210882)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2017-01-18 21:26:07 UTC (rev 210881)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2017-01-18 21:35:30 UTC (rev 210882)
</span><span class="lines">@@ -930,9 +930,8 @@
</span><span class="cx"> // FIXME-NEWPARSER: Treat all as a keyword property.
</span><span class="cx"> // case CSSPropertyAll:
</span><span class="cx">
</span><del>- // FIXME-NEWPARSER: Treat the following properties as keyword properties:
- // case CSSPropertyBackgroundRepeatX:
- // case CSSPropertyBackgroundRepeatY:
</del><ins>+ case CSSPropertyBackgroundRepeatX:
+ case CSSPropertyBackgroundRepeatY:
</ins><span class="cx">
</span><span class="cx"> // FIXME-NEWPARSER: Add the following unprefixed properties:
</span><span class="cx"> // case CSSPropertyBackfaceVisibility:
</span></span></pre>
</div>
</div>
</body>
</html>