<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210831] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210831">210831</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2017-01-17 16:02:42 -0800 (Tue, 17 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Editing nested RTL-LTR content makes the process unresponsive.
https://bugs.webkit.org/show_bug.cgi?id=167140
rdar://problem/29057611
Reviewed by Ryosuke Niwa.
Source/WebCore:
Break out of the loop if we keep coming back to the same position.
This is a workaround for the underlying editing/position bug -> webkit.org/b/167138.
Test: editing/rtl-to-ltr-editing-word-move-spin.html
* editing/VisibleUnits.cpp:
(WebCore::visualWordPosition):
LayoutTests:
* editing/rtl-to-ltr-editing-word-move-spin-expected.txt: Added.
* editing/rtl-to-ltr-editing-word-move-spin.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreeditingVisibleUnitscpp">trunk/Source/WebCore/editing/VisibleUnits.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestseditingrtltoltreditingwordmovespinexpectedtxt">trunk/LayoutTests/editing/rtl-to-ltr-editing-word-move-spin-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingrtltoltreditingwordmovespinhtml">trunk/LayoutTests/editing/rtl-to-ltr-editing-word-move-spin.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210830 => 210831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-17 23:57:09 UTC (rev 210830)
+++ trunk/LayoutTests/ChangeLog 2017-01-18 00:02:42 UTC (rev 210831)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-01-17 Zalan Bujtas <zalan@apple.com>
+
+ Editing nested RTL-LTR content makes the process unresponsive.
+ https://bugs.webkit.org/show_bug.cgi?id=167140
+ rdar://problem/29057611
+
+ Reviewed by Ryosuke Niwa.
+
+ * editing/rtl-to-ltr-editing-word-move-spin-expected.txt: Added.
+ * editing/rtl-to-ltr-editing-word-move-spin.html: Added.
+
</ins><span class="cx"> 2017-01-17 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Marking http/tests/media/hls/hls-video-resize.html as flaky on mac.
</span></span></pre></div>
<a id="trunkLayoutTestseditingrtltoltreditingwordmovespinexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/editing/rtl-to-ltr-editing-word-move-spin-expected.txt (0 => 210831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/rtl-to-ltr-editing-word-move-spin-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/rtl-to-ltr-editing-word-move-spin-expected.txt 2017-01-18 00:02:42 UTC (rev 210831)
</span><span class="lines">@@ -0,0 +1,4 @@
</span><ins>+Pass if no hang.
+‫ foobar foobar‫
+
+
</ins></span></pre></div>
<a id="trunkLayoutTestseditingrtltoltreditingwordmovespinhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/editing/rtl-to-ltr-editing-word-move-spin.html (0 => 210831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/rtl-to-ltr-editing-word-move-spin.html (rev 0)
+++ trunk/LayoutTests/editing/rtl-to-ltr-editing-word-move-spin.html 2017-01-18 00:02:42 UTC (rev 210831)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This test that we can jump word by word over rtl-ltr content.</title>
+<meta http-equiv="Content-type" content="text/html; charset=utf-8">
+</head>
+<body contenteditable="true";>
+Pass if no hang.
+<div style="direction: rtl;">&#x202B foobar foobar&#x202B</div></br>
+<script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+ getSelection().setPosition(document.querySelector('div').firstChild, 2);
+ getSelection().modify('move', 'right', 'word');
+ getSelection().modify('move', 'right', 'word');
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210830 => 210831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-17 23:57:09 UTC (rev 210830)
+++ trunk/Source/WebCore/ChangeLog 2017-01-18 00:02:42 UTC (rev 210831)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-01-17 Zalan Bujtas <zalan@apple.com>
+
+ Editing nested RTL-LTR content makes the process unresponsive.
+ https://bugs.webkit.org/show_bug.cgi?id=167140
+ rdar://problem/29057611
+
+ Reviewed by Ryosuke Niwa.
+
+ Break out of the loop if we keep coming back to the same position.
+ This is a workaround for the underlying editing/position bug -> webkit.org/b/167138.
+
+ Test: editing/rtl-to-ltr-editing-word-move-spin.html
+
+ * editing/VisibleUnits.cpp:
+ (WebCore::visualWordPosition):
+
</ins><span class="cx"> 2017-01-16 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> JSCell::classInfo() shouldn't have a bunch of mitigations for being called during destruction
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingVisibleUnitscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/VisibleUnits.cpp (210830 => 210831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/VisibleUnits.cpp 2017-01-17 23:57:09 UTC (rev 210830)
+++ trunk/Source/WebCore/editing/VisibleUnits.cpp 2017-01-18 00:02:42 UTC (rev 210831)
</span><span class="lines">@@ -352,6 +352,7 @@
</span><span class="cx"> TextDirection blockDirection = directionOfEnclosingBlock(visiblePosition.deepEquivalent());
</span><span class="cx"> InlineBox* previouslyVisitedBox = nullptr;
</span><span class="cx"> VisiblePosition current = visiblePosition;
</span><ins>+ std::optional<VisiblePosition> previousPosition;
</ins><span class="cx"> UBreakIterator* iter = nullptr;
</span><span class="cx">
</span><span class="cx"> CachedLogicallyOrderedLeafBoxes leafBoxes;
</span><span class="lines">@@ -361,6 +362,9 @@
</span><span class="cx"> VisiblePosition adjacentCharacterPosition = direction == MoveRight ? current.right(true) : current.left(true);
</span><span class="cx"> if (adjacentCharacterPosition == current || adjacentCharacterPosition.isNull())
</span><span class="cx"> return VisiblePosition();
</span><ins>+ // FIXME: This is a workaround for webkit.org/b/167138.
+ if (previousPosition && adjacentCharacterPosition == previousPosition.value())
+ return VisiblePosition();
</ins><span class="cx">
</span><span class="cx"> InlineBox* box;
</span><span class="cx"> int offsetInBox;
</span><span class="lines">@@ -409,6 +413,7 @@
</span><span class="cx"> if (isWordBreak)
</span><span class="cx"> return adjacentCharacterPosition;
</span><span class="cx">
</span><ins>+ previousPosition = current;
</ins><span class="cx"> current = adjacentCharacterPosition;
</span><span class="cx"> }
</span><span class="cx"> return VisiblePosition();
</span></span></pre>
</div>
</div>
</body>
</html>