<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210674] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210674">210674</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-01-12 12:21:58 -0800 (Thu, 12 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: cubic-bezier editor behaves poorly for invalid inputs in component fields
https://bugs.webkit.org/show_bug.cgi?id=166928
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2017-01-12
Reviewed by Brian Burg.
* UserInterface/Views/BezierEditor.css:
(.bezier-editor):
(.bezier-editor > .number-input-container > input):
* UserInterface/Views/BezierEditor.js:
(WebInspector.BezierEditor.createBezierInput):
(WebInspector.BezierEditor):
Add type, step, min, and max to the bezier component inputs to better control user input.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsBezierEditorcss">trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsBezierEditorjs">trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (210673 => 210674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2017-01-12 19:32:20 UTC (rev 210673)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-01-12 20:21:58 UTC (rev 210674)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-01-12 Devin Rousso <dcrousso+webkit@gmail.com>
+
+ Web Inspector: cubic-bezier editor behaves poorly for invalid inputs in component fields
+ https://bugs.webkit.org/show_bug.cgi?id=166928
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/BezierEditor.css:
+ (.bezier-editor):
+ (.bezier-editor > .number-input-container > input):
+
+ * UserInterface/Views/BezierEditor.js:
+ (WebInspector.BezierEditor.createBezierInput):
+ (WebInspector.BezierEditor):
+ Add type, step, min, and max to the bezier component inputs to better control user input.
+
</ins><span class="cx"> 2017-01-11 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Add another Protocol Version
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsBezierEditorcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css (210673 => 210674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css 2017-01-12 19:32:20 UTC (rev 210673)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css 2017-01-12 20:21:58 UTC (rev 210674)
</span><span class="lines">@@ -25,7 +25,7 @@
</span><span class="cx">
</span><span class="cx"> .bezier-editor {
</span><span class="cx"> width: 200px;
</span><del>- height: 260px;
</del><ins>+ height: 258px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .bezier-editor > .bezier-preview {
</span><span class="lines">@@ -107,10 +107,10 @@
</span><span class="cx">
</span><span class="cx"> .bezier-editor > .number-input-container > input {
</span><span class="cx"> width: 100%;
</span><del>- margin: 0 5px;
- padding: 1px 2px 1px 1px;
</del><ins>+ margin: 0 2px;
+ padding: 1px 0 1px 1px;
</ins><span class="cx"> text-align: right;
</span><del>- font-size: 13px;
</del><ins>+ font-size: 12px;
</ins><span class="cx"> background-color: white;
</span><span class="cx"> border: 1px solid hsl(0, 0%, 60%);
</span><span class="cx"> border-radius: 4px;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsBezierEditorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.js (210673 => 210674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.js 2017-01-12 19:32:20 UTC (rev 210673)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.js 2017-01-12 20:21:58 UTC (rev 210674)
</span><span class="lines">@@ -88,18 +88,27 @@
</span><span class="cx">
</span><span class="cx"> this._numberInputContainer = this._element.createChild("div", "number-input-container");
</span><span class="cx">
</span><del>- function createBezierInput(id, className)
</del><ins>+ function createBezierInput(id, {min, max} = {})
</ins><span class="cx"> {
</span><span class="cx"> let key = "_bezier" + id + "Input";
</span><del>- this[key] = this._numberInputContainer.createChild("input", className);
</del><ins>+ this[key] = this._numberInputContainer.createChild("input");
+ this[key].type = "number";
+ this[key].step = 0.01;
+
+ if (!isNaN(min))
+ this[key].min = min;
+
+ if (!isNaN(max))
+ this[key].max = max;
+
</ins><span class="cx"> this[key].addEventListener("input", this.debounce(250)._handleNumberInputInput);
</span><span class="cx"> this[key].addEventListener("keydown", this._handleNumberInputKeydown.bind(this));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- createBezierInput.call(this, "InX", "in-x");
- createBezierInput.call(this, "InY", "in-y");
- createBezierInput.call(this, "OutX", "out-x");
- createBezierInput.call(this, "OutY", "out-y");
</del><ins>+ createBezierInput.call(this, "InX", {min: 0, max: 1});
+ createBezierInput.call(this, "InY");
+ createBezierInput.call(this, "OutX", {min: 0, max: 1});
+ createBezierInput.call(this, "OutY");
</ins><span class="cx">
</span><span class="cx"> this._selectedControl = null;
</span><span class="cx"> this._mouseDownPosition = null;
</span></span></pre>
</div>
</div>
</body>
</html>