<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210616] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210616">210616</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-01-11 18:44:30 -0800 (Wed, 11 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove request.formData property until it gets implemented
https://bugs.webkit.org/show_bug.cgi?id=166920
<rdar://problem/29971105>
Patch by Youenn Fablet <youenn@apple.com> on 2017-01-11
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
* web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
* web-platform-tests/fetch/api/request/request-consume-expected.txt:
* web-platform-tests/fetch/api/request/request-idl-expected.txt:
* web-platform-tests/fetch/api/request/request-structure-expected.txt:
Source/WebCore:
Covered by rebased tests.
* Modules/fetch/FetchBody.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsfetchapirequestrequestconsumeemptyexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsfetchapirequestrequestconsumeexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsfetchapirequestrequestidlexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsfetchapirequestrequeststructureexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-structure-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesfetchFetchBodyidl">trunk/Source/WebCore/Modules/fetch/FetchBody.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (210615 => 210616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-12 02:08:39 UTC (rev 210615)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-12 02:44:30 UTC (rev 210616)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-01-11 Youenn Fablet <youenn@apple.com>
+
+ Remove request.formData property until it gets implemented
+ https://bugs.webkit.org/show_bug.cgi?id=166920
+ <rdar://problem/29971105>
+
+ Reviewed by Chris Dumez.
+
+ * web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
+ * web-platform-tests/fetch/api/request/request-consume-expected.txt:
+ * web-platform-tests/fetch/api/request/request-idl-expected.txt:
+ * web-platform-tests/fetch/api/request/request-structure-expected.txt:
+
</ins><span class="cx"> 2017-01-11 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Iterating over URLSearchParams does not work
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsfetchapirequestrequestconsumeemptyexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt (210615 => 210616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt 2017-01-12 02:08:39 UTC (rev 210615)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt 2017-01-12 02:44:30 UTC (rev 210616)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> PASS Consume request's body as blob
</span><span class="cx"> PASS Consume request's body as arrayBuffer
</span><span class="cx"> PASS Consume request's body as json
</span><del>-FAIL Consume request's body as formData promise_test: Unhandled rejection with value: undefined
</del><ins>+FAIL Consume request's body as formData request.formData is not a function. (In 'request.formData()', 'request.formData' is undefined)
</ins><span class="cx"> PASS Consume empty blob request body as arrayBuffer
</span><span class="cx"> PASS Consume empty text request body as arrayBuffer
</span><span class="cx"> PASS Consume empty blob request body as text
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsfetchapirequestrequestconsumeexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt (210615 => 210616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt 2017-01-12 02:08:39 UTC (rev 210615)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt 2017-01-12 02:44:30 UTC (rev 210616)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx"> PASS Consume DataView request's body as blob
</span><span class="cx"> PASS Consume DataView request's body as arrayBuffer
</span><span class="cx"> PASS Consume DataView request's body as JSON
</span><del>-FAIL Consume FormData request's body as FormData promise_test: Unhandled rejection with value: undefined
</del><ins>+FAIL Consume FormData request's body as FormData request.formData is not a function. (In 'request.formData()', 'request.formData' is undefined)
</ins><span class="cx"> PASS Consume blob response's body as blob
</span><span class="cx"> PASS Consume blob response's body as text
</span><span class="cx"> PASS Consume blob response's body as json
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsfetchapirequestrequestidlexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl-expected.txt (210615 => 210616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl-expected.txt 2017-01-12 02:08:39 UTC (rev 210615)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl-expected.txt 2017-01-12 02:44:30 UTC (rev 210616)
</span><span class="lines">@@ -20,7 +20,7 @@
</span><span class="cx"> PASS Request interface: attribute bodyUsed
</span><span class="cx"> PASS Request interface: operation arrayBuffer()
</span><span class="cx"> PASS Request interface: operation blob()
</span><del>-PASS Request interface: operation formData()
</del><ins>+FAIL Request interface: operation formData() assert_own_property: interface prototype object missing non-static operation expected property "formData" missing
</ins><span class="cx"> PASS Request interface: operation json()
</span><span class="cx"> PASS Request interface: operation text()
</span><span class="cx"> PASS Request must be primary interface of new Request("")
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> PASS Request interface: new Request("") must inherit property "bodyUsed" with the proper type (13)
</span><span class="cx"> PASS Request interface: new Request("") must inherit property "arrayBuffer" with the proper type (14)
</span><span class="cx"> PASS Request interface: new Request("") must inherit property "blob" with the proper type (15)
</span><del>-PASS Request interface: new Request("") must inherit property "formData" with the proper type (16)
</del><ins>+FAIL Request interface: new Request("") must inherit property "formData" with the proper type (16) assert_inherits: property "formData" not found in prototype chain
</ins><span class="cx"> PASS Request interface: new Request("") must inherit property "json" with the proper type (17)
</span><span class="cx"> PASS Request interface: new Request("") must inherit property "text" with the proper type (18)
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsfetchapirequestrequeststructureexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-structure-expected.txt (210615 => 210616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-structure-expected.txt 2017-01-12 02:08:39 UTC (rev 210615)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-structure-expected.txt 2017-01-12 02:44:30 UTC (rev 210616)
</span><span class="lines">@@ -2,7 +2,7 @@
</span><span class="cx"> PASS Request has clone method
</span><span class="cx"> PASS Request has arrayBuffer method
</span><span class="cx"> PASS Request has blob method
</span><del>-PASS Request has formData method
</del><ins>+FAIL Request has formData method assert_true: request has formData method expected true got false
</ins><span class="cx"> PASS Request has json method
</span><span class="cx"> PASS Request has text method
</span><span class="cx"> PASS Check method attribute
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210615 => 210616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-12 02:08:39 UTC (rev 210615)
+++ trunk/Source/WebCore/ChangeLog 2017-01-12 02:44:30 UTC (rev 210616)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-01-11 Youenn Fablet <youenn@apple.com>
+
+ Remove request.formData property until it gets implemented
+ https://bugs.webkit.org/show_bug.cgi?id=166920
+ <rdar://problem/29971105>
+
+ Reviewed by Chris Dumez.
+
+ Covered by rebased tests.
+
+ * Modules/fetch/FetchBody.idl:
+
</ins><span class="cx"> 2017-01-11 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Reverting r210598, r210597, and r210591 to fix the iOS simulator build.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesfetchFetchBodyidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/fetch/FetchBody.idl (210615 => 210616)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/fetch/FetchBody.idl 2017-01-12 02:08:39 UTC (rev 210615)
+++ trunk/Source/WebCore/Modules/fetch/FetchBody.idl 2017-01-12 02:44:30 UTC (rev 210616)
</span><span class="lines">@@ -37,7 +37,8 @@
</span><span class="cx"> [ImplementedAs=isDisturbed] readonly attribute boolean bodyUsed;
</span><span class="cx"> [NewObject] Promise<ArrayBuffer> arrayBuffer();
</span><span class="cx"> [NewObject] Promise<Blob> blob();
</span><del>- [NewObject] Promise<Blob> formData();
</del><ins>+ // FIXME: Add support for form data consumption (https://bugs.webkit.org/show_bug.cgi?id=161190).
+ //[NewObject] Promise<DOMFormData> formData();
</ins><span class="cx"> [NewObject] Promise<any> json();
</span><span class="cx"> [NewObject] Promise<USVString> text();
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>