<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210495] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210495">210495</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2017-01-07 22:02:25 -0800 (Sat, 07 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Avoid triggering rebuilds for minor changes of CSSProperties.json
https://bugs.webkit.org/show_bug.cgi?id=166810
Post-review cleanup suggested by Darin Adler.
* css/makeprop.pl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssmakeproppl">trunk/Source/WebCore/css/makeprop.pl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210494 => 210495)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-08 01:22:46 UTC (rev 210494)
+++ trunk/Source/WebCore/ChangeLog 2017-01-08 06:02:25 UTC (rev 210495)
</span><span class="lines">@@ -3,6 +3,15 @@
</span><span class="cx"> Avoid triggering rebuilds for minor changes of CSSProperties.json
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=166810
</span><span class="cx">
</span><ins>+ Post-review cleanup suggested by Darin Adler.
+
+ * css/makeprop.pl:
+
+2017-01-07 Simon Fraser <simon.fraser@apple.com>
+
+ Avoid triggering rebuilds for minor changes of CSSProperties.json
+ https://bugs.webkit.org/show_bug.cgi?id=166810
+
</ins><span class="cx"> Reviewed by Daniel Bates.
</span><span class="cx">
</span><span class="cx"> We expect to make lots of metadata-related changes to CSSProperties.json, and
</span></span></pre></div>
<a id="trunkSourceWebCorecssmakeproppl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/makeprop.pl (210494 => 210495)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/makeprop.pl 2017-01-08 01:22:46 UTC (rev 210494)
+++ trunk/Source/WebCore/css/makeprop.pl 2017-01-08 06:02:25 UTC (rev 210495)
</span><span class="lines">@@ -180,7 +180,7 @@
</span><span class="cx"> sub replaceFileIfChanged($$)
</span><span class="cx"> {
</span><span class="cx"> my ($tempFile, $file) = @_;
</span><del>-
</del><ins>+
</ins><span class="cx"> if (compare($tempFile, $file) != 0) {
</span><span class="cx"> copy($tempFile, $file) or die "Failed to copy $tempFile to $file: $!";
</span><span class="cx"> }
</span><span class="lines">@@ -189,7 +189,7 @@
</span><span class="cx">
</span><span class="cx"> my $gperfTempFile = "CSSPropertyNames.gperf.tmp";
</span><span class="cx">
</span><del>-open GPERF, ">$gperfTempFile" || die "Could not open $gperfTempFile for writing";
</del><ins>+open GPERF, ">", $gperfTempFile or die "Could not open $gperfTempFile for writing";
</ins><span class="cx"> print GPERF << "EOF";
</span><span class="cx"> %{
</span><span class="cx"> /* This file is automatically generated from $inputFile by makeprop, do not edit */
</span><span class="lines">@@ -348,9 +348,9 @@
</span><span class="cx">
</span><span class="cx"> replaceFileIfChanged($gperfTempFile, "CSSPropertyNames.gperf");
</span><span class="cx">
</span><del>-my $properyNamesHeaderTempFile = "CSSPropertyNames.h.tmp";
</del><ins>+my $propertyNamesHeaderTempFile = "CSSPropertyNames.h.tmp";
</ins><span class="cx">
</span><del>-open HEADER, ">$properyNamesHeaderTempFile" || die "Could not open $properyNamesHeaderTempFile for writing";
</del><ins>+open HEADER, ">", $propertyNamesHeaderTempFile or die "Could not open $propertyNamesHeaderTempFile for writing";
</ins><span class="cx"> print HEADER << "EOF";
</span><span class="cx"> /* This file is automatically generated from $inputFile by makeprop, do not edit */
</span><span class="cx">
</span><span class="lines">@@ -423,7 +423,7 @@
</span><span class="cx">
</span><span class="cx"> close HEADER;
</span><span class="cx">
</span><del>-replaceFileIfChanged($properyNamesHeaderTempFile, "CSSPropertyNames.h");
</del><ins>+replaceFileIfChanged($propertyNamesHeaderTempFile, "CSSPropertyNames.h");
</ins><span class="cx">
</span><span class="cx"> #
</span><span class="cx"> # StyleBuilder.cpp generator.
</span><span class="lines">@@ -916,7 +916,7 @@
</span><span class="cx">
</span><span class="cx"> my $styleBuilderTempFile = "StyleBuilder.cpp.tmp";
</span><span class="cx">
</span><del>-open STYLEBUILDER, ">$styleBuilderTempFile" || die "Could not open $styleBuilderTempFile for writing";
</del><ins>+open STYLEBUILDER, ">", $styleBuilderTempFile or die "Could not open $styleBuilderTempFile for writing";
</ins><span class="cx"> print STYLEBUILDER << "EOF";
</span><span class="cx"> /* This file is automatically generated from $inputFile by makeprop, do not edit */
</span><span class="cx">
</span><span class="lines">@@ -996,7 +996,7 @@
</span><span class="cx">
</span><span class="cx"> my $stylePropertyShorthandFunctionsHeaderTempFile = "StylePropertyShorthandFunctions.h.tmp";
</span><span class="cx">
</span><del>-open SHORTHANDS_H, ">$stylePropertyShorthandFunctionsHeaderTempFile" || die "Could not open $stylePropertyShorthandFunctionsHeaderTempFile for writing";
</del><ins>+open SHORTHANDS_H, ">", $stylePropertyShorthandFunctionsHeaderTempFile or die "Could not open $stylePropertyShorthandFunctionsHeaderTempFile for writing";
</ins><span class="cx"> print SHORTHANDS_H << "EOF";
</span><span class="cx"> /* This file is automatically generated from $inputFile by makeprop, do not edit */
</span><span class="cx">
</span><span class="lines">@@ -1028,7 +1028,7 @@
</span><span class="cx">
</span><span class="cx"> my $stylePropertyShorthandFunctionsTempFile = "StylePropertyShorthandFunctions.cpp.tmp";
</span><span class="cx">
</span><del>-open SHORTHANDS_CPP, ">$stylePropertyShorthandFunctionsTempFile" || die "Could not open $stylePropertyShorthandFunctionsTempFile for writing";
</del><ins>+open SHORTHANDS_CPP, ">", $stylePropertyShorthandFunctionsTempFile or die "Could not open $stylePropertyShorthandFunctionsTempFile for writing";
</ins><span class="cx"> print SHORTHANDS_CPP << "EOF";
</span><span class="cx"> /* This file is automatically generated from $inputFile by makeprop, do not edit */
</span><span class="cx">
</span><span class="lines">@@ -1146,4 +1146,4 @@
</span><span class="cx"> if (not $gperf) {
</span><span class="cx"> $gperf = $ENV{GPERF} ? $ENV{GPERF} : "gperf";
</span><span class="cx"> }
</span><del>-system("\"$gperf\" --key-positions=\"*\" -D -n -s 2 CSSPropertyNames.gperf --output-file=CSSPropertyNames.cpp") == 0 || die "calling gperf failed: $?";
</del><ins>+system("\"$gperf\" --key-positions=\"*\" -D -n -s 2 CSSPropertyNames.gperf --output-file=CSSPropertyNames.cpp") == 0 or die "calling gperf failed: $?";
</ins></span></pre>
</div>
</div>
</body>
</html>