<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210434] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210434">210434</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2017-01-06 01:16:17 -0800 (Fri, 06 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Warning about unconnectable outlets when opening a MiniBrowser window
https://bugs.webkit.org/show_bug.cgi?id=166756
Reviewed by Dan Bernstein.
* MiniBrowser/mac/BrowserWindow.xib:
When launching MiniBrowser, it says:
Failed to connect (Share) outlet from (WK1BrowserWindowController) to
(MBToolbarItem): missing setter or instance variable
Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
(NSButtonCell): missing setter or instance variable.
It looks like someone added the connection from the share button
to the BrowserWindowController three times; only one of the connections
is valid. Remove the other two.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsMiniBrowsermacBrowserWindowxib">trunk/Tools/MiniBrowser/mac/BrowserWindow.xib</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (210433 => 210434)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-01-06 04:09:49 UTC (rev 210433)
+++ trunk/Tools/ChangeLog 2017-01-06 09:16:17 UTC (rev 210434)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2017-01-06 Tim Horton <timothy_horton@apple.com>
+
+ Warning about unconnectable outlets when opening a MiniBrowser window
+ https://bugs.webkit.org/show_bug.cgi?id=166756
+
+ Reviewed by Dan Bernstein.
+
+ * MiniBrowser/mac/BrowserWindow.xib:
+ When launching MiniBrowser, it says:
+ Failed to connect (Share) outlet from (WK1BrowserWindowController) to
+ (MBToolbarItem): missing setter or instance variable
+ Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
+ (NSButtonCell): missing setter or instance variable.
+
+ It looks like someone added the connection from the share button
+ to the BrowserWindowController three times; only one of the connections
+ is valid. Remove the other two.
+
</ins><span class="cx"> 2017-01-05 Keith Rollin <krollin@apple.com>
</span><span class="cx">
</span><span class="cx"> Add WebCore::URL::protocolHostAndPort
</span></span></pre></div>
<a id="trunkToolsMiniBrowsermacBrowserWindowxib"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/mac/BrowserWindow.xib (210433 => 210434)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/mac/BrowserWindow.xib 2017-01-06 04:09:49 UTC (rev 210433)
+++ trunk/Tools/MiniBrowser/mac/BrowserWindow.xib 2017-01-06 09:16:17 UTC (rev 210434)
</span><span class="lines">@@ -7,7 +7,6 @@
</span><span class="cx"> <objects>
</span><span class="cx"> <customObject id="-2" userLabel="File's Owner" customClass="BrowserWindowController">
</span><span class="cx"> <connections>
</span><del>- <outlet property="Share" destination="dJx-dw-gcC" id="j0J-ps-exa"/>
</del><span class="cx"> <outlet property="backButton" destination="40" id="46"/>
</span><span class="cx"> <outlet property="containerView" destination="9" id="37"/>
</span><span class="cx"> <outlet property="findPanelWindow" destination="70" id="77"/>
</span><span class="lines">@@ -15,7 +14,6 @@
</span><span class="cx"> <outlet property="progressIndicator" destination="21" id="33"/>
</span><span class="cx"> <outlet property="reloadButton" destination="23" id="34"/>
</span><span class="cx"> <outlet property="share" destination="1hB-AH-eUl" id="si4-8e-DsM"/>
</span><del>- <outlet property="shareButton" destination="S1v-UD-QhI" id="t4L-Uq-paq"/>
</del><span class="cx"> <outlet property="toggleUseShrinkToFitButton" destination="82" id="9w7-AB-Ye3"/>
</span><span class="cx"> <outlet property="toolbar" destination="48" id="67"/>
</span><span class="cx"> <outlet property="urlText" destination="10" id="32"/>
</span></span></pre>
</div>
</div>
</body>
</html>