<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210295] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210295">210295</a></dd>
<dt>Author</dt> <dd>n_wang@apple.com</dd>
<dt>Date</dt> <dd>2017-01-04 15:07:13 -0800 (Wed, 04 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>Many new HTML5 input types still exposed as generic AXTextfield
https://bugs.webkit.org/show_bug.cgi?id=109017
<rdar://problem/13658955>
Reviewed by Chris Fleizach.
Source/WebCore:
Provided more detailed role description for input types that
are exposed as standard text fields on the mac.
Changes are covered in modified test expectation.
* English.lproj/Localizable.strings:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):
* platform/LocalizedStrings.cpp:
(WebCore::AXDateTimeFieldText):
(WebCore::AXMonthFieldText):
(WebCore::AXNumberFieldText):
(WebCore::AXWeekFieldText):
* platform/LocalizedStrings.h:
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXDateTimeFieldText):
(WebCore::AXMonthFieldText):
(WebCore::AXNumberFieldText):
(WebCore::AXWeekFieldText):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXDateTimeFieldText):
(WebCore::AXMonthFieldText):
(WebCore::AXNumberFieldText):
(WebCore::AXWeekFieldText):
LayoutTests:
* platform/mac/accessibility/roles-exposed-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityrolesexposedexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreEnglishlprojLocalizablestrings">trunk/Source/WebCore/English.lproj/Localizable.strings</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformLocalizedStringscpp">trunk/Source/WebCore/platform/LocalizedStrings.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformLocalizedStringsh">trunk/Source/WebCore/platform/LocalizedStrings.h</a></li>
<li><a href="#trunkSourceWebCoreplatformeflLocalizedStringsEflcpp">trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgtkLocalizedStringsGtkcpp">trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210294 => 210295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-04 23:05:25 UTC (rev 210294)
+++ trunk/LayoutTests/ChangeLog 2017-01-04 23:07:13 UTC (rev 210295)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2017-01-04 Nan Wang <n_wang@apple.com>
+
+ Many new HTML5 input types still exposed as generic AXTextfield
+ https://bugs.webkit.org/show_bug.cgi?id=109017
+ <rdar://problem/13658955>
+
+ Reviewed by Chris Fleizach.
+
+ * platform/mac/accessibility/roles-exposed-expected.txt:
+
</ins><span class="cx"> 2017-01-04 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Assertion hit on redfin.com: ASSERTION FAILED: collection->length() > 1
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityrolesexposedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt (210294 => 210295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2017-01-04 23:05:25 UTC (rev 210294)
+++ trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2017-01-04 23:07:13 UTC (rev 210295)
</span><span class="lines">@@ -247,7 +247,7 @@
</span><span class="cx"> input[type='datetime-local']
</span><span class="cx"> AXRole: AXTextField
</span><span class="cx"> AXSubrole:
</span><del>- AXRoleDescription: text field
</del><ins>+ AXRoleDescription: date and time field
</ins><span class="cx">
</span><span class="cx"> input[type='email']
</span><span class="cx"> AXRole: AXTextField
</span><span class="lines">@@ -272,12 +272,12 @@
</span><span class="cx"> input[type='month']
</span><span class="cx"> AXRole: AXTextField
</span><span class="cx"> AXSubrole:
</span><del>- AXRoleDescription: text field
</del><ins>+ AXRoleDescription: month and year field
</ins><span class="cx">
</span><span class="cx"> input[type='number']
</span><span class="cx"> AXRole: AXTextField
</span><span class="cx"> AXSubrole:
</span><del>- AXRoleDescription: text field
</del><ins>+ AXRoleDescription: number field
</ins><span class="cx">
</span><span class="cx"> input[type='password']
</span><span class="cx"> AXRole: AXTextField
</span><span class="lines">@@ -332,7 +332,7 @@
</span><span class="cx"> input[type='week']
</span><span class="cx"> AXRole: AXTextField
</span><span class="cx"> AXSubrole:
</span><del>- AXRoleDescription: text field
</del><ins>+ AXRoleDescription: week and year field
</ins><span class="cx">
</span><span class="cx"> ins:not([datetime])
</span><span class="cx"> AXRole: AXGroup
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210294 => 210295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2017-01-04 23:05:25 UTC (rev 210294)
+++ trunk/Source/WebCore/ChangeLog 2017-01-04 23:07:13 UTC (rev 210295)
</span><span class="lines">@@ -1,3 +1,36 @@
</span><ins>+2017-01-04 Nan Wang <n_wang@apple.com>
+
+ Many new HTML5 input types still exposed as generic AXTextfield
+ https://bugs.webkit.org/show_bug.cgi?id=109017
+ <rdar://problem/13658955>
+
+ Reviewed by Chris Fleizach.
+
+ Provided more detailed role description for input types that
+ are exposed as standard text fields on the mac.
+
+ Changes are covered in modified test expectation.
+
+ * English.lproj/Localizable.strings:
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper roleDescription]):
+ * platform/LocalizedStrings.cpp:
+ (WebCore::AXDateTimeFieldText):
+ (WebCore::AXMonthFieldText):
+ (WebCore::AXNumberFieldText):
+ (WebCore::AXWeekFieldText):
+ * platform/LocalizedStrings.h:
+ * platform/efl/LocalizedStringsEfl.cpp:
+ (WebCore::AXDateTimeFieldText):
+ (WebCore::AXMonthFieldText):
+ (WebCore::AXNumberFieldText):
+ (WebCore::AXWeekFieldText):
+ * platform/gtk/LocalizedStringsGtk.cpp:
+ (WebCore::AXDateTimeFieldText):
+ (WebCore::AXMonthFieldText):
+ (WebCore::AXNumberFieldText):
+ (WebCore::AXWeekFieldText):
+
</ins><span class="cx"> 2017-01-04 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove bindings/generic and distribute its contents appropriately
</span></span></pre></div>
<a id="trunkSourceWebCoreEnglishlprojLocalizablestrings"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (210294 => 210295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/English.lproj/Localizable.strings 2017-01-04 23:05:25 UTC (rev 210294)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2017-01-04 23:07:13 UTC (rev 210295)
</span><span class="lines">@@ -850,6 +850,9 @@
</span><span class="cx"> /* accessibility role description for a date field. */
</span><span class="cx"> "date field" = "date field";
</span><span class="cx">
</span><ins>+/* accessibility role description for a date and time field */
+"date and time field" = "date and time field";
+
</ins><span class="cx"> /* role description of ARIA definition role */
</span><span class="cx"> "definition" = "definition";
</span><span class="cx">
</span><span class="lines">@@ -952,6 +955,9 @@
</span><span class="cx"> /* HTTP result code string */
</span><span class="cx"> "method not allowed" = "method not allowed";
</span><span class="cx">
</span><ins>+/* accessibility role description for a month field. */
+"month and year field" = "month and year field";
+
</ins><span class="cx"> /* HTTP result code string */
</span><span class="cx"> "moved permanently" = "moved permanently";
</span><span class="cx">
</span><span class="lines">@@ -1012,6 +1018,9 @@
</span><span class="cx"> /* An ARIA accessibility group that acts as a note in a document. */
</span><span class="cx"> "note" = "note";
</span><span class="cx">
</span><ins>+/* accessibility role description for a number field. */
+"number field" = "number field";
+
</ins><span class="cx"> /* accessibility help text for remaining time display */
</span><span class="cx"> "number of seconds of movie remaining" = "number of seconds of movie remaining";
</span><span class="cx">
</span><span class="lines">@@ -1201,6 +1210,9 @@
</span><span class="cx"> /* An ARIA accessibility group that acts as an dialog. */
</span><span class="cx"> "web dialog" = "web dialog";
</span><span class="cx">
</span><ins>+/* accessibility role description for a week field. */
+"week and year field" = "week and year field";
+
</ins><span class="cx"> /* Option in segmented control for choosing list type in text editing */
</span><span class="cx"> "•" = "•";
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (210294 => 210295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2017-01-04 23:05:25 UTC (rev 210294)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2017-01-04 23:07:13 UTC (rev 210295)
</span><span class="lines">@@ -2532,6 +2532,8 @@
</span><span class="cx"> return AXTelephoneFieldText();
</span><span class="cx"> if (input.isURLField())
</span><span class="cx"> return AXURLFieldText();
</span><ins>+ if (input.isNumberField())
+ return AXNumberFieldText();
</ins><span class="cx">
</span><span class="cx"> // These input types are not enabled on mac yet, we check the type attribute for now.
</span><span class="cx"> auto& type = input.attributeWithoutSynchronization(typeAttr);
</span><span class="lines">@@ -2539,6 +2541,12 @@
</span><span class="cx"> return AXDateFieldText();
</span><span class="cx"> if (equalLettersIgnoringASCIICase(type, "time"))
</span><span class="cx"> return AXTimeFieldText();
</span><ins>+ if (equalLettersIgnoringASCIICase(type, "week"))
+ return AXWeekFieldText();
+ if (equalLettersIgnoringASCIICase(type, "month"))
+ return AXMonthFieldText();
+ if (equalLettersIgnoringASCIICase(type, "datetime-local"))
+ return AXDateTimeFieldText();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformLocalizedStringscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (210294 => 210295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/LocalizedStrings.cpp 2017-01-04 23:05:25 UTC (rev 210294)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp 2017-01-04 23:07:13 UTC (rev 210295)
</span><span class="lines">@@ -675,6 +675,26 @@
</span><span class="cx"> return WEB_UI_STRING("time field", "accessibility role description for a time field.");
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+String AXDateTimeFieldText()
+{
+ return WEB_UI_STRING("date and time field", "accessibility role description for a date and time field.");
+}
+
+String AXMonthFieldText()
+{
+ return WEB_UI_STRING("month and year field", "accessibility role description for a month field.");
+}
+
+String AXNumberFieldText()
+{
+ return WEB_UI_STRING("number field", "accessibility role description for a number field.");
+}
+
+String AXWeekFieldText()
+{
+ return WEB_UI_STRING("week and year field", "accessibility role description for a time field.");
+}
+
</ins><span class="cx"> String AXButtonActionVerb()
</span><span class="cx"> {
</span><span class="cx"> return WEB_UI_STRING("press", "Verb stating the action that will occur when a button is pressed, as used by accessibility");
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformLocalizedStringsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/LocalizedStrings.h (210294 => 210295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/LocalizedStrings.h 2017-01-04 23:05:25 UTC (rev 210294)
+++ trunk/Source/WebCore/platform/LocalizedStrings.h 2017-01-04 23:07:13 UTC (rev 210295)
</span><span class="lines">@@ -177,6 +177,10 @@
</span><span class="cx"> String AXURLFieldText();
</span><span class="cx"> String AXDateFieldText();
</span><span class="cx"> String AXTimeFieldText();
</span><ins>+ String AXDateTimeFieldText();
+ String AXMonthFieldText();
+ String AXNumberFieldText();
+ String AXWeekFieldText();
</ins><span class="cx">
</span><span class="cx"> String AXButtonActionVerb();
</span><span class="cx"> String AXRadioButtonActionVerb();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformeflLocalizedStringsEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp (210294 => 210295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp 2017-01-04 23:05:25 UTC (rev 210294)
+++ trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp 2017-01-04 23:07:13 UTC (rev 210295)
</span><span class="lines">@@ -443,6 +443,26 @@
</span><span class="cx"> return String::fromUTF8("time field");
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+String AXDateTimeFieldText()
+{
+ return String::fromUTF8("date and time field");
+}
+
+String AXMonthFieldText()
+{
+ return String::fromUTF8("month and year field");
+}
+
+String AXNumberFieldText()
+{
+ return String::fromUTF8("number field");
+}
+
+String AXWeekFieldText()
+{
+ return String::fromUTF8("week and year field");
+}
+
</ins><span class="cx"> String AXFooterRoleDescriptionText()
</span><span class="cx"> {
</span><span class="cx"> return String::fromUTF8("footer");
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgtkLocalizedStringsGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp (210294 => 210295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp 2017-01-04 23:05:25 UTC (rev 210294)
+++ trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp 2017-01-04 23:07:13 UTC (rev 210295)
</span><span class="lines">@@ -491,6 +491,26 @@
</span><span class="cx"> return String::fromUTF8(_("time field"));
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+String AXDateTimeFieldText()
+{
+ return String::fromUTF8(_("date and time field"));
+}
+
+String AXMonthFieldText()
+{
+ return String::fromUTF8(_("month and year field"));
+}
+
+String AXNumberFieldText()
+{
+ return String::fromUTF8(_("number field"));
+}
+
+String AXWeekFieldText()
+{
+ return String::fromUTF8(_("week and year field"));
+}
+
</ins><span class="cx"> String AXFooterRoleDescriptionText()
</span><span class="cx"> {
</span><span class="cx"> return String::fromUTF8(_("footer"));
</span></span></pre>
</div>
</div>
</body>
</html>