<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210234] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210234">210234</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2017-01-03 01:04:20 -0800 (Tue, 03 Jan 2017)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] HTTP auth layout tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=158919
Reviewed by Michael Catanzaro.
Source/WebKit2:
Implement NetworkSession::clearCredentials() for soup using the new libsoup API when available.
* NetworkProcess/soup/NetworkSessionSoup.cpp:
(WebKit::NetworkSessionSoup::clearCredentials):
* NetworkProcess/soup/NetworkSessionSoup.h:
Tools:
* gtk/jhbuild.modules: Update libsoup to version 2.57.1.
* gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
missing valac in the bots.
LayoutTests:
Unskip tests that should pass now.
* platform/gtk/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesssoupNetworkSessionSoupcpp">trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesssoupNetworkSessionSouph">trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.h</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsgtkjhbuildmodules">trunk/Tools/gtk/jhbuild.modules</a></li>
<li><a href="#trunkToolsgtkjhbuildrc">trunk/Tools/gtk/jhbuildrc</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210233 => 210234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/LayoutTests/ChangeLog 2017-01-03 09:04:20 UTC (rev 210234)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2017-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [GTK] HTTP auth layout tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=158919
+
+ Reviewed by Michael Catanzaro.
+
+ Unskip tests that should pass now.
+
+ * platform/gtk/TestExpectations:
+
</ins><span class="cx"> 2017-01-02 Chris Fleizach <cfleizach@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: Expose block quote level to iOS API
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (210233 => 210234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-01-03 09:04:20 UTC (rev 210234)
</span><span class="lines">@@ -1323,9 +1323,6 @@
</span><span class="cx"> webkit.org/b/158918 fast/css3-text/css3-text-decoration/text-decoration-dotted-dashed.html [ ImageOnlyFailure Pass ]
</span><span class="cx"> webkit.org/b/158918 fast/css3-text/css3-text-decoration/text-decoration-dotted.html [ ImageOnlyFailure Pass ]
</span><span class="cx">
</span><del>-webkit.org/b/158919 http/tests/loading/basic-auth-resend-wrong-credentials.html [ Failure Pass ]
-webkit.org/b/158919 http/tests/loading/basic-credentials-sent-automatically.html [ Failure Pass ]
-
</del><span class="cx"> # This test relies on iOS-specific font fallback.
</span><span class="cx"> fast/text/arabic-blacklisted-expected.html [ Pass ImageOnlyFailure ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (210233 => 210234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Source/WebKit2/ChangeLog 2017-01-03 09:04:20 UTC (rev 210234)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2017-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [GTK] HTTP auth layout tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=158919
+
+ Reviewed by Michael Catanzaro.
+
+ Implement NetworkSession::clearCredentials() for soup using the new libsoup API when available.
+
+ * NetworkProcess/soup/NetworkSessionSoup.cpp:
+ (WebKit::NetworkSessionSoup::clearCredentials):
+ * NetworkProcess/soup/NetworkSessionSoup.h:
+
</ins><span class="cx"> 2017-01-01 Jeff Miller <jeffm@apple.com>
</span><span class="cx">
</span><span class="cx"> Update user-visible copyright strings to include 2017
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesssoupNetworkSessionSoupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.cpp (210233 => 210234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.cpp 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.cpp 2017-01-03 09:04:20 UTC (rev 210234)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx">
</span><span class="cx"> #include <WebCore/NetworkStorageSession.h>
</span><span class="cx"> #include <WebCore/SoupNetworkSession.h>
</span><ins>+#include <libsoup/soup.h>
</ins><span class="cx">
</span><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><span class="lines">@@ -47,4 +48,11 @@
</span><span class="cx"> return networkStorageSession().soupNetworkSession().soupSession();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void NetworkSessionSoup::clearCredentials()
+{
+#if SOUP_CHECK_VERSION(2, 57, 1)
+ soup_auth_manager_clear_cached_credentials(SOUP_AUTH_MANAGER(soup_session_get_feature(soupSession(), SOUP_TYPE_AUTH_MANAGER)));
+#endif
+}
+
</ins><span class="cx"> } // namespace WebKit
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesssoupNetworkSessionSouph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.h (210233 => 210234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.h 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.h 2017-01-03 09:04:20 UTC (rev 210234)
</span><span class="lines">@@ -43,6 +43,8 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> NetworkSessionSoup(WebCore::SessionID);
</span><ins>+
+ void clearCredentials() override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebKit
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (210233 => 210234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Tools/ChangeLog 2017-01-03 09:04:20 UTC (rev 210234)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2017-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><ins>+ [GTK] HTTP auth layout tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=158919
+
+ Reviewed by Michael Catanzaro.
+
+ * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
+ * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
+ introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
+ missing valac in the bots.
+
+2017-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
+
</ins><span class="cx"> REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=165797
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsgtkjhbuildmodules"></a>
<div class="modfile"><h4>Modified: trunk/Tools/gtk/jhbuild.modules (210233 => 210234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/gtk/jhbuild.modules 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Tools/gtk/jhbuild.modules 2017-01-03 09:04:20 UTC (rev 210234)
</span><span class="lines">@@ -236,9 +236,9 @@
</span><span class="cx"> <dependencies>
</span><span class="cx"> <dep package="glib-networking"/>
</span><span class="cx"> </dependencies>
</span><del>- <branch module="libsoup" version="2.49.91.1"
</del><ins>+ <branch module="libsoup" version="2.57.1"
</ins><span class="cx"> repo="git.gnome.org"
</span><del>- tag="f7292448160128b3cb4b7cd06c2447f81fd8c6c9"/>
</del><ins>+ tag="6acdbacc107c99fe6f05b78b81f4a40fb3fde9e9"/>
</ins><span class="cx"> </autotools>
</span><span class="cx">
</span><span class="cx"> <autotools id="fontconfig"
</span></span></pre></div>
<a id="trunkToolsgtkjhbuildrc"></a>
<div class="modfile"><h4>Modified: trunk/Tools/gtk/jhbuildrc (210233 => 210234)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/gtk/jhbuildrc 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Tools/gtk/jhbuildrc 2017-01-03 09:04:20 UTC (rev 210234)
</span><span class="lines">@@ -26,10 +26,6 @@
</span><span class="cx"> sys.path = [__gtk_tools_directory] + sys.path
</span><span class="cx"> import common
</span><span class="cx">
</span><del>-# We always enable introspection so that we can sniff out problems with our
-# annotations sooner rather than later.
-autogenargs='--enable-introspection'
-
</del><span class="cx"> # LLVM requires that builddir != srcdir, and it's not possible to do that in jhbuild only
</span><span class="cx"> # for a module, so we do it here globally since it's a good idea for all other modules as well.
</span><span class="cx"> buildroot = os.path.join(os.path.dirname(checkoutroot), "Build")
</span></span></pre>
</div>
</div>
</body>
</html>