<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210150] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210150">210150</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2016-12-25 23:47:56 -0800 (Sun, 25 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: Headers of table not read by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=158693
<rdar://problem/26771065>
Reviewed by Darin Adler.
Source/WebCore:
If a table cell header is hidden, by pushing off screen then the content won't be accessible.
It seems that unless specifically requested (such as using aria-hidden), we should try to return
that table cell header.
Test: accessibility/hidden-th-still-column-header.html
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::headerObjectForSection):
LayoutTests:
* accessibility/hidden-th-still-column-header-expected.txt: Added.
* accessibility/hidden-th-still-column-header.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityTableColumncpp">trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsaccessibilityhiddenthstillcolumnheaderexpectedtxt">trunk/LayoutTests/accessibility/hidden-th-still-column-header-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilityhiddenthstillcolumnheaderhtml">trunk/LayoutTests/accessibility/hidden-th-still-column-header.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210149 => 210150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-26 06:35:07 UTC (rev 210149)
+++ trunk/LayoutTests/ChangeLog 2016-12-26 07:47:56 UTC (rev 210150)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-12-25 Chris Fleizach <cfleizach@apple.com>
+
+ AX: Headers of table not read by VoiceOver
+ https://bugs.webkit.org/show_bug.cgi?id=158693
+ <rdar://problem/26771065>
+
+ Reviewed by Darin Adler.
+
+ * accessibility/hidden-th-still-column-header-expected.txt: Added.
+ * accessibility/hidden-th-still-column-header.html: Added.
+
</ins><span class="cx"> 2016-12-25 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> [WebIDL] Remove (most) custom bindings for the IndexedDB code
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityhiddenthstillcolumnheaderexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/hidden-th-still-column-header-expected.txt (0 => 210150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/hidden-th-still-column-header-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/hidden-th-still-column-header-expected.txt 2016-12-26 07:47:56 UTC (rev 210150)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+header 1header2 header 3
+cell1 cell2 cell3
+This tests confirms even when a th tag is hidden, it will still be returned as a column header (unless it is hidden).
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS colHeaders.length is 2
+PASS colHeaders[0].childAtIndex(0).childAtIndex(0).stringValue is 'AXValue: header 1'
+PASS colHeaders[1].childAtIndex(0).stringValue is 'AXValue: header 3'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsaccessibilityhiddenthstillcolumnheaderhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/hidden-th-still-column-header.html (0 => 210150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/hidden-th-still-column-header.html (rev 0)
+++ trunk/LayoutTests/accessibility/hidden-th-still-column-header.html 2016-12-26 07:47:56 UTC (rev 210150)
</span><span class="lines">@@ -0,0 +1,31 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+<script src="../resources/accessibility-helper.js"></script>
+</head>
+<body>
+
+<table border="1" id="table">
+<tr><th style="position: absolute; left: -99999px;">header 1</th>
+<th style="position: absolute; left: -99999px;" aria-hidden="true">header2</th>
+<th>header 3</th>
+</tr>
+<tr><td>cell1</td><td>cell2</td><td>cell3</td></tr>
+</table>
+
+<p id="description"></p>
+<div id="console"></div>
+<script>
+ description("This tests confirms even when a th tag is hidden, it will still be returned as a column header (unless it is hidden).");
+ if (window.accessibilityController) {
+ var table = accessibilityController.accessibleElementById("table");
+ var colHeaders = table.columnHeaders();
+ shouldBe("colHeaders.length", "2");
+ shouldBe("colHeaders[0].childAtIndex(0).childAtIndex(0).stringValue", "'AXValue: header 1'");
+ shouldBe("colHeaders[1].childAtIndex(0).stringValue", "'AXValue: header 3'");
+ }
+</script>
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210149 => 210150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-26 06:35:07 UTC (rev 210149)
+++ trunk/Source/WebCore/ChangeLog 2016-12-26 07:47:56 UTC (rev 210150)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-12-25 Chris Fleizach <cfleizach@apple.com>
+
+ AX: Headers of table not read by VoiceOver
+ https://bugs.webkit.org/show_bug.cgi?id=158693
+ <rdar://problem/26771065>
+
+ Reviewed by Darin Adler.
+
+ If a table cell header is hidden, by pushing off screen then the content won't be accessible.
+ It seems that unless specifically requested (such as using aria-hidden), we should try to return
+ that table cell header.
+
+ Test: accessibility/hidden-th-still-column-header.html
+
+ * accessibility/AccessibilityTableColumn.cpp:
+ (WebCore::AccessibilityTableColumn::headerObjectForSection):
+
</ins><span class="cx"> 2016-12-25 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Propagate the source origin as much as possible
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityTableColumncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp (210149 => 210150)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp 2016-12-26 06:35:07 UTC (rev 210149)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp 2016-12-26 07:47:56 UTC (rev 210150)
</span><span class="lines">@@ -31,6 +31,7 @@
</span><span class="cx">
</span><span class="cx"> #include "AXObjectCache.h"
</span><span class="cx"> #include "AccessibilityTableCell.h"
</span><ins>+#include "HTMLCollection.h"
</ins><span class="cx"> #include "HTMLElement.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "RenderTable.h"
</span><span class="lines">@@ -142,12 +143,21 @@
</span><span class="cx"> if ((testCell->col() + (testCell->colSpan()-1)) < m_columnIndex)
</span><span class="cx"> break;
</span><span class="cx">
</span><del>- // If this does not have an element (like a <caption>) then check the next row
- if (!testCell->element())
</del><ins>+ Node* testCellNode = testCell->element();
+ // If the RenderTableCell doesn't have an element because its anonymous,
+ // try to see if we can find the original cell element to check if it has a <th> tag.
+ if (!testCellNode && testCell->isAnonymous()) {
+ if (Element* parentElement = testCell->parent() ? testCell->parent()->element() : nullptr) {
+ if (parentElement->hasTagName(trTag) && testCol < static_cast<int>(parentElement->countChildNodes()))
+ testCellNode = parentElement->traverseToChildAt(testCol);
+ }
+ }
+
+ if (!testCellNode)
</ins><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> // If th is required, but we found an element that doesn't have a th tag, we can stop looking.
</span><del>- if (thTagRequired && !testCell->element()->hasTagName(thTag))
</del><ins>+ if (thTagRequired && !testCellNode->hasTagName(thTag))
</ins><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> cell = testCell;
</span><span class="lines">@@ -158,7 +168,11 @@
</span><span class="cx"> if (!cell)
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- return axObjectCache()->getOrCreate(cell);
</del><ins>+ auto* cellObject = axObjectCache()->getOrCreate(cell);
+ if (!cellObject || cellObject->accessibilityIsIgnored())
+ return nullptr;
+
+ return cellObject;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool AccessibilityTableColumn::computeAccessibilityIsIgnored() const
</span></span></pre>
</div>
</div>
</body>
</html>