<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210130] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210130">210130</a></dd>
<dt>Author</dt> <dd>aestes@apple.com</dd>
<dt>Date</dt> <dd>2016-12-22 20:41:52 -0800 (Thu, 22 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Reduce QuickLook.h include overhead
https://bugs.webkit.org/show_bug.cgi?id=166454
Reviewed by Andreas Kling.
Source/WebCore:
* dom/Document.cpp: Included QuickLook.h for QLPreviewProtocol().
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setQuickLookHandle): Moved from DocumentLoader.h to here.
* loader/DocumentLoader.h: Stopped including QuickLook.h and forward-declared
QuickLookHandle.
(WebCore::DocumentLoader::setQuickLookHandle): Moved definition out-of-line since it
requires QuickLookHandle to be a complete type.
* loader/ios/QuickLook.h: Updated to use #pragma once. Cleaned up includes and forward
declarations.
* platform/network/ResourceHandle.cpp: Included QuickLook.h so that QuickLookHandle is a
complete type in the ResourceHandle constructor.
* platform/network/ResourceHandle.h: Stopped including QuickLook.h and forward-declared
QuickLookHandle.
(WebCore::ResourceHandle::setQuickLookHandle): Moved definition out-of-line since it
requires QuickLookHandle to be a complete type.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::setQuickLookHandle): Moved from ResourceHandle.h to here.
* platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Included QuickLook.h for
QuickLookHandle.
Source/WebKit:
* WebCoreSupport/WebResourceLoadScheduler.cpp: Stopped including QuickLook.h.
Source/WebKit2:
* WebProcess/Network/WebLoaderStrategy.cpp: Included QuickLook.h for QLPreviewProtocol().
* WebProcess/Network/WebResourceLoader.cpp: Included QuickLook.h for QuickLookHandle.
* WebProcess/Network/WebResourceLoader.h: Stopped including QuickLook.h.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderDocumentLoadercpp">trunk/Source/WebCore/loader/DocumentLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderDocumentLoaderh">trunk/Source/WebCore/loader/DocumentLoader.h</a></li>
<li><a href="#trunkSourceWebCoreloaderiosQuickLookh">trunk/Source/WebCore/loader/ios/QuickLook.h</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkResourceHandlecpp">trunk/Source/WebCore/platform/network/ResourceHandle.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkResourceHandleh">trunk/Source/WebCore/platform/network/ResourceHandle.h</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkmacResourceHandleMacmm">trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkmacWebCoreResourceHandleAsDelegatemm">trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitWebCoreSupportWebResourceLoadSchedulercpp">trunk/Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessNetworkWebLoaderStrategycpp">trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessNetworkWebResourceLoadercpp">trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessNetworkWebResourceLoaderh">trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebCore/ChangeLog 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -1,5 +1,32 @@
</span><span class="cx"> 2016-12-22 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><ins>+ Reduce QuickLook.h include overhead
+ https://bugs.webkit.org/show_bug.cgi?id=166454
+
+ Reviewed by Andreas Kling.
+
+ * dom/Document.cpp: Included QuickLook.h for QLPreviewProtocol().
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::setQuickLookHandle): Moved from DocumentLoader.h to here.
+ * loader/DocumentLoader.h: Stopped including QuickLook.h and forward-declared
+ QuickLookHandle.
+ (WebCore::DocumentLoader::setQuickLookHandle): Moved definition out-of-line since it
+ requires QuickLookHandle to be a complete type.
+ * loader/ios/QuickLook.h: Updated to use #pragma once. Cleaned up includes and forward
+ declarations.
+ * platform/network/ResourceHandle.cpp: Included QuickLook.h so that QuickLookHandle is a
+ complete type in the ResourceHandle constructor.
+ * platform/network/ResourceHandle.h: Stopped including QuickLook.h and forward-declared
+ QuickLookHandle.
+ (WebCore::ResourceHandle::setQuickLookHandle): Moved definition out-of-line since it
+ requires QuickLookHandle to be a complete type.
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::setQuickLookHandle): Moved from ResourceHandle.h to here.
+ * platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Included QuickLook.h for
+ QuickLookHandle.
+
+2016-12-22 Andy Estes <aestes@apple.com>
+
</ins><span class="cx"> [iOS] Move QuickLook from WebCore/platform to WebCore/loader
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=166449
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -239,6 +239,10 @@
</span><span class="cx"> #include "MediaSession.h"
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#if USE(QUICK_LOOK)
+#include "QuickLook.h"
+#endif
+
</ins><span class="cx"> #if ENABLE(REQUEST_ANIMATION_FRAME)
</span><span class="cx"> #include "RequestAnimationFrameCallback.h"
</span><span class="cx"> #include "ScriptedAnimationController.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderDocumentLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -1801,4 +1801,11 @@
</span><span class="cx"> return m_frame ? m_frame->isAlwaysOnLoggingAllowed() : true;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+#if USE(QUICK_LOOK)
+void DocumentLoader::setQuickLookHandle(std::unique_ptr<QuickLookHandle> quickLookHandle)
+{
+ m_quickLookHandle = WTFMove(quickLookHandle);
+}
+#endif
+
</ins><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderDocumentLoaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/DocumentLoader.h (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/DocumentLoader.h 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebCore/loader/DocumentLoader.h 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -52,10 +52,6 @@
</span><span class="cx"> #include <wtf/RunLoopTimer.h>
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if USE(QUICK_LOOK)
-#include "QuickLook.h"
-#endif
-
</del><span class="cx"> #if PLATFORM(COCOA) && !USE(CFURLCONNECTION)
</span><span class="cx"> #include <wtf/SchedulePair.h>
</span><span class="cx"> #endif
</span><span class="lines">@@ -74,6 +70,7 @@
</span><span class="cx"> class FrameLoader;
</span><span class="cx"> class IconLoader;
</span><span class="cx"> class Page;
</span><ins>+class QuickLookHandle;
</ins><span class="cx"> class ResourceLoader;
</span><span class="cx"> class SharedBuffer;
</span><span class="cx"> class SubresourceLoader;
</span><span class="lines">@@ -273,7 +270,7 @@
</span><span class="cx"> URL documentURL() const;
</span><span class="cx">
</span><span class="cx"> #if USE(QUICK_LOOK)
</span><del>- void setQuickLookHandle(std::unique_ptr<QuickLookHandle> quickLookHandle) { m_quickLookHandle = WTFMove(quickLookHandle); }
</del><ins>+ WEBCORE_EXPORT void setQuickLookHandle(std::unique_ptr<QuickLookHandle>);
</ins><span class="cx"> QuickLookHandle* quickLookHandle() const { return m_quickLookHandle.get(); }
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderiosQuickLookh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/ios/QuickLook.h (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/ios/QuickLook.h 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebCore/loader/ios/QuickLook.h 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> /*
</span><del>- * Copyright (C) 2009 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2009-2016 Apple Inc. All rights reserved.
</ins><span class="cx"> *
</span><span class="cx"> * Redistribution and use in source and binary forms, with or without
</span><span class="cx"> * modification, are permitted provided that the following conditions
</span><span class="lines">@@ -23,20 +23,16 @@
</span><span class="cx"> * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-#ifndef QuickLook_h
-#define QuickLook_h
</del><ins>+#pragma once
</ins><span class="cx">
</span><span class="cx"> #if USE(QUICK_LOOK)
</span><span class="cx">
</span><del>-#import "QuickLookHandleClient.h"
-#import "ResourceRequest.h"
-#import <objc/objc-runtime.h>
-#import <wtf/RefPtr.h>
</del><ins>+#include "QuickLookHandleClient.h"
+#include <objc/objc.h>
+#include <wtf/Forward.h>
+#include <wtf/RefPtr.h>
+#include <wtf/RetainPtr.h>
</ins><span class="cx">
</span><del>-#if USE(CFURLCONNECTION)
-#include "CFNetworkSPI.h"
-#endif
-
</del><span class="cx"> OBJC_CLASS NSData;
</span><span class="cx"> OBJC_CLASS NSDictionary;
</span><span class="cx"> OBJC_CLASS NSFileHandle;
</span><span class="lines">@@ -50,11 +46,11 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class QuickLookHandleClient;
</del><span class="cx"> class ResourceHandle;
</span><span class="cx"> class ResourceLoader;
</span><span class="cx"> class ResourceResponse;
</span><span class="cx"> class SynchronousResourceHandleCFURLConnectionDelegate;
</span><ins>+class URL;
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT NSSet *QLPreviewGetSupportedMIMETypesSet();
</span><span class="cx">
</span><span class="lines">@@ -122,5 +118,3 @@
</span><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // USE(QUICK_LOOK)
</span><del>-
-#endif // QuickLook_h
</del></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkResourceHandlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/ResourceHandle.cpp (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/ResourceHandle.cpp 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebCore/platform/network/ResourceHandle.cpp 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -38,6 +38,10 @@
</span><span class="cx"> #include <wtf/text/AtomicStringHash.h>
</span><span class="cx"> #include <wtf/text/CString.h>
</span><span class="cx">
</span><ins>+#if USE(QUICK_LOOK)
+#include "QuickLook.h"
+#endif
+
</ins><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> static bool shouldForceContentSniffing;
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkResourceHandleh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/ResourceHandle.h (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/ResourceHandle.h 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebCore/platform/network/ResourceHandle.h 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -35,10 +35,6 @@
</span><span class="cx"> #include <wtf/RetainPtr.h>
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if USE(QUICK_LOOK)
-#include "QuickLook.h"
-#endif
-
</del><span class="cx"> #if USE(SOUP)
</span><span class="cx"> typedef struct _GTlsCertificate GTlsCertificate;
</span><span class="cx"> typedef struct _SoupSession SoupSession;
</span><span class="lines">@@ -83,6 +79,7 @@
</span><span class="cx"> class URL;
</span><span class="cx"> class NetworkingContext;
</span><span class="cx"> class ProtectionSpace;
</span><ins>+class QuickLookHandle;
</ins><span class="cx"> class ResourceError;
</span><span class="cx"> class ResourceHandleClient;
</span><span class="cx"> class ResourceHandleInternal;
</span><span class="lines">@@ -152,7 +149,7 @@
</span><span class="cx">
</span><span class="cx"> #if USE(QUICK_LOOK)
</span><span class="cx"> QuickLookHandle* quickLookHandle() { return m_quickLook.get(); }
</span><del>- void setQuickLookHandle(std::unique_ptr<QuickLookHandle> handle) { m_quickLook = WTFMove(handle); }
</del><ins>+ void setQuickLookHandle(std::unique_ptr<QuickLookHandle>);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(WIN) && USE(CURL)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkmacResourceHandleMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -752,5 +752,12 @@
</span><span class="cx">
</span><span class="cx"> #endif // ENABLE(WEB_TIMING)
</span><span class="cx">
</span><ins>+#if USE(QUICK_LOOK)
+void ResourceHandle::setQuickLookHandle(std::unique_ptr<QuickLookHandle> handle)
+{
+ m_quickLook = WTFMove(handle);
+}
+#endif
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkmacWebCoreResourceHandleAsDelegatemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> #import "AuthenticationMac.h"
</span><span class="cx"> #import "Logging.h"
</span><span class="cx"> #import "NSURLRequestSPI.h"
</span><ins>+#import "QuickLook.h"
</ins><span class="cx"> #import "ResourceHandle.h"
</span><span class="cx"> #import "ResourceHandleClient.h"
</span><span class="cx"> #import "ResourceRequest.h"
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebKit/ChangeLog 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-12-22 Andy Estes <aestes@apple.com>
+
+ Reduce QuickLook.h include overhead
+ https://bugs.webkit.org/show_bug.cgi?id=166454
+
+ Reviewed by Andreas Kling.
+
+ * WebCoreSupport/WebResourceLoadScheduler.cpp: Stopped including QuickLook.h.
+
</ins><span class="cx"> 2016-12-15 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Sort Xcode project files
</span></span></pre></div>
<a id="trunkSourceWebKitWebCoreSupportWebResourceLoadSchedulercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -43,10 +43,6 @@
</span><span class="cx"> #include <WebCore/RuntimeApplicationChecks.h>
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if USE(QUICK_LOOK)
-#include <WebCore/QuickLook.h>
-#endif
-
</del><span class="cx"> // Match the parallel connection count used by the networking layer.
</span><span class="cx"> static unsigned maxRequestsInFlightPerHost;
</span><span class="cx"> #if !PLATFORM(IOS)
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebKit2/ChangeLog 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-12-22 Andy Estes <aestes@apple.com>
+
+ Reduce QuickLook.h include overhead
+ https://bugs.webkit.org/show_bug.cgi?id=166454
+
+ Reviewed by Andreas Kling.
+
+ * WebProcess/Network/WebLoaderStrategy.cpp: Included QuickLook.h for QLPreviewProtocol().
+ * WebProcess/Network/WebResourceLoader.cpp: Included QuickLook.h for QuickLookHandle.
+ * WebProcess/Network/WebResourceLoader.h: Stopped including QuickLook.h.
+
</ins><span class="cx"> 2016-12-22 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Null deref under WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessNetworkWebLoaderStrategycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -57,6 +57,10 @@
</span><span class="cx"> #include <WebCore/SubresourceLoader.h>
</span><span class="cx"> #include <wtf/text/CString.h>
</span><span class="cx">
</span><ins>+#if USE(QUICK_LOOK)
+#include <WebCore/QuickLook.h>
+#endif
+
</ins><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><span class="cx"> #define RELEASE_LOG_IF_ALLOWED(permissionChecker, fmt, ...) RELEASE_LOG_IF(permissionChecker.isAlwaysOnLoggingAllowed(), Network, "%p - WebLoaderStrategy::" fmt, this, ##__VA_ARGS__)
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessNetworkWebResourceLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -44,6 +44,10 @@
</span><span class="cx"> #include <WebCore/ResourceLoader.h>
</span><span class="cx"> #include <WebCore/SubresourceLoader.h>
</span><span class="cx">
</span><ins>+#if USE(QUICK_LOOK)
+#include <WebCore/QuickLook.h>
+#endif
+
</ins><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><span class="cx"> #define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(isAlwaysOnLoggingAllowed(), Network, "%p - WebResourceLoader::" fmt, this, ##__VA_ARGS__)
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessNetworkWebResourceLoaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.h (210129 => 210130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.h 2016-12-23 02:24:28 UTC (rev 210129)
+++ trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.h 2016-12-23 04:41:52 UTC (rev 210130)
</span><span class="lines">@@ -32,10 +32,6 @@
</span><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="cx"> #include <wtf/RefPtr.h>
</span><span class="cx">
</span><del>-#if USE(QUICK_LOOK)
-#include <WebCore/QuickLook.h>
-#endif
-
</del><span class="cx"> namespace IPC {
</span><span class="cx"> class DataReference;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>