<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210113] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210113">210113</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2016-12-22 14:26:37 -0800 (Thu, 22 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make http/tests/security/popup-blocked-from-{fake-event, window-open}.html actually test popup
blocker; run on WebKit2
https://bugs.webkit.org/show_bug.cgi?id=166403
Reviewed by Darin Adler.
The tests http/tests/security/popup-blocked-from-{fake-event, window-open}.html inadvertently
depended on the default behavior of DumpRenderTree to ignore the ChromeClient::createWindow()
callback when asked to create a new window instead of testing that the popup blocker blocked
opening windows. We should call testRunner.setCanOpenWindows() and testRunner.setPopupBlockingEnabled(true)
from both of these tests so that DumpRenderTree respects requests to open windows and enable
the popup blocker (it is disabled by default), respectively.
The default behavior of DumpRenderTree to disallow opening windows falls out from the purpose
and implementation of testRunner.setCanOpenWindows() to support writing tests where the embedding
client ignores requests to create a new window. We do not implement such a concept in WebKitTestRunner
(see <https://bugs.webkit.org/show_bug.cgi?id=166402>).
* http/tests/security/popup-blocked-from-fake-event.html:
* http/tests/security/popup-blocked-from-window-open.html:
* platform/wk2/TestExpectations: Unskip the above tests as they now pass.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestssecuritypopupblockedfromfakeeventhtml">trunk/LayoutTests/http/tests/security/popup-blocked-from-fake-event.html</a></li>
<li><a href="#trunkLayoutTestshttptestssecuritypopupblockedfromwindowopenhtml">trunk/LayoutTests/http/tests/security/popup-blocked-from-window-open.html</a></li>
<li><a href="#trunkLayoutTestsplatformwk2TestExpectations">trunk/LayoutTests/platform/wk2/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210112 => 210113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-22 22:20:25 UTC (rev 210112)
+++ trunk/LayoutTests/ChangeLog 2016-12-22 22:26:37 UTC (rev 210113)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2016-12-22 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><ins>+ Make http/tests/security/popup-blocked-from-{fake-event, window-open}.html actually test popup
+ blocker; run on WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=166403
+
+ Reviewed by Darin Adler.
+
+ The tests http/tests/security/popup-blocked-from-{fake-event, window-open}.html inadvertently
+ depended on the default behavior of DumpRenderTree to ignore the ChromeClient::createWindow()
+ callback when asked to create a new window instead of testing that the popup blocker blocked
+ opening windows. We should call testRunner.setCanOpenWindows() and testRunner.setPopupBlockingEnabled(true)
+ from both of these tests so that DumpRenderTree respects requests to open windows and enable
+ the popup blocker (it is disabled by default), respectively.
+
+ The default behavior of DumpRenderTree to disallow opening windows falls out from the purpose
+ and implementation of testRunner.setCanOpenWindows() to support writing tests where the embedding
+ client ignores requests to create a new window. We do not implement such a concept in WebKitTestRunner
+ (see <https://bugs.webkit.org/show_bug.cgi?id=166402>).
+
+ * http/tests/security/popup-blocked-from-fake-event.html:
+ * http/tests/security/popup-blocked-from-window-open.html:
+ * platform/wk2/TestExpectations: Unskip the above tests as they now pass.
+
+2016-12-22 Daniel Bates <dabates@apple.com>
+
</ins><span class="cx"> Bypass pop-up blocker from cross-origin or sandboxed frame
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=166290
</span><span class="cx"> <rdar://problem/29742039>
</span></span></pre></div>
<a id="trunkLayoutTestshttptestssecuritypopupblockedfromfakeeventhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/security/popup-blocked-from-fake-event.html (210112 => 210113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/security/popup-blocked-from-fake-event.html 2016-12-22 22:20:25 UTC (rev 210112)
+++ trunk/LayoutTests/http/tests/security/popup-blocked-from-fake-event.html 2016-12-22 22:26:37 UTC (rev 210113)
</span><span class="lines">@@ -4,6 +4,8 @@
</span><span class="cx"> <script>
</span><span class="cx"> if (window.testRunner) {
</span><span class="cx"> testRunner.dumpAsText();
</span><ins>+ testRunner.setCanOpenWindows();
+ testRunner.setPopupBlockingEnabled(true);
</ins><span class="cx"> testRunner.setCloseRemainingWindowsWhenComplete(true);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestshttptestssecuritypopupblockedfromwindowopenhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/security/popup-blocked-from-window-open.html (210112 => 210113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/security/popup-blocked-from-window-open.html 2016-12-22 22:20:25 UTC (rev 210112)
+++ trunk/LayoutTests/http/tests/security/popup-blocked-from-window-open.html 2016-12-22 22:26:37 UTC (rev 210113)
</span><span class="lines">@@ -3,6 +3,8 @@
</span><span class="cx"> <script>
</span><span class="cx"> if (window.testRunner) {
</span><span class="cx"> testRunner.dumpAsText();
</span><ins>+ testRunner.setCanOpenWindows();
+ testRunner.setPopupBlockingEnabled(true);
</ins><span class="cx"> testRunner.setCloseRemainingWindowsWhenComplete(true);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/wk2/TestExpectations (210112 => 210113)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/wk2/TestExpectations 2016-12-22 22:20:25 UTC (rev 210112)
+++ trunk/LayoutTests/platform/wk2/TestExpectations 2016-12-22 22:26:37 UTC (rev 210113)
</span><span class="lines">@@ -438,8 +438,6 @@
</span><span class="cx"> http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html
</span><span class="cx"> http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html
</span><span class="cx"> http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html
</span><del>-http/tests/security/popup-blocked-from-fake-event.html
-http/tests/security/popup-blocked-from-window-open.html
</del><span class="cx">
</span><span class="cx"> # Unexplained failures that were formerly in the "unsafe access" list.
</span><span class="cx"> http/tests/security/cross-frame-access-enumeration.html
</span></span></pre>
</div>
</div>
</body>
</html>