<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210092] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210092">210092</a></dd>
<dt>Author</dt> <dd>eric.carlson@apple.com</dd>
<dt>Date</dt> <dd>2016-12-21 17:41:51 -0800 (Wed, 21 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[MediaStream] Update media-stream-event-constructor test
https://bugs.webkit.org/show_bug.cgi?id=166398
Reviewed by Jer Noble.
Source/WebCore:
No new tests, updated existing test.
* Modules/mediastream/MediaStreamEvent.idl: Mark eventInitDict as optional.
LayoutTests:
Update and rebaseline test to reflect behavior changes that happened while the test was
skipped. Un-skip it on macOS.
* fast/events/constructors/media-stream-event-constructor-expected.txt:
* fast/events/constructors/media-stream-event-constructor.html:
* platform/mac/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorsmediastreameventconstructorexpectedtxt">trunk/LayoutTests/fast/events/constructors/media-stream-event-constructor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsconstructorsmediastreameventconstructorhtml">trunk/LayoutTests/fast/events/constructors/media-stream-event-constructor.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamEventidl">trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210091 => 210092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-22 01:26:09 UTC (rev 210091)
+++ trunk/LayoutTests/ChangeLog 2016-12-22 01:41:51 UTC (rev 210092)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-12-21 Eric Carlson <eric.carlson@apple.com>
+
+ [MediaStream] Update media-stream-event-constructor test
+ https://bugs.webkit.org/show_bug.cgi?id=166398
+
+ Reviewed by Jer Noble.
+
+ Update and rebaseline test to reflect behavior changes that happened while the test was
+ skipped. Un-skip it on macOS.
+
+ * fast/events/constructors/media-stream-event-constructor-expected.txt:
+ * fast/events/constructors/media-stream-event-constructor.html:
+ * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2016-12-21 John Wilander <wilander@apple.com>
</span><span class="cx">
</span><span class="cx"> Switch to a blacklist model for restricted Accept headers in simple CORS requests
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorsmediastreameventconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/media-stream-event-constructor-expected.txt (210091 => 210092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/media-stream-event-constructor-expected.txt 2016-12-22 01:26:09 UTC (rev 210091)
+++ trunk/LayoutTests/fast/events/constructors/media-stream-event-constructor-expected.txt 2016-12-22 01:41:51 UTC (rev 210092)
</span><span class="lines">@@ -11,19 +11,19 @@
</span><span class="cx"> PASS new MediaStreamEvent('eventType', { cancelable: false }).cancelable is false
</span><span class="cx"> PASS new MediaStreamEvent('eventType', { cancelable: true }).cancelable is true
</span><span class="cx"> PASS new MediaStreamEvent('eventType', { stream: mediaStream }).stream is mediaStream
</span><del>-PASS new MediaStreamEvent('eventType', { stream: testObject }).stream is null
-PASS new MediaStreamEvent('eventType', { stream: document }).stream is null
</del><ins>+PASS new MediaStreamEvent('eventType', { stream: testObject }).stream threw exception TypeError: Type error.
+PASS new MediaStreamEvent('eventType', { stream: document }).stream threw exception TypeError: Type error.
</ins><span class="cx"> PASS new MediaStreamEvent('eventType', { stream: undefined }).stream is null
</span><span class="cx"> PASS new MediaStreamEvent('eventType', { stream: null }).stream is null
</span><del>-PASS new MediaStreamEvent('eventType', { stream: false }).stream is null
-PASS new MediaStreamEvent('eventType', { stream: true }).stream is null
-PASS new MediaStreamEvent('eventType', { stream: '' }).stream is null
-PASS new MediaStreamEvent('eventType', { stream: 'chocolate' }).stream is null
-PASS new MediaStreamEvent('eventType', { stream: 12345 }).stream is null
-PASS new MediaStreamEvent('eventType', { stream: 18446744073709551615 }).stream is null
-PASS new MediaStreamEvent('eventType', { stream: NaN }).stream is null
-PASS new MediaStreamEvent('eventType', { stream: {valueOf: function () { return mediaStream; } } }).stream == mediaStream is false
-PASS new MediaStreamEvent('eventType', { get stream() { return 123; } }).stream is null
</del><ins>+PASS new MediaStreamEvent('eventType', { stream: false }).stream threw exception TypeError: Type error.
+PASS new MediaStreamEvent('eventType', { stream: true }).stream threw exception TypeError: Type error.
+PASS new MediaStreamEvent('eventType', { stream: '' }).stream threw exception TypeError: Type error.
+PASS new MediaStreamEvent('eventType', { stream: 'chocolate' }).stream threw exception TypeError: Type error.
+PASS new MediaStreamEvent('eventType', { stream: 12345 }).stream threw exception TypeError: Type error.
+PASS new MediaStreamEvent('eventType', { stream: 18446744073709551615 }).stream threw exception TypeError: Type error.
+PASS new MediaStreamEvent('eventType', { stream: NaN }).stream threw exception TypeError: Type error.
+PASS new MediaStreamEvent('eventType', { stream: {valueOf: function () { return mediaStream; } } }).stream threw exception TypeError: Type error.
+PASS new MediaStreamEvent('eventType', { get stream() { return 123; } }).stream threw exception TypeError: Type error.
</ins><span class="cx"> PASS new MediaStreamEvent('eventType', { get stream() { throw 'MediaStreamEvent Error'; } }) threw exception MediaStreamEvent Error.
</span><span class="cx"> PASS new MediaStreamEvent('eventType', { bubbles: true, cancelable: true, stream: mediaStream }).bubbles is true
</span><span class="cx"> PASS new MediaStreamEvent('eventType', { bubbles: true, cancelable: true, stream: mediaStream }).cancelable is true
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsconstructorsmediastreameventconstructorhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/constructors/media-stream-event-constructor.html (210091 => 210092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/constructors/media-stream-event-constructor.html 2016-12-22 01:26:09 UTC (rev 210091)
+++ trunk/LayoutTests/fast/events/constructors/media-stream-event-constructor.html 2016-12-22 01:41:51 UTC (rev 210092)
</span><span class="lines">@@ -29,20 +29,20 @@
</span><span class="cx"> shouldBe("new MediaStreamEvent('eventType', { stream: mediaStream }).stream", "mediaStream");
</span><span class="cx">
</span><span class="cx"> // Invalid objects.
</span><del>-shouldBe("new MediaStreamEvent('eventType', { stream: testObject }).stream", "null");
-shouldBe("new MediaStreamEvent('eventType', { stream: document }).stream", "null");
</del><ins>+shouldThrowErrorName("new MediaStreamEvent('eventType', { stream: testObject }).stream", "TypeError");
+shouldThrowErrorName("new MediaStreamEvent('eventType', { stream: document }).stream", "TypeError");
</ins><span class="cx"> shouldBe("new MediaStreamEvent('eventType', { stream: undefined }).stream", "null");
</span><span class="cx"> shouldBe("new MediaStreamEvent('eventType', { stream: null }).stream", "null");
</span><del>-shouldBe("new MediaStreamEvent('eventType', { stream: false }).stream", "null");
-shouldBe("new MediaStreamEvent('eventType', { stream: true }).stream", "null");
-shouldBe("new MediaStreamEvent('eventType', { stream: '' }).stream", "null");
-shouldBe("new MediaStreamEvent('eventType', { stream: 'chocolate' }).stream", "null");
-shouldBe("new MediaStreamEvent('eventType', { stream: 12345 }).stream", "null");
-shouldBe("new MediaStreamEvent('eventType', { stream: 18446744073709551615 }).stream", "null");
-shouldBe("new MediaStreamEvent('eventType', { stream: NaN }).stream", "null");
</del><ins>+shouldThrowErrorName("new MediaStreamEvent('eventType', { stream: false }).stream", "TypeError");
+shouldThrowErrorName("new MediaStreamEvent('eventType', { stream: true }).stream", "TypeError");
+shouldThrowErrorName("new MediaStreamEvent('eventType', { stream: '' }).stream", "TypeError");
+shouldThrowErrorName("new MediaStreamEvent('eventType', { stream: 'chocolate' }).stream", "TypeError");
+shouldThrowErrorName("new MediaStreamEvent('eventType', { stream: 12345 }).stream", "TypeError");
+shouldThrowErrorName("new MediaStreamEvent('eventType', { stream: 18446744073709551615 }).stream", "TypeError");
+shouldThrowErrorName("new MediaStreamEvent('eventType', { stream: NaN }).stream", "TypeError");
</ins><span class="cx"> // Note that valueOf() is not called, when the left hand side is evaluated.
</span><del>-shouldBeFalse("new MediaStreamEvent('eventType', { stream: {valueOf: function () { return mediaStream; } } }).stream == mediaStream");
-shouldBe("new MediaStreamEvent('eventType', { get stream() { return 123; } }).stream", "null");
</del><ins>+shouldThrowErrorName("new MediaStreamEvent('eventType', { stream: {valueOf: function () { return mediaStream; } } }).stream", "TypeError");
+shouldThrowErrorName("new MediaStreamEvent('eventType', { get stream() { return 123; } }).stream", "TypeError");
</ins><span class="cx"> shouldThrow("new MediaStreamEvent('eventType', { get stream() { throw 'MediaStreamEvent Error'; } })");
</span><span class="cx">
</span><span class="cx"> // All initializers are passed.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (210091 => 210092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2016-12-22 01:26:09 UTC (rev 210091)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-12-22 01:41:51 UTC (rev 210092)
</span><span class="lines">@@ -162,7 +162,6 @@
</span><span class="cx"> fast/mediastream/MediaStreamTrack.html
</span><span class="cx">
</span><span class="cx"> # WebRTC is not supported yet.
</span><del>-fast/events/constructors/media-stream-event-constructor.html
</del><span class="cx"> fast/mediastream/RTCPeerConnection-dtmf.html [ Skip ]
</span><span class="cx"> fast/mediastream/RTCPeerConnection-events.html [ Skip ]
</span><span class="cx"> fast/mediastream/RTCPeerConnection-ice.html [ Skip ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210091 => 210092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-22 01:26:09 UTC (rev 210091)
+++ trunk/Source/WebCore/ChangeLog 2016-12-22 01:41:51 UTC (rev 210092)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-12-21 Eric Carlson <eric.carlson@apple.com>
+
+ [MediaStream] Update media-stream-event-constructor test
+ https://bugs.webkit.org/show_bug.cgi?id=166398
+
+ Reviewed by Jer Noble.
+
+ No new tests, updated existing test.
+
+ * Modules/mediastream/MediaStreamEvent.idl: Mark eventInitDict as optional.
+
</ins><span class="cx"> 2016-12-21 Jiewen Tan <jiewen_tan@apple.com>
</span><span class="cx">
</span><span class="cx"> WebKit should set Original URL of a download request correctly
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl (210091 => 210092)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl 2016-12-22 01:26:09 UTC (rev 210091)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl 2016-12-22 01:41:51 UTC (rev 210092)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx">
</span><span class="cx"> [
</span><span class="cx"> Conditional=WEB_RTC,
</span><del>- Constructor(DOMString type, MediaStreamEventInit eventInitDict),
</del><ins>+ Constructor(DOMString type, optional MediaStreamEventInit eventInitDict),
</ins><span class="cx"> EnabledAtRuntime=mediaStream,
</span><span class="cx"> ] interface MediaStreamEvent : Event {
</span><span class="cx"> readonly attribute MediaStream? stream;
</span></span></pre>
</div>
</div>
</body>
</html>