<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210072] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210072">210072</a></dd>
<dt>Author</dt> <dd>wenson_hsieh@apple.com</dd>
<dt>Date</dt> <dd>2016-12-21 12:27:46 -0800 (Wed, 21 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add a layout test for scroll snapping with padding in the container
https://bugs.webkit.org/show_bug.cgi?id=144927
<rdar://problem/20923772>
Reviewed by Brent Fulgham.
The issue was actually addressed by changes to snap offset computation in AxisScrollSnapOffsets.cpp with
<https://trac.webkit.org/changeset/210024>, but there was no test for this. This patch adds a new layout test
verifying that the padding on child elements is accounted for when computing the scroll snap offsets of a scroll
snapping container.
* css3/scroll-snap/scroll-snap-children-with-padding-expected.txt: Added.
* css3/scroll-snap/scroll-snap-children-with-padding.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscss3scrollsnapscrollsnapchildrenwithpaddingexpectedtxt">trunk/LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding-expected.txt</a></li>
<li><a href="#trunkLayoutTestscss3scrollsnapscrollsnapchildrenwithpaddinghtml">trunk/LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210071 => 210072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-21 20:19:02 UTC (rev 210071)
+++ trunk/LayoutTests/ChangeLog 2016-12-21 20:27:46 UTC (rev 210072)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-12-21 Wenson Hsieh <wenson_hsieh@apple.com>
+
+ Add a layout test for scroll snapping with padding in the container
+ https://bugs.webkit.org/show_bug.cgi?id=144927
+ <rdar://problem/20923772>
+
+ Reviewed by Brent Fulgham.
+
+ The issue was actually addressed by changes to snap offset computation in AxisScrollSnapOffsets.cpp with
+ <https://trac.webkit.org/changeset/210024>, but there was no test for this. This patch adds a new layout test
+ verifying that the padding on child elements is accounted for when computing the scroll snap offsets of a scroll
+ snapping container.
+
+ * css3/scroll-snap/scroll-snap-children-with-padding-expected.txt: Added.
+ * css3/scroll-snap/scroll-snap-children-with-padding.html: Added.
+
</ins><span class="cx"> 2016-12-21 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
</span></span></pre></div>
<a id="trunkLayoutTestscss3scrollsnapscrollsnapchildrenwithpaddingexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding-expected.txt (0 => 210072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding-expected.txt 2016-12-21 20:27:46 UTC (rev 210072)
</span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+Scroll-snap offsets are: vertical = { 0, 10, 625, 1240, 1660, 2275, 2890, 2920 }
+
</ins></span></pre></div>
<a id="trunkLayoutTestscss3scrollsnapscrollsnapchildrenwithpaddinghtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding.html (0 => 210072)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding.html (rev 0)
+++ trunk/LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding.html 2016-12-21 20:27:46 UTC (rev 210072)
</span><span class="lines">@@ -0,0 +1,62 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+ <style>
+ #container {
+ position: absolute;
+ width: 400px;
+ height: 400px;
+ top: 0;
+ left: 0;
+ scroll-snap-type: y mandatory;
+ overflow-x: hidden;
+ overflow-y: scroll;
+ opacity: 0.75;
+ background-color: #EEE;
+ padding: 10px;
+ }
+
+ .child {
+ width: 400px;
+ height: 400px;
+ padding-top: 100px;
+ padding-bottom: 50px;
+ left: 0;
+ }
+ </style>
+ <script>
+ let write = s => output.innerHTML += s + "<br>";
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
+
+ function run()
+ {
+ if (!window.testRunner || !window.internals) {
+ write(`To manually test, verify that scrolling in the container snaps such that:`);
+ write(`- The first and fourth boxes align their top edge to the top edge of the scrolling container`);
+ write(`- The second and fifth boxes align their center to the center of the scrolling container`);
+ write(`- The third and sixth boxes align their bottom edge to the bottom edge of the scrolling container`);
+ return;
+ }
+
+ setTimeout(() => {
+ write("Scroll-snap offsets are: " + internals.scrollSnapOffsets(container));
+ testRunner.notifyDone();
+ }, 0);
+ }
+ </script>
+</head>
+<body onload=run()>
+ <div id="container">
+ <div class="child" style="background-color: red; scroll-snap-align: start;"></div>
+ <div class="child" style="background-color: green; scroll-snap-align: center;"></div>
+ <div class="child" style="background-color: blue; scroll-snap-align: end;"></div>
+ <div class="child" style="background-color: aqua; scroll-snap-align: start;"></div>
+ <div class="child" style="background-color: yellow; scroll-snap-align: center;"></div>
+ <div class="child" style="background-color: fuchsia; scroll-snap-align: end;"></div>
+ </div>
+ <div id="output"></div>
+</body>
+</html>
</ins></span></pre>
</div>
</div>
</body>
</html>