<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210016] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210016">210016</a></dd>
<dt>Author</dt> <dd>utatane.tea@gmail.com</dd>
<dt>Date</dt> <dd>2016-12-20 00:32:52 -0800 (Tue, 20 Dec 2016)</dd>
</dl>

<h3>Log Message</h3>
<pre>[ES6] Enable ES6 Modules
https://bugs.webkit.org/show_bug.cgi?id=165849

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* features.json:

Source/WebCore:

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::determineScriptType):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
* page/Settings.in:

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences es6ModulesEnabled]): Deleted.
(-[WebPreferences setES6ModulesEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit/win:

* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::setES6ModulesEnabled): Deleted.
(WebPreferences::es6ModulesEnabled): Deleted.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WebKit2:

* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetES6ModulesEnabled): Deleted.
(WKPreferencesGetES6ModulesEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setES6ModulesEnabled): Deleted.
* WebKitTestRunner/InjectedBundle/TestRunner.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorefeaturesjson">trunk/Source/JavaScriptCore/features.json</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomScriptElementcpp">trunk/Source/WebCore/dom/ScriptElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlparserHTMLPreloadScannercpp">trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp</a></li>
<li><a href="#trunkSourceWebCorepageSettingsin">trunk/Source/WebCore/page/Settings.in</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl">trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferenceKeysPrivateh">trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferencescpp">trunk/Source/WebKit/win/WebPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebPreferencesh">trunk/Source/WebKit/win/WebPreferences.h</a></li>
<li><a href="#trunkSourceWebKitwinWebViewcpp">trunk/Source/WebKit/win/WebView.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesDefinitionsh">trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencescpp">trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp">trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreemacDumpRenderTreemm">trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm</a></li>
<li><a href="#trunkToolsDumpRenderTreewinDumpRenderTreecpp">trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleInjectedBundlecpp">trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleTestRunnercpp">trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleTestRunnerh">trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebCorecryptogcryptCryptoAlgorithmRSASSA_PKCS1_v1_5GCryptcpp">trunk/Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/JavaScriptCore/ChangeLog        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-12-19  Yusuke Suzuki  &lt;utatane.tea@gmail.com&gt;
+
+        [ES6] Enable ES6 Modules
+        https://bugs.webkit.org/show_bug.cgi?id=165849
+
+        Reviewed by Geoffrey Garen.
+
+        * features.json:
+
</ins><span class="cx"> 2016-12-19  Mark Lam  &lt;mark.lam@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Rolling out r209974 and r209952. They break some websites in mysterious ways. Step 2: Rollout r209952.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorefeaturesjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/features.json (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/features.json        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/JavaScriptCore/features.json        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -193,7 +193,7 @@
</span><span class="cx">     {
</span><span class="cx">         &quot;name&quot;: &quot;Modules&quot;,
</span><span class="cx">         &quot;status&quot;: {
</span><del>-            &quot;status&quot;: &quot;In Development&quot;,
</del><ins>+            &quot;status&quot;: &quot;Done&quot;,
</ins><span class="cx">             &quot;enabled-by-default&quot;: true
</span><span class="cx">         },
</span><span class="cx">         &quot;url&quot;: &quot;http://www.ecma-international.org/ecma-262/6.0/index.html#sec-modules&quot;,
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebCore/ChangeLog        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-12-19  Yusuke Suzuki  &lt;utatane.tea@gmail.com&gt;
+
+        [ES6] Enable ES6 Modules
+        https://bugs.webkit.org/show_bug.cgi?id=165849
+
+        Reviewed by Geoffrey Garen.
+
+        * dom/ScriptElement.cpp:
+        (WebCore::ScriptElement::determineScriptType):
+        * html/parser/HTMLPreloadScanner.cpp:
+        (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
+        * page/Settings.in:
+
</ins><span class="cx"> 2016-12-17  Sam Weinig  &lt;sam@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Remove a few trivial custom bindings
</span></span></pre></div>
<a id="trunkSourceWebCorecryptogcryptCryptoAlgorithmRSASSA_PKCS1_v1_5GCryptcpp"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp (0 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp                                (rev 0)
+++ trunk/Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -0,0 +1,64 @@
</span><ins>+/*
+ * Copyright (C) 2016 Yusuke Suzuki &lt;utatane.tea@gmail.com&gt;.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include &quot;config.h&quot;
+#include &quot;CryptoAlgorithmRSASSA_PKCS1_v1_5.h&quot;
+
+#if ENABLE(SUBTLE_CRYPTO)
+
+#include &quot;CryptoAlgorithmRsaSsaParamsDeprecated.h&quot;
+#include &quot;CryptoKeyRSA.h&quot;
+#include &quot;ExceptionCode.h&quot;
+#include &quot;NotImplemented.h&quot;
+#include &lt;gcrypt.h&gt;
+#include &lt;wtf/CryptographicUtilities.h&gt;
+
+namespace WebCore {
+
+void CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign(Ref&lt;CryptoKey&gt;&amp;&amp;, Vector&lt;uint8_t&gt;&amp;&amp;, VectorCallback&amp;&amp;, ExceptionCallback&amp;&amp;, ScriptExecutionContext&amp;, WorkQueue&amp;)
+{
+    notImplemented();
+}
+
+void CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify(Ref&lt;CryptoKey&gt;&amp;&amp;, Vector&lt;uint8_t&gt;&amp;&amp;, Vector&lt;uint8_t&gt;&amp;&amp;, BoolCallback&amp;&amp;, ExceptionCallback&amp;&amp;, ScriptExecutionContext&amp;, WorkQueue&amp;)
+{
+    notImplemented();
+}
+
+ExceptionOr&lt;void&gt; CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign(const CryptoAlgorithmRsaSsaParamsDeprecated&amp;, const CryptoKeyRSA&amp;, const CryptoOperationData&amp;, VectorCallback&amp;&amp;, VoidCallback&amp;&amp;)
+{
+    notImplemented();
+    return Exception { NOT_SUPPORTED_ERR };
+}
+
+ExceptionOr&lt;void&gt; CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify(const CryptoAlgorithmRsaSsaParamsDeprecated&amp;, const CryptoKeyRSA&amp;, const CryptoOperationData&amp;, const CryptoOperationData&amp;, BoolCallback&amp;&amp;, VoidCallback&amp;&amp;)
+{
+    notImplemented();
+    return Exception { NOT_SUPPORTED_ERR };
+}
+
+} // namespace WebCore
+
+#endif // ENABLE(SUBTLE_CRYPTO)
</ins></span></pre></div>
<a id="trunkSourceWebCoredomScriptElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ScriptElement.cpp (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ScriptElement.cpp        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebCore/dom/ScriptElement.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -170,9 +170,6 @@
</span><span class="cx">     if (!m_element.document().isHTMLDocument())
</span><span class="cx">         return std::nullopt;
</span><span class="cx"> 
</span><del>-    auto* settings = m_element.document().settings();
-    if (!settings || !settings-&gt;es6ModulesEnabled())
-        return std::nullopt;
</del><span class="cx">     // https://html.spec.whatwg.org/multipage/scripting.html#attr-script-type
</span><span class="cx">     // Setting the attribute to an ASCII case-insensitive match for the string &quot;module&quot; means that the script is a module script.
</span><span class="cx">     if (equalLettersIgnoringASCIICase(type, &quot;module&quot;))
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserHTMLPreloadScannercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -212,11 +212,8 @@
</span><span class="cx">             break;
</span><span class="cx">         case TagId::Script:
</span><span class="cx">             if (match(attributeName, typeAttr)) {
</span><del>-                auto* settings = document.settings();
-                if (settings &amp;&amp; settings-&gt;es6ModulesEnabled()) {
-                    m_moduleScript = equalLettersIgnoringASCIICase(attributeValue, &quot;module&quot;) ? PreloadRequest::ModuleScript::Yes : PreloadRequest::ModuleScript::No;
-                    break;
-                }
</del><ins>+                m_moduleScript = equalLettersIgnoringASCIICase(attributeValue, &quot;module&quot;) ? PreloadRequest::ModuleScript::Yes : PreloadRequest::ModuleScript::No;
+                break;
</ins><span class="cx">             } else if (match(attributeName, nonceAttr))
</span><span class="cx">                 m_nonceAttribute = attributeValue;
</span><span class="cx">             processImageAndScriptAttribute(attributeName, attributeValue);
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.in (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.in        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebCore/page/Settings.in        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -291,6 +291,4 @@
</span><span class="cx"> largeImageAsyncDecodingEnabled initial=true
</span><span class="cx"> animatedImageAsyncDecodingEnabled initial=true
</span><span class="cx"> 
</span><del>-es6ModulesEnabled initial=false
-
</del><span class="cx"> shouldSuppressKeyboardInputDuringProvisionalNavigation initial=false
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/mac/ChangeLog        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-12-19  Yusuke Suzuki  &lt;utatane.tea@gmail.com&gt;
+
+        [ES6] Enable ES6 Modules
+        https://bugs.webkit.org/show_bug.cgi?id=165849
+
+        Reviewed by Geoffrey Garen.
+
+        * WebView/WebPreferenceKeysPrivate.h:
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]):
+        (-[WebPreferences es6ModulesEnabled]): Deleted.
+        (-[WebPreferences setES6ModulesEnabled:]): Deleted.
+        * WebView/WebPreferencesPrivate.h:
+        * WebView/WebView.mm:
+        (-[WebView _preferencesChanged:]):
+
</ins><span class="cx"> 2016-12-16  Dave Hyatt  &lt;hyatt@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -168,7 +168,6 @@
</span><span class="cx"> #define WebKitDOMIteratorEnabledPreferenceKey @&quot;WebKitDOMIteratorEnabled&quot;
</span><span class="cx"> #define WebKitFetchAPIEnabledPreferenceKey @&quot;WebKitFetchAPIEnabled&quot;
</span><span class="cx"> #define WebKitDownloadAttributeEnabledPreferenceKey @&quot;WebKitDownloadAttributeEnabled&quot;
</span><del>-#define WebKitES6ModulesEnabledPreferenceKey @&quot;WebKitES6ModulesEnabled&quot;
</del><span class="cx"> #define WebKitCSSGridLayoutEnabledPreferenceKey @&quot;WebKitCSSGridLayoutEnabled&quot;
</span><span class="cx"> #define WebKitVisualViewportEnabledPreferenceKey @&quot;WebKitVisualViewportEnabled&quot;
</span><span class="cx"> #define WebKitModernMediaControlsEnabledPreferenceKey @&quot;WebKitModernMediaControlsEnabled&quot;
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -621,7 +621,6 @@
</span><span class="cx"> #if ENABLE(DOWNLOAD_ATTRIBUTE)
</span><span class="cx">         [NSNumber numberWithBool:NO], WebKitDownloadAttributeEnabledPreferenceKey,
</span><span class="cx"> #endif
</span><del>-        [NSNumber numberWithBool:NO], WebKitES6ModulesEnabledPreferenceKey,
</del><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx">         [NSNumber numberWithBool:YES], WebKitCSSGridLayoutEnabledPreferenceKey,
</span><span class="cx"> #endif
</span><span class="lines">@@ -2848,16 +2847,6 @@
</span><span class="cx">     [self _setBoolValue:flag forKey:WebKitDownloadAttributeEnabledPreferenceKey];
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-- (BOOL)es6ModulesEnabled
-{
-    return [self _boolValueForKey:WebKitES6ModulesEnabledPreferenceKey];
-}
-
-- (void)setES6ModulesEnabled:(BOOL)flag
-{
-    [self _setBoolValue:flag forKey:WebKitES6ModulesEnabledPreferenceKey];
-}
-
</del><span class="cx"> - (BOOL)isCSSGridLayoutEnabled
</span><span class="cx"> {
</span><span class="cx">     return [self _boolValueForKey:WebKitCSSGridLayoutEnabledPreferenceKey];
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -505,9 +505,6 @@
</span><span class="cx"> - (void)setDownloadAttributeEnabled:(BOOL)flag;
</span><span class="cx"> - (BOOL)downloadAttributeEnabled;
</span><span class="cx"> 
</span><del>-- (void)setES6ModulesEnabled:(BOOL)flag;
-- (BOOL)es6ModulesEnabled;
-
</del><span class="cx"> - (void)setCSSGridLayoutEnabled:(BOOL)flag;
</span><span class="cx"> - (BOOL)isCSSGridLayoutEnabled;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -2859,8 +2859,6 @@
</span><span class="cx">     RuntimeEnabledFeatures::sharedFeatures().setDownloadAttributeEnabled([preferences downloadAttributeEnabled]);
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    settings.setEs6ModulesEnabled([preferences es6ModulesEnabled]);
-
</del><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx">     RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled([preferences isCSSGridLayoutEnabled]);
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/ChangeLog        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-12-19  Yusuke Suzuki  &lt;utatane.tea@gmail.com&gt;
+
+        [ES6] Enable ES6 Modules
+        https://bugs.webkit.org/show_bug.cgi?id=165849
+
+        Reviewed by Geoffrey Garen.
+
+        * Interfaces/IWebPreferencesPrivate.idl:
+        * WebPreferenceKeysPrivate.h:
+        * WebPreferences.cpp:
+        (WebPreferences::setES6ModulesEnabled): Deleted.
+        (WebPreferences::es6ModulesEnabled): Deleted.
+        * WebPreferences.h:
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
</ins><span class="cx"> 2016-12-10  Filip Pizlo  &lt;fpizlo@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         The DOM should have an advancing wavefront opaque root barrier
</span></span></pre></div>
<a id="trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -185,8 +185,6 @@
</span><span class="cx">     HRESULT setCustomElementsEnabled([in] BOOL enabled);
</span><span class="cx">     HRESULT modernMediaControlsEnabled([out, retval] BOOL* enabled);
</span><span class="cx">     HRESULT setModernMediaControlsEnabled([in] BOOL enabled);
</span><del>-    HRESULT es6ModulesEnabled([out, retval] BOOL* enabled);
-    HRESULT setES6ModulesEnabled([in] BOOL enabled);
</del><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> [uuid(F9582D72-6348-45B1-AB09-39E33459B5B9)]
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -177,5 +177,3 @@
</span><span class="cx"> #define WebKitCustomElementsEnabledPreferenceKey &quot;WebKitCustomElementsEnabled&quot;
</span><span class="cx"> 
</span><span class="cx"> #define WebKitModernMediaControlsEnabledPreferenceKey &quot;WebKitModernMediaControlsEnabled&quot;
</span><del>-
-#define WebKitES6ModulesEnabledPreferenceKey &quot;WebKitES6ModulesEnabled&quot;
</del></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferences.cpp (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferences.cpp        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/WebPreferences.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -2003,20 +2003,6 @@
</span><span class="cx">     return S_OK;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-HRESULT WebPreferences::setES6ModulesEnabled(BOOL enabled)
-{
-    setBoolValue(WebKitES6ModulesEnabledPreferenceKey, enabled);
-    return S_OK;
-}
-
-HRESULT WebPreferences::es6ModulesEnabled(_Out_ BOOL* enabled)
-{
-    if (!enabled)
-        return E_POINTER;
-    *enabled = boolValueForKey(WebKitES6ModulesEnabledPreferenceKey);
-    return S_OK;
-}
-
</del><span class="cx"> HRESULT WebPreferences::setApplicationId(BSTR applicationId)
</span><span class="cx"> {
</span><span class="cx">     m_applicationId = String(applicationId).createCFString();
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebPreferencesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferences.h (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebPreferences.h        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/WebPreferences.h        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -242,8 +242,6 @@
</span><span class="cx">     virtual HRESULT STDMETHODCALLTYPE setCustomElementsEnabled(BOOL);
</span><span class="cx">     virtual HRESULT STDMETHODCALLTYPE modernMediaControlsEnabled(_Out_ BOOL*);
</span><span class="cx">     virtual HRESULT STDMETHODCALLTYPE setModernMediaControlsEnabled(BOOL);
</span><del>-    virtual HRESULT STDMETHODCALLTYPE es6ModulesEnabled(_Out_ BOOL*);
-    virtual HRESULT STDMETHODCALLTYPE setES6ModulesEnabled(BOOL);
</del><span class="cx"> 
</span><span class="cx">     // IWebPreferencesPrivate4
</span><span class="cx">     virtual HRESULT STDMETHODCALLTYPE setApplicationId(BSTR);
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebView.cpp (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebView.cpp        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit/win/WebView.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -5254,11 +5254,6 @@
</span><span class="cx">         return hr;
</span><span class="cx">     RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled(!!enabled);
</span><span class="cx"> 
</span><del>-    hr = prefsPrivate-&gt;es6ModulesEnabled(&amp;enabled);
-    if (FAILED(hr))
-        return hr;
-    settings.setEs6ModulesEnabled(!!enabled);
-
</del><span class="cx">     hr = prefsPrivate-&gt;modernMediaControlsEnabled(&amp;enabled);
</span><span class="cx">     if (FAILED(hr))
</span><span class="cx">         return hr;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/ChangeLog        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-12-19  Yusuke Suzuki  &lt;utatane.tea@gmail.com&gt;
+
+        [ES6] Enable ES6 Modules
+        https://bugs.webkit.org/show_bug.cgi?id=165849
+
+        Reviewed by Geoffrey Garen.
+
+        * Shared/WebPreferencesDefinitions.h:
+        * UIProcess/API/C/WKPreferences.cpp:
+        (WKPreferencesSetES6ModulesEnabled): Deleted.
+        (WKPreferencesGetES6ModulesEnabled): Deleted.
+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::updatePreferences):
+
</ins><span class="cx"> 2016-12-19  Keith Rollin  &lt;krollin@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Fix unwanted deletion of record/replay files
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesDefinitionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -321,7 +321,6 @@
</span><span class="cx">     macro(InputEventsEnabled, inputEventsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, &quot;Input Events&quot;, &quot;Enable InputEvents support&quot;) \
</span><span class="cx">     macro(SubtleCryptoEnabled, subtleCryptoEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, &quot;SubtleCrypto&quot;, &quot;Enable SubtleCrypto support&quot;) \
</span><span class="cx">     macro(WebGL2Enabled, webGL2Enabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, &quot;WebGL 2.0&quot;, &quot;WebGL 2 prototype&quot;) \
</span><del>-    macro(ES6ModulesEnabled, es6ModulesEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, &quot;ES6 Modules&quot;, &quot;Enable ES6 Modules support&quot;) \
</del><span class="cx">     \
</span><span class="cx"> 
</span><span class="cx"> #if PLATFORM(COCOA)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -1561,16 +1561,6 @@
</span><span class="cx">     return toImpl(preferencesRef)-&gt;downloadAttributeEnabled();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void WKPreferencesSetES6ModulesEnabled(WKPreferencesRef preferencesRef, bool flag)
-{
-    toImpl(preferencesRef)-&gt;setES6ModulesEnabled(flag);
-}
-
-bool WKPreferencesGetES6ModulesEnabled(WKPreferencesRef preferencesRef)
-{
-    return toImpl(preferencesRef)-&gt;es6ModulesEnabled();
-}
-
</del><span class="cx"> void WKPreferencesSetIntersectionObserverEnabled(WKPreferencesRef preferencesRef, bool flag)
</span><span class="cx"> {
</span><span class="cx">     toImpl(preferencesRef)-&gt;setIntersectionObserverEnabled(flag);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -442,10 +442,6 @@
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetAllowsPictureInPictureMediaPlayback(WKPreferencesRef);
</span><span class="cx"> 
</span><span class="cx"> // Defaults to false
</span><del>-WK_EXPORT void WKPreferencesSetES6ModulesEnabled(WKPreferencesRef, bool flag);
-WK_EXPORT bool WKPreferencesGetES6ModulesEnabled(WKPreferencesRef);
-
-// Defaults to false
</del><span class="cx"> WK_EXPORT void WKPreferencesSetIntersectionObserverEnabled(WKPreferencesRef, bool flag);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetIntersectionObserverEnabled(WKPreferencesRef);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -259,7 +259,6 @@
</span><span class="cx">     macro(WebKitVisualViewportEnabled, VisualViewportEnabled, visualViewportEnabled) \
</span><span class="cx">     macro(WebKitLargeImageAsyncDecodingEnabled, LargeImageAsyncDecodingEnabled, largeImageAsyncDecodingEnabled) \
</span><span class="cx">     macro(WebKitAnimatedImageAsyncDecodingEnabled, AnimatedImageAsyncDecodingEnabled, animatedImageAsyncDecodingEnabled) \
</span><del>-    macro(WebKitES6ModulesEnabled, Es6ModulesEnabled, es6ModulesEnabled) \
</del><span class="cx">     \
</span><span class="cx"> 
</span><span class="cx"> #define OVERRIDE_PREFERENCE_AND_SET_IN_EXISTING_PAGES(TestRunnerName, SettingsName, WebPreferencesName) \
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -3189,8 +3189,6 @@
</span><span class="cx">     RuntimeEnabledFeatures::sharedFeatures().setDownloadAttributeEnabled(store.getBoolValueForKey(WebPreferencesKey::downloadAttributeEnabledKey()));
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-    settings.setEs6ModulesEnabled(store.getBoolValueForKey(WebPreferencesKey::es6ModulesEnabledKey()));
-
</del><span class="cx">     RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(store.getBoolValueForKey(WebPreferencesKey::shadowDOMEnabledKey()));
</span><span class="cx"> 
</span><span class="cx">     RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled(store.getBoolValueForKey(WebPreferencesKey::interactiveFormValidationEnabledKey()));
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/ChangeLog        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-12-19  Yusuke Suzuki  &lt;utatane.tea@gmail.com&gt;
+
+        [ES6] Enable ES6 Modules
+        https://bugs.webkit.org/show_bug.cgi?id=165849
+
+        Reviewed by Geoffrey Garen.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (resetWebPreferencesToConsistentValues):
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (resetWebPreferencesToConsistentValues):
+        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+        (WTR::InjectedBundle::beginTesting):
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::setES6ModulesEnabled): Deleted.
+        * WebKitTestRunner/InjectedBundle/TestRunner.h:
+
</ins><span class="cx"> 2016-12-19  Ryan Haddad  &lt;ryanhaddad@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Repurpose bots and clean up dashboard.
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacDumpRenderTreemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -992,8 +992,6 @@
</span><span class="cx"> 
</span><span class="cx">     [preferences setDownloadAttributeEnabled:YES];
</span><span class="cx"> 
</span><del>-    [preferences setES6ModulesEnabled:YES];
-
</del><span class="cx">     [preferences setHiddenPageDOMTimerThrottlingEnabled:NO];
</span><span class="cx">     [preferences setHiddenPageCSSAnimationSuspensionEnabled:NO];
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreewinDumpRenderTreecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -853,7 +853,6 @@
</span><span class="cx">     prefsPrivate3-&gt;setFetchAPIEnabled(TRUE);
</span><span class="cx">     prefsPrivate3-&gt;setShadowDOMEnabled(TRUE);
</span><span class="cx">     prefsPrivate3-&gt;setCustomElementsEnabled(TRUE);
</span><del>-    prefsPrivate3-&gt;setES6ModulesEnabled(TRUE);
</del><span class="cx"> 
</span><span class="cx">     prefsPrivate3-&gt;setDOMIteratorEnabled(TRUE);
</span><span class="cx">     prefsPrivate3-&gt;setModernMediaControlsEnabled(FALSE);
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -330,8 +330,6 @@
</span><span class="cx"> 
</span><span class="cx">     m_testRunner-&gt;setDownloadAttributeEnabled(true);
</span><span class="cx"> 
</span><del>-    m_testRunner-&gt;setES6ModulesEnabled(true);
-
</del><span class="cx">     m_testRunner-&gt;setEncryptedMediaAPIEnabled(true);
</span><span class="cx"> 
</span><span class="cx">     m_testRunner-&gt;setCloseRemainingWindowsWhenComplete(false);
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleTestRunnercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -410,13 +410,6 @@
</span><span class="cx">     WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void TestRunner::setES6ModulesEnabled(bool enabled)
-{
-    WKRetainPtr&lt;WKStringRef&gt; key(AdoptWK, WKStringCreateWithUTF8CString(&quot;WebKitES6ModulesEnabled&quot;));
-    auto&amp; injectedBundle = InjectedBundle::singleton();
-    WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
-}
-
</del><span class="cx"> void TestRunner::setEncryptedMediaAPIEnabled(bool enabled)
</span><span class="cx"> {
</span><span class="cx">     WKRetainPtr&lt;WKStringRef&gt; key(AdoptWK, WKStringCreateWithUTF8CString(&quot;WebKitEncryptedMediaAPIEnabled&quot;));
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleTestRunnerh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h (210015 => 210016)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h        2016-12-20 03:14:10 UTC (rev 210015)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h        2016-12-20 08:32:52 UTC (rev 210016)
</span><span class="lines">@@ -129,7 +129,6 @@
</span><span class="cx">     void setAsynchronousSpellCheckingEnabled(bool);
</span><span class="cx">     void setDownloadAttributeEnabled(bool);
</span><span class="cx">     void setAllowsAnySSLCertificate(bool);
</span><del>-    void setES6ModulesEnabled(bool);
</del><span class="cx">     void setEncryptedMediaAPIEnabled(bool);
</span><span class="cx">     void setSubtleCryptoEnabled(bool);
</span><span class="cx">     void setMediaStreamEnabled(bool);
</span></span></pre>
</div>
</div>

</body>
</html>