<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210045] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210045">210045</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2016-12-20 15:53:48 -0800 (Tue, 20 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove initEvent quirk
https://bugs.webkit.org/show_bug.cgi?id=166284
Reviewed by Dan Bernstein.
LayoutTests/imported/w3c:
* web-platform-tests/dom/interfaces-expected.txt:
We regress conformance, but a change has been proposed to the spec. Hopefully this will be a temporary regression.
Source/WebCore:
We added this quirk in <a href="http://trac.webkit.org/projects/webkit/changeset/207908">r207908</a> and expanded it in <a href="http://trac.webkit.org/projects/webkit/changeset/209946">r209946</a> and <a href="http://trac.webkit.org/projects/webkit/changeset/210034">r210034</a>.
Many web compatibility issues have been found, which leads us to believe that many more exist.
This reverts the behavior to match how it was before <a href="http://trac.webkit.org/projects/webkit/changeset/203848">r203848</a>.
This change was proposed to the spec in https://github.com/whatwg/dom/issues/387
* dom/Event.cpp:
(WebCore::Event::initEventForBindings): Deleted.
* dom/Event.h:
* dom/Event.idl:
* platform/RuntimeApplicationChecks.h:
* platform/RuntimeApplicationChecks.mm:
(WebCore::IOSApplication::isBaiduNuomi): Deleted.
(WebCore::IOSApplication::isAutoNaviAMap): Deleted.
(WebCore::IOSApplication::isFlipboard): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomEventcpp">trunk/Source/WebCore/dom/Event.cpp</a></li>
<li><a href="#trunkSourceWebCoredomEventh">trunk/Source/WebCore/dom/Event.h</a></li>
<li><a href="#trunkSourceWebCoredomEventidl">trunk/Source/WebCore/dom/Event.idl</a></li>
<li><a href="#trunkSourceWebCoreplatformRuntimeApplicationChecksh">trunk/Source/WebCore/platform/RuntimeApplicationChecks.h</a></li>
<li><a href="#trunkSourceWebCoreplatformRuntimeApplicationChecksmm">trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (210044 => 210045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-12-20 23:42:25 UTC (rev 210044)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-12-20 23:53:48 UTC (rev 210045)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-12-20 Alex Christensen <achristensen@webkit.org>
+
+ Remove initEvent quirk
+ https://bugs.webkit.org/show_bug.cgi?id=166284
+
+ Reviewed by Dan Bernstein.
+
+ * web-platform-tests/dom/interfaces-expected.txt:
+ We regress conformance, but a change has been proposed to the spec. Hopefully this will be a temporary regression.
+
</ins><span class="cx"> 2016-12-20 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> WebRTC: RTCPeerConnection constructor argument should be optional
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (210044 => 210045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-12-20 23:42:25 UTC (rev 210044)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-12-20 23:53:48 UTC (rev 210045)
</span><span class="lines">@@ -46,7 +46,9 @@
</span><span class="cx"> PASS Event interface: document.createEvent("Event") must have own property "isTrusted"
</span><span class="cx"> PASS Event interface: document.createEvent("Event") must inherit property "timeStamp" with the proper type (15)
</span><span class="cx"> PASS Event interface: document.createEvent("Event") must inherit property "initEvent" with the proper type (16)
</span><del>-PASS Event interface: calling initEvent(DOMString,boolean,boolean) on document.createEvent("Event") with too few arguments must throw TypeError
</del><ins>+FAIL Event interface: calling initEvent(DOMString,boolean,boolean) on document.createEvent("Event") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
+ fn.apply(obj, args);
+ }" did not throw
</ins><span class="cx"> PASS Event must be primary interface of new Event("foo")
</span><span class="cx"> PASS Stringification of new Event("foo")
</span><span class="cx"> PASS Event interface: new Event("foo") must inherit property "type" with the proper type (0)
</span><span class="lines">@@ -66,7 +68,9 @@
</span><span class="cx"> PASS Event interface: new Event("foo") must have own property "isTrusted"
</span><span class="cx"> PASS Event interface: new Event("foo") must inherit property "timeStamp" with the proper type (15)
</span><span class="cx"> PASS Event interface: new Event("foo") must inherit property "initEvent" with the proper type (16)
</span><del>-PASS Event interface: calling initEvent(DOMString,boolean,boolean) on new Event("foo") with too few arguments must throw TypeError
</del><ins>+FAIL Event interface: calling initEvent(DOMString,boolean,boolean) on new Event("foo") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
+ fn.apply(obj, args);
+ }" did not throw
</ins><span class="cx"> PASS CustomEvent interface: existence and properties of interface object
</span><span class="cx"> PASS CustomEvent interface object length
</span><span class="cx"> PASS CustomEvent interface object name
</span><span class="lines">@@ -96,7 +100,9 @@
</span><span class="cx"> PASS Event interface: new CustomEvent("foo") must have own property "isTrusted"
</span><span class="cx"> PASS Event interface: new CustomEvent("foo") must inherit property "timeStamp" with the proper type (15)
</span><span class="cx"> PASS Event interface: new CustomEvent("foo") must inherit property "initEvent" with the proper type (16)
</span><del>-PASS Event interface: calling initEvent(DOMString,boolean,boolean) on new CustomEvent("foo") with too few arguments must throw TypeError
</del><ins>+FAIL Event interface: calling initEvent(DOMString,boolean,boolean) on new CustomEvent("foo") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
+ fn.apply(obj, args);
+ }" did not throw
</ins><span class="cx"> PASS EventTarget interface: existence and properties of interface object
</span><span class="cx"> PASS EventTarget interface object length
</span><span class="cx"> PASS EventTarget interface object name
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210044 => 210045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-20 23:42:25 UTC (rev 210044)
+++ trunk/Source/WebCore/ChangeLog 2016-12-20 23:53:48 UTC (rev 210045)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-12-20 Alex Christensen <achristensen@webkit.org>
+
+ Remove initEvent quirk
+ https://bugs.webkit.org/show_bug.cgi?id=166284
+
+ Reviewed by Dan Bernstein.
+
+ We added this quirk in r207908 and expanded it in r209946 and r210034.
+ Many web compatibility issues have been found, which leads us to believe that many more exist.
+ This reverts the behavior to match how it was before r203848.
+ This change was proposed to the spec in https://github.com/whatwg/dom/issues/387
+
+ * dom/Event.cpp:
+ (WebCore::Event::initEventForBindings): Deleted.
+ * dom/Event.h:
+ * dom/Event.idl:
+ * platform/RuntimeApplicationChecks.h:
+ * platform/RuntimeApplicationChecks.mm:
+ (WebCore::IOSApplication::isBaiduNuomi): Deleted.
+ (WebCore::IOSApplication::isAutoNaviAMap): Deleted.
+ (WebCore::IOSApplication::isFlipboard): Deleted.
+
</ins><span class="cx"> 2016-12-20 JF Bastien <jfbastien@apple.com>
</span><span class="cx">
</span><span class="cx"> INDIE_UI: fix cmake build
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Event.cpp (210044 => 210045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Event.cpp 2016-12-20 23:42:25 UTC (rev 210044)
+++ trunk/Source/WebCore/dom/Event.cpp 2016-12-20 23:53:48 UTC (rev 210045)
</span><span class="lines">@@ -26,7 +26,6 @@
</span><span class="cx"> #include "EventNames.h"
</span><span class="cx"> #include "EventPath.h"
</span><span class="cx"> #include "EventTarget.h"
</span><del>-#include "RuntimeApplicationChecks.h"
</del><span class="cx"> #include "UserGestureIndicator.h"
</span><span class="cx"> #include <wtf/CurrentTime.h>
</span><span class="cx">
</span><span class="lines">@@ -90,25 +89,6 @@
</span><span class="cx"> m_cancelable = cancelableArg;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-ExceptionOr<void> Event::initEventForBindings(ScriptExecutionContext& scriptExecutionContext, const AtomicString& type, bool bubbles)
-{
-#if PLATFORM(IOS)
- // FIXME: Temporary quirk for Baidu Nuomi App which calls initEvent() with too few parameters (rdar://problem/28707838).
- // FIXME: Quirk also needed for Flipboard for same reason (rdar://problem/28264190).
- // FIXME: We really ought to consider if this is web compatible. AutoNavi also uses initEvent with one parameter. rdar://problem/29420268
- if (IOSApplication::isBaiduNuomi() || IOSApplication::isFlipboard() || IOSApplication::isAutoNaviAMap()) {
- scriptExecutionContext.addConsoleMessage(MessageSource::JS, MessageLevel::Warning, ASCIILiteral("Calling Event.prototype.initEvent() with less than 3 parameters is deprecated."));
- initEvent(type, bubbles, false);
- return { };
- }
-#else
- UNUSED_PARAM(scriptExecutionContext);
- UNUSED_PARAM(type);
- UNUSED_PARAM(bubbles);
-#endif
- return Exception { TypeError, ASCIILiteral("Not enough arguments") };
-}
-
</del><span class="cx"> bool Event::composed() const
</span><span class="cx"> {
</span><span class="cx"> if (m_composed)
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Event.h (210044 => 210045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Event.h 2016-12-20 23:42:25 UTC (rev 210044)
+++ trunk/Source/WebCore/dom/Event.h 2016-12-20 23:53:48 UTC (rev 210045)
</span><span class="lines">@@ -96,7 +96,6 @@
</span><span class="cx"> virtual ~Event();
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void initEvent(const AtomicString& type, bool canBubble, bool cancelable);
</span><del>- ExceptionOr<void> initEventForBindings(ScriptExecutionContext&, const AtomicString& type, bool bubbles); // Quirk.
</del><span class="cx">
</span><span class="cx"> bool isInitialized() const { return m_isInitialized; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Event.idl (210044 => 210045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Event.idl 2016-12-20 23:42:25 UTC (rev 210044)
+++ trunk/Source/WebCore/dom/Event.idl 2016-12-20 23:53:48 UTC (rev 210045)
</span><span class="lines">@@ -66,8 +66,7 @@
</span><span class="cx"> void stopPropagation();
</span><span class="cx"> void preventDefault();
</span><span class="cx">
</span><del>- void initEvent(DOMString type, boolean bubbles, boolean cancelable); // Standard.
- [MayThrowException, ImplementedAs=initEventForBindings, CallWith=ScriptExecutionContext] void initEvent(DOMString type, optional boolean bubbles = false); // Quirk.
</del><ins>+ void initEvent(optional DOMString type = "undefined", optional boolean bubbles = false, optional boolean cancelable = false);
</ins><span class="cx">
</span><span class="cx"> readonly attribute boolean defaultPrevented;
</span><span class="cx"> void stopImmediatePropagation();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformRuntimeApplicationChecksh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (210044 => 210045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2016-12-20 23:42:25 UTC (rev 210044)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2016-12-20 23:53:48 UTC (rev 210045)
</span><span class="lines">@@ -76,9 +76,6 @@
</span><span class="cx"> WEBCORE_EXPORT bool isWebProcess();
</span><span class="cx"> bool isIBooks();
</span><span class="cx"> WEBCORE_EXPORT bool isTheSecretSocietyHiddenMystery();
</span><del>-bool isBaiduNuomi();
-bool isFlipboard();
-bool isAutoNaviAMap();
</del><span class="cx">
</span><span class="cx"> } // IOSApplication
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformRuntimeApplicationChecksmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm (210044 => 210045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm 2016-12-20 23:42:25 UTC (rev 210044)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.mm 2016-12-20 23:53:48 UTC (rev 210045)
</span><span class="lines">@@ -253,24 +253,6 @@
</span><span class="cx"> return isTheSecretSocietyHiddenMystery;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool IOSApplication::isBaiduNuomi()
-{
- static bool isBaiduNuomi = applicationBundleIsEqualTo("com.renren-inc.nuomi");
- return isBaiduNuomi;
-}
-
-bool IOSApplication::isAutoNaviAMap()
-{
- static bool isBaiduNuomi = applicationBundleIsEqualTo("com.autonavi.amap");
- return isBaiduNuomi;
-}
-
-bool IOSApplication::isFlipboard()
-{
- static bool isFlipboard = applicationBundleIsEqualTo("com.flipboard.flipboard-ipad");
- return isFlipboard;
-}
-
</del><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre>
</div>
</div>
</body>
</html>