<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210022] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210022">210022</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-12-20 09:25:26 -0800 (Tue, 20 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix memory leak in malformed test
https://bugs.webkit.org/show_bug.cgi?id=165917
Patch by Megan Gardner <megan_gardner@apple.com> on 2016-12-20
Reviewed by Alexey Proskuryakov.
Navigation caused 'onload' to be called twice, causing test harness to have extraneous
HID callback around after script controller was dismantled. Loading in body will eliminate
double load, and also prevent other race conditions where the body doesn't load fast enough.
* http/tests/quicklook/hide-referer-on-navigation.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestsquicklookhiderefereronnavigationhtml">trunk/LayoutTests/http/tests/quicklook/hide-referer-on-navigation.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210021 => 210022)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-20 12:27:51 UTC (rev 210021)
+++ trunk/LayoutTests/ChangeLog 2016-12-20 17:25:26 UTC (rev 210022)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-12-20 Megan Gardner <megan_gardner@apple.com>
+
+ Fix memory leak in malformed test
+ https://bugs.webkit.org/show_bug.cgi?id=165917
+
+ Reviewed by Alexey Proskuryakov.
+
+ Navigation caused 'onload' to be called twice, causing test harness to have extraneous
+ HID callback around after script controller was dismantled. Loading in body will eliminate
+ double load, and also prevent other race conditions where the body doesn't load fast enough.
+
+ * http/tests/quicklook/hide-referer-on-navigation.html:
+
</ins><span class="cx"> 2016-12-20 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> WebRTC: RTCPeerConnection constructor argument should be optional
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsquicklookhiderefereronnavigationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/quicklook/hide-referer-on-navigation.html (210021 => 210022)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/quicklook/hide-referer-on-navigation.html 2016-12-20 12:27:51 UTC (rev 210021)
+++ trunk/LayoutTests/http/tests/quicklook/hide-referer-on-navigation.html 2016-12-20 17:25:26 UTC (rev 210022)
</span><span class="lines">@@ -3,6 +3,10 @@
</span><span class="cx"> <head>
</span><span class="cx"> <script src="resources/tap-at-point-and-notify-done.js"></script>
</span><span class="cx"> <script>
</span><ins>+function doTest(){
+ tapAtPointAndNotifyDone(document.getElementsByTagName('iframe')[0].offsetLeft + 5, document.getElementsByTagName('iframe')[0].offsetTop + 5)
+}
+
</ins><span class="cx"> if (window.testRunner) {
</span><span class="cx"> testRunner.dumpAsText();
</span><span class="cx"> testRunner.dumpChildFramesAsText();
</span><span class="lines">@@ -10,8 +14,9 @@
</span><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span><del>-<body>
</del><ins>+<body onload="doTest()">
</ins><span class="cx"> <p>This test verifies that the HTTP referrer is hidden when navigating from a Microsoft Word QuickLook preview. This test PASSED only if nothing is printed below.</p>
</span><del>-<iframe src="resources/hide-referer-on-navigation.docx" onload="tapAtPoint(this.offsetLeft + 5, this.offsetTop + 5, function () { /* Do nothing */ })"></iframe>
</del><ins>+
+<iframe src="resources/hide-referer-on-navigation.docx"></iframe>
</ins><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre>
</div>
</div>
</body>
</html>