<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[210017] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/210017">210017</a></dd>
<dt>Author</dt> <dd>nael.ouedraogo@crf.canon.fr</dd>
<dt>Date</dt> <dd>2016-12-20 02:24:39 -0800 (Tue, 20 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>WebRTC: RTCPeerConnection constructor argument should be optional
https://bugs.webkit.org/show_bug.cgi?id=164057
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Update expectation of RTCPeerConnection constructor tests.
* web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:
Source/WebCore:
Modify RTCPeerConnection JSBuiltin constructor to allow RTCPeerConfiguration
argument to be optional.
Update existing tests.
* Modules/mediastream/RTCPeerConnection.js:
(initializeRTCPeerConnection):
LayoutTests:
Remove tests since they are duplicated with WPT tests.
* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/RTCPeerConnection.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionexpectedtxt">trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediastreamRTCPeerConnectionhtml">trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestswebrtcrtcpeerconnectionrtcpeerconnectionconstructorexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCPeerConnectionjs">trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (210016 => 210017)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-20 08:32:52 UTC (rev 210016)
+++ trunk/LayoutTests/ChangeLog 2016-12-20 10:24:39 UTC (rev 210017)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-12-20 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
+
+ WebRTC: RTCPeerConnection constructor argument should be optional
+ https://bugs.webkit.org/show_bug.cgi?id=164057
+
+ Reviewed by Youenn Fablet.
+
+ Remove tests since they are duplicated with WPT tests.
+
+ * fast/mediastream/RTCPeerConnection-expected.txt:
+ * fast/mediastream/RTCPeerConnection.html:
+
</ins><span class="cx"> 2016-12-19 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Marking http/tests/fetch/fetching-same-resource-with-diffferent-options.html as flaky on macOS.
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt (210016 => 210017)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt 2016-12-20 08:32:52 UTC (rev 210016)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt 2016-12-20 10:24:39 UTC (rev 210017)
</span><span class="lines">@@ -4,8 +4,6 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> PASS new RTCPeerConnection(null); threw exception TypeError: RTCPeerConnection argument must be a valid dictionary.
</span><del>-PASS new RTCPeerConnection(undefined); threw exception TypeError: RTCPeerConnection argument must be a valid dictionary.
-PASS new RTCPeerConnection(); threw exception TypeError: Not enough arguments.
</del><span class="cx"> PASS new RTCPeerConnection(''); threw exception TypeError: RTCPeerConnection argument must be a valid dictionary.
</span><span class="cx"> PASS new RTCPeerConnection({}); did not throw exception.
</span><span class="cx"> PASS new RTCPeerConnection({iceServers:[]}); did not throw exception.
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediastreamRTCPeerConnectionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html (210016 => 210017)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html 2016-12-20 08:32:52 UTC (rev 210016)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection.html 2016-12-20 10:24:39 UTC (rev 210017)
</span><span class="lines">@@ -8,8 +8,6 @@
</span><span class="cx"> description("Tests the RTCPeerConnection constructor.");
</span><span class="cx">
</span><span class="cx"> shouldThrow("new RTCPeerConnection(null);");
</span><del>- shouldThrow("new RTCPeerConnection(undefined);");
- shouldThrow("new RTCPeerConnection();");
</del><span class="cx"> shouldThrow("new RTCPeerConnection('');");
</span><span class="cx"> shouldNotThrow("new RTCPeerConnection({});");
</span><span class="cx"> shouldNotThrow("new RTCPeerConnection({iceServers:[]});");
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (210016 => 210017)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-12-20 08:32:52 UTC (rev 210016)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-12-20 10:24:39 UTC (rev 210017)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-12-20 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
+
+ WebRTC: RTCPeerConnection constructor argument should be optional
+ https://bugs.webkit.org/show_bug.cgi?id=164057
+
+ Reviewed by Youenn Fablet.
+
+ Update expectation of RTCPeerConnection constructor tests.
+
+ * web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:
+
</ins><span class="cx"> 2016-12-16 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> [Fetch API] Improve resource loading console logging
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestswebrtcrtcpeerconnectionrtcpeerconnectionconstructorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt (210016 => 210017)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt 2016-12-20 08:32:52 UTC (rev 210016)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt 2016-12-20 10:24:39 UTC (rev 210017)
</span><span class="lines">@@ -1,8 +1,8 @@
</span><span class="cx">
</span><span class="cx"> PASS RTCPeerConnection.length
</span><del>-FAIL new RTCPeerConnection() Not enough arguments
</del><ins>+PASS new RTCPeerConnection()
</ins><span class="cx"> FAIL new RTCPeerConnection(null) RTCPeerConnection argument must be a valid dictionary
</span><del>-FAIL new RTCPeerConnection(undefined) RTCPeerConnection argument must be a valid dictionary
</del><ins>+PASS new RTCPeerConnection(undefined)
</ins><span class="cx"> PASS new RTCPeerConnection({})
</span><span class="cx"> PASS new RTCPeerConnection({ iceServers: null })
</span><span class="cx"> PASS new RTCPeerConnection({ iceServers: undefined })
</span><span class="lines">@@ -93,15 +93,15 @@
</span><span class="cx"> }" did not throw
</span><span class="cx"> FAIL new RTCPeerConnection({ certificates: [certificate] }) RTCPeerConnection.generateCertificate is not a function. (In 'RTCPeerConnection.generateCertificate({ name: "ECDSA", namedCurve: "P-256" })', 'RTCPeerConnection.generateCertificate' is undefined)
</span><span class="cx"> FAIL new RTCPeerConnection({ certificates: [expiredCertificate] }) RTCPeerConnection.generateCertificate is not a function. (In 'RTCPeerConnection.generateCertificate({ name: "ECDSA", namedCurve: "P-256", expires: 0 })', 'RTCPeerConnection.generateCertificate' is undefined)
</span><del>-FAIL localDescription initial value Not enough arguments
-FAIL currentLocalDescription initial value Not enough arguments
-FAIL pendingLocalDescription initial value Not enough arguments
-FAIL remoteDescription initial value Not enough arguments
-FAIL currentRemoteDescription initial value Not enough arguments
-FAIL pendingRemoteDescription initial value Not enough arguments
-FAIL signalingState initial value Not enough arguments
-FAIL iceGatheringState initial value Not enough arguments
-FAIL iceConnectionState initial value Not enough arguments
-FAIL connectionState initial value Not enough arguments
-FAIL canTrickleIceCandidates initial value Not enough arguments
</del><ins>+PASS localDescription initial value
+PASS currentLocalDescription initial value
+PASS pendingLocalDescription initial value
+PASS remoteDescription initial value
+PASS currentRemoteDescription initial value
+PASS pendingRemoteDescription initial value
+PASS signalingState initial value
+PASS iceGatheringState initial value
+PASS iceConnectionState initial value
+FAIL connectionState initial value assert_equals: expected (string) "new" but got (undefined) undefined
+FAIL canTrickleIceCandidates initial value assert_equals: expected (object) null but got (undefined) undefined
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (210016 => 210017)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-20 08:32:52 UTC (rev 210016)
+++ trunk/Source/WebCore/ChangeLog 2016-12-20 10:24:39 UTC (rev 210017)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-12-20 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
+
+ WebRTC: RTCPeerConnection constructor argument should be optional
+ https://bugs.webkit.org/show_bug.cgi?id=164057
+
+ Reviewed by Youenn Fablet.
+
+ Modify RTCPeerConnection JSBuiltin constructor to allow RTCPeerConfiguration
+ argument to be optional.
+
+ Update existing tests.
+
+ * Modules/mediastream/RTCPeerConnection.js:
+ (initializeRTCPeerConnection):
+
</ins><span class="cx"> 2016-12-19 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [ES6] Enable ES6 Modules
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCPeerConnectionjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.js (210016 => 210017)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.js 2016-12-20 08:32:52 UTC (rev 210016)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.js 2016-12-20 10:24:39 UTC (rev 210017)
</span><span class="lines">@@ -34,10 +34,9 @@
</span><span class="cx"> {
</span><span class="cx"> "use strict";
</span><span class="cx">
</span><del>- if (arguments.length < 1)
- @throwTypeError("Not enough arguments");
-
- if (!@isObject(configuration))
</del><ins>+ if (configuration === @undefined)
+ configuration = {};
+ else if (!@isObject(configuration))
</ins><span class="cx"> @throwTypeError("RTCPeerConnection argument must be a valid dictionary");
</span><span class="cx">
</span><span class="cx"> // FIXME: Handle errors in a better way than catching and re-throwing (http://webkit.org/b/158936)
</span><span class="lines">@@ -48,7 +47,6 @@
</span><span class="cx"> : "Error creating RTCPeerConnection";
</span><span class="cx"> @throwTypeError(message);
</span><span class="cx"> }
</span><del>-
</del><span class="cx"> this.@operations = [];
</span><span class="cx"> this.@localStreams = [];
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>