<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209971] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209971">209971</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-12-18 00:11:45 -0800 (Sun, 18 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Build fix: linking WebCore was failing: you can't export inline functions.
* css/DeprecatedCSSOMPrimitiveValue.cpp:
(WebCore::DeprecatedCSSOMPrimitiveValue::primitiveType):
(WebCore::DeprecatedCSSOMPrimitiveValue::setFloatValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::getFloatValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::setStringValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::getStringValue):
* css/DeprecatedCSSOMPrimitiveValue.h:
(WebCore::DeprecatedCSSOMPrimitiveValue::primitiveType): Deleted.
(WebCore::DeprecatedCSSOMPrimitiveValue::setFloatValue): Deleted.
(WebCore::DeprecatedCSSOMPrimitiveValue::getFloatValue): Deleted.
(WebCore::DeprecatedCSSOMPrimitiveValue::setStringValue): Deleted.
(WebCore::DeprecatedCSSOMPrimitiveValue::getStringValue): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssDeprecatedCSSOMPrimitiveValuecpp">trunk/Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssDeprecatedCSSOMPrimitiveValueh">trunk/Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209970 => 209971)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-18 06:07:17 UTC (rev 209970)
+++ trunk/Source/WebCore/ChangeLog 2016-12-18 08:11:45 UTC (rev 209971)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-12-17 Simon Fraser <simon.fraser@apple.com>
+
+ Build fix: linking WebCore was failing: you can't export inline functions.
+
+ * css/DeprecatedCSSOMPrimitiveValue.cpp:
+ (WebCore::DeprecatedCSSOMPrimitiveValue::primitiveType):
+ (WebCore::DeprecatedCSSOMPrimitiveValue::setFloatValue):
+ (WebCore::DeprecatedCSSOMPrimitiveValue::getFloatValue):
+ (WebCore::DeprecatedCSSOMPrimitiveValue::setStringValue):
+ (WebCore::DeprecatedCSSOMPrimitiveValue::getStringValue):
+ * css/DeprecatedCSSOMPrimitiveValue.h:
+ (WebCore::DeprecatedCSSOMPrimitiveValue::primitiveType): Deleted.
+ (WebCore::DeprecatedCSSOMPrimitiveValue::setFloatValue): Deleted.
+ (WebCore::DeprecatedCSSOMPrimitiveValue::getFloatValue): Deleted.
+ (WebCore::DeprecatedCSSOMPrimitiveValue::setStringValue): Deleted.
+ (WebCore::DeprecatedCSSOMPrimitiveValue::getStringValue): Deleted.
+
</ins><span class="cx"> 2016-12-16 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
</span></span></pre></div>
<a id="trunkSourceWebCorecssDeprecatedCSSOMPrimitiveValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp (209970 => 209971)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp 2016-12-18 06:07:17 UTC (rev 209970)
+++ trunk/Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.cpp 2016-12-18 08:11:45 UTC (rev 209971)
</span><span class="lines">@@ -37,6 +37,32 @@
</span><span class="cx"> // such as StyleCounterValue, StyleRectValue, and StyleColorValue, these methods will get
</span><span class="cx"> // more complicated.
</span><span class="cx">
</span><ins>+
+unsigned short DeprecatedCSSOMPrimitiveValue::primitiveType() const
+{
+ return m_value->primitiveType();
+}
+
+ExceptionOr<void> DeprecatedCSSOMPrimitiveValue::setFloatValue(unsigned short unitType, double floatValue)
+{
+ return m_value->setFloatValue(unitType, floatValue);
+}
+
+ExceptionOr<float> DeprecatedCSSOMPrimitiveValue::getFloatValue(unsigned short unitType) const
+{
+ return m_value->getFloatValue(unitType);
+}
+
+ExceptionOr<void> DeprecatedCSSOMPrimitiveValue::setStringValue(unsigned short stringType, const String& stringValue)
+{
+ return m_value->setStringValue(stringType, stringValue);
+}
+
+ExceptionOr<String> DeprecatedCSSOMPrimitiveValue::getStringValue() const
+{
+ return m_value->getStringValue();
+}
+
</ins><span class="cx"> ExceptionOr<Ref<DeprecatedCSSOMCounter>> DeprecatedCSSOMPrimitiveValue::getCounterValue() const
</span><span class="cx"> {
</span><span class="cx"> ExceptionOr<Counter&> counter = m_value->getCounterValue();
</span></span></pre></div>
<a id="trunkSourceWebCorecssDeprecatedCSSOMPrimitiveValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h (209970 => 209971)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h 2016-12-18 06:07:17 UTC (rev 209970)
+++ trunk/Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h 2016-12-18 08:11:45 UTC (rev 209971)
</span><span class="lines">@@ -81,11 +81,11 @@
</span><span class="cx">
</span><span class="cx"> // FIXME: Eventually these will contain more code and not just call through to
</span><span class="cx"> // CSSPrimitiveValue.
</span><del>- WEBCORE_EXPORT unsigned short primitiveType() const { return m_value->primitiveType(); }
- WEBCORE_EXPORT ExceptionOr<void> setFloatValue(unsigned short unitType, double floatValue) { return m_value->setFloatValue(unitType, floatValue); }
- WEBCORE_EXPORT ExceptionOr<float> getFloatValue(unsigned short unitType) const { return m_value->getFloatValue(unitType); }
- WEBCORE_EXPORT ExceptionOr<void> setStringValue(unsigned short stringType, const String& stringValue) { return m_value->setStringValue(stringType, stringValue); }
- WEBCORE_EXPORT ExceptionOr<String> getStringValue() const { return m_value->getStringValue(); }
</del><ins>+ WEBCORE_EXPORT unsigned short primitiveType() const;
+ WEBCORE_EXPORT ExceptionOr<void> setFloatValue(unsigned short unitType, double);
+ WEBCORE_EXPORT ExceptionOr<float> getFloatValue(unsigned short unitType) const;
+ WEBCORE_EXPORT ExceptionOr<void> setStringValue(unsigned short stringType, const String&);
+ WEBCORE_EXPORT ExceptionOr<String> getStringValue() const;
</ins><span class="cx"> WEBCORE_EXPORT ExceptionOr<Ref<DeprecatedCSSOMCounter>> getCounterValue() const;
</span><span class="cx"> WEBCORE_EXPORT ExceptionOr<Ref<DeprecatedCSSOMRect>> getRectValue() const;
</span><span class="cx"> WEBCORE_EXPORT ExceptionOr<Ref<DeprecatedCSSOMRGBColor>> getRGBColorValue() const;
</span></span></pre>
</div>
</div>
</body>
</html>