<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209941] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209941">209941</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-12-16 15:00:48 -0800 (Fri, 16 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>HTML form validation bubble should be dismissed on navigation
https://bugs.webkit.org/show_bug.cgi?id=165960
<rdar://problem/29668086>
Reviewed by Simon Fraser.
Source/WebKit/mac:
Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
* WebView/WebView.mm:
(-[WebView _didStartProvisionalLoadForFrame:]):
Source/WebKit2:
Dismiss HTML form validation bubble on top-level navigation on WK2.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
LayoutTests:
Add layout test coverage.
* http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt: Added.
* http/tests/navigation/navigation-dismisses-validation-bubbles.html: Added.
* http/tests/navigation/resources/check-validation-bubble-not-visible.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestshttptestsnavigationnavigationdismissesvalidationbubblesexpectedtxt">trunk/LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsnavigationnavigationdismissesvalidationbubbleshtml">trunk/LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html</a></li>
<li><a href="#trunkLayoutTestshttptestsnavigationresourcescheckvalidationbubblenotvisiblehtml">trunk/LayoutTests/http/tests/navigation/resources/check-validation-bubble-not-visible.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209940 => 209941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-16 22:33:00 UTC (rev 209940)
+++ trunk/LayoutTests/ChangeLog 2016-12-16 23:00:48 UTC (rev 209941)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-12-16 Chris Dumez <cdumez@apple.com>
+
+ HTML form validation bubble should be dismissed on navigation
+ https://bugs.webkit.org/show_bug.cgi?id=165960
+ <rdar://problem/29668086>
+
+ Reviewed by Simon Fraser.
+
+ Add layout test coverage.
+
+ * http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt: Added.
+ * http/tests/navigation/navigation-dismisses-validation-bubbles.html: Added.
+ * http/tests/navigation/resources/check-validation-bubble-not-visible.html: Added.
+
</ins><span class="cx"> 2016-12-16 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Move the skip expectation for fast/visual-viewport/ios/zoomed-focus-in-fixed.html to ios-simulator-wk2.
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationnavigationdismissesvalidationbubblesexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt (0 => 209941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt 2016-12-16 23:00:48 UTC (rev 209941)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+PASS: The HTML validation bubble is no longer visible after navigating
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationnavigationdismissesvalidationbubbleshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html (0 => 209941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html (rev 0)
+++ trunk/LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html 2016-12-16 23:00:48 UTC (rev 209941)
</span><span class="lines">@@ -0,0 +1,23 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<form>
+<input id="testInput" type="text" required>
+<input id="testSubmit" type="submit">
+</form>
+<script>
+if (window.testRunner)
+ testRunner.waitUntilDone();
+
+document.getElementById("testSubmit").onclick = function() {
+ setTimeout(function() {
+ window.location = "resources/check-validation-bubble-not-visible.html";
+ }, 0);
+}
+
+onload = function() {
+ document.getElementById("testSubmit").click();
+};
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestsnavigationresourcescheckvalidationbubblenotvisiblehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/http/tests/navigation/resources/check-validation-bubble-not-visible.html (0 => 209941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/navigation/resources/check-validation-bubble-not-visible.html (rev 0)
+++ trunk/LayoutTests/http/tests/navigation/resources/check-validation-bubble-not-visible.html 2016-12-16 23:00:48 UTC (rev 209941)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+<script>
+if (window.testRunner) {
+ testRunner.waitUntilDone();
+ testRunner.dumpAsText();
+}
+
+function getValidationBubbleContents()
+{
+ return `
+ (function() {
+ return JSON.stringify(uiController.contentsOfUserInterfaceItem('validationBubble'));
+ })();`
+}
+testRunner.runUIScript(getValidationBubbleContents(), function(result) {
+ validationBubbleContents = JSON.parse(result).validationBubble;
+ if (validationBubbleContents.message === "")
+ document.body.innerHTML = "PASS: The HTML validation bubble is no longer visible after navigating";
+ else
+ document.body.innerHTML = "FAIL: The HTML validation bubble is still visible after navigating";
+
+ if (window.testRunner)
+ testRunner.notifyDone();
+});
+</script>
</ins></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (209940 => 209941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-12-16 22:33:00 UTC (rev 209940)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-12-16 23:00:48 UTC (rev 209941)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-12-16 Chris Dumez <cdumez@apple.com>
+
+ HTML form validation bubble should be dismissed on navigation
+ https://bugs.webkit.org/show_bug.cgi?id=165960
+ <rdar://problem/29668086>
+
+ Reviewed by Simon Fraser.
+
+ Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
+
+ * WebView/WebView.mm:
+ (-[WebView _didStartProvisionalLoadForFrame:]):
+
</ins><span class="cx"> 2016-12-15 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Use asString instead of toWTFString, toString, or getString when we already checked isString
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (209940 => 209941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-12-16 22:33:00 UTC (rev 209940)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-12-16 23:00:48 UTC (rev 209941)
</span><span class="lines">@@ -3286,6 +3286,8 @@
</span><span class="cx"> [self _didChangeValueForKey: _WebIsLoadingKey];
</span><span class="cx">
</span><span class="cx"> [self _willChangeValueForKey: _WebMainFrameURLKey];
</span><ins>+
+ [self hideFormValidationMessage];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> [NSApp setWindowsNeedUpdate:YES];
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (209940 => 209941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-12-16 22:33:00 UTC (rev 209940)
+++ trunk/Source/WebKit2/ChangeLog 2016-12-16 23:00:48 UTC (rev 209941)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-12-16 Chris Dumez <cdumez@apple.com>
+
+ HTML form validation bubble should be dismissed on navigation
+ https://bugs.webkit.org/show_bug.cgi?id=165960
+ <rdar://problem/29668086>
+
+ Reviewed by Simon Fraser.
+
+ Dismiss HTML form validation bubble on top-level navigation on WK2.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
+
</ins><span class="cx"> 2016-12-16 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> Small refactor: Use HashCountedSet rather than HashMap<..., int> to store client counts in WebPlaybackSessionManager{,Proxy}.
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (209940 => 209941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-12-16 22:33:00 UTC (rev 209940)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-12-16 23:00:48 UTC (rev 209941)
</span><span class="lines">@@ -3169,8 +3169,10 @@
</span><span class="cx"> if (frame->isMainFrame() && navigationID)
</span><span class="cx"> navigation = &navigationState().navigation(navigationID);
</span><span class="cx">
</span><del>- if (frame->isMainFrame())
</del><ins>+ if (frame->isMainFrame()) {
</ins><span class="cx"> m_pageLoadState.didStartProvisionalLoad(transaction, url, unreachableURL);
</span><ins>+ hideValidationMessage();
+ }
</ins><span class="cx">
</span><span class="cx"> frame->setUnreachableURL(unreachableURL);
</span><span class="cx"> frame->didStartProvisionalLoad(url);
</span></span></pre>
</div>
</div>
</body>
</html>