<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209902] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209902">209902</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2016-12-15 19:35:54 -0800 (Thu, 15 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>check-style should not complain about code in icu directories
https://bugs.webkit.org/show_bug.cgi?id=53929
Reviewed by Darin Adler.
Skip style checking of imported ICU headers to avoid a deluge of style issues
as they do not conform to the WebKit Code Style guideline. We want to preserve
the formatting of these headers so as to make it straightforward to merge
changes to them, if necessary.
* Scripts/webkitpy/style/checker.py:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckerpy">trunk/Tools/Scripts/webkitpy/style/checker.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (209901 => 209902)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-12-16 03:14:52 UTC (rev 209901)
+++ trunk/Tools/ChangeLog 2016-12-16 03:35:54 UTC (rev 209902)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-12-15 Daniel Bates <dabates@apple.com>
+
+ check-style should not complain about code in icu directories
+ https://bugs.webkit.org/show_bug.cgi?id=53929
+
+ Reviewed by Darin Adler.
+
+ Skip style checking of imported ICU headers to avoid a deluge of style issues
+ as they do not conform to the WebKit Code Style guideline. We want to preserve
+ the formatting of these headers so as to make it straightforward to merge
+ changes to them, if necessary.
+
+ * Scripts/webkitpy/style/checker.py:
+
</ins><span class="cx"> 2016-12-15 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Move JSC testers from Yosemite to Sierra
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckerpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (209901 => 209902)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checker.py 2016-12-16 03:14:52 UTC (rev 209901)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py 2016-12-16 03:35:54 UTC (rev 209902)
</span><span class="lines">@@ -315,9 +315,17 @@
</span><span class="cx"> # with FileType.NONE are automatically skipped without warning.
</span><span class="cx"> _SKIPPED_FILES_WITHOUT_WARNING = [
</span><span class="cx"> "LayoutTests" + os.path.sep,
</span><ins>+
</ins><span class="cx"> # Files generated by the bindings script should not be checked for style.
</span><del>- os.path.join('Source', 'WebCore', 'bindings', 'scripts', 'test')]
</del><ins>+ os.path.join('Source', 'WebCore', 'bindings', 'scripts', 'test'),
</ins><span class="cx">
</span><ins>+ # ICU headers are imported.
+ os.path.join('Source', 'JavaScriptCore', 'icu'),
+ os.path.join('Source', 'WebCore', 'icu'),
+ os.path.join('Source', 'WebKit', 'mac', 'icu'),
+ os.path.join('Source', 'WTF', 'icu'),
+ ]
+
</ins><span class="cx"> # Extensions of files which are allowed to contain carriage returns.
</span><span class="cx"> _CARRIAGE_RETURN_ALLOWED_FILE_EXTENSIONS = [
</span><span class="cx"> 'png',
</span></span></pre>
</div>
</div>
</body>
</html>