<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209802] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209802">209802</a></dd>
<dt>Author</dt> <dd>antti@apple.com</dd>
<dt>Date</dt> <dd>2016-12-14 08:06:50 -0800 (Wed, 14 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make Style::Update const in RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=165845
Reviewed by Andreas Kling.
Moving style away from unique_ptrs leaves them in weird state.
* style/RenderTreeUpdater.cpp:
(WebCore::findRenderingRoots):
(WebCore::RenderTreeUpdater::commit):
(WebCore::RenderTreeUpdater::updateElementRenderer):
Clone the style instead of moving it. This is not meaningfully more expensive.
Remove null checks, style is never null.
* style/RenderTreeUpdater.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorestyleRenderTreeUpdatercpp">trunk/Source/WebCore/style/RenderTreeUpdater.cpp</a></li>
<li><a href="#trunkSourceWebCorestyleRenderTreeUpdaterh">trunk/Source/WebCore/style/RenderTreeUpdater.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209801 => 209802)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-14 16:04:30 UTC (rev 209801)
+++ trunk/Source/WebCore/ChangeLog 2016-12-14 16:06:50 UTC (rev 209802)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-12-14 Antti Koivisto <antti@apple.com>
+
+ Make Style::Update const in RenderTreeUpdater
+ https://bugs.webkit.org/show_bug.cgi?id=165845
+
+ Reviewed by Andreas Kling.
+
+ Moving style away from unique_ptrs leaves them in weird state.
+
+ * style/RenderTreeUpdater.cpp:
+ (WebCore::findRenderingRoots):
+ (WebCore::RenderTreeUpdater::commit):
+ (WebCore::RenderTreeUpdater::updateElementRenderer):
+
+ Clone the style instead of moving it. This is not meaningfully more expensive.
+ Remove null checks, style is never null.
+
+ * style/RenderTreeUpdater.h:
+
</ins><span class="cx"> 2016-12-13 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Use JSValue::toWTFString instead of calling toString(exec) and value(exec)
</span></span></pre></div>
<a id="trunkSourceWebCorestyleRenderTreeUpdatercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/style/RenderTreeUpdater.cpp (209801 => 209802)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/style/RenderTreeUpdater.cpp 2016-12-14 16:04:30 UTC (rev 209801)
+++ trunk/Source/WebCore/style/RenderTreeUpdater.cpp 2016-12-14 16:06:50 UTC (rev 209802)
</span><span class="lines">@@ -93,7 +93,7 @@
</span><span class="cx"> return &node.document();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static ListHashSet<ContainerNode*> findRenderingRoots(Style::Update& update)
</del><ins>+static ListHashSet<ContainerNode*> findRenderingRoots(const Style::Update& update)
</ins><span class="cx"> {
</span><span class="cx"> ListHashSet<ContainerNode*> renderingRoots;
</span><span class="cx"> for (auto* root : update.roots()) {
</span><span class="lines">@@ -105,7 +105,7 @@
</span><span class="cx"> return renderingRoots;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderTreeUpdater::commit(std::unique_ptr<Style::Update> styleUpdate)
</del><ins>+void RenderTreeUpdater::commit(std::unique_ptr<const Style::Update> styleUpdate)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(&m_document == &styleUpdate->document());
</span><span class="cx">
</span><span class="lines">@@ -247,7 +247,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RenderTreeUpdater::updateElementRenderer(Element& element, Style::ElementUpdate& update)
</del><ins>+void RenderTreeUpdater::updateElementRenderer(Element& element, const Style::ElementUpdate& update)
</ins><span class="cx"> {
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> CheckForVisibilityChange checkForVisibilityChange(element);
</span><span class="lines">@@ -257,7 +257,7 @@
</span><span class="cx"> if (shouldTearDownRenderers)
</span><span class="cx"> tearDownRenderers(element, TeardownType::KeepHoverAndActive);
</span><span class="cx">
</span><del>- bool hasDisplayContents = update.style && update.style->display() == CONTENTS;
</del><ins>+ bool hasDisplayContents = update.style->display() == CONTENTS;
</ins><span class="cx"> if (hasDisplayContents != element.hasDisplayContents()) {
</span><span class="cx"> element.setHasDisplayContents(hasDisplayContents);
</span><span class="cx"> // Render tree position needs to be recomputed as rendering siblings may be found from the display:contents subtree.
</span><span class="lines">@@ -264,11 +264,11 @@
</span><span class="cx"> renderTreePosition().invalidateNextSibling();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- bool shouldCreateNewRenderer = !element.renderer() && update.style && !hasDisplayContents;
</del><ins>+ bool shouldCreateNewRenderer = !element.renderer() && !hasDisplayContents;
</ins><span class="cx"> if (shouldCreateNewRenderer) {
</span><span class="cx"> if (element.hasCustomStyleResolveCallbacks())
</span><span class="cx"> element.willAttachRenderers();
</span><del>- createRenderer(element, WTFMove(*update.style));
</del><ins>+ createRenderer(element, RenderStyle::clone(*update.style));
</ins><span class="cx"> invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded(element);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -278,19 +278,19 @@
</span><span class="cx"> auto& renderer = *element.renderer();
</span><span class="cx">
</span><span class="cx"> if (update.recompositeLayer) {
</span><del>- renderer.setStyle(WTFMove(*update.style), StyleDifferenceRecompositeLayer);
</del><ins>+ renderer.setStyle(RenderStyle::clone(*update.style), StyleDifferenceRecompositeLayer);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (update.change == Style::NoChange) {
</span><span class="cx"> if (pseudoStyleCacheIsInvalid(&renderer, update.style.get()) || (parent().styleChange == Style::Force && renderer.requiresForcedStyleRecalcPropagation())) {
</span><del>- renderer.setStyle(WTFMove(*update.style), StyleDifferenceEqual);
</del><ins>+ renderer.setStyle(RenderStyle::clone(*update.style), StyleDifferenceEqual);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- renderer.setStyle(WTFMove(*update.style), StyleDifferenceEqual);
</del><ins>+ renderer.setStyle(RenderStyle::clone(*update.style), StyleDifferenceEqual);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_REGIONS)
</span></span></pre></div>
<a id="trunkSourceWebCorestyleRenderTreeUpdaterh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/style/RenderTreeUpdater.h (209801 => 209802)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/style/RenderTreeUpdater.h 2016-12-14 16:04:30 UTC (rev 209801)
+++ trunk/Source/WebCore/style/RenderTreeUpdater.h 2016-12-14 16:06:50 UTC (rev 209802)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> public:
</span><span class="cx"> RenderTreeUpdater(Document&);
</span><span class="cx">
</span><del>- void commit(std::unique_ptr<Style::Update>);
</del><ins>+ void commit(std::unique_ptr<const Style::Update>);
</ins><span class="cx">
</span><span class="cx"> enum class TeardownType { Normal, KeepHoverAndActive };
</span><span class="cx"> static void tearDownRenderers(Element&, TeardownType = TeardownType::Normal);
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> private:
</span><span class="cx"> void updateRenderTree(ContainerNode& root);
</span><span class="cx"> void updateTextRenderer(Text&);
</span><del>- void updateElementRenderer(Element&, Style::ElementUpdate&);
</del><ins>+ void updateElementRenderer(Element&, const Style::ElementUpdate&);
</ins><span class="cx"> void createRenderer(Element&, RenderStyle&&);
</span><span class="cx"> void invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded(Node&);
</span><span class="cx"> void updateBeforeOrAfterPseudoElement(Element&, PseudoId);
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx"> void popParentsToDepth(unsigned depth);
</span><span class="cx">
</span><span class="cx"> Document& m_document;
</span><del>- std::unique_ptr<Style::Update> m_styleUpdate;
</del><ins>+ std::unique_ptr<const Style::Update> m_styleUpdate;
</ins><span class="cx">
</span><span class="cx"> Vector<Parent> m_parentStack;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>