<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209841] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209841">209841</a></dd>
<dt>Author</dt> <dd>weinig@apple.com</dd>
<dt>Date</dt> <dd>2016-12-14 16:04:01 -0800 (Wed, 14 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Source/WebCore:
REGRESSION (204679): Google notifications never load (expecting DOMStringList rather than JS array for Location.ancestorOrigins)
<rdar://problem/29573563>
https://bugs.webkit.org/show_bug.cgi?id=165872
Reviewed by Chris Dumez.
Revert the Location.ancestorOrigins part of <a href="http://trac.webkit.org/projects/webkit/changeset/204679">r204679</a> because google.com is relying on
it returning a DOMStringList (or at least something with a .item() function), rather
than a frozen javascript array.
Spec changes are tracked with https://github.com/whatwg/html/issues/2179.
* page/Location.cpp:
(WebCore::Location::ancestorOrigins):
* page/Location.h:
* page/Location.idl:
Change Location.ancestorOrigins back to returning a DOMStringList.
Source/WebKit2:
[WebIDL] Add support for converting dictionaries to JS
https://bugs.webkit.org/show_bug.cgi?id=165367
Reviewed by Chris Dumez.
* CMakeLists.txt:
Add missing directories to look in for headers.
LayoutTests:
REGRESSION (204679): Google notifications never load (expecting DOMStringList rather than JS array for Location.ancestorOrigins)
<rdar://problem/29573563>
https://bugs.webkit.org/show_bug.cgi?id=165872
Reviewed by Chris Dumez.
* fast/dom/Window/Location/ancestor-origins-expected.txt:
* fast/dom/Window/Location/ancestor-origins.html:
Change back to test that Location.ancestorOrigins returns a DOMStringList.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomWindowLocationancestororiginsexpectedtxt">trunk/LayoutTests/fast/dom/Window/Location/ancestor-origins-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomWindowLocationancestororiginshtml">trunk/LayoutTests/fast/dom/Window/Location/ancestor-origins.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageLocationcpp">trunk/Source/WebCore/page/Location.cpp</a></li>
<li><a href="#trunkSourceWebCorepageLocationh">trunk/Source/WebCore/page/Location.h</a></li>
<li><a href="#trunkSourceWebCorepageLocationidl">trunk/Source/WebCore/page/Location.idl</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209840 => 209841)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-15 00:00:38 UTC (rev 209840)
+++ trunk/LayoutTests/ChangeLog 2016-12-15 00:04:01 UTC (rev 209841)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-12-14 Sam Weinig <sam@webkit.org>
+
+ REGRESSION (204679): Google notifications never load (expecting DOMStringList rather than JS array for Location.ancestorOrigins)
+ <rdar://problem/29573563>
+ https://bugs.webkit.org/show_bug.cgi?id=165872
+
+ Reviewed by Chris Dumez.
+
+ * fast/dom/Window/Location/ancestor-origins-expected.txt:
+ * fast/dom/Window/Location/ancestor-origins.html:
+ Change back to test that Location.ancestorOrigins returns a DOMStringList.
+
</ins><span class="cx"> 2016-12-14 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Marking streams/pipe-to.html as flaky on macOS debug.
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomWindowLocationancestororiginsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Window/Location/ancestor-origins-expected.txt (209840 => 209841)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Window/Location/ancestor-origins-expected.txt 2016-12-15 00:00:38 UTC (rev 209840)
+++ trunk/LayoutTests/fast/dom/Window/Location/ancestor-origins-expected.txt 2016-12-15 00:04:01 UTC (rev 209841)
</span><span class="lines">@@ -3,11 +3,9 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS window.location.ancestorOrigins is an instance of Array
</del><ins>+PASS window.location.ancestorOrigins is an instance of DOMStringList
</ins><span class="cx"> PASS window.location.ancestorOrigins.length is 0
</span><del>-PASS Object.isFrozen(window.location.ancestorOrigins) is true
</del><span class="cx"> PASS window.location.ancestorOrigins === window.location.ancestorOrigins is true
</span><del>-PASS subframeOrigins is an instance of Array
</del><span class="cx"> PASS subframeOrigins.length is 1
</span><span class="cx"> PASS subframeOrigins[0] is 'file://'
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomWindowLocationancestororiginshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Window/Location/ancestor-origins.html (209840 => 209841)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Window/Location/ancestor-origins.html 2016-12-15 00:00:38 UTC (rev 209840)
+++ trunk/LayoutTests/fast/dom/Window/Location/ancestor-origins.html 2016-12-15 00:04:01 UTC (rev 209841)
</span><span class="lines">@@ -9,9 +9,8 @@
</span><span class="cx">
</span><span class="cx"> description("Test the Location object's ancestorOrigins property.")
</span><span class="cx">
</span><del>-shouldBeType("window.location.ancestorOrigins", "Array");
</del><ins>+shouldBeType("window.location.ancestorOrigins", "DOMStringList");
</ins><span class="cx"> shouldBe("window.location.ancestorOrigins.length", "0");
</span><del>-shouldBeTrue("Object.isFrozen(window.location.ancestorOrigins)");
</del><span class="cx"> shouldBeTrue("window.location.ancestorOrigins === window.location.ancestorOrigins");
</span><span class="cx">
</span><span class="cx"> var subframeOrigins;
</span><span class="lines">@@ -20,7 +19,6 @@
</span><span class="cx"> {
</span><span class="cx"> subframeOrigins = event.data;
</span><span class="cx">
</span><del>- shouldBeType("subframeOrigins", "Array");
</del><span class="cx"> shouldBe("subframeOrigins.length", "1");
</span><span class="cx"> shouldBe("subframeOrigins[0]", "'file://'");
</span><span class="cx">
</span><span class="lines">@@ -30,7 +28,11 @@
</span><span class="cx"> </script>
</span><span class="cx"> <iframe srcdoc="
</span><span class="cx"> <script>
</span><del>- top.postMessage(location.ancestorOrigins, '*')
</del><ins>+ var origins = [];
+ for (var i = 0; i < location.ancestorOrigins.length; ++i) {
+ origins.push(location.ancestorOrigins.item(i));
+ }
+ top.postMessage(origins, '*')
</ins><span class="cx"> </script>
</span><span class="cx"> "></iframe>
</span><span class="cx"> <script src="../../../../resources/js-test-post.js"></script>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209840 => 209841)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-15 00:00:38 UTC (rev 209840)
+++ trunk/Source/WebCore/ChangeLog 2016-12-15 00:04:01 UTC (rev 209841)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-12-14 Sam Weinig <sam@webkit.org>
+
+ REGRESSION (204679): Google notifications never load (expecting DOMStringList rather than JS array for Location.ancestorOrigins)
+ <rdar://problem/29573563>
+ https://bugs.webkit.org/show_bug.cgi?id=165872
+
+ Reviewed by Chris Dumez.
+
+ Revert the Location.ancestorOrigins part of r204679 because google.com is relying on
+ it returning a DOMStringList (or at least something with a .item() function), rather
+ than a frozen javascript array.
+
+ Spec changes are tracked with https://github.com/whatwg/html/issues/2179.
+
+ * page/Location.cpp:
+ (WebCore::Location::ancestorOrigins):
+ * page/Location.h:
+ * page/Location.idl:
+ Change Location.ancestorOrigins back to returning a DOMStringList.
+
</ins><span class="cx"> 2016-12-14 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> [CSS Parser] Rename StyleKeyframe to StyleRuleKeyframe
</span></span></pre></div>
<a id="trunkSourceWebCorepageLocationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Location.cpp (209840 => 209841)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Location.cpp 2016-12-15 00:00:38 UTC (rev 209840)
+++ trunk/Source/WebCore/page/Location.cpp 2016-12-15 00:04:01 UTC (rev 209841)
</span><span class="lines">@@ -131,13 +131,13 @@
</span><span class="cx"> return SecurityOrigin::create(url())->toString();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-Vector<String> Location::ancestorOrigins() const
</del><ins>+Ref<DOMStringList> Location::ancestorOrigins() const
</ins><span class="cx"> {
</span><del>- Vector<String> origins;
</del><ins>+ auto origins = DOMStringList::create();
</ins><span class="cx"> if (!m_frame)
</span><span class="cx"> return origins;
</span><span class="cx"> for (Frame* frame = m_frame->tree().parent(); frame; frame = frame->tree().parent())
</span><del>- origins.append(frame->document()->securityOrigin()->toString());
</del><ins>+ origins->append(frame->document()->securityOrigin()->toString());
</ins><span class="cx"> return origins;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageLocationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Location.h (209840 => 209841)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Location.h 2016-12-15 00:00:38 UTC (rev 209840)
+++ trunk/Source/WebCore/page/Location.h 2016-12-15 00:04:01 UTC (rev 209841)
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx">
</span><span class="cx"> String toString() const { return href(); }
</span><span class="cx">
</span><del>- Vector<String> ancestorOrigins() const;
</del><ins>+ Ref<DOMStringList> ancestorOrigins() const;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> explicit Location(Frame*);
</span></span></pre></div>
<a id="trunkSourceWebCorepageLocationidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Location.idl (209840 => 209841)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Location.idl 2016-12-15 00:00:38 UTC (rev 209840)
+++ trunk/Source/WebCore/page/Location.idl 2016-12-15 00:04:01 UTC (rev 209841)
</span><span class="lines">@@ -58,6 +58,6 @@
</span><span class="cx">
</span><span class="cx"> readonly attribute USVString origin;
</span><span class="cx">
</span><del>- // FIXME: Add support for SameObject
- [Unforgeable, CachedAttribute] readonly attribute FrozenArray<USVString> ancestorOrigins;
</del><ins>+ // FIXME: Add support for SameObject.
+ [Unforgeable, CachedAttribute] readonly attribute DOMStringList ancestorOrigins;
</ins><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (209840 => 209841)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-12-15 00:00:38 UTC (rev 209840)
+++ trunk/Source/WebKit2/ChangeLog 2016-12-15 00:04:01 UTC (rev 209841)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-12-04 Sam Weinig <sam@webkit.org>
+
+ [WebIDL] Add support for converting dictionaries to JS
+ https://bugs.webkit.org/show_bug.cgi?id=165367
+
+ Reviewed by Chris Dumez.
+
+ * CMakeLists.txt:
+ Add missing directories to look in for headers.
+
</ins><span class="cx"> 2016-12-14 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Add WKContextRefreshPlugIns
</span></span></pre>
</div>
</div>
</body>
</html>