<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209677] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209677">209677</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-12-10 16:04:30 -0800 (Sat, 10 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Support the deprecated dictionary constructor for DOMPointReadOnly and DOMPoint
https://bugs.webkit.org/show_bug.cgi?id=165732
Reviewed by Sam Weinig.
Source/WebCore:
For compatibility with other browsers, support the DOMPointInit constructor to
DOMPoint and DOMPointReadOnly per <https://www.w3.org/TR/geometry-1/#DOMPoint>
Extended geometry/DOMPoint-001.html to test.
* dom/DOMPoint.h:
* dom/DOMPoint.idl:
* dom/DOMPointReadOnly.h:
(WebCore::DOMPointReadOnly::create):
* dom/DOMPointReadOnly.idl:
LayoutTests:
* geometry/DOMPoint-001-expected.txt:
* geometry/DOMPoint-001.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsgeometryDOMPoint001expectedtxt">trunk/LayoutTests/geometry/DOMPoint-001-expected.txt</a></li>
<li><a href="#trunkLayoutTestsgeometryDOMPoint001html">trunk/LayoutTests/geometry/DOMPoint-001.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDOMPointh">trunk/Source/WebCore/dom/DOMPoint.h</a></li>
<li><a href="#trunkSourceWebCoredomDOMPointidl">trunk/Source/WebCore/dom/DOMPoint.idl</a></li>
<li><a href="#trunkSourceWebCoredomDOMPointReadOnlyh">trunk/Source/WebCore/dom/DOMPointReadOnly.h</a></li>
<li><a href="#trunkSourceWebCoredomDOMPointReadOnlyidl">trunk/Source/WebCore/dom/DOMPointReadOnly.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209676 => 209677)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-10 23:36:59 UTC (rev 209676)
+++ trunk/LayoutTests/ChangeLog 2016-12-11 00:04:30 UTC (rev 209677)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2016-12-10 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ Support the deprecated dictionary constructor for DOMPointReadOnly and DOMPoint
+ https://bugs.webkit.org/show_bug.cgi?id=165732
+
+ Reviewed by Sam Weinig.
+
+ * geometry/DOMPoint-001-expected.txt:
+ * geometry/DOMPoint-001.html:
+
+2016-12-10 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> Animation followed by transition doesn't always fire transitionend event
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=165731
</span><span class="cx"> rdar://problem/28471240
</span></span></pre></div>
<a id="trunkLayoutTestsgeometryDOMPoint001expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/geometry/DOMPoint-001-expected.txt (209676 => 209677)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/geometry/DOMPoint-001-expected.txt 2016-12-10 23:36:59 UTC (rev 209676)
+++ trunk/LayoutTests/geometry/DOMPoint-001-expected.txt 2016-12-11 00:04:30 UTC (rev 209677)
</span><span class="lines">@@ -7,6 +7,10 @@
</span><span class="cx"> PASS testConstructor3
</span><span class="cx"> PASS testConstructor4
</span><span class="cx"> PASS testConstructor5
</span><ins>+PASS testDictionaryConstructor1
+PASS testDictionaryConstructor2
+PASS testDictionaryConstructor3
+PASS testDictionaryConstructor4
</ins><span class="cx"> PASS testConstructorDOMPointInit0
</span><span class="cx"> PASS testConstructorDOMPointInit1
</span><span class="cx"> PASS testConstructorDOMPointInit2
</span></span></pre></div>
<a id="trunkLayoutTestsgeometryDOMPoint001html"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/geometry/DOMPoint-001.html (209676 => 209677)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/geometry/DOMPoint-001.html 2016-12-10 23:36:59 UTC (rev 209676)
+++ trunk/LayoutTests/geometry/DOMPoint-001.html 2016-12-11 00:04:30 UTC (rev 209677)
</span><span class="lines">@@ -35,7 +35,22 @@
</span><span class="cx"> test(function() {
</span><span class="cx"> checkDOMPoint(new DOMPoint(1, 2, 3, 4, 5), {x:1, y:2, z:3, w:4});
</span><span class="cx"> },'testConstructor5');
</span><ins>+
+ // Dictionary constructors are in http://www.w3.org/TR/geometry-1 but not http://dev.w3.org/fxtf/geometry.
</ins><span class="cx"> test(function() {
</span><ins>+ checkDOMPoint(new DOMPoint({x:1, y:2, z:3, w:4}), {x:1, y:2, z:3, w:4});
+ },'testDictionaryConstructor1');
+ test(function() {
+ checkDOMPoint(new DOMPoint({}), {x:0, y:0, z:0, w:1});
+ },'testDictionaryConstructor2');
+ test(function() {
+ checkDOMPoint(new DOMPoint({x:1}), {x:1, y:0, z:0, w:1});
+ },'testDictionaryConstructor3');
+ test(function() {
+ checkDOMPoint(new DOMPoint({y:3, w:0.5}), {x:0, y:3, z:0, w:0.5});
+ },'testDictionaryConstructor4');
+
+ test(function() {
</ins><span class="cx"> checkDOMPoint(DOMPoint.fromPoint({}), {x:0, y:0, z:0, w:1});
</span><span class="cx"> },'testConstructorDOMPointInit0');
</span><span class="cx"> test(function() {
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209676 => 209677)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-10 23:36:59 UTC (rev 209676)
+++ trunk/Source/WebCore/ChangeLog 2016-12-11 00:04:30 UTC (rev 209677)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-12-10 Simon Fraser <simon.fraser@apple.com>
+
+ Support the deprecated dictionary constructor for DOMPointReadOnly and DOMPoint
+ https://bugs.webkit.org/show_bug.cgi?id=165732
+
+ Reviewed by Sam Weinig.
+
+ For compatibility with other browsers, support the DOMPointInit constructor to
+ DOMPoint and DOMPointReadOnly per <https://www.w3.org/TR/geometry-1/#DOMPoint>
+
+ Extended geometry/DOMPoint-001.html to test.
+
+ * dom/DOMPoint.h:
+ * dom/DOMPoint.idl:
+ * dom/DOMPointReadOnly.h:
+ (WebCore::DOMPointReadOnly::create):
+ * dom/DOMPointReadOnly.idl:
+
</ins><span class="cx"> 2016-12-10 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> [CSS Parser] Make sure content extensions initialize AtomicString
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMPointh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMPoint.h (209676 => 209677)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMPoint.h 2016-12-10 23:36:59 UTC (rev 209676)
+++ trunk/Source/WebCore/dom/DOMPoint.h 2016-12-11 00:04:30 UTC (rev 209677)
</span><span class="lines">@@ -38,6 +38,7 @@
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> static Ref<DOMPoint> create(double x, double y, double z, double w) { return adoptRef(*new DOMPoint(x, y, z, w)); }
</span><ins>+ static Ref<DOMPoint> create(const DOMPointInit& init) { return create(init.x, init.y, init.z, init.w); }
</ins><span class="cx"> static Ref<DOMPoint> fromPoint(const DOMPointInit& init) { return create(init.x, init.y, init.z, init.w); }
</span><span class="cx">
</span><span class="cx"> void setX(double x) { m_x = x; }
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMPointidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMPoint.idl (209676 => 209677)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMPoint.idl 2016-12-10 23:36:59 UTC (rev 209676)
+++ trunk/Source/WebCore/dom/DOMPoint.idl 2016-12-11 00:04:30 UTC (rev 209677)
</span><span class="lines">@@ -28,7 +28,9 @@
</span><span class="cx"> * OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><ins>+// The DOMPointInit constructor exists in https://www.w3.org/TR/geometry-1/ but is removed in https://drafts.fxtf.org/geometry/
</ins><span class="cx"> [
</span><ins>+ Constructor(DOMPointInit point),
</ins><span class="cx"> Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
</span><span class="cx"> optional unrestricted double z = 0, optional unrestricted double w = 1),
</span><span class="cx"> Exposed=(Window,Worker),
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMPointReadOnlyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMPointReadOnly.h (209676 => 209677)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMPointReadOnly.h 2016-12-10 23:36:59 UTC (rev 209676)
+++ trunk/Source/WebCore/dom/DOMPointReadOnly.h 2016-12-11 00:04:30 UTC (rev 209677)
</span><span class="lines">@@ -40,6 +40,7 @@
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="cx"> static Ref<DOMPointReadOnly> create(double x, double y, double z, double w) { return adoptRef(*new DOMPointReadOnly(x, y, z, w)); }
</span><ins>+ static Ref<DOMPointReadOnly> create(const DOMPointInit& init) { return create(init.x, init.y, init.z, init.w); }
</ins><span class="cx"> static Ref<DOMPointReadOnly> fromPoint(const DOMPointInit& init) { return create(init.x, init.y, init.z, init.w); }
</span><span class="cx">
</span><span class="cx"> double x() const { return m_x; }
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMPointReadOnlyidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMPointReadOnly.idl (209676 => 209677)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMPointReadOnly.idl 2016-12-10 23:36:59 UTC (rev 209676)
+++ trunk/Source/WebCore/dom/DOMPointReadOnly.idl 2016-12-11 00:04:30 UTC (rev 209677)
</span><span class="lines">@@ -28,7 +28,9 @@
</span><span class="cx"> * OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><ins>+// The DOMPointInit constructor exists in https://www.w3.org/TR/geometry-1/ but is removed in https://drafts.fxtf.org/geometry/
</ins><span class="cx"> [
</span><ins>+ Constructor(DOMPointInit point),
</ins><span class="cx"> Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
</span><span class="cx"> optional unrestricted double z = 0, optional unrestricted double w = 1),
</span><span class="cx"> Exposed=(Window,Worker),
</span></span></pre>
</div>
</div>
</body>
</html>