<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209627] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209627">209627</a></dd>
<dt>Author</dt> <dd>ggaren@apple.com</dd>
<dt>Date</dt> <dd>2016-12-09 14:04:14 -0800 (Fri, 09 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>TextPosition and OrdinalNumber should be more like idiomatic numbers
https://bugs.webkit.org/show_bug.cgi?id=165678
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Adopt default constructor.
* API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
* API/JSObjectRef.cpp:
(JSObjectMakeFunction):
* API/JSScriptRef.cpp:
(OpaqueJSScript::OpaqueJSScript):
* jsc.cpp:
(functionCheckModuleSyntax):
* parser/SourceCode.h:
(JSC::makeSource):
* parser/SourceProvider.h:
(JSC::StringSourceProvider::create):
(JSC::WebAssemblySourceProvider::WebAssemblySourceProvider):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/ModuleLoaderPrototype.cpp:
(JSC::moduleLoaderPrototypeParseModule):
Source/WebCore:
* bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::sourcePosition):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::eventHandlerPosition):
* bindings/js/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::create):
* dom/ScriptElement.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::uninitializedPositionValue1):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo): Adopt
default construtor.
* xml/XMLErrors.cpp:
(WebCore::XMLErrors::XMLErrors):
(WebCore::XMLErrors::handleError):
* xml/XMLErrors.h: Use std::optional instead of belowRangePosition()
because in-band signaling is harder to reason about.
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::textPosition): Adopt default constructor.
Source/WebKit/win:
Adopt default constructor.
* Plugins/PluginPackage.cpp:
(WebCore::makeSource):
Source/WTF:
* wtf/text/TextPosition.h:
(WTF::TextPosition::minimumPosition): Deleted. Just use the default
constructor. Other numbers use their default constructors to mean zero.
Any time you need a comment that says "used as a default value", that's
a pretty good indicator that it should be the default constructor.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreAPIJSBasecpp">trunk/Source/JavaScriptCore/API/JSBase.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSObjectRefcpp">trunk/Source/JavaScriptCore/API/JSObjectRef.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreAPIJSScriptRefcpp">trunk/Source/JavaScriptCore/API/JSScriptRef.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorejsccpp">trunk/Source/JavaScriptCore/jsc.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserSourceCodeh">trunk/Source/JavaScriptCore/parser/SourceCode.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserSourceProviderh">trunk/Source/JavaScriptCore/parser/SourceProvider.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeFunctionConstructorcpp">trunk/Source/JavaScriptCore/runtime/FunctionConstructor.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeModuleLoaderPrototypecpp">trunk/Source/JavaScriptCore/runtime/ModuleLoaderPrototype.cpp</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtftextOrdinalNumberh">trunk/Source/WTF/wtf/text/OrdinalNumber.h</a></li>
<li><a href="#trunkSourceWTFwtftextTextPositionh">trunk/Source/WTF/wtf/text/TextPosition.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsCachedScriptSourceProviderh">trunk/Source/WebCore/bindings/js/CachedScriptSourceProvider.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSEventListenerh">trunk/Source/WebCore/bindings/js/JSEventListener.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSLazyEventListenercpp">trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsScriptControllercpp">trunk/Source/WebCore/bindings/js/ScriptController.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsScriptSourceCodeh">trunk/Source/WebCore/bindings/js/ScriptSourceCode.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSStyleSheetcpp">trunk/Source/WebCore/css/CSSStyleSheet.cpp</a></li>
<li><a href="#trunkSourceWebCoredomScriptElementh">trunk/Source/WebCore/dom/ScriptElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlparserHTMLTreeBuildercpp">trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorStyleSheetcpp">trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXMLErrorscpp">trunk/Source/WebCore/xml/XMLErrors.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXMLErrorsh">trunk/Source/WebCore/xml/XMLErrors.h</a></li>
<li><a href="#trunkSourceWebCorexmlparserXMLDocumentParserLibxml2cpp">trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinPluginsPluginPackagecpp">trunk/Source/WebKit/win/Plugins/PluginPackage.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreAPIJSBasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSBase.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSBase.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/JavaScriptCore/API/JSBase.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx">
</span><span class="cx"> // evaluate sets "this" to the global object if it is NULL
</span><span class="cx"> JSGlobalObject* globalObject = exec->vmEntryGlobalObject();
</span><del>- SourceCode source = makeSource(script->string(), sourceURL ? sourceURL->string() : String(), TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber::first()));
</del><ins>+ SourceCode source = makeSource(script->string(), sourceURL ? sourceURL->string() : String(), TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber()));
</ins><span class="cx">
</span><span class="cx"> NakedPtr<Exception> evaluationException;
</span><span class="cx"> JSValue returnValue = profiledEvaluate(globalObject->globalExec(), ProfilingReason::API, source, jsThisObject, evaluationException);
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx">
</span><span class="cx"> startingLineNumber = std::max(1, startingLineNumber);
</span><span class="cx">
</span><del>- SourceCode source = makeSource(script->string(), sourceURL ? sourceURL->string() : String(), TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber::first()));
</del><ins>+ SourceCode source = makeSource(script->string(), sourceURL ? sourceURL->string() : String(), TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber()));
</ins><span class="cx">
</span><span class="cx"> JSValue syntaxException;
</span><span class="cx"> bool isValidSyntax = checkSyntax(exec->vmEntryGlobalObject()->globalExec(), source, &syntaxException);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSObjectRefcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSObjectRef.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSObjectRef.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/JavaScriptCore/API/JSObjectRef.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -146,7 +146,7 @@
</span><span class="cx"> args.append(jsString(exec, parameterNames[i]->string()));
</span><span class="cx"> args.append(jsString(exec, body->string()));
</span><span class="cx">
</span><del>- JSObject* result = constructFunction(exec, exec->lexicalGlobalObject(), args, nameID, sourceURL ? sourceURL->string() : String(), TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber::first()));
</del><ins>+ JSObject* result = constructFunction(exec, exec->lexicalGlobalObject(), args, nameID, sourceURL ? sourceURL->string() : String(), TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber()));
</ins><span class="cx"> if (handleExceptionIfNeeded(exec, exception) == ExceptionStatus::DidThrow)
</span><span class="cx"> result = 0;
</span><span class="cx"> return toRef(result);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreAPIJSScriptRefcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSScriptRef.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSScriptRef.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/JavaScriptCore/API/JSScriptRef.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -60,7 +60,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> OpaqueJSScript(VM* vm, const String& url, int startingLineNumber, const String& source)
</span><del>- : SourceProvider(url, TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber::first()), SourceProviderSourceType::Program)
</del><ins>+ : SourceProvider(url, TextPosition(OrdinalNumber::fromOneBasedInt(startingLineNumber), OrdinalNumber()), SourceProviderSourceType::Program)
</ins><span class="cx"> , m_vm(vm)
</span><span class="cx"> , m_source(source.isNull() ? *StringImpl::empty() : *source.impl())
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2016-12-09 Geoffrey Garen <ggaren@apple.com>
+
+ TextPosition and OrdinalNumber should be more like idiomatic numbers
+ https://bugs.webkit.org/show_bug.cgi?id=165678
+
+ Reviewed by Filip Pizlo.
+
+ Adopt default constructor.
+
+ * API/JSBase.cpp:
+ (JSEvaluateScript):
+ (JSCheckScriptSyntax):
+ * API/JSObjectRef.cpp:
+ (JSObjectMakeFunction):
+ * API/JSScriptRef.cpp:
+ (OpaqueJSScript::OpaqueJSScript):
+ * jsc.cpp:
+ (functionCheckModuleSyntax):
+ * parser/SourceCode.h:
+ (JSC::makeSource):
+ * parser/SourceProvider.h:
+ (JSC::StringSourceProvider::create):
+ (JSC::WebAssemblySourceProvider::WebAssemblySourceProvider):
+ * runtime/FunctionConstructor.cpp:
+ (JSC::constructFunction):
+ * runtime/ModuleLoaderPrototype.cpp:
+ (JSC::moduleLoaderPrototypeParseModule):
+
</ins><span class="cx"> 2016-12-09 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, disable concurrent GC for real.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejsccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jsc.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jsc.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/JavaScriptCore/jsc.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -2429,7 +2429,7 @@
</span><span class="cx"> stopWatch.start();
</span><span class="cx">
</span><span class="cx"> ParserError error;
</span><del>- bool validSyntax = checkModuleSyntax(exec, makeSource(source, String(), TextPosition::minimumPosition(), SourceProviderSourceType::Module), error);
</del><ins>+ bool validSyntax = checkModuleSyntax(exec, makeSource(source, String(), TextPosition(), SourceProviderSourceType::Module), error);
</ins><span class="cx"> stopWatch.stop();
</span><span class="cx">
</span><span class="cx"> if (!validSyntax)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserSourceCodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/SourceCode.h (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/SourceCode.h 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/JavaScriptCore/parser/SourceCode.h 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> int m_startColumn;
</span><span class="cx"> };
</span><span class="cx">
</span><del>- inline SourceCode makeSource(const String& source, const String& url = String(), const TextPosition& startPosition = TextPosition::minimumPosition(), SourceProviderSourceType sourceType = SourceProviderSourceType::Program)
</del><ins>+ inline SourceCode makeSource(const String& source, const String& url = String(), const TextPosition& startPosition = TextPosition(), SourceProviderSourceType sourceType = SourceProviderSourceType::Program)
</ins><span class="cx"> {
</span><span class="cx"> return SourceCode(StringSourceProvider::create(source, url, startPosition, sourceType), startPosition.m_line.oneBasedInt(), startPosition.m_column.oneBasedInt());
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserSourceProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/SourceProvider.h (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/SourceProvider.h 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/JavaScriptCore/parser/SourceProvider.h 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx">
</span><span class="cx"> class StringSourceProvider : public SourceProvider {
</span><span class="cx"> public:
</span><del>- static Ref<StringSourceProvider> create(const String& source, const String& url, const TextPosition& startPosition = TextPosition::minimumPosition(), SourceProviderSourceType sourceType = SourceProviderSourceType::Program)
</del><ins>+ static Ref<StringSourceProvider> create(const String& source, const String& url, const TextPosition& startPosition = TextPosition(), SourceProviderSourceType sourceType = SourceProviderSourceType::Program)
</ins><span class="cx"> {
</span><span class="cx"> return adoptRef(*new StringSourceProvider(source, url, startPosition, sourceType));
</span><span class="cx"> }
</span><span class="lines">@@ -139,7 +139,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> WebAssemblySourceProvider(const Vector<uint8_t>& data, const String& url)
</span><del>- : SourceProvider(url, TextPosition::minimumPosition(), SourceProviderSourceType::WebAssembly)
</del><ins>+ : SourceProvider(url, TextPosition(), SourceProviderSourceType::WebAssembly)
</ins><span class="cx"> , m_source("[WebAssembly source]")
</span><span class="cx"> , m_data(data)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeFunctionConstructorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/FunctionConstructor.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/FunctionConstructor.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/JavaScriptCore/runtime/FunctionConstructor.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -170,7 +170,7 @@
</span><span class="cx"> // ECMA 15.3.2 The Function Constructor
</span><span class="cx"> JSObject* constructFunction(ExecState* exec, JSGlobalObject* globalObject, const ArgList& args, FunctionConstructionMode functionConstructionMode, JSValue newTarget)
</span><span class="cx"> {
</span><del>- return constructFunction(exec, globalObject, args, exec->propertyNames().anonymous, String(), TextPosition::minimumPosition(), functionConstructionMode, newTarget);
</del><ins>+ return constructFunction(exec, globalObject, args, exec->propertyNames().anonymous, String(), TextPosition(), functionConstructionMode, newTarget);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace JSC
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeModuleLoaderPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ModuleLoaderPrototype.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ModuleLoaderPrototype.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/JavaScriptCore/runtime/ModuleLoaderPrototype.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -113,7 +113,7 @@
</span><span class="cx"> String source = exec->argument(1).toString(exec)->value(exec);
</span><span class="cx"> RETURN_IF_EXCEPTION(scope, encodedJSValue());
</span><span class="cx">
</span><del>- SourceCode sourceCode = makeSource(source, moduleKey.impl(), TextPosition::minimumPosition(), SourceProviderSourceType::Module);
</del><ins>+ SourceCode sourceCode = makeSource(source, moduleKey.impl(), TextPosition(), SourceProviderSourceType::Module);
</ins><span class="cx">
</span><span class="cx"> CodeProfiling profile(sourceCode);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WTF/ChangeLog 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -1,5 +1,19 @@
</span><span class="cx"> 2016-12-09 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><ins>+ TextPosition and OrdinalNumber should be more like idiomatic numbers
+ https://bugs.webkit.org/show_bug.cgi?id=165678
+
+ Reviewed by Filip Pizlo.
+
+ * wtf/text/TextPosition.h:
+ (WTF::TextPosition::minimumPosition): Deleted. Just use the default
+ constructor. Other numbers use their default constructors to mean zero.
+
+ Any time you need a comment that says "used as a default value", that's
+ a pretty good indicator that it should be the default constructor.
+
+2016-12-09 Geoffrey Garen <ggaren@apple.com>
+
</ins><span class="cx"> Moved OrdinalNumber into its own file
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=165663
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWTFwtftextOrdinalNumberh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/OrdinalNumber.h (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/OrdinalNumber.h 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WTF/wtf/text/OrdinalNumber.h 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -33,6 +33,7 @@
</span><span class="cx"> public:
</span><span class="cx"> static OrdinalNumber fromZeroBasedInt(int zeroBasedInt) { return OrdinalNumber(zeroBasedInt); }
</span><span class="cx"> static OrdinalNumber fromOneBasedInt(int oneBasedInt) { return OrdinalNumber(oneBasedInt - 1); }
</span><ins>+
</ins><span class="cx"> OrdinalNumber() : m_zeroBasedValue(0) { }
</span><span class="cx">
</span><span class="cx"> int zeroBasedInt() const { return m_zeroBasedValue; }
</span><span class="lines">@@ -41,7 +42,6 @@
</span><span class="cx"> bool operator==(OrdinalNumber other) { return m_zeroBasedValue == other.m_zeroBasedValue; }
</span><span class="cx"> bool operator!=(OrdinalNumber other) { return !((*this) == other); }
</span><span class="cx">
</span><del>- static OrdinalNumber first() { return OrdinalNumber(0); }
</del><span class="cx"> static OrdinalNumber beforeFirst() { return OrdinalNumber(-1); }
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWTFwtftextTextPositionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/TextPosition.h (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/TextPosition.h 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WTF/wtf/text/TextPosition.h 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -37,13 +37,11 @@
</span><span class="cx"> , m_column(column)
</span><span class="cx"> {
</span><span class="cx"> }
</span><ins>+
</ins><span class="cx"> TextPosition() { }
</span><span class="cx"> bool operator==(const TextPosition& other) { return m_line == other.m_line && m_column == other.m_column; }
</span><span class="cx"> bool operator!=(const TextPosition& other) { return !((*this) == other); }
</span><span class="cx">
</span><del>- // A 'minimum' value of position, used as a default value.
- static TextPosition minimumPosition() { return TextPosition(OrdinalNumber::first(), OrdinalNumber::first()); }
-
</del><span class="cx"> // A value with line value less than a minimum; used as an impossible position.
</span><span class="cx"> static TextPosition belowRangePosition() { return TextPosition(OrdinalNumber::beforeFirst(), OrdinalNumber::beforeFirst()); }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/ChangeLog 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2016-12-09 Geoffrey Garen <ggaren@apple.com>
+
+ TextPosition and OrdinalNumber should be more like idiomatic numbers
+ https://bugs.webkit.org/show_bug.cgi?id=165678
+
+ Reviewed by Filip Pizlo.
+
+ * bindings/js/CachedScriptSourceProvider.h:
+ (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
+ * bindings/js/JSEventListener.h:
+ (WebCore::JSEventListener::sourcePosition):
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::JSLazyEventListener::JSLazyEventListener):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::eventHandlerPosition):
+ * bindings/js/ScriptSourceCode.h:
+ (WebCore::ScriptSourceCode::ScriptSourceCode):
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::create):
+ * dom/ScriptElement.h:
+ * html/parser/HTMLTreeBuilder.cpp:
+ (WebCore::uninitializedPositionValue1):
+ * inspector/InspectorStyleSheet.cpp:
+ (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo): Adopt
+ default construtor.
+
+ * xml/XMLErrors.cpp:
+ (WebCore::XMLErrors::XMLErrors):
+ (WebCore::XMLErrors::handleError):
+ * xml/XMLErrors.h: Use std::optional instead of belowRangePosition()
+ because in-band signaling is harder to reason about.
+
+ * xml/parser/XMLDocumentParserLibxml2.cpp:
+ (WebCore::XMLDocumentParser::textPosition): Adopt default constructor.
+
</ins><span class="cx"> 2016-12-09 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> [Cocoa] Validation message for required checkbox doesn’t conform the the Apple Style Guide
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsCachedScriptSourceProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/CachedScriptSourceProvider.h (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/CachedScriptSourceProvider.h 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/bindings/js/CachedScriptSourceProvider.h 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> CachedScriptSourceProvider(CachedScript* cachedScript, JSC::SourceProviderSourceType sourceType)
</span><del>- : SourceProvider(cachedScript->response().url(), TextPosition::minimumPosition(), sourceType)
</del><ins>+ : SourceProvider(cachedScript->response().url(), TextPosition(), sourceType)
</ins><span class="cx"> , m_cachedScript(cachedScript)
</span><span class="cx"> {
</span><span class="cx"> m_cachedScript->addClient(*this);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSEventListenerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSEventListener.h (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSEventListener.h 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/bindings/js/JSEventListener.h 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx"> void setWrapper(JSC::VM&, JSC::JSObject* wrapper) const { m_wrapper = JSC::Weak<JSC::JSObject>(wrapper); }
</span><span class="cx">
</span><span class="cx"> virtual String sourceURL() const { return String(); }
</span><del>- virtual TextPosition sourcePosition() const { return TextPosition::minimumPosition(); }
</del><ins>+ virtual TextPosition sourcePosition() const { return TextPosition(); }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> virtual JSC::JSObject* initializeJSFunction(ScriptExecutionContext*) const;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSLazyEventListenercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> // A JSLazyEventListener can be created with a line number of zero when it is created with
</span><span class="cx"> // a setAttribute call from JavaScript, so make the line number 1 in that case.
</span><span class="cx"> if (m_sourcePosition == TextPosition::belowRangePosition())
</span><del>- m_sourcePosition = TextPosition::minimumPosition();
</del><ins>+ m_sourcePosition = TextPosition();
</ins><span class="cx">
</span><span class="cx"> ASSERT(m_eventParameterName == "evt" || m_eventParameterName == "event");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsScriptControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/ScriptController.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/ScriptController.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/bindings/js/ScriptController.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -420,7 +420,7 @@
</span><span class="cx"> ScriptableDocumentParser* parser = m_frame.document()->scriptableDocumentParser();
</span><span class="cx"> if (parser)
</span><span class="cx"> return parser->textPosition();
</span><del>- return TextPosition::minimumPosition();
</del><ins>+ return TextPosition();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ScriptController::enableEval()
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsScriptSourceCodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/ScriptSourceCode.h (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/ScriptSourceCode.h 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/bindings/js/ScriptSourceCode.h 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx">
</span><span class="cx"> class ScriptSourceCode {
</span><span class="cx"> public:
</span><del>- ScriptSourceCode(const String& source, const URL& url = URL(), const TextPosition& startPosition = TextPosition::minimumPosition(), JSC::SourceProviderSourceType sourceType = JSC::SourceProviderSourceType::Program)
</del><ins>+ ScriptSourceCode(const String& source, const URL& url = URL(), const TextPosition& startPosition = TextPosition(), JSC::SourceProviderSourceType sourceType = JSC::SourceProviderSourceType::Program)
</ins><span class="cx"> : m_provider(JSC::StringSourceProvider::create(source, url.isNull() ? String() : url.string(), startPosition, sourceType))
</span><span class="cx"> , m_code(m_provider, startPosition.m_line.oneBasedInt(), startPosition.m_column.oneBasedInt())
</span><span class="cx"> , m_url(url)
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSStyleSheetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSStyleSheet.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSStyleSheet.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/css/CSSStyleSheet.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx">
</span><span class="cx"> Ref<CSSStyleSheet> CSSStyleSheet::create(Ref<StyleSheetContents>&& sheet, Node& ownerNode, const std::optional<bool>& isCleanOrigin)
</span><span class="cx"> {
</span><del>- return adoptRef(*new CSSStyleSheet(WTFMove(sheet), ownerNode, TextPosition::minimumPosition(), false, isCleanOrigin));
</del><ins>+ return adoptRef(*new CSSStyleSheet(WTFMove(sheet), ownerNode, TextPosition(), false, isCleanOrigin));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<CSSStyleSheet> CSSStyleSheet::createInline(Ref<StyleSheetContents>&& sheet, Element& owner, const TextPosition& startPosition)
</span></span></pre></div>
<a id="trunkSourceWebCoredomScriptElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ScriptElement.h (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ScriptElement.h 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/dom/ScriptElement.h 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> const Element& element() const { return m_element; }
</span><span class="cx">
</span><span class="cx"> enum LegacyTypeSupport { DisallowLegacyTypeInTypeAttribute, AllowLegacyTypeInTypeAttribute };
</span><del>- bool prepareScript(const TextPosition& scriptStartPosition = TextPosition::minimumPosition(), LegacyTypeSupport = DisallowLegacyTypeInTypeAttribute);
</del><ins>+ bool prepareScript(const TextPosition& scriptStartPosition = TextPosition(), LegacyTypeSupport = DisallowLegacyTypeInTypeAttribute);
</ins><span class="cx">
</span><span class="cx"> String scriptCharset() const { return m_characterEncoding; }
</span><span class="cx"> WEBCORE_EXPORT String scriptContent() const;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserHTMLTreeBuildercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx">
</span><span class="cx"> static inline TextPosition uninitializedPositionValue1()
</span><span class="cx"> {
</span><del>- return TextPosition(OrdinalNumber::fromOneBasedInt(-1), OrdinalNumber::first());
</del><ins>+ return TextPosition(OrdinalNumber::fromOneBasedInt(-1), OrdinalNumber());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline bool isAllWhitespace(const String& string)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorStyleSheetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -1032,7 +1032,7 @@
</span><span class="cx"> .setSourceURL(finalURL())
</span><span class="cx"> .setTitle(styleSheet->title())
</span><span class="cx"> .setFrameId(m_pageAgent->frameId(frame))
</span><del>- .setIsInline(styleSheet->isInline() && styleSheet->startPosition() != TextPosition::minimumPosition())
</del><ins>+ .setIsInline(styleSheet->isInline() && styleSheet->startPosition() != TextPosition())
</ins><span class="cx"> .setStartLine(styleSheet->startPosition().m_line.zeroBasedInt())
</span><span class="cx"> .setStartColumn(styleSheet->startPosition().m_column.zeroBasedInt())
</span><span class="cx"> .release();
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXMLErrorscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XMLErrors.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XMLErrors.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/xml/XMLErrors.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -50,7 +50,6 @@
</span><span class="cx">
</span><span class="cx"> XMLErrors::XMLErrors(Document& document)
</span><span class="cx"> : m_document(document)
</span><del>- , m_lastErrorPosition(TextPosition::belowRangePosition())
</del><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -61,7 +60,7 @@
</span><span class="cx">
</span><span class="cx"> void XMLErrors::handleError(ErrorType type, const char* message, TextPosition position)
</span><span class="cx"> {
</span><del>- if (type == fatal || (m_errorCount < maxErrors && m_lastErrorPosition.m_line != position.m_line && m_lastErrorPosition.m_column != position.m_column)) {
</del><ins>+ if (type == fatal || (m_errorCount < maxErrors && (!m_lastErrorPosition || (m_lastErrorPosition->m_line != position.m_line && m_lastErrorPosition->m_column != position.m_column)))) {
</ins><span class="cx"> switch (type) {
</span><span class="cx"> case warning:
</span><span class="cx"> appendErrorMessage("warning", position, message);
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXMLErrorsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XMLErrors.h (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XMLErrors.h 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/xml/XMLErrors.h 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx">
</span><span class="cx"> Document& m_document;
</span><span class="cx"> int m_errorCount { 0 };
</span><del>- TextPosition m_lastErrorPosition;
</del><ins>+ std::optional<TextPosition> m_lastErrorPosition;
</ins><span class="cx"> StringBuilder m_errorMessages;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorexmlparserXMLDocumentParserLibxml2cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -1381,7 +1381,7 @@
</span><span class="cx"> {
</span><span class="cx"> xmlParserCtxtPtr context = this->context();
</span><span class="cx"> if (!context)
</span><del>- return TextPosition::minimumPosition();
</del><ins>+ return TextPosition();
</ins><span class="cx"> return TextPosition(OrdinalNumber::fromOneBasedInt(context->input->line),
</span><span class="cx"> OrdinalNumber::fromOneBasedInt(context->input->col));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebKit/win/ChangeLog 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-12-09 Geoffrey Garen <ggaren@apple.com>
+
+ TextPosition and OrdinalNumber should be more like idiomatic numbers
+ https://bugs.webkit.org/show_bug.cgi?id=165678
+
+ Reviewed by Filip Pizlo.
+
+ Adopt default constructor.
+
+ * Plugins/PluginPackage.cpp:
+ (WebCore::makeSource):
+
</ins><span class="cx"> 2016-12-08 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> Enable SharedArrayBuffer, remove the flag
</span></span></pre></div>
<a id="trunkSourceWebKitwinPluginsPluginPackagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/Plugins/PluginPackage.cpp (209626 => 209627)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/Plugins/PluginPackage.cpp 2016-12-09 22:00:28 UTC (rev 209626)
+++ trunk/Source/WebKit/win/Plugins/PluginPackage.cpp 2016-12-09 22:04:14 UTC (rev 209627)
</span><span class="lines">@@ -192,7 +192,7 @@
</span><span class="cx"> aList.append(JSC::Bindings::convertNPVariantToValue(exec, &args[i], rootObject));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline JSC::SourceCode makeSource(const String& source, const String& url = String(), const TextPosition& startPosition = TextPosition::minimumPosition())
</del><ins>+static inline JSC::SourceCode makeSource(const String& source, const String& url = String(), const TextPosition& startPosition = TextPosition())
</ins><span class="cx"> {
</span><span class="cx"> return JSC::SourceCode(JSC::StringSourceProvider::create(source, url, startPosition), startPosition.m_line.oneBasedInt(), startPosition.m_column.oneBasedInt());
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>