<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209590] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209590">209590</a></dd>
<dt>Author</dt> <dd>ddkilzer@apple.com</dd>
<dt>Date</dt> <dd>2016-12-08 17:54:31 -0800 (Thu, 08 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Always check the return value of pthread_key_create()
<https://webkit.org/b/165274>
Reviewed by Darin Adler.
Source/bmalloc:
* bmalloc/PerThread.h:
(bmalloc::PerThreadStorage::init): Call BCRASH() if
pthread_key_create() returns an error. The error code will be
stored in a register available in a crash log, so no need to log
the value explicitly.
Source/WebCore:
* platform/ios/wak/WebCoreThread.mm:
(InitThreadContextKey): Call CRASH() if pthread_key_create()
returns an error. The error code will be stored in a register
available in a crash log, so no need to log the value
explicitly.
Source/WTF:
* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::initializeOnce): Make the code more
readable by assigning a variable to the result of
pthread_key_create(). This matches the idiom used elsewhere.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfThreadIdentifierDataPthreadscpp">trunk/Source/WTF/wtf/ThreadIdentifierDataPthreads.cpp</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformioswakWebCoreThreadmm">trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm</a></li>
<li><a href="#trunkSourcebmallocChangeLog">trunk/Source/bmalloc/ChangeLog</a></li>
<li><a href="#trunkSourcebmallocbmallocPerThreadh">trunk/Source/bmalloc/bmalloc/PerThread.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (209589 => 209590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-12-09 01:51:17 UTC (rev 209589)
+++ trunk/Source/WTF/ChangeLog 2016-12-09 01:54:31 UTC (rev 209590)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-12-08 David Kilzer <ddkilzer@apple.com>
+
+ Always check the return value of pthread_key_create()
+ <https://webkit.org/b/165274>
+
+ Reviewed by Darin Adler.
+
+ * wtf/ThreadIdentifierDataPthreads.cpp:
+ (WTF::ThreadIdentifierData::initializeOnce): Make the code more
+ readable by assigning a variable to the result of
+ pthread_key_create(). This matches the idiom used elsewhere.
+
</ins><span class="cx"> 2016-12-08 Keith Miller <keith_miller@apple.com>
</span><span class="cx">
</span><span class="cx"> Add 64-bit signed LEB decode method
</span></span></pre></div>
<a id="trunkSourceWTFwtfThreadIdentifierDataPthreadscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/ThreadIdentifierDataPthreads.cpp (209589 => 209590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/ThreadIdentifierDataPthreads.cpp 2016-12-09 01:51:17 UTC (rev 209589)
+++ trunk/Source/WTF/wtf/ThreadIdentifierDataPthreads.cpp 2016-12-09 01:54:31 UTC (rev 209590)
</span><span class="lines">@@ -56,7 +56,8 @@
</span><span class="cx">
</span><span class="cx"> void ThreadIdentifierData::initializeOnce()
</span><span class="cx"> {
</span><del>- if (pthread_key_create(&m_key, destruct))
</del><ins>+ int error = pthread_key_create(&m_key, destruct);
+ if (error)
</ins><span class="cx"> CRASH();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209589 => 209590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-09 01:51:17 UTC (rev 209589)
+++ trunk/Source/WebCore/ChangeLog 2016-12-09 01:54:31 UTC (rev 209590)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-12-08 David Kilzer <ddkilzer@apple.com>
+
+ Always check the return value of pthread_key_create()
+ <https://webkit.org/b/165274>
+
+ Reviewed by Darin Adler.
+
+ * platform/ios/wak/WebCoreThread.mm:
+ (InitThreadContextKey): Call CRASH() if pthread_key_create()
+ returns an error. The error code will be stored in a register
+ available in a crash log, so no need to log the value
+ explicitly.
+
</ins><span class="cx"> 2016-12-08 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Reduce PassRefPtr use in platform/graphics
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformioswakWebCoreThreadmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm (209589 => 209590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm 2016-12-09 01:51:17 UTC (rev 209589)
+++ trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm 2016-12-09 01:54:31 UTC (rev 209590)
</span><span class="lines">@@ -620,7 +620,9 @@
</span><span class="cx">
</span><span class="cx"> static void InitThreadContextKey()
</span><span class="cx"> {
</span><del>- pthread_key_create(&threadContextKey, FreeThreadContext);
</del><ins>+ int error = pthread_key_create(&threadContextKey, FreeThreadContext);
+ if (error)
+ CRASH();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static WebThreadContext *CurrentThreadContext(void)
</span></span></pre></div>
<a id="trunkSourcebmallocChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/ChangeLog (209589 => 209590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/ChangeLog 2016-12-09 01:51:17 UTC (rev 209589)
+++ trunk/Source/bmalloc/ChangeLog 2016-12-09 01:54:31 UTC (rev 209590)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-12-08 David Kilzer <ddkilzer@apple.com>
+
+ Always check the return value of pthread_key_create()
+ <https://webkit.org/b/165274>
+
+ Reviewed by Darin Adler.
+
+ * bmalloc/PerThread.h:
+ (bmalloc::PerThreadStorage::init): Call BCRASH() if
+ pthread_key_create() returns an error. The error code will be
+ stored in a register available in a crash log, so no need to log
+ the value explicitly.
+
</ins><span class="cx"> 2016-12-06 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Correct SDKROOT values in xcconfig files
</span></span></pre></div>
<a id="trunkSourcebmallocbmallocPerThreadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/bmalloc/PerThread.h (209589 => 209590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/bmalloc/PerThread.h 2016-12-09 01:51:17 UTC (rev 209589)
+++ trunk/Source/bmalloc/bmalloc/PerThread.h 2016-12-09 01:54:31 UTC (rev 209590)
</span><span class="lines">@@ -97,7 +97,9 @@
</span><span class="cx"> static void init(void* object, void (*destructor)(void*))
</span><span class="cx"> {
</span><span class="cx"> std::call_once(s_onceFlag, [destructor]() {
</span><del>- pthread_key_create(&s_key, destructor);
</del><ins>+ int error = pthread_key_create(&s_key, destructor);
+ if (error)
+ BCRASH();
</ins><span class="cx"> s_didInitialize = true;
</span><span class="cx"> });
</span><span class="cx"> pthread_setspecific(s_key, object);
</span></span></pre>
</div>
</div>
</body>
</html>