<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209568] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209568">209568</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2016-12-08 13:56:23 -0800 (Thu, 08 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Enable SharedArrayBuffer, remove the flag
https://bugs.webkit.org/show_bug.cgi?id=165614
Rubber stamped by Geoffrey Garen.
Source/JavaScriptCore:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/RuntimeFlags.h:
Source/WebKit/mac:
* WebView/WebPreferencesPrivate.h:
Source/WebKit/win:
* Interfaces/IWebPreferencesPrivate.idl:
Source/WebKit2:
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGlobalObjectcpp">trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeRuntimeFlagsh">trunk/Source/JavaScriptCore/runtime/RuntimeFlags.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl">trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKPreferencesPrivateh">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (209567 => 209568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-12-08 21:54:21 UTC (rev 209567)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-12-08 21:56:23 UTC (rev 209568)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-12-08 Filip Pizlo <fpizlo@apple.com>
+
+ Enable SharedArrayBuffer, remove the flag
+ https://bugs.webkit.org/show_bug.cgi?id=165614
+
+ Rubber stamped by Geoffrey Garen.
+
+ * runtime/JSGlobalObject.cpp:
+ (JSC::JSGlobalObject::init):
+ * runtime/RuntimeFlags.h:
+
</ins><span class="cx"> 2016-12-08 JF Bastien <jfbastien@apple.com>
</span><span class="cx">
</span><span class="cx"> WebAssembly JS API: wire up Instance imports
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGlobalObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp (209567 => 209568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp 2016-12-08 21:54:21 UTC (rev 209567)
+++ trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp 2016-12-08 21:56:23 UTC (rev 209568)
</span><span class="lines">@@ -578,10 +578,8 @@
</span><span class="cx">
</span><span class="cx"> m_arrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Default));
</span><span class="cx"> m_arrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_arrayBufferPrototype.get()));
</span><del>- if (m_runtimeFlags.isSharedArrayBufferEnabled()) {
- m_sharedArrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Shared));
- m_sharedArrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_sharedArrayBufferPrototype.get()));
- }
</del><ins>+ m_sharedArrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Shared));
+ m_sharedArrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_sharedArrayBufferPrototype.get()));
</ins><span class="cx">
</span><span class="cx"> #define CREATE_PROTOTYPE_FOR_SIMPLE_TYPE(capitalName, lowerName, properName, instanceType, jsName, prototypeBase) \
</span><span class="cx"> m_ ## lowerName ## Prototype.set(vm, this, capitalName##Prototype::create(vm, this, capitalName##Prototype::createStructure(vm, this, m_ ## prototypeBase ## Prototype.get()))); \
</span><span class="lines">@@ -636,10 +634,8 @@
</span><span class="cx"> JSArrayBufferConstructor* arrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_arrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Default);
</span><span class="cx"> m_arrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, arrayBufferConstructor, DontEnum);
</span><span class="cx"> JSArrayBufferConstructor* sharedArrayBufferConstructor = nullptr;
</span><del>- if (m_runtimeFlags.isSharedArrayBufferEnabled()) {
- sharedArrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_sharedArrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Shared);
- m_sharedArrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, sharedArrayBufferConstructor, DontEnum);
- }
</del><ins>+ sharedArrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_sharedArrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Shared);
+ m_sharedArrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, sharedArrayBufferConstructor, DontEnum);
</ins><span class="cx">
</span><span class="cx"> #define CREATE_CONSTRUCTOR_FOR_SIMPLE_TYPE(capitalName, lowerName, properName, instanceType, jsName, prototypeBase) \
</span><span class="cx"> capitalName ## Constructor* lowerName ## Constructor = capitalName ## Constructor::create(vm, capitalName ## Constructor::createStructure(vm, this, m_functionPrototype.get()), m_ ## lowerName ## Prototype.get(), m_speciesGetterSetter.get()); \
</span><span class="lines">@@ -703,8 +699,7 @@
</span><span class="cx"> putDirectWithoutTransition(vm, vm.propertyNames->builtinNames().ArrayPrivateName(), arrayConstructor, DontEnum | DontDelete | ReadOnly);
</span><span class="cx">
</span><span class="cx"> putDirectWithoutTransition(vm, vm.propertyNames->ArrayBuffer, arrayBufferConstructor, DontEnum);
</span><del>- if (m_runtimeFlags.isSharedArrayBufferEnabled())
- putDirectWithoutTransition(vm, vm.propertyNames->SharedArrayBuffer, sharedArrayBufferConstructor, DontEnum);
</del><ins>+ putDirectWithoutTransition(vm, vm.propertyNames->SharedArrayBuffer, sharedArrayBufferConstructor, DontEnum);
</ins><span class="cx">
</span><span class="cx"> #define PUT_CONSTRUCTOR_FOR_SIMPLE_TYPE(capitalName, lowerName, properName, instanceType, jsName, prototypeBase) \
</span><span class="cx"> putDirectWithoutTransition(vm, vm.propertyNames-> jsName, lowerName ## Constructor, DontEnum); \
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeRuntimeFlagsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/RuntimeFlags.h (209567 => 209568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/RuntimeFlags.h 2016-12-08 21:54:21 UTC (rev 209567)
+++ trunk/Source/JavaScriptCore/runtime/RuntimeFlags.h 2016-12-08 21:56:23 UTC (rev 209568)
</span><span class="lines">@@ -31,8 +31,7 @@
</span><span class="cx"> namespace JSC {
</span><span class="cx">
</span><span class="cx"> // macro(name, isEnabledFlag)
</span><del>-#define JSC_RUNTIME_FLAG(macro) \
- macro(SharedArrayBufferEnabled, true)
</del><ins>+#define JSC_RUNTIME_FLAG(macro)
</ins><span class="cx">
</span><span class="cx"> class RuntimeFlags {
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (209567 => 209568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-12-08 21:54:21 UTC (rev 209567)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-12-08 21:56:23 UTC (rev 209568)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-12-08 Filip Pizlo <fpizlo@apple.com>
+
+ Enable SharedArrayBuffer, remove the flag
+ https://bugs.webkit.org/show_bug.cgi?id=165614
+
+ Rubber stamped by Geoffrey Garen.
+
+ * WebView/WebPreferencesPrivate.h:
+
</ins><span class="cx"> 2016-12-07 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove runtime toggle for pointer-lock
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (209567 => 209568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-12-08 21:54:21 UTC (rev 209567)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-12-08 21:56:23 UTC (rev 209568)
</span><span class="lines">@@ -53,8 +53,7 @@
</span><span class="cx"> } WebStorageBlockingPolicy;
</span><span class="cx">
</span><span class="cx"> typedef enum {
</span><del>- WebKitJavaScriptRuntimeFlagsSharedArrayBufferEnabled = 1u << 0,
- WebKitJavaScriptRuntimeFlagsAllEnabled = WebKitJavaScriptRuntimeFlagsSharedArrayBufferEnabled
</del><ins>+ WebKitJavaScriptRuntimeFlagsAllEnabled = 0
</ins><span class="cx"> } WebKitJavaScriptRuntimeFlags;
</span><span class="cx">
</span><span class="cx"> extern NSString *WebPreferencesChangedNotification;
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (209567 => 209568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2016-12-08 21:54:21 UTC (rev 209567)
+++ trunk/Source/WebKit/win/ChangeLog 2016-12-08 21:56:23 UTC (rev 209568)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-12-08 Filip Pizlo <fpizlo@apple.com>
+
+ Enable SharedArrayBuffer, remove the flag
+ https://bugs.webkit.org/show_bug.cgi?id=165614
+
+ Rubber stamped by Geoffrey Garen.
+
+ * Interfaces/IWebPreferencesPrivate.idl:
+
</ins><span class="cx"> 2016-11-26 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [WTF] Import std::optional reference implementation as WTF::Optional
</span></span></pre></div>
<a id="trunkSourceWebKitwinInterfacesIWebPreferencesPrivateidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl (209567 => 209568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2016-12-08 21:54:21 UTC (rev 209567)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl 2016-12-08 21:56:23 UTC (rev 209568)
</span><span class="lines">@@ -32,8 +32,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> typedef enum WebKitJavaScriptRuntimeFlags {
</span><del>- WebKitJavaScriptRuntimeFlagsSharedArrayBufferEnabled = 1,
- WebKitJavaScriptRuntimeFlagsAllEnabled = 1
</del><ins>+ WebKitJavaScriptRuntimeFlagsAllEnabled = 0
</ins><span class="cx"> } WebKitJavaScriptRuntimeFlags;
</span><span class="cx">
</span><span class="cx"> [
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (209567 => 209568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-12-08 21:54:21 UTC (rev 209567)
+++ trunk/Source/WebKit2/ChangeLog 2016-12-08 21:56:23 UTC (rev 209568)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-12-08 Filip Pizlo <fpizlo@apple.com>
+
+ Enable SharedArrayBuffer, remove the flag
+ https://bugs.webkit.org/show_bug.cgi?id=165614
+
+ Rubber stamped by Geoffrey Garen.
+
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+
</ins><span class="cx"> 2016-12-08 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add SPI for sending WebsiteSettings to WebProcess during navigation
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (209567 => 209568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-12-08 21:54:21 UTC (rev 209567)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-12-08 21:56:23 UTC (rev 209568)
</span><span class="lines">@@ -50,8 +50,7 @@
</span><span class="cx"> typedef enum WKEditableLinkBehavior WKEditableLinkBehavior;
</span><span class="cx">
</span><span class="cx"> enum WKJavaScriptRuntimeFlags {
</span><del>- kWKJavaScriptRuntimeFlagsSharedArrayBufferEnabled = 1 << 0,
- kWKJavaScriptRuntimeFlagsAllEnabled = kWKJavaScriptRuntimeFlagsSharedArrayBufferEnabled
</del><ins>+ kWKJavaScriptRuntimeFlagsAllEnabled = 0
</ins><span class="cx"> };
</span><span class="cx"> typedef unsigned WKJavaScriptRuntimeFlagSet;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h (209567 => 209568)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2016-12-08 21:54:21 UTC (rev 209567)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2016-12-08 21:56:23 UTC (rev 209568)
</span><span class="lines">@@ -43,8 +43,7 @@
</span><span class="cx"> } WK_API_AVAILABLE(macosx(10.11), ios(9.0));
</span><span class="cx">
</span><span class="cx"> typedef NS_OPTIONS(NSUInteger, _WKJavaScriptRuntimeFlags) {
</span><del>- _WKJavaScriptRuntimeFlagsSharedArrayBufferEnabled = 1 << 0,
- _WKJavaScriptRuntimeFlagsAllEnabled = _WKJavaScriptRuntimeFlagsSharedArrayBufferEnabled
</del><ins>+ _WKJavaScriptRuntimeFlagsAllEnabled = 0
</ins><span class="cx"> } WK_API_AVAILABLE(macosx(10.11), ios(9.0));
</span><span class="cx">
</span><span class="cx"> @class _WKExperimentalFeature;
</span></span></pre>
</div>
</div>
</body>
</html>