<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209555] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209555">209555</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-12-08 12:01:00 -0800 (Thu, 08 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>pointer lock should exit when a js alert is shown
https://bugs.webkit.org/show_bug.cgi?id=165423
rdar://problem/29430803
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-12-08
Reviewed by Jer Noble.
Source/WebCore:
Test: pointer-lock/lock-lost-on-alert.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::alert):
(WebCore::DOMWindow::confirm):
(WebCore::DOMWindow::prompt):
LayoutTests:
* platform/mac/TestExpectations:
* pointer-lock/lock-lost-on-alert-expected.txt: Added.
* pointer-lock/lock-lost-on-alert.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowcpp">trunk/Source/WebCore/page/DOMWindow.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestspointerlocklocklostonalertexpectedtxt">trunk/LayoutTests/pointer-lock/lock-lost-on-alert-expected.txt</a></li>
<li><a href="#trunkLayoutTestspointerlocklocklostonalerthtml">trunk/LayoutTests/pointer-lock/lock-lost-on-alert.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209554 => 209555)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-08 19:58:21 UTC (rev 209554)
+++ trunk/LayoutTests/ChangeLog 2016-12-08 20:01:00 UTC (rev 209555)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-12-08 Jeremy Jones <jeremyj@apple.com>
+
+ pointer lock should exit when a js alert is shown
+ https://bugs.webkit.org/show_bug.cgi?id=165423
+ rdar://problem/29430803
+
+ Reviewed by Jer Noble.
+
+ * platform/mac/TestExpectations:
+ * pointer-lock/lock-lost-on-alert-expected.txt: Added.
+ * pointer-lock/lock-lost-on-alert.html: Added.
+
</ins><span class="cx"> 2016-12-08 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> [WebIDL] WebGLContextAttributes should be a dictionary
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (209554 => 209555)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2016-12-08 19:58:21 UTC (rev 209554)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-12-08 20:01:00 UTC (rev 209555)
</span><span class="lines">@@ -291,6 +291,8 @@
</span><span class="cx"> pointer-lock/lock-lost-on-navigation.html [ Pass ]
</span><span class="cx"> http/tests/pointer-lock/
</span><span class="cx">
</span><ins>+pointer-lock/lock-lost-on-alert.html [ Pass ]
+
</ins><span class="cx"> webkit.org/b/82763 fast/forms/textarea-placeholder-set-attribute.html
</span><span class="cx">
</span><span class="cx"> webkit.org/b/102257 fast/dom/Window/open-window-min-size.html
</span></span></pre></div>
<a id="trunkLayoutTestspointerlocklocklostonalertexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/pointer-lock/lock-lost-on-alert-expected.txt (0 => 209555)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/pointer-lock/lock-lost-on-alert-expected.txt (rev 0)
+++ trunk/LayoutTests/pointer-lock/lock-lost-on-alert-expected.txt 2016-12-08 20:01:00 UTC (rev 209555)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+ALERT: Alert text
+Test that pointerlockchange event is dispatched when lock is lost.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS window.testRunner is defined.
+ Lock targetDiv1.
+PASS onpointerlockchange received after: Lock targetDiv1.
+PASS document.pointerLockElement is targetDiv1
+ Alert cancel targetDiv1 lock.
+PASS document.pointerLockElement is null
+PASS onpointerlockchange received after: Alert cancel targetDiv1 lock.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestspointerlocklocklostonalerthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/pointer-lock/lock-lost-on-alert.html (0 => 209555)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/pointer-lock/lock-lost-on-alert.html (rev 0)
+++ trunk/LayoutTests/pointer-lock/lock-lost-on-alert.html 2016-12-08 20:01:00 UTC (rev 209555)
</span><span class="lines">@@ -0,0 +1,39 @@
</span><ins>+<!DOCTYPE HTML>
+<html>
+<head>
+<script src="../http/tests/resources/js-test-pre.js"></script>
+<script src="../http/tests/resources/pointer-lock/pointer-lock-test-harness.js"></script>
+</head>
+<body>
+<div>
+ <div id="target1"></div>
+</div>
+<script>
+ description("Test that pointerlockchange event is dispatched when lock is lost.")
+ window.jsTestIsAsync = true;
+ shouldBeDefined("window.testRunner");
+
+ targetDiv1 = document.getElementById("target1");
+
+ todo = [
+ function () {
+ expectOnlyChangeEvent("Lock targetDiv1.");
+ targetDiv1.requestPointerLock();
+ // doNextStep called by event handler.
+ },
+ function () {
+ shouldBe("document.pointerLockElement", "targetDiv1");
+ doNextStepWithUserGesture();
+ },
+ function () {
+ expectOnlyChangeEvent("Alert cancel targetDiv1 lock.");
+ alert('Alert text');
+ shouldBe("document.pointerLockElement", "null");
+ },
+ ];
+ doNextStepWithUserGesture();
+</script>
+<script src="../http/tests/resources/js-test-post.js"></script>
+</body>
+</html>
+
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209554 => 209555)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-08 19:58:21 UTC (rev 209554)
+++ trunk/Source/WebCore/ChangeLog 2016-12-08 20:01:00 UTC (rev 209555)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-12-08 Jeremy Jones <jeremyj@apple.com>
+
+ pointer lock should exit when a js alert is shown
+ https://bugs.webkit.org/show_bug.cgi?id=165423
+ rdar://problem/29430803
+
+ Reviewed by Jer Noble.
+
+ Test: pointer-lock/lock-lost-on-alert.html
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::alert):
+ (WebCore::DOMWindow::confirm):
+ (WebCore::DOMWindow::prompt):
+
</ins><span class="cx"> 2016-12-07 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> [WebIDL] WebGLContextAttributes should be a dictionary
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.cpp (209554 => 209555)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.cpp 2016-12-08 19:58:21 UTC (rev 209554)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2016-12-08 20:01:00 UTC (rev 209555)
</span><span class="lines">@@ -137,6 +137,10 @@
</span><span class="cx"> #include "GamepadManager.h"
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#if ENABLE(POINTER_LOCK)
+#include "PointerLockController.h"
+#endif
+
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> #if ENABLE(GEOLOCATION)
</span><span class="cx"> #include "NavigatorGeolocation.h"
</span><span class="lines">@@ -1141,6 +1145,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> m_frame->document()->updateStyleIfNeeded();
</span><ins>+#if ENABLE(POINTER_LOCK)
+ page->pointerLockController().requestPointerUnlock();
+#endif
</ins><span class="cx">
</span><span class="cx"> page->chrome().runJavaScriptAlert(m_frame, message);
</span><span class="cx"> }
</span><span class="lines">@@ -1160,6 +1167,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> m_frame->document()->updateStyleIfNeeded();
</span><ins>+#if ENABLE(POINTER_LOCK)
+ page->pointerLockController().requestPointerUnlock();
+#endif
</ins><span class="cx">
</span><span class="cx"> return page->chrome().runJavaScriptConfirm(m_frame, message);
</span><span class="cx"> }
</span><span class="lines">@@ -1179,6 +1189,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> m_frame->document()->updateStyleIfNeeded();
</span><ins>+#if ENABLE(POINTER_LOCK)
+ page->pointerLockController().requestPointerUnlock();
+#endif
</ins><span class="cx">
</span><span class="cx"> String returnValue;
</span><span class="cx"> if (page->chrome().runJavaScriptPrompt(m_frame, message, defaultValue, returnValue))
</span></span></pre>
</div>
</div>
</body>
</html>