<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209505] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209505">209505</a></dd>
<dt>Author</dt> <dd>ggaren@apple.com</dd>
<dt>Date</dt> <dd>2016-12-07 17:31:43 -0800 (Wed, 07 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Renamed SourceCode members to match their accessor names
https://bugs.webkit.org/show_bug.cgi?id=165573
Reviewed by Keith Miller.
startChar => startOffset
endChar => endOffset
* parser/UnlinkedSourceCode.h:
(JSC::UnlinkedSourceCode::UnlinkedSourceCode):
(JSC::UnlinkedSourceCode::view):
(JSC::UnlinkedSourceCode::startOffset):
(JSC::UnlinkedSourceCode::endOffset):
(JSC::UnlinkedSourceCode::length):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserUnlinkedSourceCodecpp">trunk/Source/JavaScriptCore/parser/UnlinkedSourceCode.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserUnlinkedSourceCodeh">trunk/Source/JavaScriptCore/parser/UnlinkedSourceCode.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (209504 => 209505)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-12-08 01:19:03 UTC (rev 209504)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-12-08 01:31:43 UTC (rev 209505)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-12-07 Geoffrey Garen <ggaren@apple.com>
+
+ Renamed SourceCode members to match their accessor names
+ https://bugs.webkit.org/show_bug.cgi?id=165573
+
+ Reviewed by Keith Miller.
+
+ startChar => startOffset
+ endChar => endOffset
+
+ * parser/UnlinkedSourceCode.h:
+ (JSC::UnlinkedSourceCode::UnlinkedSourceCode):
+ (JSC::UnlinkedSourceCode::view):
+ (JSC::UnlinkedSourceCode::startOffset):
+ (JSC::UnlinkedSourceCode::endOffset):
+ (JSC::UnlinkedSourceCode::length):
+
</ins><span class="cx"> 2016-12-07 Keith Miller <keith_miller@apple.com>
</span><span class="cx">
</span><span class="cx"> Add more missing trivial wasm ops.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserUnlinkedSourceCodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/UnlinkedSourceCode.cpp (209504 => 209505)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/UnlinkedSourceCode.cpp 2016-12-08 01:19:03 UTC (rev 209504)
+++ trunk/Source/JavaScriptCore/parser/UnlinkedSourceCode.cpp 2016-12-08 01:31:43 UTC (rev 209505)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> if (!m_provider)
</span><span class="cx"> return CString("", 0);
</span><span class="cx">
</span><del>- return m_provider->source().substring(m_startChar, m_endChar - m_startChar).utf8();
</del><ins>+ return m_provider->source().substring(m_startOffset, m_endOffset - m_startOffset).utf8();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace JSC
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserUnlinkedSourceCodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/UnlinkedSourceCode.h (209504 => 209505)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/UnlinkedSourceCode.h 2016-12-08 01:19:03 UTC (rev 209504)
+++ trunk/Source/JavaScriptCore/parser/UnlinkedSourceCode.h 2016-12-08 01:31:43 UTC (rev 209505)
</span><span class="lines">@@ -37,8 +37,8 @@
</span><span class="cx"> public:
</span><span class="cx"> UnlinkedSourceCode()
</span><span class="cx"> : m_provider(0)
</span><del>- , m_startChar(0)
- , m_endChar(0)
</del><ins>+ , m_startOffset(0)
+ , m_endOffset(0)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -49,22 +49,22 @@
</span><span class="cx">
</span><span class="cx"> UnlinkedSourceCode(PassRefPtr<SourceProvider> provider)
</span><span class="cx"> : m_provider(provider)
</span><del>- , m_startChar(0)
- , m_endChar(m_provider->source().length())
</del><ins>+ , m_startOffset(0)
+ , m_endOffset(m_provider->source().length())
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> UnlinkedSourceCode(PassRefPtr<SourceProvider> provider, int startOffset, int endOffset)
</span><span class="cx"> : m_provider(provider)
</span><del>- , m_startChar(startOffset)
- , m_endChar(endOffset)
</del><ins>+ , m_startOffset(startOffset)
+ , m_endOffset(endOffset)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> UnlinkedSourceCode(const UnlinkedSourceCode& other)
</span><span class="cx"> : m_provider(other.m_provider)
</span><del>- , m_startChar(other.m_startChar)
- , m_endChar(other.m_endChar)
</del><ins>+ , m_startOffset(other.m_startOffset)
+ , m_endOffset(other.m_endOffset)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -80,20 +80,20 @@
</span><span class="cx"> {
</span><span class="cx"> if (!m_provider)
</span><span class="cx"> return StringView();
</span><del>- return m_provider->getRange(m_startChar, m_endChar);
</del><ins>+ return m_provider->getRange(m_startOffset, m_endOffset);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> CString toUTF8() const;
</span><span class="cx">
</span><span class="cx"> bool isNull() const { return !m_provider; }
</span><del>- int startOffset() const { return m_startChar; }
- int endOffset() const { return m_endChar; }
- int length() const { return m_endChar - m_startChar; }
</del><ins>+ int startOffset() const { return m_startOffset; }
+ int endOffset() const { return m_endOffset; }
+ int length() const { return m_endOffset - m_startOffset; }
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> RefPtr<SourceProvider> m_provider;
</span><del>- int m_startChar;
- int m_endChar;
</del><ins>+ int m_startOffset;
+ int m_endOffset;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace JSC
</span></span></pre>
</div>
</div>
</body>
</html>