<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209460] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209460">209460</a></dd>
<dt>Author</dt> <dd>hyatt@apple.com</dd>
<dt>Date</dt> <dd>2016-12-07 09:18:45 -0800 (Wed, 07 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Parser] Turn back on a bunch of layout tests
https://bugs.webkit.org/show_bug.cgi?id=165529
Reviewed by Zalan Bujtas.
Source/WebCore:
Fixes fast/css/transform-origin-parsing.html.
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeTransformOrigin):
The implicit check was relying on a null check of the z value, but
we called releaseNonNull on it already. This meant all z properties were
marked as implicit incorrectly. Fix by storing whether or not we had a z
value in a local variable.
LayoutTests:
* TestExpectations:
* css3/parsing-css3-nthchild-expected.txt:
* css3/parsing-css3-nthchild.html:
* css3/scroll-snap/scroll-snap-position-values-expected.txt:
* css3/scroll-snap/scroll-snap-position-values.html:
* editing/execCommand/insert-list-with-noneditable-content-expected.txt:
* fast/css/object-position/parsing-object-position-expected.txt:
* fast/css/object-position/parsing-object-position.html:
* fast/css/parsing-css-number-types-expected.txt:
* fast/css/parsing-css-wrap-expected.txt:
* fast/css/script-tests/transform-origin-parsing.js:
* fast/css/transform-inline-style-remove-expected.txt:
* fast/css/transform-origin-parsing-expected.txt:
* fast/css/variables/custom-property-dynamic-update-expected.html:
* fast/events/mouse-cursor-expected.txt:
* fast/inspector-support/style-expected.txt:
* platform/mac/svg/webarchive/svg-script-subresouces-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestscss3parsingcss3nthchildexpectedtxt">trunk/LayoutTests/css3/parsing-css3-nthchild-expected.txt</a></li>
<li><a href="#trunkLayoutTestscss3parsingcss3nthchildhtml">trunk/LayoutTests/css3/parsing-css3-nthchild.html</a></li>
<li><a href="#trunkLayoutTestscss3scrollsnapscrollsnappositionvaluesexpectedtxt">trunk/LayoutTests/css3/scroll-snap/scroll-snap-position-values-expected.txt</a></li>
<li><a href="#trunkLayoutTestscss3scrollsnapscrollsnappositionvalueshtml">trunk/LayoutTests/css3/scroll-snap/scroll-snap-position-values.html</a></li>
<li><a href="#trunkLayoutTestseditingexecCommandinsertlistwithnoneditablecontentexpectedtxt">trunk/LayoutTests/editing/execCommand/insert-list-with-noneditable-content-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssobjectpositionparsingobjectpositionexpectedtxt">trunk/LayoutTests/fast/css/object-position/parsing-object-position-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssobjectpositionparsingobjectpositionhtml">trunk/LayoutTests/fast/css/object-position/parsing-object-position.html</a></li>
<li><a href="#trunkLayoutTestsfastcssparsingcssnumbertypesexpectedtxt">trunk/LayoutTests/fast/css/parsing-css-number-types-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssparsingcsswrapexpectedtxt">trunk/LayoutTests/fast/css/parsing-css-wrap-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssscriptteststransformoriginparsingjs">trunk/LayoutTests/fast/css/script-tests/transform-origin-parsing.js</a></li>
<li><a href="#trunkLayoutTestsfastcsstransforminlinestyleremoveexpectedtxt">trunk/LayoutTests/fast/css/transform-inline-style-remove-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcsstransformoriginparsingexpectedtxt">trunk/LayoutTests/fast/css/transform-origin-parsing-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssvariablescustompropertydynamicupdateexpectedhtml">trunk/LayoutTests/fast/css/variables/custom-property-dynamic-update-expected.html</a></li>
<li><a href="#trunkLayoutTestsfasteventsmousecursorexpectedtxt">trunk/LayoutTests/fast/events/mouse-cursor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastinspectorsupportstyleexpectedtxt">trunk/LayoutTests/fast/inspector-support/style-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacsvgwebarchivesvgscriptsubresoucesexpectedtxt">trunk/LayoutTests/platform/mac/svg/webarchive/svg-script-subresouces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssparserCSSPropertyParsercpp">trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/ChangeLog 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2016-12-07 Dave Hyatt <hyatt@apple.com>
+
+ [CSS Parser] Turn back on a bunch of layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=165529
+
+ Reviewed by Zalan Bujtas.
+
+ * TestExpectations:
+ * css3/parsing-css3-nthchild-expected.txt:
+ * css3/parsing-css3-nthchild.html:
+ * css3/scroll-snap/scroll-snap-position-values-expected.txt:
+ * css3/scroll-snap/scroll-snap-position-values.html:
+ * editing/execCommand/insert-list-with-noneditable-content-expected.txt:
+ * fast/css/object-position/parsing-object-position-expected.txt:
+ * fast/css/object-position/parsing-object-position.html:
+ * fast/css/parsing-css-number-types-expected.txt:
+ * fast/css/parsing-css-wrap-expected.txt:
+ * fast/css/script-tests/transform-origin-parsing.js:
+ * fast/css/transform-inline-style-remove-expected.txt:
+ * fast/css/transform-origin-parsing-expected.txt:
+ * fast/css/variables/custom-property-dynamic-update-expected.html:
+ * fast/events/mouse-cursor-expected.txt:
+ * fast/inspector-support/style-expected.txt:
+ * platform/mac/svg/webarchive/svg-script-subresouces-expected.txt:
+
</ins><span class="cx"> 2016-12-07 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Rebaseline fast/table/003.html after r209421.
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/TestExpectations 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -993,25 +993,6 @@
</span><span class="cx"> webkit.org/b/164797 js/dom/domjit-function-get-element-by-id-licm.html [ Pass Timeout ]
</span><span class="cx"> webkit.org/b/164797 js/dom/domjit-function-get-element-by-id-changed.html [ Pass Timeout ]
</span><span class="cx">
</span><del>-# The following layout tests are allowed to fail temporarily until we get the new CSS parser
-# enabled. Once it is turned on, all of these tests should have their results reset.
-webkit.org/b/165195 css3/parsing-css3-nthchild.html [ Pass Failure ]
-webkit.org/b/165195 css3/scroll-snap/scroll-snap-position-values.html [ Pass Failure ]
-webkit.org/b/165195 css3/scroll-snap/scroll-snap-position-values.html [ Pass Failure ]
-webkit.org/b/165195 editing/execCommand/insert-list-with-noneditable-content.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/object-position/parsing-object-position.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/large-value-csstext.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/parsing-css-number-types.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/parsing-css-wrap.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/transform-origin-parsing.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/transform-inline-style-remove.html [ Pass Failure ]
-webkit.org/b/165195 fast/css/variables/custom-property-dynamic-update.html [ Skip ]
-webkit.org/b/165195 fast/events/mouse-cursor.html [ Pass Failure ]
-webkit.org/b/165195 fast/forms/basic-selects.html [ Pass Failure ]
-webkit.org/b/165195 fast/shadow-dom/slotted-pseudo-element-css-text.html [ Pass Failure ]
-webkit.org/b/165195 fast/inspector-support/style.html [ Pass Failure ]
-webkit.org/b/165195 svg/webarchive/svg-script-subresouces.svg [ Pass Failure ]
-
</del><span class="cx"> # The following layout tests need to be changed when the new CSS Parser is turned on, since they
</span><span class="cx"> # incorrectly indicate failures on valid syntax.
</span><span class="cx"> webkit.org/b/165195 css3/font-variant-parsing.html [ Pass Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestscss3parsingcss3nthchildexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/css3/parsing-css3-nthchild-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/parsing-css3-nthchild-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/css3/parsing-css3-nthchild-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -6,10 +6,8 @@
</span><span class="cx"> #b:nth-child(n- 10) { color: green; }
</span><span class="cx"> #g:nth-child(-n-1) { color: green; }
</span><span class="cx"> #h:nth-child(-n- 10) { color: green; }
</span><del>-#n:nth-child(-n
- - 1) { color: green; }
-#o:nth-child(-n
- +13) { color: green; }
</del><ins>+#n:nth-child(-n - 1) { color: green; }
+#o:nth-child(-n +13) { color: green; }
</ins><span class="cx"> Expected result:
</span><span class="cx">
</span><span class="cx"> #a:nth-child(n-1) { color: green; }
</span><span class="lines">@@ -16,8 +14,6 @@
</span><span class="cx"> #b:nth-child(n- 10) { color: green; }
</span><span class="cx"> #g:nth-child(-n-1) { color: green; }
</span><span class="cx"> #h:nth-child(-n- 10) { color: green; }
</span><del>-#n:nth-child(-n
- - 1) { color: green; }
-#o:nth-child(-n
- +13) { color: green; }
</del><ins>+#n:nth-child(-n - 1) { color: green; }
+#o:nth-child(-n +13) { color: green; }
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestscss3parsingcss3nthchildhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/css3/parsing-css3-nthchild.html (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/parsing-css3-nthchild.html 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/css3/parsing-css3-nthchild.html 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -56,9 +56,7 @@
</span><span class="cx"> #b:nth-child(n- 10) { color: green; }
</span><span class="cx"> #g:nth-child(-n-1) { color: green; }
</span><span class="cx"> #h:nth-child(-n- 10) { color: green; }
</span><del>-#n:nth-child(-n
- - 1) { color: green; }
-#o:nth-child(-n
- +13) { color: green; }
</del><ins>+#n:nth-child(-n - 1) { color: green; }
+#o:nth-child(-n +13) { color: green; }
</ins><span class="cx"> </pre>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkLayoutTestscss3scrollsnapscrollsnappositionvaluesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/css3/scroll-snap/scroll-snap-position-values-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/scroll-snap/scroll-snap-position-values-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/css3/scroll-snap/scroll-snap-position-values-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> PASS window.getComputedStyle(initialDestination).getPropertyValue('-webkit-scroll-snap-points-y') is "repeat(100%)"
</span><span class="cx"> PASS initialDestination.style['-webkit-scroll-snap-destination'] is "initial"
</span><span class="cx"> PASS window.getComputedStyle(initialDestination).getPropertyValue('-webkit-scroll-snap-destination') is "0px 0px"
</span><del>-PASS initialDestination.style['-webkit-scroll-snap-coordinate'] is ""
</del><ins>+PASS initialDestination.style['-webkit-scroll-snap-coordinate'] is "none"
</ins><span class="cx"> PASS window.getComputedStyle(initialDestination).getPropertyValue('-webkit-scroll-snap-coordinate') is "none"
</span><span class="cx"> PASS initialSnapCoordinate.style['-webkit-scroll-snap-type'] is ""
</span><span class="cx"> PASS window.getComputedStyle(initialSnapCoordinate).getPropertyValue('-webkit-scroll-snap-type') is "mandatory"
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> PASS window.getComputedStyle(noneSnapCoordinateAndDestination).getPropertyValue('-webkit-scroll-snap-points-y') is "repeat(100%)"
</span><span class="cx"> PASS noneSnapCoordinateAndDestination.style['-webkit-scroll-snap-destination'] is ""
</span><span class="cx"> PASS window.getComputedStyle(noneSnapCoordinateAndDestination).getPropertyValue('-webkit-scroll-snap-destination') is "0px 0px"
</span><del>-PASS noneSnapCoordinateAndDestination.style['-webkit-scroll-snap-coordinate'] is ""
</del><ins>+PASS noneSnapCoordinateAndDestination.style['-webkit-scroll-snap-coordinate'] is "none"
</ins><span class="cx"> PASS window.getComputedStyle(noneSnapCoordinateAndDestination).getPropertyValue('-webkit-scroll-snap-coordinate') is "none"
</span><span class="cx"> PASS calculatedCoordinateAndDestination.style['-webkit-scroll-snap-type'] is ""
</span><span class="cx"> PASS window.getComputedStyle(calculatedCoordinateAndDestination).getPropertyValue('-webkit-scroll-snap-type') is "mandatory"
</span></span></pre></div>
<a id="trunkLayoutTestscss3scrollsnapscrollsnappositionvalueshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/css3/scroll-snap/scroll-snap-position-values.html (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/scroll-snap/scroll-snap-position-values.html 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/css3/scroll-snap/scroll-snap-position-values.html 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -253,7 +253,7 @@
</span><span class="cx"> shouldBeEqualToString("window.getComputedStyle(initialDestination).getPropertyValue('-webkit-scroll-snap-points-y')", "repeat(100%)");
</span><span class="cx"> shouldBeEqualToString("initialDestination.style['-webkit-scroll-snap-destination']", "initial");
</span><span class="cx"> shouldBeEqualToString("window.getComputedStyle(initialDestination).getPropertyValue('-webkit-scroll-snap-destination')", "0px 0px");
</span><del>- shouldBeEmptyString("initialDestination.style['-webkit-scroll-snap-coordinate']");
</del><ins>+ shouldBeEqualToString("initialDestination.style['-webkit-scroll-snap-coordinate']", "none");
</ins><span class="cx"> shouldBeEqualToString("window.getComputedStyle(initialDestination).getPropertyValue('-webkit-scroll-snap-coordinate')", "none");
</span><span class="cx">
</span><span class="cx"> var initialSnapCoordinate = document.getElementById('initialSnapCoordinate');
</span><span class="lines">@@ -289,7 +289,7 @@
</span><span class="cx"> shouldBeEqualToString("window.getComputedStyle(noneSnapCoordinateAndDestination).getPropertyValue('-webkit-scroll-snap-points-y')", "repeat(100%)");
</span><span class="cx"> shouldBeEmptyString("noneSnapCoordinateAndDestination.style['-webkit-scroll-snap-destination']");
</span><span class="cx"> shouldBeEqualToString("window.getComputedStyle(noneSnapCoordinateAndDestination).getPropertyValue('-webkit-scroll-snap-destination')", "0px 0px");
</span><del>- shouldBeEmptyString("noneSnapCoordinateAndDestination.style['-webkit-scroll-snap-coordinate']");
</del><ins>+ shouldBeEqualToString("noneSnapCoordinateAndDestination.style['-webkit-scroll-snap-coordinate']", "none");
</ins><span class="cx"> shouldBeEqualToString("window.getComputedStyle(noneSnapCoordinateAndDestination).getPropertyValue('-webkit-scroll-snap-coordinate')", "none");
</span><span class="cx">
</span><span class="cx"> var calculatedCoordinateAndDestination = document.getElementById('calculatedCoordinateAndDestination');
</span></span></pre></div>
<a id="trunkLayoutTestseditingexecCommandinsertlistwithnoneditablecontentexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/editing/execCommand/insert-list-with-noneditable-content-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/execCommand/insert-list-with-noneditable-content-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/editing/execCommand/insert-list-with-noneditable-content-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> | <li>
</span><span class="cx"> | "Editabl<#selection-anchor>e paragraph containing a "
</span><span class="cx"> | <span>
</span><del>-| style="background-color: rgb(211, 211, 211);"
</del><ins>+| style="background-color: lightgray;"
</ins><span class="cx"> | "non-editable"
</span><span class="cx"> | " in the middle"
</span><span class="cx"> | <br>
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssobjectpositionparsingobjectpositionexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/object-position/parsing-object-position-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/object-position/parsing-object-position-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/fast/css/object-position/parsing-object-position-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -6,8 +6,8 @@
</span><span class="cx"> PASS testComputedStyle(";") is "50% 50%"
</span><span class="cx"> PASS test("object-position: inherit;") is "inherit"
</span><span class="cx"> PASS test("object-position: initial;") is "initial"
</span><del>-PASS test("object-position: 23px;") is "23px 50%"
-PASS test("object-position: center 23px;") is "50% 23px"
</del><ins>+PASS test("object-position: 23px;") is "23px center"
+PASS test("object-position: center 23px;") is "50% center"
</ins><span class="cx"> PASS test("object-position: 50% 23px;") is "50% 23px"
</span><span class="cx"> PASS test("object-position: 50% left;") is ""
</span><span class="cx"> PASS test("object-position: left 10px top 15px;") is "left 10px top 15px"
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssobjectpositionparsingobjectpositionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/object-position/parsing-object-position.html (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/object-position/parsing-object-position.html 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/fast/css/object-position/parsing-object-position.html 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -33,8 +33,8 @@
</span><span class="cx"> shouldBe('test("object-position: inherit;")', '"inherit"');
</span><span class="cx"> shouldBe('test("object-position: initial;")', '"initial"');
</span><span class="cx">
</span><del>- shouldBeEqualToString('test("object-position: 23px;")', '23px 50%');
- shouldBeEqualToString('test("object-position: center 23px;")', '50% 23px');
</del><ins>+ shouldBeEqualToString('test("object-position: 23px;")', '23px center');
+ shouldBeEqualToString('test("object-position: center 23px;")', 'center 23px');
</ins><span class="cx"> shouldBeEqualToString('test("object-position: 50% 23px;")', '50% 23px');
</span><span class="cx"> shouldBeEqualToString('test("object-position: 50% left;")', '');
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssparsingcssnumbertypesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/parsing-css-number-types-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/parsing-css-number-types-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/fast/css/parsing-css-number-types-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -1,25 +1,25 @@
</span><span class="cx"> Test parsing of CSS number types.
</span><span class="cx">
</span><del>-FAILURE
</del><ins>+SUCCESS
</ins><span class="cx">
</span><span class="cx"> Rules from the stylesheet:
</span><span class="cx">
</span><span class="cx"> #a { font-size: 1em; }
</span><del>-#b { }
-#c { }
-#d { }
</del><ins>+#b { font-size: 1em; }
+#c { font-size: 1em; }
+#d { font-size: 1em; }
</ins><span class="cx"> #e { font-size: 1rem; }
</span><del>-#f { }
</del><ins>+#f { font-size: 1ex; }
</ins><span class="cx"> #g { font-size: 16px; }
</span><span class="cx"> #h { font-size: 16px; }
</span><del>-#i { }
-#j { }
</del><ins>+#i { font-size: 16px; }
+#j { font-size: 16px; }
</ins><span class="cx"> #k { font-size: 1cm; }
</span><del>-#l { }
</del><ins>+#l { font-size: 1mm; }
</ins><span class="cx"> #m { font-size: 1in; }
</span><span class="cx"> #n { font-size: 12pt; }
</span><del>-#o { }
-#p { }
</del><ins>+#o { font-size: 16px; }
+#p { font-size: 1pc; }
</ins><span class="cx"> #q { font-size: 100%; }
</span><span class="cx"> Expected result:
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssparsingcsswrapexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/parsing-css-wrap-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/parsing-css-wrap-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/fast/css/parsing-css-wrap-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> Test parsing of CSS '\r\n' newline characters.
</span><span class="cx">
</span><del>-FAILURE
</del><ins>+SUCCESS
</ins><span class="cx">
</span><span class="cx"> Rules from the stylesheet:
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssscriptteststransformoriginparsingjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/script-tests/transform-origin-parsing.js (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/script-tests/transform-origin-parsing.js 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/fast/css/script-tests/transform-origin-parsing.js 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -17,5 +17,5 @@
</span><span class="cx"> shouldBeEqualToString('test("-webkit-transform-origin: 10px 10px 10%", "-webkit-transform-origin")', '');
</span><span class="cx"> shouldBe('test("-webkit-transform-origin: 10px 10px 10px", "-webkit-transform-origin")', '"10px 10px 10px"');
</span><span class="cx"> shouldBeEqualToString('test("-webkit-transform-origin: left top 10%", "-webkit-transform-origin")', '');
</span><del>-shouldBe('test("-webkit-transform-origin: left top 10px", "-webkit-transform-origin")', '"0% 0% 10px"');
</del><ins>+shouldBe('test("-webkit-transform-origin: left top 10px", "-webkit-transform-origin")', '"left top 10px"');
</ins><span class="cx"> shouldBeEqualToString('test("-webkit-transform-origin: left top left", "-webkit-transform-origin")', '');
</span></span></pre></div>
<a id="trunkLayoutTestsfastcsstransforminlinestyleremoveexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/transform-inline-style-remove-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/transform-inline-style-remove-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/fast/css/transform-inline-style-remove-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -12,8 +12,8 @@
</span><span class="cx"> transition duration (after):
</span><span class="cx"> transition timing function (after):
</span><span class="cx">
</span><del>-transform origin (before): 0% 30%
-transform origin X (before): 0%
</del><ins>+transform origin (before): left 30%
+transform origin X (before): left
</ins><span class="cx"> transform origin Y (before): 30%
</span><span class="cx"> transform origin (after):
</span><span class="cx"> transform origin X (after):
</span></span></pre></div>
<a id="trunkLayoutTestsfastcsstransformoriginparsingexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/transform-origin-parsing-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/transform-origin-parsing-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/fast/css/transform-origin-parsing-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx"> PASS test("-webkit-transform-origin: 10px 10px 10%", "-webkit-transform-origin") is ""
</span><span class="cx"> PASS test("-webkit-transform-origin: 10px 10px 10px", "-webkit-transform-origin") is "10px 10px 10px"
</span><span class="cx"> PASS test("-webkit-transform-origin: left top 10%", "-webkit-transform-origin") is ""
</span><del>-PASS test("-webkit-transform-origin: left top 10px", "-webkit-transform-origin") is "0% 0% 10px"
</del><ins>+PASS test("-webkit-transform-origin: left top 10px", "-webkit-transform-origin") is "left top 10px"
</ins><span class="cx"> PASS test("-webkit-transform-origin: left top left", "-webkit-transform-origin") is ""
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssvariablescustompropertydynamicupdateexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/variables/custom-property-dynamic-update-expected.html (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/variables/custom-property-dynamic-update-expected.html 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/fast/css/variables/custom-property-dynamic-update-expected.html 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> <html>
</span><span class="cx"> <body>
</span><del>-linear-gradient(to top, rgb(204, 0, 102), white)<br>
</del><ins>+linear-gradient(to top, #c06, white)<br>
</ins><span class="cx"> linear-gradient(to top, green, white)
</span><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsmousecursorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/mouse-cursor-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/mouse-cursor-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/fast/events/mouse-cursor-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -25,7 +25,7 @@
</span><span class="cx"> Cursor Info: type=Grabbing hotSpot=0,0
</span><span class="cx">
</span><span class="cx"> TEST CASE: Existing 25x25 image
</span><del>-Cursor Info: type=Custom hotSpot=0,0 image=25x25
</del><ins>+Cursor Info: type=IBeam hotSpot=0,0
</ins><span class="cx">
</span><span class="cx"> TEST CASE: Invalid URL with fallback to pointer
</span><span class="cx"> Cursor Info: type=Hand hotSpot=0,0
</span></span></pre></div>
<a id="trunkLayoutTestsfastinspectorsupportstyleexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/inspector-support/style-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/inspector-support/style-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/fast/inspector-support/style-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -1,15 +1,15 @@
</span><span class="cx"> Note that background is buggy right now!
</span><span class="cx"> Test
</span><span class="cx"> background-image: initial (original property was background)
</span><ins>+background-position-x: initial (original property was background)
+background-position-y: initial (original property was background)
+background-size: initial (original property was background)
</ins><span class="cx"> background-repeat-x: initial (original property was background)
</span><span class="cx"> background-repeat-y: initial (original property was background)
</span><span class="cx"> background-attachment: initial (original property was background)
</span><del>-background-position-x: initial (original property was background)
-background-position-y: initial (original property was background)
</del><span class="cx"> background-origin: initial (original property was background)
</span><span class="cx"> background-clip: initial (original property was background)
</span><span class="cx"> background-color: purple (original property was background)
</span><del>-background-size: initial (original property was background)
</del><span class="cx"> margin-top: 1em (original property was margin)
</span><span class="cx"> margin-right: 1em (original property was margin and property was implicitly set.)
</span><span class="cx"> margin-bottom: 1em (original property was margin and property was implicitly set.)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacsvgwebarchivesvgscriptsubresoucesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/svg/webarchive/svg-script-subresouces-expected.txt (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/svg/webarchive/svg-script-subresouces-expected.txt 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/LayoutTests/platform/mac/svg/webarchive/svg-script-subresouces-expected.txt 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -10,7 +10,7 @@
</span><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.dumpDOMAsWebArchive();
</span><span class="cx"> &lt;/script&gt;
</span><del>- &lt;rect id="rect" width="100" height="100" fill="red" style="fill: rgb(0, 128, 0);"/&gt;
</del><ins>+ &lt;rect id="rect" width="100" height="100" fill="red" style="fill: green;"/&gt;
</ins><span class="cx"> &lt;script xlink:href="resources/svg-script-subresources.js" type="text/ecmascript"/&gt;
</span><span class="cx"> &lt;/svg&gt;</string>
</span><span class="cx"> <key>WebResourceFrameName</key>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/Source/WebCore/ChangeLog 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-12-07 Dave Hyatt <hyatt@apple.com>
+
+ [CSS Parser] Turn back on a bunch of layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=165529
+
+ Reviewed by Zalan Bujtas.
+
+ Fixes fast/css/transform-origin-parsing.html.
+
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::CSSPropertyParser::consumeTransformOrigin):
+ The implicit check was relying on a null check of the z value, but
+ we called releaseNonNull on it already. This meant all z properties were
+ marked as implicit incorrectly. Fix by storing whether or not we had a z
+ value in a local variable.
+
</ins><span class="cx"> 2016-12-07 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Remove bitrotted FrameLoader attempt to limit page caching under memory pressure.
</span></span></pre></div>
<a id="trunkSourceWebCorecssparserCSSPropertyParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (209459 => 209460)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2016-12-07 16:48:03 UTC (rev 209459)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2016-12-07 17:18:45 UTC (rev 209460)
</span><span class="lines">@@ -375,11 +375,12 @@
</span><span class="cx"> m_range.consumeWhitespace();
</span><span class="cx"> bool atEnd = m_range.atEnd();
</span><span class="cx"> RefPtr<CSSPrimitiveValue> resultZ = consumeLength(m_range, m_context.mode, ValueRangeAll);
</span><del>- if (!resultZ && !atEnd)
</del><ins>+ bool hasZ = resultZ;
+ if (!hasZ && !atEnd)
</ins><span class="cx"> return false;
</span><span class="cx"> addProperty(CSSPropertyTransformOriginX, CSSPropertyTransformOrigin, resultX.releaseNonNull(), important);
</span><span class="cx"> addProperty(CSSPropertyTransformOriginY, CSSPropertyTransformOrigin, resultY.releaseNonNull(), important);
</span><del>- addProperty(CSSPropertyTransformOriginZ, CSSPropertyTransformOrigin, resultZ ? resultZ.releaseNonNull() : CSSValuePool::singleton().createValue(0, CSSPrimitiveValue::UnitTypes::CSS_PX), important, !resultZ);
</del><ins>+ addProperty(CSSPropertyTransformOriginZ, CSSPropertyTransformOrigin, resultZ ? resultZ.releaseNonNull() : CSSValuePool::singleton().createValue(0, CSSPrimitiveValue::UnitTypes::CSS_PX), important, !hasZ);
</ins><span class="cx">
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>