<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209527] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209527">209527</a></dd>
<dt>Author</dt> <dd>hyatt@apple.com</dd>
<dt>Date</dt> <dd>2016-12-07 22:47:53 -0800 (Wed, 07 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Parser] Remove font test that tests something nobody supports
https://bugs.webkit.org/show_bug.cgi?id=165596
Reviewed by Zalan Bujtas.
Remove this test that thinks "default" should be a special keyword in fonts. No
other browser treat this as special. Our old parser did, but it's just from some
reading of ancient CSS2 specs and not for any real-world reason.
* TestExpectations:
* fast/css/font-family-parse-keyword.html: Removed.
* fast/css/font-family-parse-keyword-expected.html: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssfontfamilyparsekeywordexpectedhtml">trunk/LayoutTests/fast/css/font-family-parse-keyword-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastcssfontfamilyparsekeywordhtml">trunk/LayoutTests/fast/css/font-family-parse-keyword.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209526 => 209527)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-08 06:29:46 UTC (rev 209526)
+++ trunk/LayoutTests/ChangeLog 2016-12-08 06:47:53 UTC (rev 209527)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2016-12-07 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><ins>+ [CSS Parser] Remove font test that tests something nobody supports
+ https://bugs.webkit.org/show_bug.cgi?id=165596
+
+ Reviewed by Zalan Bujtas.
+
+ Remove this test that thinks "default" should be a special keyword in fonts. No
+ other browser treat this as special. Our old parser did, but it's just from some
+ reading of ancient CSS2 specs and not for any real-world reason.
+
+ * TestExpectations:
+ * fast/css/font-family-parse-keyword.html: Removed.
+ * fast/css/font-family-parse-keyword-expected.html: Removed.
+
+2016-12-07 Dave Hyatt <hyatt@apple.com>
+
</ins><span class="cx"> REGRESSION: font shorthand parsing is broken
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=165594
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (209526 => 209527)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2016-12-08 06:29:46 UTC (rev 209526)
+++ trunk/LayoutTests/TestExpectations 2016-12-08 06:47:53 UTC (rev 209527)
</span><span class="lines">@@ -998,7 +998,6 @@
</span><span class="cx"> # The following layout tests need to be changed when the new CSS Parser is turned on, since they
</span><span class="cx"> # incorrectly indicate failures on valid syntax.
</span><span class="cx"> webkit.org/b/165195 fast/css/attr-parsing.html [ Pass Failure ]
</span><del>-webkit.org/b/165195 fast/css/font-family-parse-keyword.html [ Skip ]
</del><span class="cx"> webkit.org/b/165195 fast/css/font-property-priority.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/165195 fast/css/font_property_normal.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/165195 fast/css/image-set-unprefixed.html [ Pass Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssfontfamilyparsekeywordexpectedhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/css/font-family-parse-keyword-expected.html (209526 => 209527)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/font-family-parse-keyword-expected.html 2016-12-08 06:29:46 UTC (rev 209526)
+++ trunk/LayoutTests/fast/css/font-family-parse-keyword-expected.html 2016-12-08 06:47:53 UTC (rev 209527)
</span><span class="lines">@@ -1,46 +0,0 @@
</span><del>-<!DOCTYPE html>
-<style>
-@font-face {
- font-family: webkit-ahem;
- src: url(../../resources/Ahem.ttf) format(truetype);
-}
-</style>
-<body>
- <p>
- https://bugs.webkit.org/b/107231 - CSSParser::parseFontFamily should allow
- the keyword "default" as part of a font name
- </p>
- <p>
- The next 4 lines should use the default font (same as this line):<br>
- Test 1<br>
- Test 2<br>
- Test 3<br>
- Test 4
- </p>
- <p>
- The next 6 lines should use the font Arial:<br>
- <span style="font-family: arial">
- Test 1<br>
- Test 2<br>
- Test 3<br>
- Test 4<br>
- Test 5<br>
- Test 6
- </span>
- </p>
- <p>
- The next 9 lines should use the font Ahem (black boxes):<br>
- <span style="font-family: webkit-ahem">
- Test 1<br>
- Test 2<br>
- Test 3<br>
- Test 4<br>
- Test 5<br>
- Test 6<br>
- Test 7<br>
- Test 8<br>
- Test 9
- </span>
- </p>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsfastcssfontfamilyparsekeywordhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/css/font-family-parse-keyword.html (209526 => 209527)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/font-family-parse-keyword.html 2016-12-08 06:29:46 UTC (rev 209526)
+++ trunk/LayoutTests/fast/css/font-family-parse-keyword.html 2016-12-08 06:47:53 UTC (rev 209527)
</span><span class="lines">@@ -1,50 +0,0 @@
</span><del>-<!DOCTYPE html>
-<style>
-@font-face {
- font-family: webkit-ahem;
- src: url(../../resources/Ahem.ttf) format(truetype);
-}
-@font-face {
- font-family: default foo;
- src: url(../../resources/Ahem.ttf) format(truetype);
-}
-@font-face {
- font-family: bar default;
- src: url(../../resources/Ahem.ttf) format(truetype);
-}
-</style>
-<body>
- <p>
- https://bugs.webkit.org/b/107231 - CSSParser::parseFontFamily should allow
- the keyword "default" as part of a font name
- </p>
- <p>
- The next 4 lines should use the default font (same as this line):<br>
- Test 1<br>
- <span style="font-family: default">Test 2</span><br>
- <span style="font-family: default, invalid">Test 3</span><br>
- <span style="font-family: invalid, default">Test 4</span>
- </p>
- <p>
- The next 6 lines should use the font Arial:<br>
- <span style="font-family: arial">Test 1</span><br>
- <span style="font-family: default, arial">Test 2</span><br>
- <span style="font-family: default foobar, arial">Test 3</span><br>
- <span style="font-family: arial, default">Test 4</span><br>
- <span style="font-family: arial, default foobar">Test 5</span><br>
- <span style="font-family: invalid, default, arial">Test 6</span>
- </p>
- <p>
- The next 9 lines should use the font Ahem (black boxes):<br>
- <span style="font-family: webkit-ahem">Test 1</span><br>
- <span style="font-family: default foo">Test 2</span><br>
- <span style="font-family: default foo, invalid">Test 3</span><br>
- <span style="font-family: invalid, default foo">Test 4</span><br>
- <span style="font-family: invalid, default foo, foobar">Test 5</span><br>
- <span style="font-family: bar default">Test 6</span><br>
- <span style="font-family: bar default, invalid">Test 7</span><br>
- <span style="font-family: invalid, bar default">Test 8</span><br>
- <span style="font-family: invalid, bar default, foobar">Test 9</span>
- </p>
-</body>
-</html>
</del></span></pre>
</div>
</div>
</body>
</html>