<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209510] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209510">209510</a></dd>
<dt>Author</dt> <dd>wilander@apple.com</dd>
<dt>Date</dt> <dd>2016-12-07 18:08:28 -0800 (Wed, 07 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Allow commas in Accept, Accept-Language, and Content-Language request headers for simple CORS
https://bugs.webkit.org/show_bug.cgi?id=165566
<rdar://problem/29560983>
Reviewed by Alex Christensen.
Source/WebCore:
Updated the existing tests.
* platform/network/HTTPParsers.cpp:
(WebCore::isValidAcceptHeaderValue):
Now also accepts ','.
(WebCore::isValidLanguageHeaderValue):
Ditto.
LayoutTests:
* http/tests/xmlhttprequest/cors-non-standard-safelisted-headers-should-trigger-preflight.html:
Added ',' to the tests as well as two examples from
two sites where we found a regression.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestsxmlhttprequestcorsnonstandardsafelistedheadersshouldtriggerpreflighthtml">trunk/LayoutTests/http/tests/xmlhttprequest/cors-non-standard-safelisted-headers-should-trigger-preflight.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkHTTPParserscpp">trunk/Source/WebCore/platform/network/HTTPParsers.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209509 => 209510)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-08 02:01:30 UTC (rev 209509)
+++ trunk/LayoutTests/ChangeLog 2016-12-08 02:08:28 UTC (rev 209510)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-12-07 John Wilander <wilander@apple.com>
+
+ Allow commas in Accept, Accept-Language, and Content-Language request headers for simple CORS
+ https://bugs.webkit.org/show_bug.cgi?id=165566
+ <rdar://problem/29560983>
+
+ Reviewed by Alex Christensen.
+
+ * http/tests/xmlhttprequest/cors-non-standard-safelisted-headers-should-trigger-preflight.html:
+ Added ',' to the tests as well as two examples from
+ two sites where we found a regression.
+
</ins><span class="cx"> 2016-12-07 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> [CSS Parser] Stop skipping tests in the css3 LayoutTests subdirectory
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsxmlhttprequestcorsnonstandardsafelistedheadersshouldtriggerpreflighthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/xmlhttprequest/cors-non-standard-safelisted-headers-should-trigger-preflight.html (209509 => 209510)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/xmlhttprequest/cors-non-standard-safelisted-headers-should-trigger-preflight.html 2016-12-08 02:01:30 UTC (rev 209509)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/cors-non-standard-safelisted-headers-should-trigger-preflight.html 2016-12-08 02:08:28 UTC (rev 209510)
</span><span class="lines">@@ -34,12 +34,12 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var abnormalSimpleCorsHeaderValue = "() { :;};"
</span><del>- var allAllowedNonAlphanumericCharactersForAcceptHeader = " *./;="
- var allAllowedNonAlphanumericCharactersForAcceptAndContentLanguageHeader = " *-.;="
</del><ins>+ var allAllowedNonAlphanumericCharactersForAcceptHeader = " *,./;="
+ var allAllowedNonAlphanumericCharactersForAcceptAndContentLanguageHeader = " *,-.;="
</ins><span class="cx"> var testCases = [
</span><span class="cx"> // Positive test cases with normal headers
</span><span class="cx"> {
</span><del>- headersToAdd: [{ name : "Accept", value: "text/*" }],
</del><ins>+ headersToAdd: [{ name : "Accept", value: "application/json,text/*,*/*" }],
</ins><span class="cx"> explicitlyAllowHeaders: false,
</span><span class="cx"> shouldCausePreflight: false,
</span><span class="cx"> description: "Accept header with normal value SHOULD NOT cause a preflight"
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> description: "Accept header value with all allowed non-alphanumeric characters SHOULD NOT cause a preflight"
</span><span class="cx"> }
</span><span class="cx"> ,{
</span><del>- headersToAdd: [{ name : "Accept-Language", value: "en" }],
</del><ins>+ headersToAdd: [{ name : "Accept-Language", value: "en-US,en;q=0.8" }],
</ins><span class="cx"> explicitlyAllowHeaders: false,
</span><span class="cx"> shouldCausePreflight: false,
</span><span class="cx"> description: "Accept-Language header with normal value SHOULD NOT cause a preflight"
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209509 => 209510)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-08 02:01:30 UTC (rev 209509)
+++ trunk/Source/WebCore/ChangeLog 2016-12-08 02:08:28 UTC (rev 209510)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-12-07 John Wilander <wilander@apple.com>
+
+ Allow commas in Accept, Accept-Language, and Content-Language request headers for simple CORS
+ https://bugs.webkit.org/show_bug.cgi?id=165566
+ <rdar://problem/29560983>
+
+ Reviewed by Alex Christensen.
+
+ Updated the existing tests.
+
+ * platform/network/HTTPParsers.cpp:
+ (WebCore::isValidAcceptHeaderValue):
+ Now also accepts ','.
+ (WebCore::isValidLanguageHeaderValue):
+ Ditto.
+
</ins><span class="cx"> 2016-12-07 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> [CSS Parser] Stop skipping tests in the css3 LayoutTests subdirectory
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkHTTPParserscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/HTTPParsers.cpp (209509 => 209510)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/HTTPParsers.cpp 2016-12-08 02:01:30 UTC (rev 209509)
+++ trunk/Source/WebCore/platform/network/HTTPParsers.cpp 2016-12-08 02:08:28 UTC (rev 209510)
</span><span class="lines">@@ -132,7 +132,7 @@
</span><span class="cx"> {
</span><span class="cx"> for (unsigned i = 0; i < value.length(); ++i) {
</span><span class="cx"> UChar c = value[i];
</span><del>- if (isASCIIAlphanumeric(c) || c == ' ' || c == '*' || c == '.' || c == '/' || c == ';' || c == '=')
</del><ins>+ if (isASCIIAlphanumeric(c) || c == ' ' || c == '*' || c == ',' || c == '.' || c == '/' || c == ';' || c == '=')
</ins><span class="cx"> continue;
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="lines">@@ -145,7 +145,7 @@
</span><span class="cx"> {
</span><span class="cx"> for (unsigned i = 0; i < value.length(); ++i) {
</span><span class="cx"> UChar c = value[i];
</span><del>- if (isASCIIAlphanumeric(c) || c == ' ' || c == '*' || c == '-' || c == '.' || c == ';' || c == '=')
</del><ins>+ if (isASCIIAlphanumeric(c) || c == ' ' || c == '*' || c == ',' || c == '-' || c == '.' || c == ';' || c == '=')
</ins><span class="cx"> continue;
</span><span class="cx"> return false;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>