<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209465] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209465">209465</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-12-07 11:31:08 -0800 (Wed, 07 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Remove unused and mostly untested Page domain commands and events
https://bugs.webkit.org/show_bug.cgi?id=165507
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-12-07
Reviewed by Brian Burg.
Source/JavaScriptCore:
Remove unused and unsupported commands and events.
- Page.setDocumentContent
- Page.getScriptExecutionStatus
- Page.setScriptExecutionDisabled
- Page.handleJavaScriptDialog
- Page.javascriptDialogOpening
- Page.javascriptDialogClosed
- Page.scriptsEnabled
* inspector/protocol/Page.json:
Source/WebCore:
Remove any code associated with the commands/events being removed.
* inspector/DOMPatchSupport.cpp:
* inspector/DOMPatchSupport.h:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::handleJavaScriptDialog): Deleted.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::scriptsEnabledImpl): Deleted.
(WebCore::InspectorInstrumentation::willRunJavaScriptDialogImpl): Deleted.
(WebCore::InspectorInstrumentation::didRunJavaScriptDialogImpl): Deleted.
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::scriptsEnabled): Deleted.
(WebCore::InspectorInstrumentation::willRunJavaScriptDialog): Deleted.
(WebCore::InspectorInstrumentation::didRunJavaScriptDialog): Deleted.
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::archive):
(WebCore::createXHRTextDecoder): Deleted.
(WebCore::InspectorPageAgent::getScriptExecutionStatus): Deleted.
(WebCore::InspectorPageAgent::setScriptExecutionDisabled): Deleted.
(WebCore::InspectorPageAgent::willRunJavaScriptDialog): Deleted.
(WebCore::InspectorPageAgent::didRunJavaScriptDialog): Deleted.
(WebCore::InspectorPageAgent::scriptsEnabled): Deleted.
(WebCore::InspectorPageAgent::handleJavaScriptDialog): Deleted.
* inspector/InspectorPageAgent.h:
* page/Chrome.cpp:
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
* page/Settings.cpp:
(WebCore::Settings::setScriptEnabled):
Source/WebInspectorUI:
* UserInterface/Protocol/PageObserver.js:
(WebInspector.PageObserver.prototype.javascriptDialogOpening):
(WebInspector.PageObserver.prototype.javascriptDialogClosed):
(WebInspector.PageObserver.prototype.scriptsEnabled):
Keep stub in case legacy backends dispatch the event to the frontend.
* UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
* UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
* Versions/Inspector-iOS-10.0.json:
* Versions/Inspector-iOS-7.0.json:
* Versions/Inspector-iOS-8.0.json:
* Versions/Inspector-iOS-9.0.json:
* Versions/Inspector-iOS-9.3.json:
Remove handleJavaScriptDialog command from legacy backends because it
doesn't appear as if the iOS backend handled it at all.
LayoutTests:
* inspector/page/javascriptDialogEvents-expected.txt: Removed.
* inspector/page/javascriptDialogEvents.html: Removed.
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
Remove test skipped by all platforms.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorprotocolPagejson">trunk/Source/JavaScriptCore/inspector/protocol/Page.json</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorDOMPatchSupportcpp">trunk/Source/WebCore/inspector/DOMPatchSupport.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorDOMPatchSupporth">trunk/Source/WebCore/inspector/DOMPatchSupport.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorClienth">trunk/Source/WebCore/inspector/InspectorClient.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInstrumentationcpp">trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInstrumentationh">trunk/Source/WebCore/inspector/InspectorInstrumentation.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgentcpp">trunk/Source/WebCore/inspector/InspectorPageAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorPageAgenth">trunk/Source/WebCore/inspector/InspectorPageAgent.h</a></li>
<li><a href="#trunkSourceWebCorepageChromecpp">trunk/Source/WebCore/page/Chrome.cpp</a></li>
<li><a href="#trunkSourceWebCorepageSettingscpp">trunk/Source/WebCore/page/Settings.cpp</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolLegacy100InspectorBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolLegacy70InspectorBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolLegacy80InspectorBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolLegacy90InspectorBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolLegacy93InspectorBackendCommandsjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolPageObserverjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/PageObserver.js</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS100json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS70json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS80json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS90json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json</a></li>
<li><a href="#trunkSourceWebInspectorUIVersionsInspectoriOS93json">trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsinspectorpagejavascriptDialogEventsexpectedtxt">trunk/LayoutTests/inspector/page/javascriptDialogEvents-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorpagejavascriptDialogEventshtml">trunk/LayoutTests/inspector/page/javascriptDialogEvents.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/LayoutTests/ChangeLog 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-12-07 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Remove unused and mostly untested Page domain commands and events
+ https://bugs.webkit.org/show_bug.cgi?id=165507
+
+ Reviewed by Brian Burg.
+
+ * inspector/page/javascriptDialogEvents-expected.txt: Removed.
+ * inspector/page/javascriptDialogEvents.html: Removed.
+ * platform/gtk/TestExpectations:
+ * platform/mac/TestExpectations:
+ Remove test skipped by all platforms.
+
</ins><span class="cx"> 2016-12-07 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix a bad result that I landed by accident.
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorpagejavascriptDialogEventsexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector/page/javascriptDialogEvents-expected.txt (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/page/javascriptDialogEvents-expected.txt 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/LayoutTests/inspector/page/javascriptDialogEvents-expected.txt 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -1,13 +0,0 @@
</span><del>-CONFIRM NAVIGATION: beforeunload in javascriptDialogEvents
-ALERT: alert
-CONFIRM: confirm
-PROMPT: prompt, default text:
-Opening with message: beforeunload in javascriptDialogEvents
-Closed
-Opening with message: alert
-Closed
-Opening with message: confirm
-Closed
-Opening with message: prompt
-Closed
-
</del></span></pre></div>
<a id="trunkLayoutTestsinspectorpagejavascriptDialogEventshtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector/page/javascriptDialogEvents.html (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/page/javascriptDialogEvents.html 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/LayoutTests/inspector/page/javascriptDialogEvents.html 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -1,44 +0,0 @@
</span><del>-<html>
-<head>
-<script type="text/javascript" src="../../http/tests/inspector/resources/protocol-test.js"></script>
-<script>
-
-window.addEventListener("beforeunload", onBeforeUnload);
-
-function onBeforeUnload()
-{
- window.removeEventListener("beforeunload", onBeforeUnload);
- return "beforeunload in javascriptDialogEvents";
-}
-
-function test()
-{
- InspectorProtocol.eventHandler["Page.javascriptDialogOpening"] = onOpening;
- InspectorProtocol.eventHandler["Page.javascriptDialogClosed"] = onClosed;
- InspectorProtocol.sendCommand("Page.enable", {});
-
- function onOpening(event)
- {
- ProtocolTest.log("Opening with message: " + event.params.message);
- }
- function onClosed()
- {
- ProtocolTest.log("Closed");
- }
-
- InspectorProtocol.sendCommand("Page.navigate", { "url": "nosuchurl" });
- InspectorProtocol.sendCommand("Runtime.evaluate", { "expression": "alert('alert')" });
- InspectorProtocol.sendCommand("Runtime.evaluate", { "expression": "confirm('confirm')" });
- InspectorProtocol.sendCommand("Runtime.evaluate", { "expression": "prompt('prompt')" }, onDone);
-
- function onDone()
- {
- ProtocolTest.completeTest();
- }
-}
-
-</script>
-</head>
-<body onload="runTest()">
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -1470,7 +1470,6 @@
</span><span class="cx"> webkit.org/b/122571 inspector/dom/focus.html [ Failure Timeout Pass ]
</span><span class="cx"> webkit.org/b/122571 inspector/runtime/getProperties.html [ Timeout Pass Crash ]
</span><span class="cx"> webkit.org/b/122571 inspector/runtime/saveResult.html [ Timeout Pass Crash ]
</span><del>-webkit.org/b/122571 inspector/page/javascriptDialogEvents.html [ Timeout Pass ]
</del><span class="cx"> webkit.org/b/122571 inspector/page/frameStartedLoading.html [ Timeout Pass ]
</span><span class="cx"> webkit.org/b/122571 inspector/page/frameScheduledNavigation.html [ Timeout Pass Crash ]
</span><span class="cx"> webkit.org/b/122571 inspector/page/setEmulatedMedia.html [ Timeout Pass ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -620,8 +620,6 @@
</span><span class="cx"> # Enable when support drag-and-drop autoscrolling
</span><span class="cx"> webkit.org/b/39725 fast/events/drag-and-drop-autoscroll.html [ Skip ]
</span><span class="cx">
</span><del>-webkit.org/b/110186 inspector/page/javascriptDialogEvents.html [ Skip ]
-
</del><span class="cx"> # Need support for ResourceHandle::didChangePriority and DRT support
</span><span class="cx"> webkit.org/b/111016 http/tests/loading/promote-img-preload-priority.html [ Failure ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-12-07 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Remove unused and mostly untested Page domain commands and events
+ https://bugs.webkit.org/show_bug.cgi?id=165507
+
+ Reviewed by Brian Burg.
+
+ Remove unused and unsupported commands and events.
+
+ - Page.setDocumentContent
+ - Page.getScriptExecutionStatus
+ - Page.setScriptExecutionDisabled
+ - Page.handleJavaScriptDialog
+ - Page.javascriptDialogOpening
+ - Page.javascriptDialogClosed
+ - Page.scriptsEnabled
+
+ * inspector/protocol/Page.json:
+
</ins><span class="cx"> 2016-12-07 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [JSC] Merge PromiseReactions
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorprotocolPagejson"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/protocol/Page.json (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/protocol/Page.json 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/JavaScriptCore/inspector/protocol/Page.json 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -186,14 +186,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "setDocumentContent",
- "description": "Sets given markup as the document's HTML.",
- "parameters": [
- { "name": "frameId", "$ref": "Network.FrameId", "description": "Frame id to set HTML for." },
- { "name": "html", "type": "string", "description": "HTML content to set." }
- ]
- },
- {
</del><span class="cx"> "name": "setShowPaintRects",
</span><span class="cx"> "description": "Requests that backend shows paint rectangles",
</span><span class="cx"> "parameters": [
</span><span class="lines">@@ -201,20 +193,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "getScriptExecutionStatus",
- "description": "Determines if scripts can be executed in the page.",
- "returns": [
- { "name": "result", "type": "string", "enum": ["allowed", "disabled", "forbidden"], "description": "Script execution status: \"allowed\" if scripts can be executed, \"disabled\" if script execution has been disabled through page settings, \"forbidden\" if script execution for the given page is not possible for other reasons." }
- ]
- },
- {
- "name": "setScriptExecutionDisabled",
- "description": "Switches script execution in the page.",
- "parameters": [
- { "name": "value", "type": "boolean", "description": "Whether script execution should be disabled in the page." }
- ]
- },
- {
</del><span class="cx"> "name": "setEmulatedMedia",
</span><span class="cx"> "description": "Emulates the given media for CSS media queries.",
</span><span class="cx"> "parameters": [
</span><span class="lines">@@ -260,14 +238,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "handleJavaScriptDialog",
- "description": "Accepts or dismisses a JavaScript initiated dialog (alert, confirm, prompt, or onbeforeunload).",
- "parameters": [
- { "name": "accept", "type": "boolean", "description": "Whether to accept or dismiss the dialog." },
- { "name": "promptText", "type": "string", "optional": true, "description": "The text to enter into the dialog prompt before accepting. Used only if this is a prompt dialog." }
- ]
- },
- {
</del><span class="cx"> "name": "archive",
</span><span class="cx"> "description": "Grab an archive of the page.",
</span><span class="cx"> "returns": [
</span><span class="lines">@@ -330,24 +300,6 @@
</span><span class="cx"> "parameters": [
</span><span class="cx"> { "name": "frameId", "$ref": "Network.FrameId", "description": "Id of the frame that has cleared its scheduled navigation." }
</span><span class="cx"> ]
</span><del>- },
- {
- "name": "javascriptDialogOpening",
- "description": "Fired when a JavaScript initiated dialog (alert, confirm, prompt, or onbeforeunload) is about to open.",
- "parameters": [
- { "name": "message", "type": "string", "description": "Message that will be displayed by the dialog." }
- ]
- },
- {
- "name": "javascriptDialogClosed",
- "description": "Fired when a JavaScript initiated dialog (alert, confirm, prompt, or onbeforeunload) has been closed."
- },
- {
- "name": "scriptsEnabled",
- "description": "Fired when the JavaScript is enabled/disabled on the page",
- "parameters": [
- { "name": "isEnabled", "type": "boolean", "description": "Whether script execution is enabled or disabled on the page." }
- ]
</del><span class="cx"> }
</span><span class="cx"> ]
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebCore/ChangeLog 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -1,3 +1,46 @@
</span><ins>+2016-12-07 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Remove unused and mostly untested Page domain commands and events
+ https://bugs.webkit.org/show_bug.cgi?id=165507
+
+ Reviewed by Brian Burg.
+
+ Remove any code associated with the commands/events being removed.
+
+ * inspector/DOMPatchSupport.cpp:
+ * inspector/DOMPatchSupport.h:
+ * inspector/InspectorClient.h:
+ (WebCore::InspectorClient::handleJavaScriptDialog): Deleted.
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::InspectorInstrumentation::scriptsEnabledImpl): Deleted.
+ (WebCore::InspectorInstrumentation::willRunJavaScriptDialogImpl): Deleted.
+ (WebCore::InspectorInstrumentation::didRunJavaScriptDialogImpl): Deleted.
+ * inspector/InspectorInstrumentation.h:
+ (WebCore::InspectorInstrumentation::scriptsEnabled): Deleted.
+ (WebCore::InspectorInstrumentation::willRunJavaScriptDialog): Deleted.
+ (WebCore::InspectorInstrumentation::didRunJavaScriptDialog): Deleted.
+ * inspector/InspectorPageAgent.cpp:
+ (WebCore::InspectorPageAgent::disable):
+ (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
+ (WebCore::InspectorPageAgent::didPaint):
+ (WebCore::InspectorPageAgent::buildObjectForFrame):
+ (WebCore::InspectorPageAgent::archive):
+ (WebCore::createXHRTextDecoder): Deleted.
+ (WebCore::InspectorPageAgent::getScriptExecutionStatus): Deleted.
+ (WebCore::InspectorPageAgent::setScriptExecutionDisabled): Deleted.
+ (WebCore::InspectorPageAgent::willRunJavaScriptDialog): Deleted.
+ (WebCore::InspectorPageAgent::didRunJavaScriptDialog): Deleted.
+ (WebCore::InspectorPageAgent::scriptsEnabled): Deleted.
+ (WebCore::InspectorPageAgent::handleJavaScriptDialog): Deleted.
+ * inspector/InspectorPageAgent.h:
+ * page/Chrome.cpp:
+ (WebCore::Chrome::runBeforeUnloadConfirmPanel):
+ (WebCore::Chrome::runJavaScriptAlert):
+ (WebCore::Chrome::runJavaScriptConfirm):
+ (WebCore::Chrome::runJavaScriptPrompt):
+ * page/Settings.cpp:
+ (WebCore::Settings::setScriptEnabled):
+
</ins><span class="cx"> 2016-12-07 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> [pointer-lock] Cursor should become visible when exiting pointer-lock via ESC key.
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorDOMPatchSupportcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/DOMPatchSupport.cpp (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/DOMPatchSupport.cpp 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebCore/inspector/DOMPatchSupport.cpp 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -64,14 +64,6 @@
</span><span class="cx"> Vector<std::unique_ptr<Digest>> children;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-void DOMPatchSupport::patchDocument(Document& document, const String& markup)
-{
- InspectorHistory history;
- DOMEditor domEditor { history };
- DOMPatchSupport patchSupport(domEditor, document);
- patchSupport.patchDocument(markup);
-}
-
</del><span class="cx"> DOMPatchSupport::DOMPatchSupport(DOMEditor& domEditor, Document& document)
</span><span class="cx"> : m_domEditor(domEditor)
</span><span class="cx"> , m_document(document)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorDOMPatchSupporth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/DOMPatchSupport.h (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/DOMPatchSupport.h 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebCore/inspector/DOMPatchSupport.h 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -43,8 +43,6 @@
</span><span class="cx">
</span><span class="cx"> class DOMPatchSupport final {
</span><span class="cx"> public:
</span><del>- static void patchDocument(Document&, const String& markup);
-
</del><span class="cx"> DOMPatchSupport(DOMEditor&, Document&);
</span><span class="cx">
</span><span class="cx"> void patchDocument(const String& markup);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorClient.h (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorClient.h 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -61,8 +61,6 @@
</span><span class="cx"> virtual void didSetSearchingForNode(bool) { }
</span><span class="cx"> virtual void elementSelectionChanged(bool) { }
</span><span class="cx">
</span><del>- virtual bool handleJavaScriptDialog(bool, const String*) { return false; }
-
</del><span class="cx"> WEBCORE_EXPORT static void doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message);
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInstrumentationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -434,12 +434,6 @@
</span><span class="cx"> timelineAgent->didEvaluateScript(frame);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorInstrumentation::scriptsEnabledImpl(InstrumentingAgents& instrumentingAgents, bool isEnabled)
-{
- if (InspectorPageAgent* pageAgent = instrumentingAgents.inspectorPageAgent())
- pageAgent->scriptsEnabled(isEnabled);
-}
-
</del><span class="cx"> InspectorInstrumentationCookie InspectorInstrumentation::willFireTimerImpl(InstrumentingAgents& instrumentingAgents, int timerId, ScriptExecutionContext& context)
</span><span class="cx"> {
</span><span class="cx"> pauseOnNativeEventIfNeeded(instrumentingAgents, false, timerFiredEventName, false);
</span><span class="lines">@@ -846,19 +840,6 @@
</span><span class="cx"> inspectorPageAgent->frameClearedScheduledNavigation(frame);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-InspectorInstrumentationCookie InspectorInstrumentation::willRunJavaScriptDialogImpl(InstrumentingAgents& instrumentingAgents, const String& message)
-{
- if (InspectorPageAgent* inspectorPageAgent = instrumentingAgents.inspectorPageAgent())
- inspectorPageAgent->willRunJavaScriptDialog(message);
- return InspectorInstrumentationCookie(instrumentingAgents, 0);
-}
-
-void InspectorInstrumentation::didRunJavaScriptDialogImpl(const InspectorInstrumentationCookie& cookie)
-{
- if (InspectorPageAgent* inspectorPageAgent = cookie.instrumentingAgents()->inspectorPageAgent())
- inspectorPageAgent->didRunJavaScriptDialog();
-}
-
</del><span class="cx"> void InspectorInstrumentation::willDestroyCachedResourceImpl(CachedResource& cachedResource)
</span><span class="cx"> {
</span><span class="cx"> if (!s_instrumentingAgentsSet)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInstrumentationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -134,7 +134,6 @@
</span><span class="cx"> static void didDispatchEventOnWindow(const InspectorInstrumentationCookie&);
</span><span class="cx"> static InspectorInstrumentationCookie willEvaluateScript(Frame&, const String& url, int lineNumber);
</span><span class="cx"> static void didEvaluateScript(const InspectorInstrumentationCookie&, Frame&);
</span><del>- static void scriptsEnabled(Page&, bool isEnabled);
</del><span class="cx"> static InspectorInstrumentationCookie willFireTimer(ScriptExecutionContext&, int timerId);
</span><span class="cx"> static void didFireTimer(const InspectorInstrumentationCookie&);
</span><span class="cx"> static void didInvalidateLayout(Frame&);
</span><span class="lines">@@ -179,8 +178,6 @@
</span><span class="cx"> static void frameStoppedLoading(Frame&);
</span><span class="cx"> static void frameScheduledNavigation(Frame&, double delay);
</span><span class="cx"> static void frameClearedScheduledNavigation(Frame&);
</span><del>- static InspectorInstrumentationCookie willRunJavaScriptDialog(Page&, const String& message);
- static void didRunJavaScriptDialog(const InspectorInstrumentationCookie&);
</del><span class="cx"> static void willDestroyCachedResource(CachedResource&);
</span><span class="cx">
</span><span class="cx"> static void addMessageToConsole(Page&, std::unique_ptr<Inspector::ConsoleMessage>);
</span><span class="lines">@@ -307,7 +304,6 @@
</span><span class="cx"> static void didDispatchEventOnWindowImpl(const InspectorInstrumentationCookie&);
</span><span class="cx"> static InspectorInstrumentationCookie willEvaluateScriptImpl(InstrumentingAgents&, Frame&, const String& url, int lineNumber);
</span><span class="cx"> static void didEvaluateScriptImpl(const InspectorInstrumentationCookie&, Frame&);
</span><del>- static void scriptsEnabledImpl(InstrumentingAgents&, bool isEnabled);
</del><span class="cx"> static InspectorInstrumentationCookie willFireTimerImpl(InstrumentingAgents&, int timerId, ScriptExecutionContext&);
</span><span class="cx"> static void didFireTimerImpl(const InspectorInstrumentationCookie&);
</span><span class="cx"> static void didInvalidateLayoutImpl(InstrumentingAgents&, Frame&);
</span><span class="lines">@@ -353,8 +349,6 @@
</span><span class="cx"> static void frameStoppedLoadingImpl(InstrumentingAgents&, Frame&);
</span><span class="cx"> static void frameScheduledNavigationImpl(InstrumentingAgents&, Frame&, double delay);
</span><span class="cx"> static void frameClearedScheduledNavigationImpl(InstrumentingAgents&, Frame&);
</span><del>- static InspectorInstrumentationCookie willRunJavaScriptDialogImpl(InstrumentingAgents&, const String& message);
- static void didRunJavaScriptDialogImpl(const InspectorInstrumentationCookie&);
</del><span class="cx"> static void willDestroyCachedResourceImpl(CachedResource&);
</span><span class="cx">
</span><span class="cx"> static void addMessageToConsoleImpl(InstrumentingAgents&, std::unique_ptr<Inspector::ConsoleMessage>);
</span><span class="lines">@@ -733,12 +727,6 @@
</span><span class="cx"> didEvaluateScriptImpl(cookie, frame);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline void InspectorInstrumentation::scriptsEnabled(Page& page, bool isEnabled)
-{
- FAST_RETURN_IF_NO_FRONTENDS(void());
- return scriptsEnabledImpl(instrumentingAgentsForPage(page), isEnabled);
-}
-
</del><span class="cx"> inline InspectorInstrumentationCookie InspectorInstrumentation::willFireTimer(ScriptExecutionContext& context, int timerId)
</span><span class="cx"> {
</span><span class="cx"> FAST_RETURN_IF_NO_FRONTENDS(InspectorInstrumentationCookie());
</span><span class="lines">@@ -1014,19 +1002,6 @@
</span><span class="cx"> frameClearedScheduledNavigationImpl(*instrumentingAgents, frame);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline InspectorInstrumentationCookie InspectorInstrumentation::willRunJavaScriptDialog(Page& page, const String& message)
-{
- FAST_RETURN_IF_NO_FRONTENDS(InspectorInstrumentationCookie());
- return willRunJavaScriptDialogImpl(instrumentingAgentsForPage(page), message);
-}
-
-inline void InspectorInstrumentation::didRunJavaScriptDialog(const InspectorInstrumentationCookie& cookie)
-{
- FAST_RETURN_IF_NO_FRONTENDS(void());
- if (cookie.isValid())
- didRunJavaScriptDialogImpl(cookie);
-}
-
</del><span class="cx"> inline void InspectorInstrumentation::willDestroyCachedResource(CachedResource& cachedResource)
</span><span class="cx"> {
</span><span class="cx"> FAST_RETURN_IF_NO_FRONTENDS(void());
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -40,7 +40,6 @@
</span><span class="cx"> #include "CachedScript.h"
</span><span class="cx"> #include "Cookie.h"
</span><span class="cx"> #include "CookieJar.h"
</span><del>-#include "DOMPatchSupport.h"
</del><span class="cx"> #include "DOMWrapperWorld.h"
</span><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "DocumentLoader.h"
</span><span class="lines">@@ -373,8 +372,6 @@
</span><span class="cx"> auto stopwatch = m_environment.executionStopwatch();
</span><span class="cx"> stopwatch->reset();
</span><span class="cx"> stopwatch->start();
</span><del>-
- m_originalScriptExecutionDisabled = !mainFrame().settings().isScriptEnabled();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void InspectorPageAgent::disable(ErrorString&)
</span><span class="lines">@@ -384,7 +381,6 @@
</span><span class="cx"> m_instrumentingAgents.setInspectorPageAgent(nullptr);
</span><span class="cx">
</span><span class="cx"> ErrorString unused;
</span><del>- setScriptExecutionDisabled(unused, m_originalScriptExecutionDisabled);
</del><span class="cx"> setShowPaintRects(unused, false);
</span><span class="cx"> setEmulatedMedia(unused, emptyString());
</span><span class="cx"> }
</span><span class="lines">@@ -656,20 +652,6 @@
</span><span class="cx"> networkAgent->searchOtherRequests(regex, result);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorPageAgent::setDocumentContent(ErrorString& errorString, const String& frameId, const String& html)
-{
- Frame* frame = assertFrame(errorString, frameId);
- if (!frame)
- return;
-
- Document* document = frame->document();
- if (!document) {
- errorString = ASCIILiteral("No Document instance to set HTML for");
- return;
- }
- DOMPatchSupport::patchDocument(*document, html);
-}
-
</del><span class="cx"> void InspectorPageAgent::setShowPaintRects(ErrorString&, bool show)
</span><span class="cx"> {
</span><span class="cx"> m_showPaintRects = show;
</span><span class="lines">@@ -681,31 +663,6 @@
</span><span class="cx"> m_overlay->setShowingPaintRects(show);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorPageAgent::getScriptExecutionStatus(ErrorString&, Inspector::PageBackendDispatcherHandler::Result* status)
-{
- bool disabledByScriptController = false;
- bool disabledInSettings = false;
- disabledByScriptController = mainFrame().script().canExecuteScripts(NotAboutToExecuteScript);
- disabledInSettings = !mainFrame().settings().isScriptEnabled();
-
- if (!disabledByScriptController) {
- *status = Inspector::PageBackendDispatcherHandler::Result::Allowed;
- return;
- }
-
- if (disabledInSettings)
- *status = Inspector::PageBackendDispatcherHandler::Result::Disabled;
- else
- *status = Inspector::PageBackendDispatcherHandler::Result::Forbidden;
-}
-
-void InspectorPageAgent::setScriptExecutionDisabled(ErrorString&, bool value)
-{
- m_ignoreScriptsEnabledNotification = true;
- mainFrame().settings().setScriptEnabled(!value);
- m_ignoreScriptsEnabledNotification = false;
-}
-
</del><span class="cx"> void InspectorPageAgent::didClearWindowObjectInWorld(Frame* frame, DOMWrapperWorld& world)
</span><span class="cx"> {
</span><span class="cx"> if (&world != &mainThreadNormalWorld())
</span><span class="lines">@@ -846,16 +803,6 @@
</span><span class="cx"> m_frontendDispatcher->frameClearedScheduledNavigation(frameId(&frame));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorPageAgent::willRunJavaScriptDialog(const String& message)
-{
- m_frontendDispatcher->javascriptDialogOpening(message);
-}
-
-void InspectorPageAgent::didRunJavaScriptDialog()
-{
- m_frontendDispatcher->javascriptDialogClosed();
-}
-
</del><span class="cx"> void InspectorPageAgent::didPaint(RenderObject& renderer, const LayoutRect& rect)
</span><span class="cx"> {
</span><span class="cx"> if (!m_enabled || !m_showPaintRects)
</span><span class="lines">@@ -902,14 +849,6 @@
</span><span class="cx"> m_overlay->update();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorPageAgent::scriptsEnabled(bool isEnabled)
-{
- if (m_ignoreScriptsEnabledNotification)
- return;
-
- m_frontendDispatcher->scriptsEnabled(isEnabled);
-}
-
</del><span class="cx"> Ref<Inspector::Protocol::Page::Frame> InspectorPageAgent::buildObjectForFrame(Frame* frame)
</span><span class="cx"> {
</span><span class="cx"> ASSERT_ARG(frame, frame);
</span><span class="lines">@@ -1042,12 +981,6 @@
</span><span class="cx"> *outDataURL = snapshot->toDataURL(ASCIILiteral("image/png"));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorPageAgent::handleJavaScriptDialog(ErrorString& errorString, bool accept, const String* promptText)
-{
- if (!m_client->handleJavaScriptDialog(accept, promptText))
- errorString = ASCIILiteral("Could not handle JavaScript dialog");
-}
-
</del><span class="cx"> void InspectorPageAgent::archive(ErrorString& errorString, String* data)
</span><span class="cx"> {
</span><span class="cx"> #if ENABLE(WEB_ARCHIVE) && USE(CF)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorPageAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.h (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorPageAgent.h 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.h 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -98,16 +98,12 @@
</span><span class="cx"> void getResourceContent(ErrorString&, const String& frameId, const String& url, String* content, bool* base64Encoded) override;
</span><span class="cx"> void searchInResource(ErrorString&, const String& frameId, const String& url, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, const String* optionalRequestId, RefPtr<Inspector::Protocol::Array<Inspector::Protocol::GenericTypes::SearchMatch>>&) override;
</span><span class="cx"> void searchInResources(ErrorString&, const String&, const bool* caseSensitive, const bool* isRegex, RefPtr<Inspector::Protocol::Array<Inspector::Protocol::Page::SearchResult>>&) override;
</span><del>- void setDocumentContent(ErrorString&, const String& frameId, const String& html) override;
</del><span class="cx"> void setShowPaintRects(ErrorString&, bool show) override;
</span><del>- void getScriptExecutionStatus(ErrorString&, Inspector::PageBackendDispatcherHandler::Result*) override;
- void setScriptExecutionDisabled(ErrorString&, bool) override;
</del><span class="cx"> void setEmulatedMedia(ErrorString&, const String&) override;
</span><span class="cx"> void getCompositingBordersVisible(ErrorString&, bool* out_param) override;
</span><span class="cx"> void setCompositingBordersVisible(ErrorString&, bool) override;
</span><span class="cx"> void snapshotNode(ErrorString&, int nodeId, String* outDataURL) override;
</span><span class="cx"> void snapshotRect(ErrorString&, int x, int y, int width, int height, const String& coordinateSystem, String* outDataURL) override;
</span><del>- void handleJavaScriptDialog(ErrorString&, bool accept, const String* promptText) override;
</del><span class="cx"> void archive(ErrorString&, String* data) override;
</span><span class="cx">
</span><span class="cx"> // InspectorInstrumentation
</span><span class="lines">@@ -121,14 +117,11 @@
</span><span class="cx"> void frameStoppedLoading(Frame&);
</span><span class="cx"> void frameScheduledNavigation(Frame&, double delay);
</span><span class="cx"> void frameClearedScheduledNavigation(Frame&);
</span><del>- void willRunJavaScriptDialog(const String& message);
- void didRunJavaScriptDialog();
</del><span class="cx"> void applyEmulatedMedia(String&);
</span><span class="cx"> void didPaint(RenderObject&, const LayoutRect&);
</span><span class="cx"> void didLayout();
</span><span class="cx"> void didScroll();
</span><span class="cx"> void didRecalculateStyle();
</span><del>- void scriptsEnabled(bool isEnabled);
</del><span class="cx">
</span><span class="cx"> // Inspector Controller API
</span><span class="cx"> void didCreateFrontendAndBackend(Inspector::FrontendRouter*, Inspector::BackendDispatcher*) override;
</span><span class="lines">@@ -137,7 +130,6 @@
</span><span class="cx"> // Cross-agents API
</span><span class="cx"> Page& page() { return m_page; }
</span><span class="cx"> MainFrame& mainFrame();
</span><del>- String createIdentifier();
</del><span class="cx"> Frame* frameForId(const String& frameId);
</span><span class="cx"> WEBCORE_EXPORT String frameId(Frame*);
</span><span class="cx"> bool hasIdForFrame(Frame*) const;
</span><span class="lines">@@ -170,8 +162,6 @@
</span><span class="cx"> HashMap<DocumentLoader*, String> m_loaderToIdentifier;
</span><span class="cx"> bool m_enabled { false };
</span><span class="cx"> bool m_isFirstLayoutAfterOnLoad { false };
</span><del>- bool m_originalScriptExecutionDisabled { false };
- bool m_ignoreScriptsEnabledNotification { false };
</del><span class="cx"> bool m_showPaintRects { false };
</span><span class="cx"> String m_emulatedMedia;
</span><span class="cx"> RefPtr<Inspector::InspectorObject> m_scriptsToEvaluateOnLoad;
</span></span></pre></div>
<a id="trunkSourceWebCorepageChromecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Chrome.cpp (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Chrome.cpp 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebCore/page/Chrome.cpp 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -50,7 +50,6 @@
</span><span class="cx"> #include "WindowFeatures.h"
</span><span class="cx"> #include <runtime/VM.h>
</span><span class="cx"> #include <wtf/PassRefPtr.h>
</span><del>-#include <wtf/RefPtr.h>
</del><span class="cx"> #include <wtf/SetForScope.h>
</span><span class="cx"> #include <wtf/Vector.h>
</span><span class="cx">
</span><span class="lines">@@ -284,10 +283,7 @@
</span><span class="cx"> // otherwise cause the load to continue while we're in the middle of executing JavaScript.
</span><span class="cx"> PageGroupLoadDeferrer deferrer(m_page, true);
</span><span class="cx">
</span><del>- InspectorInstrumentationCookie cookie = InspectorInstrumentation::willRunJavaScriptDialog(m_page, message);
- bool ok = m_client.runBeforeUnloadConfirmPanel(message, frame);
- InspectorInstrumentation::didRunJavaScriptDialog(cookie);
- return ok;
</del><ins>+ return m_client.runBeforeUnloadConfirmPanel(message, frame);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Chrome::closeWindowSoon()
</span><span class="lines">@@ -305,9 +301,7 @@
</span><span class="cx"> notifyPopupOpeningObservers();
</span><span class="cx"> String displayMessage = frame->displayStringModifiedByEncoding(message);
</span><span class="cx">
</span><del>- InspectorInstrumentationCookie cookie = InspectorInstrumentation::willRunJavaScriptDialog(m_page, displayMessage);
</del><span class="cx"> m_client.runJavaScriptAlert(frame, displayMessage);
</span><del>- InspectorInstrumentation::didRunJavaScriptDialog(cookie);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool Chrome::runJavaScriptConfirm(Frame* frame, const String& message)
</span><span class="lines">@@ -320,10 +314,7 @@
</span><span class="cx"> notifyPopupOpeningObservers();
</span><span class="cx"> String displayMessage = frame->displayStringModifiedByEncoding(message);
</span><span class="cx">
</span><del>- InspectorInstrumentationCookie cookie = InspectorInstrumentation::willRunJavaScriptDialog(m_page, displayMessage);
- bool ok = m_client.runJavaScriptConfirm(frame, displayMessage);
- InspectorInstrumentation::didRunJavaScriptDialog(cookie);
- return ok;
</del><ins>+ return m_client.runJavaScriptConfirm(frame, displayMessage);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool Chrome::runJavaScriptPrompt(Frame* frame, const String& prompt, const String& defaultValue, String& result)
</span><span class="lines">@@ -336,10 +327,7 @@
</span><span class="cx"> notifyPopupOpeningObservers();
</span><span class="cx"> String displayPrompt = frame->displayStringModifiedByEncoding(prompt);
</span><span class="cx">
</span><del>- InspectorInstrumentationCookie cookie = InspectorInstrumentation::willRunJavaScriptDialog(m_page, displayPrompt);
</del><span class="cx"> bool ok = m_client.runJavaScriptPrompt(frame, displayPrompt, frame->displayStringModifiedByEncoding(defaultValue), result);
</span><del>- InspectorInstrumentation::didRunJavaScriptDialog(cookie);
-
</del><span class="cx"> if (ok)
</span><span class="cx"> result = frame->displayStringModifiedByEncoding(result);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.cpp (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.cpp 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebCore/page/Settings.cpp 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -39,7 +39,6 @@
</span><span class="cx"> #include "FrameView.h"
</span><span class="cx"> #include "HTMLMediaElement.h"
</span><span class="cx"> #include "HistoryItem.h"
</span><del>-#include "InspectorInstrumentation.h"
</del><span class="cx"> #include "MainFrame.h"
</span><span class="cx"> #include "Page.h"
</span><span class="cx"> #include "PageCache.h"
</span><span class="lines">@@ -389,7 +388,6 @@
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> m_page->setNeedsRecalcStyleInAllFrames();
</span><span class="cx"> #endif
</span><del>- InspectorInstrumentation::scriptsEnabled(*m_page, m_isScriptEnabled);
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Settings::setJavaEnabled(bool isJavaEnabled)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2016-12-07 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Remove unused and mostly untested Page domain commands and events
+ https://bugs.webkit.org/show_bug.cgi?id=165507
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Protocol/PageObserver.js:
+ (WebInspector.PageObserver.prototype.javascriptDialogOpening):
+ (WebInspector.PageObserver.prototype.javascriptDialogClosed):
+ (WebInspector.PageObserver.prototype.scriptsEnabled):
+ Keep stub in case legacy backends dispatch the event to the frontend.
+
+ * UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
+ * Versions/Inspector-iOS-10.0.json:
+ * Versions/Inspector-iOS-7.0.json:
+ * Versions/Inspector-iOS-8.0.json:
+ * Versions/Inspector-iOS-9.0.json:
+ * Versions/Inspector-iOS-9.3.json:
+ Remove handleJavaScriptDialog command from legacy backends because it
+ doesn't appear as if the iOS backend handled it at all.
+
</ins><span class="cx"> 2016-12-06 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Correct SDKROOT values in xcconfig files
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolLegacy100InspectorBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -338,7 +338,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Page.snapshotNode", [{"name": "nodeId", "type": "number", "optional": false}], ["dataURL"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.snapshotRect", [{"name": "x", "type": "number", "optional": false}, {"name": "y", "type": "number", "optional": false}, {"name": "width", "type": "number", "optional": false}, {"name": "height", "type": "number", "optional": false}, {"name": "coordinateSystem", "type": "string", "optional": false}], ["dataURL"]);
</span><del>-InspectorBackend.registerCommand("Page.handleJavaScriptDialog", [{"name": "accept", "type": "boolean", "optional": false}, {"name": "promptText", "type": "string", "optional": true}], []);
</del><span class="cx"> InspectorBackend.registerCommand("Page.archive", [], ["data"]);
</span><span class="cx"> InspectorBackend.activateDomain("Page", "web");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolLegacy70InspectorBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -70,7 +70,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Page.setEmulatedMedia", [{"name": "media", "type": "string", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Page.getCompositingBordersVisible", [], ["result"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
</span><del>-InspectorBackend.registerCommand("Page.handleJavaScriptDialog", [{"name": "accept", "type": "boolean", "optional": false}, {"name": "promptText", "type": "string", "optional": true}], []);
</del><span class="cx"> InspectorBackend.activateDomain("Page");
</span><span class="cx">
</span><span class="cx"> // Runtime.
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolLegacy80InspectorBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -328,7 +328,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Page.snapshotNode", [{"name": "nodeId", "type": "number", "optional": false}], ["dataURL"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.snapshotRect", [{"name": "x", "type": "number", "optional": false}, {"name": "y", "type": "number", "optional": false}, {"name": "width", "type": "number", "optional": false}, {"name": "height", "type": "number", "optional": false}, {"name": "coordinateSystem", "type": "string", "optional": false}], ["dataURL"]);
</span><del>-InspectorBackend.registerCommand("Page.handleJavaScriptDialog", [{"name": "accept", "type": "boolean", "optional": false}, {"name": "promptText", "type": "string", "optional": true}], []);
</del><span class="cx"> InspectorBackend.registerCommand("Page.archive", [], ["data"]);
</span><span class="cx"> InspectorBackend.activateDomain("Page", "web");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolLegacy90InspectorBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -298,7 +298,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Page.snapshotNode", [{"name": "nodeId", "type": "number", "optional": false}], ["dataURL"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.snapshotRect", [{"name": "x", "type": "number", "optional": false}, {"name": "y", "type": "number", "optional": false}, {"name": "width", "type": "number", "optional": false}, {"name": "height", "type": "number", "optional": false}, {"name": "coordinateSystem", "type": "string", "optional": false}], ["dataURL"]);
</span><del>-InspectorBackend.registerCommand("Page.handleJavaScriptDialog", [{"name": "accept", "type": "boolean", "optional": false}, {"name": "promptText", "type": "string", "optional": true}], []);
</del><span class="cx"> InspectorBackend.registerCommand("Page.archive", [], ["data"]);
</span><span class="cx"> InspectorBackend.activateDomain("Page", "web");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolLegacy93InspectorBackendCommandsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -309,7 +309,6 @@
</span><span class="cx"> InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
</span><span class="cx"> InspectorBackend.registerCommand("Page.snapshotNode", [{"name": "nodeId", "type": "number", "optional": false}], ["dataURL"]);
</span><span class="cx"> InspectorBackend.registerCommand("Page.snapshotRect", [{"name": "x", "type": "number", "optional": false}, {"name": "y", "type": "number", "optional": false}, {"name": "width", "type": "number", "optional": false}, {"name": "height", "type": "number", "optional": false}, {"name": "coordinateSystem", "type": "string", "optional": false}], ["dataURL"]);
</span><del>-InspectorBackend.registerCommand("Page.handleJavaScriptDialog", [{"name": "accept", "type": "boolean", "optional": false}, {"name": "promptText", "type": "string", "optional": true}], []);
</del><span class="cx"> InspectorBackend.registerCommand("Page.archive", [], ["data"]);
</span><span class="cx"> InspectorBackend.activateDomain("Page", "web");
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolPageObserverjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/PageObserver.js (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/PageObserver.js 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/PageObserver.js 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -69,16 +69,16 @@
</span><span class="cx">
</span><span class="cx"> javascriptDialogOpening(message)
</span><span class="cx"> {
</span><del>- // Not handled yet.
</del><ins>+ // COMPATIBILITY (iOS 10): Page.javascriptDialogOpening was removed after iOS 10.
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> javascriptDialogClosed()
</span><span class="cx"> {
</span><del>- // Not handled yet.
</del><ins>+ // COMPATIBILITY (iOS 10): Page.javascriptDialogClosed was removed after iOS 10.
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> scriptsEnabled(enabled)
</span><span class="cx"> {
</span><del>- // Not handled yet.
</del><ins>+ // COMPATIBILITY (iOS 10): Page.scriptsEnabled was removed after iOS 10.
</ins><span class="cx"> }
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS100json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -2991,14 +2991,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "handleJavaScriptDialog",
- "description": "Accepts or dismisses a JavaScript initiated dialog (alert, confirm, prompt, or onbeforeunload).",
- "parameters": [
- { "name": "accept", "type": "boolean", "description": "Whether to accept or dismiss the dialog." },
- { "name": "promptText", "type": "string", "optional": true, "description": "The text to enter into the dialog prompt before accepting. Used only if this is a prompt dialog." }
- ]
- },
- {
</del><span class="cx"> "name": "archive",
</span><span class="cx"> "description": "Grab an archive of the page.",
</span><span class="cx"> "returns": [
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS70json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -270,14 +270,6 @@
</span><span class="cx"> "parameters": [
</span><span class="cx"> { "name": "visible", "type": "boolean", "description": "True for showing compositing borders." }
</span><span class="cx"> ]
</span><del>- },
- {
- "name": "handleJavaScriptDialog",
- "description": "Accepts or dismisses a JavaScript initiated dialog (alert, confirm, prompt, or onbeforeunload).",
- "parameters": [
- { "name": "accept", "type": "boolean", "description": "Whether to accept or dismiss the dialog." },
- { "name": "promptText", "type": "string", "optional": true, "description": "The text to enter into the dialog prompt before accepting. Used only if this is a prompt dialog." }
- ]
</del><span class="cx"> }
</span><span class="cx"> ],
</span><span class="cx"> "events": [
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS80json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -2859,14 +2859,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "handleJavaScriptDialog",
- "description": "Accepts or dismisses a JavaScript initiated dialog (alert, confirm, prompt, or onbeforeunload).",
- "parameters": [
- { "name": "accept", "type": "boolean", "description": "Whether to accept or dismiss the dialog." },
- { "name": "promptText", "type": "string", "optional": true, "description": "The text to enter into the dialog prompt before accepting. Used only if this is a prompt dialog." }
- ]
- },
- {
</del><span class="cx"> "name": "archive",
</span><span class="cx"> "description": "Grab an archive of the page.",
</span><span class="cx"> "returns": [
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS90json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -2737,14 +2737,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "handleJavaScriptDialog",
- "description": "Accepts or dismisses a JavaScript initiated dialog (alert, confirm, prompt, or onbeforeunload).",
- "parameters": [
- { "name": "accept", "type": "boolean", "description": "Whether to accept or dismiss the dialog." },
- { "name": "promptText", "type": "string", "optional": true, "description": "The text to enter into the dialog prompt before accepting. Used only if this is a prompt dialog." }
- ]
- },
- {
</del><span class="cx"> "name": "archive",
</span><span class="cx"> "description": "Grab an archive of the page.",
</span><span class="cx"> "returns": [
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIVersionsInspectoriOS93json"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json (209464 => 209465)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json 2016-12-07 19:30:45 UTC (rev 209464)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json 2016-12-07 19:31:08 UTC (rev 209465)
</span><span class="lines">@@ -2819,14 +2819,6 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "handleJavaScriptDialog",
- "description": "Accepts or dismisses a JavaScript initiated dialog (alert, confirm, prompt, or onbeforeunload).",
- "parameters": [
- { "name": "accept", "type": "boolean", "description": "Whether to accept or dismiss the dialog." },
- { "name": "promptText", "type": "string", "optional": true, "description": "The text to enter into the dialog prompt before accepting. Used only if this is a prompt dialog." }
- ]
- },
- {
</del><span class="cx"> "name": "archive",
</span><span class="cx"> "description": "Grab an archive of the page.",
</span><span class="cx"> "returns": [
</span></span></pre>
</div>
</div>
</body>
</html>