<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209404] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209404">209404</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2016-12-06 09:58:39 -0800 (Tue, 06 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make fast/selectors/040.html actually test background-color painting for ::selection when run in DRT
https://bugs.webkit.org/show_bug.cgi?id=79694
Reviewed by Beth Dakin.
Currently the test case fast/selectors/040.html doesn't actually test that we
honor the background-color of ::selection when run in DRT. In particular, it
doesn't programmatically select any text and hence the DRT results reflect a
paragraph of non-selected text. Instead, we should programmatically select the
test paragraph so that DRT can capture the painting of background-color for ::selection.
* fast/selectors/040-expected.html: Added.
* fast/selectors/040.html:
* platform/efl/fast/selectors/040-expected.png: Removed.
* platform/efl/fast/selectors/040-expected.txt: Removed.
* platform/gtk/fast/selectors/040-expected.png: Removed.
* platform/gtk/fast/selectors/040-expected.txt: Removed.
* platform/ios-simulator/fast/selectors/040-expected.txt: Removed.
* platform/mac/fast/selectors/040-expected.png: Removed.
* platform/mac/fast/selectors/040-expected.txt: Removed.
* platform/win/fast/selectors/040-expected.txt: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastselectors040html">trunk/LayoutTests/fast/selectors/040.html</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastselectors040expectedhtml">trunk/LayoutTests/fast/selectors/040-expected.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformeflfastselectors040expectedpng">trunk/LayoutTests/platform/efl/fast/selectors/040-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformeflfastselectors040expectedtxt">trunk/LayoutTests/platform/efl/fast/selectors/040-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfastselectors040expectedpng">trunk/LayoutTests/platform/gtk/fast/selectors/040-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfastselectors040expectedtxt">trunk/LayoutTests/platform/gtk/fast/selectors/040-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorfastselectors040expectedtxt">trunk/LayoutTests/platform/ios-simulator/fast/selectors/040-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastselectors040expectedpng">trunk/LayoutTests/platform/mac/fast/selectors/040-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastselectors040expectedtxt">trunk/LayoutTests/platform/mac/fast/selectors/040-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwinfastselectors040expectedtxt">trunk/LayoutTests/platform/win/fast/selectors/040-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209403 => 209404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-06 17:46:48 UTC (rev 209403)
+++ trunk/LayoutTests/ChangeLog 2016-12-06 17:58:39 UTC (rev 209404)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2016-12-06 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><ins>+ Make fast/selectors/040.html actually test background-color painting for ::selection when run in DRT
+ https://bugs.webkit.org/show_bug.cgi?id=79694
+
+ Reviewed by Beth Dakin.
+
+ Currently the test case fast/selectors/040.html doesn't actually test that we
+ honor the background-color of ::selection when run in DRT. In particular, it
+ doesn't programmatically select any text and hence the DRT results reflect a
+ paragraph of non-selected text. Instead, we should programmatically select the
+ test paragraph so that DRT can capture the painting of background-color for ::selection.
+
+ * fast/selectors/040-expected.html: Added.
+ * fast/selectors/040.html:
+ * platform/efl/fast/selectors/040-expected.png: Removed.
+ * platform/efl/fast/selectors/040-expected.txt: Removed.
+ * platform/gtk/fast/selectors/040-expected.png: Removed.
+ * platform/gtk/fast/selectors/040-expected.txt: Removed.
+ * platform/ios-simulator/fast/selectors/040-expected.txt: Removed.
+ * platform/mac/fast/selectors/040-expected.png: Removed.
+ * platform/mac/fast/selectors/040-expected.txt: Removed.
+ * platform/win/fast/selectors/040-expected.txt: Removed.
+
+2016-12-06 Daniel Bates <dabates@apple.com>
+
</ins><span class="cx"> Test insecure-xhr-sync-in-main-frame.html fails with CORS error if run before r203542
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=165407
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastselectors040expectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/selectors/040-expected.html (0 => 209404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/selectors/040-expected.html (rev 0)
+++ trunk/LayoutTests/fast/selectors/040-expected.html 2016-12-06 17:58:39 UTC (rev 209404)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN">
+<html>
+ <head>
+ <title>::selection pseudo-element</title>
+ <style type="text/css">
+ .highlight { background-color: rgba(99, 254, 0, 0.95); }
+ </style>
+ </head>
+ <body>
+<!-- This result mimics the text-wrapping that would occur in a window with size 800 x 600 pixels. -->
+<p style="margin-bottom: 0" class="highlight">Any textual selection in this long paragraph should have green background. Any textual selection in this long paragraph</p><p style="margin-top: 0"><span class="highlight">should have green background. Any textual selection in this long paragraph should have green background.</span></p>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastselectors040html"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/selectors/040.html (209403 => 209404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/selectors/040.html 2016-12-06 17:46:48 UTC (rev 209403)
+++ trunk/LayoutTests/fast/selectors/040.html 2016-12-06 17:58:39 UTC (rev 209404)
</span><span class="lines">@@ -2,7 +2,7 @@
</span><span class="cx"> <html>
</span><span class="cx"> <head>
</span><span class="cx"> <title>::selection pseudo-element</title>
</span><del>- <style type="text/css">p::selection { background-color : lime }
</del><ins>+ <style type="text/css">p::selection { background-color: rgba(99, 254, 0, 0.95); /* alpha < 1 so that we don't blend the background color with white. */ }
</ins><span class="cx"> </style>
</span><span class="cx"> <link rel="first" href="css3-modsel-1.html" title="Groups of selectors">
</span><span class="cx"> <link rel="prev" href="css3-modsel-39b.html" title="::first-letter pseudo-element">
</span><span class="lines">@@ -13,5 +13,9 @@
</span><span class="cx"> </head>
</span><span class="cx"> <body>
</span><span class="cx"> <p>Any textual selection in this long paragraph should have green background. Any textual selection in this long paragraph should have green background. Any textual selection in this long paragraph should have green background.</p>
</span><ins>+<script>
+var p = document.querySelector("p");
+window.getSelection().setBaseAndExtent(p, 0, p, 1);
+</script>
</ins><span class="cx"> </body>
</span><del>-</html>
</del><span class="cx">\ No newline at end of file
</span><ins>+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformeflfastselectors040expectedpng"></a>
<div class="binary"><h4>Deleted: trunk/LayoutTests/platform/efl/fast/selectors/040-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflfastselectors040expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/efl/fast/selectors/040-expected.txt (209403 => 209404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/fast/selectors/040-expected.txt 2016-12-06 17:46:48 UTC (rev 209403)
+++ trunk/LayoutTests/platform/efl/fast/selectors/040-expected.txt 2016-12-06 17:58:39 UTC (rev 209404)
</span><span class="lines">@@ -1,9 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x68
- RenderBlock {HTML} at (0,0) size 800x68
- RenderBody {BODY} at (8,16) size 784x36
- RenderBlock {P} at (0,0) size 784x36
- RenderText {#text} at (0,0) size 754x35
- text run at (0,0) width 754: "Any textual selection in this long paragraph should have green background. Any textual selection in this long paragraph"
- text run at (0,18) width 678: "should have green background. Any textual selection in this long paragraph should have green background."
</del></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfastselectors040expectedpng"></a>
<div class="binary"><h4>Deleted: trunk/LayoutTests/platform/gtk/fast/selectors/040-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfastselectors040expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/gtk/fast/selectors/040-expected.txt (209403 => 209404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fast/selectors/040-expected.txt 2016-12-06 17:46:48 UTC (rev 209403)
+++ trunk/LayoutTests/platform/gtk/fast/selectors/040-expected.txt 2016-12-06 17:58:39 UTC (rev 209404)
</span><span class="lines">@@ -1,9 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x66
- RenderBlock {HTML} at (0,0) size 800x66
- RenderBody {BODY} at (8,16) size 784x34
- RenderBlock {P} at (0,0) size 784x34
- RenderText {#text} at (0,0) size 754x34
- text run at (0,0) width 754: "Any textual selection in this long paragraph should have green background. Any textual selection in this long paragraph"
- text run at (0,17) width 678: "should have green background. Any textual selection in this long paragraph should have green background."
</del></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorfastselectors040expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/ios-simulator/fast/selectors/040-expected.txt (209403 => 209404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/fast/selectors/040-expected.txt 2016-12-06 17:46:48 UTC (rev 209403)
+++ trunk/LayoutTests/platform/ios-simulator/fast/selectors/040-expected.txt 2016-12-06 17:58:39 UTC (rev 209404)
</span><span class="lines">@@ -1,9 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x72
- RenderBlock {HTML} at (0,0) size 800x72
- RenderBody {BODY} at (8,16) size 784x40
- RenderBlock {P} at (0,0) size 784x40
- RenderText {#text} at (0,0) size 768x39
- text run at (0,0) width 768: "Any textual selection in this long paragraph should have green background. Any textual selection in this long paragraph"
- text run at (0,20) width 688: "should have green background. Any textual selection in this long paragraph should have green background."
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmacfastselectors040expectedpng"></a>
<div class="binary"><h4>Deleted: trunk/LayoutTests/platform/mac/fast/selectors/040-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacfastselectors040expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/mac/fast/selectors/040-expected.txt (209403 => 209404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fast/selectors/040-expected.txt 2016-12-06 17:46:48 UTC (rev 209403)
+++ trunk/LayoutTests/platform/mac/fast/selectors/040-expected.txt 2016-12-06 17:58:39 UTC (rev 209404)
</span><span class="lines">@@ -1,9 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x68
- RenderBlock {HTML} at (0,0) size 800x68
- RenderBody {BODY} at (8,16) size 784x36
- RenderBlock {P} at (0,0) size 784x36
- RenderText {#text} at (0,0) size 768x36
- text run at (0,0) width 768: "Any textual selection in this long paragraph should have green background. Any textual selection in this long paragraph"
- text run at (0,18) width 688: "should have green background. Any textual selection in this long paragraph should have green background."
</del></span></pre></div>
<a id="trunkLayoutTestsplatformwinfastselectors040expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/win/fast/selectors/040-expected.txt (209403 => 209404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/fast/selectors/040-expected.txt 2016-12-06 17:46:48 UTC (rev 209403)
+++ trunk/LayoutTests/platform/win/fast/selectors/040-expected.txt 2016-12-06 17:58:39 UTC (rev 209404)
</span><span class="lines">@@ -1,9 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x68
- RenderBlock {HTML} at (0,0) size 800x68
- RenderBody {BODY} at (8,16) size 784x36
- RenderBlock {P} at (0,0) size 784x36
- RenderText {#text} at (0,0) size 754x36
- text run at (0,0) width 754: "Any textual selection in this long paragraph should have green background. Any textual selection in this long paragraph"
- text run at (0,18) width 678: "should have green background. Any textual selection in this long paragraph should have green background."
</del></span></pre>
</div>
</div>
</body>
</html>