<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209322] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209322">209322</a></dd>
<dt>Author</dt> <dd>annulen@yandex.ru</dd>
<dt>Date</dt> <dd>2016-12-05 09:47:34 -0800 (Mon, 05 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add __STDC_FORMAT_MACROS before inttypes.h is included
https://bugs.webkit.org/show_bug.cgi?id=165374
We need formatting macros like PRIu64 to be available in all places where
inttypes.h header is used. All these usages get inttypes.h definitions
via wtf/Assertions.h header, except SQLiteFileSystem.cpp where formatting
macros are not used anymore since <a href="http://trac.webkit.org/projects/webkit/changeset/185129">r185129</a>.
This patch fixes multiple build errors with MinGW and reduces number of
independent __STDC_FORMAT_MACROS uses in the code base.
Reviewed by Darin Adler.
Source/JavaScriptCore:
* disassembler/ARM64/A64DOpcode.cpp: Removed __STDC_FORMAT_MACROS
because it is obtained via Assertions.h now
* disassembler/ARM64Disassembler.cpp: Ditto.
Source/WebCore:
No new tests needed.
* platform/sql/SQLiteFileSystem.cpp: Removed unused inttypes.h
inclusion.
Source/WTF:
* wtf/Assertions.h: Define __STDC_FORMAT_MACROS.
* wtf/StdLibExtras.h: Remove definition of PRId64 for Windows, as we
have __STDC_FORMAT_MACROS defined now.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredisassemblerARM64A64DOpcodecpp">trunk/Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredisassemblerARM64Disassemblercpp">trunk/Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfAssertionsh">trunk/Source/WTF/wtf/Assertions.h</a></li>
<li><a href="#trunkSourceWTFwtfStdLibExtrash">trunk/Source/WTF/wtf/StdLibExtras.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformsqlSQLiteFileSystemcpp">trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (209321 => 209322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-12-05 17:43:37 UTC (rev 209321)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-12-05 17:47:34 UTC (rev 209322)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-12-05 Konstantin Tokarev <annulen@yandex.ru>
+
+ Add __STDC_FORMAT_MACROS before inttypes.h is included
+ https://bugs.webkit.org/show_bug.cgi?id=165374
+
+ We need formatting macros like PRIu64 to be available in all places where
+ inttypes.h header is used. All these usages get inttypes.h definitions
+ via wtf/Assertions.h header, except SQLiteFileSystem.cpp where formatting
+ macros are not used anymore since r185129.
+
+ This patch fixes multiple build errors with MinGW and reduces number of
+ independent __STDC_FORMAT_MACROS uses in the code base.
+
+ Reviewed by Darin Adler.
+
+ * disassembler/ARM64/A64DOpcode.cpp: Removed __STDC_FORMAT_MACROS
+ because it is obtained via Assertions.h now
+ * disassembler/ARM64Disassembler.cpp: Ditto.
+
</ins><span class="cx"> 2016-12-04 Keith Miller <keith_miller@apple.com>
</span><span class="cx">
</span><span class="cx"> Add support for Wasm ctz and popcnt
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredisassemblerARM64A64DOpcodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp (209321 => 209322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp 2016-12-05 17:43:37 UTC (rev 209321)
+++ trunk/Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp 2016-12-05 17:47:34 UTC (rev 209322)
</span><span class="lines">@@ -23,7 +23,6 @@
</span><span class="cx"> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-#define __STDC_FORMAT_MACROS
</del><span class="cx"> #include "config.h"
</span><span class="cx">
</span><span class="cx"> #if USE(ARM64_DISASSEMBLER)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredisassemblerARM64Disassemblercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp (209321 => 209322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp 2016-12-05 17:43:37 UTC (rev 209321)
+++ trunk/Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp 2016-12-05 17:47:34 UTC (rev 209322)
</span><span class="lines">@@ -23,7 +23,6 @@
</span><span class="cx"> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-#define __STDC_FORMAT_MACROS
</del><span class="cx"> #include "config.h"
</span><span class="cx"> #include "Disassembler.h"
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (209321 => 209322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-12-05 17:43:37 UTC (rev 209321)
+++ trunk/Source/WTF/ChangeLog 2016-12-05 17:47:34 UTC (rev 209322)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-12-05 Konstantin Tokarev <annulen@yandex.ru>
+
+ Add __STDC_FORMAT_MACROS before inttypes.h is included
+ https://bugs.webkit.org/show_bug.cgi?id=165374
+
+ We need formatting macros like PRIu64 to be available in all places where
+ inttypes.h header is used. All these usages get inttypes.h definitions
+ via wtf/Assertions.h header, except SQLiteFileSystem.cpp where formatting
+ macros are not used anymore since r185129.
+
+ This patch fixes multiple build errors with MinGW and reduces number of
+ independent __STDC_FORMAT_MACROS uses in the code base.
+
+ Reviewed by Darin Adler.
+
+ * wtf/Assertions.h: Define __STDC_FORMAT_MACROS.
+ * wtf/StdLibExtras.h: Remove definition of PRId64 for Windows, as we
+ have __STDC_FORMAT_MACROS defined now.
+
</ins><span class="cx"> 2016-12-03 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Refactor SymbolImpl layout
</span></span></pre></div>
<a id="trunkSourceWTFwtfAssertionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Assertions.h (209321 => 209322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Assertions.h 2016-12-05 17:43:37 UTC (rev 209321)
+++ trunk/Source/WTF/wtf/Assertions.h 2016-12-05 17:47:34 UTC (rev 209322)
</span><span class="lines">@@ -39,6 +39,8 @@
</span><span class="cx"> having any effect.
</span><span class="cx"> */
</span><span class="cx">
</span><ins>+#undef __STDC_FORMAT_MACROS
+#define __STDC_FORMAT_MACROS
</ins><span class="cx"> #include <inttypes.h>
</span><span class="cx"> #include <stdarg.h>
</span><span class="cx"> #include <stdbool.h>
</span></span></pre></div>
<a id="trunkSourceWTFwtfStdLibExtrash"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/StdLibExtras.h (209321 => 209322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/StdLibExtras.h 2016-12-05 17:43:37 UTC (rev 209321)
+++ trunk/Source/WTF/wtf/StdLibExtras.h 2016-12-05 17:47:34 UTC (rev 209322)
</span><span class="lines">@@ -79,11 +79,6 @@
</span><span class="cx"> #define WTF_CONCAT(a, b) WTF_CONCAT_INTERNAL_DONT_USE(a, b)
</span><span class="cx">
</span><span class="cx">
</span><del>-// Make "PRId64" format specifier work for Visual C++ on Windows.
-#if OS(WINDOWS) && !defined(PRId64)
-#define PRId64 "lld"
-#endif
-
</del><span class="cx"> /*
</span><span class="cx"> * The reinterpret_cast<Type1*>([pointer to Type2]) expressions - where
</span><span class="cx"> * sizeof(Type1) > sizeof(Type2) - cause the following warning on ARM with GCC:
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209321 => 209322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-05 17:43:37 UTC (rev 209321)
+++ trunk/Source/WebCore/ChangeLog 2016-12-05 17:47:34 UTC (rev 209322)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-12-05 Konstantin Tokarev <annulen@yandex.ru>
+
+ Add __STDC_FORMAT_MACROS before inttypes.h is included
+ https://bugs.webkit.org/show_bug.cgi?id=165374
+
+ We need formatting macros like PRIu64 to be available in all places where
+ inttypes.h header is used. All these usages get inttypes.h definitions
+ via wtf/Assertions.h header, except SQLiteFileSystem.cpp where formatting
+ macros are not used anymore since r185129.
+
+ This patch fixes multiple build errors with MinGW and reduces number of
+ independent __STDC_FORMAT_MACROS uses in the code base.
+
+ Reviewed by Darin Adler.
+
+ No new tests needed.
+
+ * platform/sql/SQLiteFileSystem.cpp: Removed unused inttypes.h
+ inclusion.
+
</ins><span class="cx"> 2016-12-05 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> [CSS Parser] Properly fail on bad values for -webkit-clip-path
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformsqlSQLiteFileSystemcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp (209321 => 209322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp 2016-12-05 17:43:37 UTC (rev 209321)
+++ trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp 2016-12-05 17:47:34 UTC (rev 209322)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx"> * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-#define __STDC_FORMAT_MACROS
</del><span class="cx"> #include "config.h"
</span><span class="cx"> #include "SQLiteFileSystem.h"
</span><span class="cx">
</span><span class="lines">@@ -35,7 +34,6 @@
</span><span class="cx"> #include "FileSystem.h"
</span><span class="cx"> #include "SQLiteDatabase.h"
</span><span class="cx"> #include "SQLiteStatement.h"
</span><del>-#include <inttypes.h>
</del><span class="cx"> #include <sqlite3.h>
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span></span></pre>
</div>
</div>
</body>
</html>