<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209374] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209374">209374</a></dd>
<dt>Author</dt> <dd>hyatt@apple.com</dd>
<dt>Date</dt> <dd>2016-12-05 18:30:38 -0800 (Mon, 05 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Parser] Tweak more layout tests to pass
https://bugs.webkit.org/show_bug.cgi?id=165447
Reviewed by Zalan Bujtas.
* TestExpectations:
Add a few more tests to avoid.
* fast/css/parsing-font-variant-ligatures-expected.txt:
* fast/css/parsing-font-variant-ligatures.html:
Remove the assumption that multiple occurrences of the
same value are allowed.
* fast/filter-image/parse-filter-image-expected.txt:
* fast/filter-image/parse-filter-image.html:
Change the test to require url(), since you cannot omit it
and expect the filter to parse properly.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsfastcssparsingfontvariantligaturesexpectedtxt">trunk/LayoutTests/fast/css/parsing-font-variant-ligatures-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssparsingfontvariantligatureshtml">trunk/LayoutTests/fast/css/parsing-font-variant-ligatures.html</a></li>
<li><a href="#trunkLayoutTestsfastfilterimageparsefilterimageexpectedtxt">trunk/LayoutTests/fast/filter-image/parse-filter-image-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastfilterimageparsefilterimagehtml">trunk/LayoutTests/fast/filter-image/parse-filter-image.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209373 => 209374)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/ChangeLog 2016-12-06 02:30:38 UTC (rev 209374)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-12-05 Dave Hyatt <hyatt@apple.com>
+
+ [CSS Parser] Tweak more layout tests to pass
+ https://bugs.webkit.org/show_bug.cgi?id=165447
+
+ Reviewed by Zalan Bujtas.
+
+ * TestExpectations:
+ Add a few more tests to avoid.
+
+ * fast/css/parsing-font-variant-ligatures-expected.txt:
+ * fast/css/parsing-font-variant-ligatures.html:
+ Remove the assumption that multiple occurrences of the
+ same value are allowed.
+
+ * fast/filter-image/parse-filter-image-expected.txt:
+ * fast/filter-image/parse-filter-image.html:
+ Change the test to require url(), since you cannot omit it
+ and expect the filter to parse properly.
+
</ins><span class="cx"> 2016-12-05 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> MediaDocuments crash with modern media controls
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (209373 => 209374)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/TestExpectations 2016-12-06 02:30:38 UTC (rev 209374)
</span><span class="lines">@@ -1011,6 +1011,7 @@
</span><span class="cx"> webkit.org/b/165195 fast/forms/basic-selects.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/165195 fast/shadow-dom/slotted-pseudo-element-css-text.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/165195 fast/inspector-support/style.html [ Pass Failure ]
</span><ins>+webkit.org/b/165195 svg/webarchive/svg-script-subresouces.svg [ Pass Failure ]
</ins><span class="cx">
</span><span class="cx"> # The following layout tests need to be changed when the new CSS Parser is turned on, since they
</span><span class="cx"> # incorrectly indicate failures on valid syntax.
</span><span class="lines">@@ -1057,6 +1058,7 @@
</span><span class="cx"> webkit.org/b/165195 fast/css-grid-layout/grid-auto-flow-get-set.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/165195 fast/css-grid-layout/grid-columns-rows-get-set.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/165195 fast/css-grid-layout/non-grid-columns-rows-get-set.html [ Pass Failure ]
</span><ins>+webkit.org/b/165195 fast/masking/parsing-mask.html [ Pass Failure ]
</ins><span class="cx">
</span><span class="cx"> # The following tests match Blink/Chrome, but we're not sure yet what to do with them when the
</span><span class="cx"> # new CSS parser is turned on. The tests may be right, and these may be bugs in Blink/Chrome, or
</span><span class="lines">@@ -1073,4 +1075,5 @@
</span><span class="cx"> # the new CSS Parser turns on.
</span><span class="cx"> webkit.org/b/165195 svg/dom/SVGColor.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/165195 svg/dom/SVGPaint.html [ Pass Failure ]
</span><ins>+webkit.org/b/165195 svg/dom/rgb-color-parser.html [ Pass Failure ]
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssparsingfontvariantligaturesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/parsing-font-variant-ligatures-expected.txt (209373 => 209374)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/parsing-font-variant-ligatures-expected.txt 2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/fast/css/parsing-font-variant-ligatures-expected.txt 2016-12-06 02:30:38 UTC (rev 209374)
</span><span class="lines">@@ -13,7 +13,6 @@
</span><span class="cx"> PASS: 'no-historical-ligatures' parsed as 'no-historical-ligatures' and computed to 'no-historical-ligatures'
</span><span class="cx"> PASS: 'historical-ligatures' parsed as 'historical-ligatures' and computed to 'historical-ligatures'
</span><span class="cx">
</span><del>-PASS: 'no-common-ligatures no-common-ligatures' parsed as 'no-common-ligatures' and computed to 'no-common-ligatures'
</del><span class="cx"> PASS: 'common-ligatures no-discretionary-ligatures' parsed as 'common-ligatures no-discretionary-ligatures' and computed to 'common-ligatures no-discretionary-ligatures'
</span><span class="cx"> PASS: 'common-ligatures no-discretionary-ligatures historical-ligatures' parsed as 'common-ligatures no-discretionary-ligatures historical-ligatures' and computed to 'common-ligatures no-discretionary-ligatures historical-ligatures'
</span><span class="cx"> PASS: 'common-ligatures no-discretionary-ligatures normal' parsed as '' and computed to 'normal'
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssparsingfontvariantligatureshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/parsing-font-variant-ligatures.html (209373 => 209374)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/parsing-font-variant-ligatures.html 2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/fast/css/parsing-font-variant-ligatures.html 2016-12-06 02:30:38 UTC (rev 209374)
</span><span class="lines">@@ -43,7 +43,6 @@
</span><span class="cx"> test('historical-ligatures', 'historical-ligatures', 'historical-ligatures');
</span><span class="cx">
</span><span class="cx"> log("");
</span><del>- test('no-common-ligatures no-common-ligatures', 'no-common-ligatures', 'no-common-ligatures');
</del><span class="cx"> test('common-ligatures no-discretionary-ligatures', 'common-ligatures no-discretionary-ligatures', 'common-ligatures no-discretionary-ligatures');
</span><span class="cx"> test('common-ligatures no-discretionary-ligatures historical-ligatures', 'common-ligatures no-discretionary-ligatures historical-ligatures', 'common-ligatures no-discretionary-ligatures historical-ligatures');
</span><span class="cx"> test('common-ligatures no-discretionary-ligatures normal', '', 'normal');
</span></span></pre></div>
<a id="trunkLayoutTestsfastfilterimageparsefilterimageexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/filter-image/parse-filter-image-expected.txt (209373 => 209374)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/filter-image/parse-filter-image-expected.txt 2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/fast/filter-image/parse-filter-image-expected.txt 2016-12-06 02:30:38 UTC (rev 209374)
</span><span class="lines">@@ -80,7 +80,7 @@
</span><span class="cx"> PASS innerStyle("background-image", "filter(linear-gradient(0deg, white -20%, blue, black 120%), hue-rotate(90deg))") is "filter(linear-gradient(0deg, white -20%, blue, black 120%), hue-rotate(90deg))"
</span><span class="cx"> PASS innerStyle("background-image", "filter(-webkit-cross-fade(url(http://image1.png), url(http://image2.png), 50%), contrast(0.5))") is "filter(-webkit-cross-fade(url(http://image1.png/), url(http://image2.png/), 0.5), contrast(0.5))"
</span><span class="cx"> PASS innerStyle("background-image", "filter(url(http://image1.png), brightness(50%))") is "filter(url(http://image1.png/), brightness(50%))"
</span><del>-PASS innerStyle("background-image", "filter('http://image1.png', brightness(50%))") is "filter(url(http://image1.png/), brightness(50%))"
</del><ins>+PASS innerStyle("background-image", "filter(url('http://image1.png'), brightness(50%))") is "filter(url(http://image1.png/), brightness(50%))"
</ins><span class="cx"> PASS innerStyle("border-image-source", "filter(url(http://image1.png), invert(50%))") is "filter(url(http://image1.png/), invert(50%))"
</span><span class="cx"> PASS innerStyle("-webkit-mask-image", "filter(url(http://image1.png), invert(50%))") is "filter(url(http://image1.png/), invert(50%))"
</span><span class="cx"> PASS innerStyle("-webkit-mask-box-image-source", "filter(url(http://image1.png), invert(50%))") is "filter(url(http://image1.png/), invert(50%))"
</span></span></pre></div>
<a id="trunkLayoutTestsfastfilterimageparsefilterimagehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/filter-image/parse-filter-image.html (209373 => 209374)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/filter-image/parse-filter-image.html 2016-12-06 02:19:40 UTC (rev 209373)
+++ trunk/LayoutTests/fast/filter-image/parse-filter-image.html 2016-12-06 02:30:38 UTC (rev 209374)
</span><span class="lines">@@ -353,7 +353,7 @@
</span><span class="cx"> "filter(url(http://image1.png/), brightness(50%))");
</span><span class="cx"> testInner(
</span><span class="cx"> "background-image",
</span><del>- "filter('http://image1.png', brightness(50%))",
</del><ins>+ "filter(url('http://image1.png'), brightness(50%))",
</ins><span class="cx"> "filter(url(http://image1.png/), brightness(50%))");
</span><span class="cx">
</span><span class="cx"> // Test different properties, taking CSS Image values.
</span></span></pre>
</div>
</div>
</body>
</html>