<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209364] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209364">209364</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2016-12-05 15:48:15 -0800 (Mon, 05 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>pointer lock needs to be feature detectable
https://bugs.webkit.org/show_bug.cgi?id=165426
<rdar://problem/29486715>
Reviewed by Antoine Quint.
Source/WebCore:
Annotate the public-facing API for pointer-lock, so
that it is hidden when not available.
Also move the Setting to a RuntimeEnabledFeature, since
pointer-lock is exposed from WebKit as a feature.
Tests: pointer-lock/pointerlock-interface-disabled.html
pointer-lock/pointerlock-interface.html
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::pointerLockEnabled):
* dom/Document.idl:
* dom/Element.idl:
* page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::requestPointerUnlock):
* page/Settings.in:
Source/WebKit/mac:
Set the RuntimeEnabledFeature as preferences
change.
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Set the RuntimeEnabledFeature as preferences
change.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetPointerLockEnabled):
(WKPreferencesGetPointerLockEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Expose the comment line to turn on/off pointer lock.
* DumpRenderTree/TestOptions.h:
* DumpRenderTree/TestOptions.mm:
(TestOptions::TestOptions):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestOptions.h:
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::viewSupportsOptions):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::viewSupportsOptions):
Websites/webkit.org:
We can now accurately detect pointer-lock.
* experimental-features.html:
LayoutTests:
Checks that the API is hidden when the feature is turned off.
* pointer-lock/pointerlock-interface-disabled-expected.txt: Added.
* pointer-lock/pointerlock-interface-disabled.html: Added.
* pointer-lock/pointerlock-interface-expected.txt: Added.
* pointer-lock/pointerlock-interface.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh">trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h</a></li>
<li><a href="#trunkSourceWebCoredomDocumentidl">trunk/Source/WebCore/dom/Document.idl</a></li>
<li><a href="#trunkSourceWebCoredomElementidl">trunk/Source/WebCore/dom/Element.idl</a></li>
<li><a href="#trunkSourceWebCorepagePointerLockControllercpp">trunk/Source/WebCore/page/PointerLockController.cpp</a></li>
<li><a href="#trunkSourceWebCorepageSettingsin">trunk/Source/WebCore/page/Settings.in</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencescpp">trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreeTestOptionsh">trunk/Tools/DumpRenderTree/TestOptions.h</a></li>
<li><a href="#trunkToolsDumpRenderTreeTestOptionsmm">trunk/Tools/DumpRenderTree/TestOptions.mm</a></li>
<li><a href="#trunkToolsDumpRenderTreemacDumpRenderTreemm">trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm</a></li>
<li><a href="#trunkToolsWebKitTestRunnerTestControllercpp">trunk/Tools/WebKitTestRunner/TestController.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnerTestOptionsh">trunk/Tools/WebKitTestRunner/TestOptions.h</a></li>
<li><a href="#trunkToolsWebKitTestRunneriosPlatformWebViewIOSmm">trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm</a></li>
<li><a href="#trunkToolsWebKitTestRunnermacPlatformWebViewMacmm">trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm</a></li>
<li><a href="#trunkWebsiteswebkitorgChangeLog">trunk/Websites/webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsiteswebkitorgexperimentalfeatureshtml">trunk/Websites/webkit.org/experimental-features.html</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestspointerlockpointerlockinterfacedisabledexpectedtxt">trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt</a></li>
<li><a href="#trunkLayoutTestspointerlockpointerlockinterfacedisabledhtml">trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled.html</a></li>
<li><a href="#trunkLayoutTestspointerlockpointerlockinterfaceexpectedtxt">trunk/LayoutTests/pointer-lock/pointerlock-interface-expected.txt</a></li>
<li><a href="#trunkLayoutTestspointerlockpointerlockinterfacehtml">trunk/LayoutTests/pointer-lock/pointerlock-interface.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/LayoutTests/ChangeLog 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-12-05 Dean Jackson <dino@apple.com>
+
+ pointer lock needs to be feature detectable
+ https://bugs.webkit.org/show_bug.cgi?id=165426
+ <rdar://problem/29486715>
+
+ Reviewed by Antoine Quint.
+
+ Checks that the API is hidden when the feature is turned off.
+
+ * pointer-lock/pointerlock-interface-disabled-expected.txt: Added.
+ * pointer-lock/pointerlock-interface-disabled.html: Added.
+ * pointer-lock/pointerlock-interface-expected.txt: Added.
+ * pointer-lock/pointerlock-interface.html: Added.
+
</ins><span class="cx"> 2016-12-05 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> [CSS Parser] Skip a grid test
</span></span></pre></div>
<a id="trunkLayoutTestspointerlockpointerlockinterfacedisabledexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt (0 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt (rev 0)
+++ trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+
+PASS Document.prototype.exitPointerLock does not exist
+PASS Document.prototype.pointerLockElement does not exist
+PASS Document.prototype.onpointerlockchange does not exist
+PASS Document.prototype.onpointerlockerror does not exist
+PASS Element.prototype.requestPointerLock does not exist
+
</ins><span class="cx">Property changes on: trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<ins>+native
</ins><span class="cx">\ No newline at end of property
</span><a id="svnkeywords"></a>
<div class="addfile"><h4>Added: svn:keywords</h4></div>
<ins>+Date Revision
</ins><span class="cx">\ No newline at end of property
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<ins>+text/plain
</ins><span class="cx">\ No newline at end of property
</span><a id="trunkLayoutTestspointerlockpointerlockinterfacedisabledhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled.html (0 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled.html (rev 0)
+++ trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled.html 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ enablePointerLock=false ] -->
+<head>
+ <title>PointerLock interface tests.</title>
+ <link rel="help" href="https://w3c.github.io/pointerlock/">
+ <script src="../resources/testharness.js"></script>
+ <script src="../resources/testharnessreport.js"></script>
+</head>
+<body>
+<div id="log"></div>
+<script>
+test(function() {
+ assert_false('exitPointerLock' in Document.prototype);
+},'Document.prototype.exitPointerLock does not exist');
+
+test(function() {
+ assert_false('pointerLockElement' in Document.prototype);
+},'Document.prototype.pointerLockElement does not exist');
+
+test(function() {
+ assert_false('onpointerlockchange' in Document.prototype);
+},'Document.prototype.onpointerlockchange does not exist');
+
+test(function() {
+ assert_false('onpointerlockerror' in Document.prototype);
+},'Document.prototype.onpointerlockerror does not exist');
+
+test(function() {
+ assert_false('requestPointerLock' in Element.prototype);
+},'Element.prototype.requestPointerLock does not exist');
+</script>
+</body>
+</html>
</ins><span class="cx">Property changes on: trunk/LayoutTests/pointer-lock/pointerlock-interface-disabled.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<ins>+native
</ins><span class="cx">\ No newline at end of property
</span><a id="svnkeywords"></a>
<div class="addfile"><h4>Added: svn:keywords</h4></div>
<ins>+Date Revision
</ins><span class="cx">\ No newline at end of property
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<ins>+text/html
</ins><span class="cx">\ No newline at end of property
</span><a id="trunkLayoutTestspointerlockpointerlockinterfaceexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/pointer-lock/pointerlock-interface-expected.txt (0 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/pointer-lock/pointerlock-interface-expected.txt (rev 0)
+++ trunk/LayoutTests/pointer-lock/pointerlock-interface-expected.txt 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+
+PASS Document.prototype.exitPointerLock exists
+PASS Document.prototype.pointerLockElement exists
+PASS Document.prototype.onpointerlockchange exists
+PASS Document.prototype.onpointerlockerror exists
+PASS Element.prototype.requestPointerLock exists
+
</ins><span class="cx">Property changes on: trunk/LayoutTests/pointer-lock/pointerlock-interface-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<ins>+native
</ins><span class="cx">\ No newline at end of property
</span><a id="svnkeywords"></a>
<div class="addfile"><h4>Added: svn:keywords</h4></div>
<ins>+Date Revision
</ins><span class="cx">\ No newline at end of property
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<ins>+text/plain
</ins><span class="cx">\ No newline at end of property
</span><a id="trunkLayoutTestspointerlockpointerlockinterfacehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/pointer-lock/pointerlock-interface.html (0 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/pointer-lock/pointerlock-interface.html (rev 0)
+++ trunk/LayoutTests/pointer-lock/pointerlock-interface.html 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ enablePointerLock=true ] -->
+<head>
+ <title>PointerLock interface tests.</title>
+ <link rel="help" href="https://w3c.github.io/pointerlock/">
+ <script src="../resources/testharness.js"></script>
+ <script src="../resources/testharnessreport.js"></script>
+</head>
+<body>
+<div id="log"></div>
+<script>
+test(function() {
+ assert_true('exitPointerLock' in Document.prototype);
+},'Document.prototype.exitPointerLock exists');
+
+test(function() {
+ assert_true('pointerLockElement' in Document.prototype);
+},'Document.prototype.pointerLockElement exists');
+
+test(function() {
+ assert_true('onpointerlockchange' in Document.prototype);
+},'Document.prototype.onpointerlockchange exists');
+
+test(function() {
+ assert_true('onpointerlockerror' in Document.prototype);
+},'Document.prototype.onpointerlockerror exists');
+
+test(function() {
+ assert_true('requestPointerLock' in Element.prototype);
+},'Element.prototype.requestPointerLock exists');
+</script>
+</body>
+</html>
</ins><span class="cx">Property changes on: trunk/LayoutTests/pointer-lock/pointerlock-interface.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<ins>+native
</ins><span class="cx">\ No newline at end of property
</span><a id="svnkeywords"></a>
<div class="addfile"><h4>Added: svn:keywords</h4></div>
<ins>+Date Revision
</ins><span class="cx">\ No newline at end of property
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<ins>+text/html
</ins><span class="cx">\ No newline at end of property
</span><a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebCore/ChangeLog 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -1,3 +1,30 @@
</span><ins>+2016-12-05 Dean Jackson <dino@apple.com>
+
+ pointer lock needs to be feature detectable
+ https://bugs.webkit.org/show_bug.cgi?id=165426
+ <rdar://problem/29486715>
+
+ Reviewed by Antoine Quint.
+
+ Annotate the public-facing API for pointer-lock, so
+ that it is hidden when not available.
+
+ Also move the Setting to a RuntimeEnabledFeature, since
+ pointer-lock is exposed from WebKit as a feature.
+
+ Tests: pointer-lock/pointerlock-interface-disabled.html
+ pointer-lock/pointerlock-interface.html
+
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setPointerLockEnabled):
+ (WebCore::RuntimeEnabledFeatures::pointerLockEnabled):
+ * dom/Document.idl:
+ * dom/Element.idl:
+ * page/PointerLockController.cpp:
+ (WebCore::PointerLockController::requestPointerLock):
+ (WebCore::PointerLockController::requestPointerUnlock):
+ * page/Settings.in:
+
</ins><span class="cx"> 2016-12-05 Keith Rollin <krollin@apple.com>
</span><span class="cx">
</span><span class="cx"> Reduce number of platformMemoryUsage calls
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -212,6 +212,11 @@
</span><span class="cx"> bool webGL2Enabled() const { return m_isWebGL2Enabled; }
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#if ENABLE(POINTER_LOCK)
+ void setPointerLockEnabled(bool isEnabled) { m_isPointerLockEnabled = isEnabled; }
+ bool pointerLockEnabled() const { return m_isPointerLockEnabled; }
+#endif
+
</ins><span class="cx"> #if ENABLE(FETCH_API)
</span><span class="cx"> void setFetchAPIEnabled(bool isEnabled) { m_isFetchAPIEnabled = isEnabled; }
</span><span class="cx"> bool fetchAPIEnabled() const { return m_isFetchAPIEnabled; }
</span><span class="lines">@@ -347,6 +352,10 @@
</span><span class="cx"> bool m_isWebGL2Enabled;
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#if ENABLE(POINTER_LOCK)
+ bool m_isPointerLockEnabled;
+#endif
+
</ins><span class="cx"> #if ENABLE(FETCH_API)
</span><span class="cx"> bool m_isFetchAPIEnabled { false };
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.idl (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.idl 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebCore/dom/Document.idl 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -152,8 +152,8 @@
</span><span class="cx"> void webkitExitFullscreen();
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- [Conditional=POINTER_LOCK] void exitPointerLock();
- [Conditional=POINTER_LOCK] readonly attribute Element? pointerLockElement;
</del><ins>+ [Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] void exitPointerLock();
+ [Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] readonly attribute Element? pointerLockElement;
</ins><span class="cx">
</span><span class="cx"> [Conditional=CSS_REGIONS] DOMNamedFlowCollection webkitGetNamedFlows();
</span><span class="cx">
</span><span class="lines">@@ -202,8 +202,8 @@
</span><span class="cx"> // Unique to Document
</span><span class="cx"> [LenientThis] attribute EventHandler onreadystatechange;
</span><span class="cx"> [NotEnumerable, Conditional=CSP_NEXT] attribute EventHandler onsecuritypolicyviolation;
</span><del>- [NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockchange;
- [NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockerror;
</del><ins>+ [NotEnumerable, Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] attribute EventHandler onpointerlockchange;
+ [NotEnumerable, Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] attribute EventHandler onpointerlockerror;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> Document implements ParentNode;
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.idl (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.idl 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebCore/dom/Element.idl 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -128,7 +128,7 @@
</span><span class="cx"> [CEReactions, MayThrowException] void insertAdjacentHTML(DOMString where, DOMString html);
</span><span class="cx"> [MayThrowException] void insertAdjacentText(DOMString where, DOMString text);
</span><span class="cx">
</span><del>- [Conditional=POINTER_LOCK] void requestPointerLock();
</del><ins>+ [Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] void requestPointerLock();
</ins><span class="cx">
</span><span class="cx"> // CSS Regions API
</span><span class="cx"> [Conditional=CSS_REGIONS] readonly attribute DOMString webkitRegionOverset;
</span></span></pre></div>
<a id="trunkSourceWebCorepagePointerLockControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PointerLockController.cpp (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PointerLockController.cpp 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebCore/page/PointerLockController.cpp 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> #include "EventNames.h"
</span><span class="cx"> #include "Page.h"
</span><span class="cx"> #include "PlatformMouseEvent.h"
</span><ins>+#include "RuntimeEnabledFeatures.h"
</ins><span class="cx"> #include "ScriptController.h"
</span><span class="cx"> #include "Settings.h"
</span><span class="cx"> #include "VoidCallback.h"
</span><span class="lines">@@ -49,7 +50,7 @@
</span><span class="cx">
</span><span class="cx"> void PointerLockController::requestPointerLock(Element* target)
</span><span class="cx"> {
</span><del>- if (!m_page.settings().pointerLockEnabled())
</del><ins>+ if (!RuntimeEnabledFeatures::sharedFeatures().pointerLockEnabled())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (!target || !target->inDocument() || m_documentOfRemovedElementWhileWaitingForUnlock) {
</span><span class="lines">@@ -92,7 +93,7 @@
</span><span class="cx"> if (!m_element)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (!m_page.settings().pointerLockEnabled())
</del><ins>+ if (!RuntimeEnabledFeatures::sharedFeatures().pointerLockEnabled())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> m_page.chrome().client().requestPointerUnlock();
</span></span></pre></div>
<a id="trunkSourceWebCorepageSettingsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Settings.in (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Settings.in 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebCore/page/Settings.in 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -293,4 +293,3 @@
</span><span class="cx"> animatedImageAsyncDecodingEnabled initial=true
</span><span class="cx">
</span><span class="cx"> es6ModulesEnabled initial=false
</span><del>-pointerLockEnabled initial=false
</del></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-12-05 Dean Jackson <dino@apple.com>
+
+ pointer lock needs to be feature detectable
+ https://bugs.webkit.org/show_bug.cgi?id=165426
+ <rdar://problem/29486715>
+
+ Reviewed by Antoine Quint.
+
+ Set the RuntimeEnabledFeature as preferences
+ change.
+
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
</ins><span class="cx"> 2016-12-05 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r209299.
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -2650,10 +2650,6 @@
</span><span class="cx"> settings.setXSSAuditorEnabled([preferences isXSSAuditorEnabled]);
</span><span class="cx"> settings.setDNSPrefetchingEnabled([preferences isDNSPrefetchingEnabled]);
</span><span class="cx">
</span><del>-#if ENABLE(POINTER_LOCK)
- settings.setPointerLockEnabled([preferences pointerLockEnabled]);
-#endif
-
</del><span class="cx"> settings.setAcceleratedCompositingEnabled([preferences acceleratedCompositingEnabled]);
</span><span class="cx"> settings.setAcceleratedDrawingEnabled([preferences acceleratedDrawingEnabled]);
</span><span class="cx"> settings.setDisplayListDrawingEnabled([preferences displayListDrawingEnabled]);
</span><span class="lines">@@ -2846,6 +2842,10 @@
</span><span class="cx">
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled([preferences customElementsEnabled]);
</span><span class="cx">
</span><ins>+#if ENABLE(POINTER_LOCK)
+ RuntimeEnabledFeatures::sharedFeatures().setPointerLockEnabled([preferences pointerLockEnabled]);
+#endif
+
</ins><span class="cx"> #if ENABLE(FETCH_API)
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled([preferences fetchAPIEnabled]);
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebKit2/ChangeLog 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-12-05 Dean Jackson <dino@apple.com>
+
+ pointer lock needs to be feature detectable
+ https://bugs.webkit.org/show_bug.cgi?id=165426
+ <rdar://problem/29486715>
+
+ Reviewed by Antoine Quint.
+
+ Set the RuntimeEnabledFeature as preferences
+ change.
+
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetPointerLockEnabled):
+ (WKPreferencesGetPointerLockEnabled):
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
</ins><span class="cx"> 2016-12-05 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> [Cocoa] Add some memory usage related information to sysdiagnose state dumps
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -832,6 +832,16 @@
</span><span class="cx"> return toImpl(preferencesRef)->modernMediaControlsEnabled();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void WKPreferencesSetPointerLockEnabled(WKPreferencesRef preferencesRef, bool flag)
+{
+ toImpl(preferencesRef)->setPointerLockEnabled(flag);
+}
+
+bool WKPreferencesGetPointerLockEnabled(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->pointerLockEnabled();
+}
+
</ins><span class="cx"> void WKPreferencesSetShowsToolTipOverTruncatedText(WKPreferencesRef preferencesRef, bool flag)
</span><span class="cx"> {
</span><span class="cx"> toImpl(preferencesRef)->setShowsToolTipOverTruncatedText(flag);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -209,6 +209,10 @@
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetModernMediaControlsEnabled(WKPreferencesRef preferencesRef);
</span><span class="cx">
</span><span class="cx"> // Defaults to false.
</span><ins>+WK_EXPORT void WKPreferencesSetPointerLockEnabled(WKPreferencesRef preferencesRef, bool flag);
+WK_EXPORT bool WKPreferencesGetPointerLockEnabled(WKPreferencesRef preferencesRef);
+
+// Defaults to false.
</ins><span class="cx"> WK_EXPORT void WKPreferencesSetShowsToolTipOverTruncatedText(WKPreferencesRef preferencesRef, bool flag);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetShowsToolTipOverTruncatedText(WKPreferencesRef preferencesRef);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -2992,9 +2992,6 @@
</span><span class="cx"> #if ENABLE(ATTACHMENT_ELEMENT)
</span><span class="cx"> settings.setAttachmentElementEnabled(store.getBoolValueForKey(WebPreferencesKey::attachmentElementEnabledKey()));
</span><span class="cx"> #endif
</span><del>-#if ENABLE(POINTER_LOCK)
- settings.setPointerLockEnabled(store.getBoolValueForKey(WebPreferencesKey::pointerLockEnabledKey()));
-#endif
</del><span class="cx"> settings.setAllowsPictureInPictureMediaPlayback(store.getBoolValueForKey(WebPreferencesKey::allowsPictureInPictureMediaPlaybackKey()));
</span><span class="cx"> settings.setMediaControlsScaleWithPageZoom(store.getBoolValueForKey(WebPreferencesKey::mediaControlsScaleWithPageZoomKey()));
</span><span class="cx"> settings.setMockScrollbarsEnabled(store.getBoolValueForKey(WebPreferencesKey::mockScrollbarsEnabledKey()));
</span><span class="lines">@@ -3188,6 +3185,10 @@
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setWebGL2Enabled(store.getBoolValueForKey(WebPreferencesKey::webGL2EnabledKey()));
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#if ENABLE(POINTER_LOCK)
+ RuntimeEnabledFeatures::sharedFeatures().setPointerLockEnabled(store.getBoolValueForKey(WebPreferencesKey::pointerLockEnabledKey()));
+#endif
+
</ins><span class="cx"> settings.setSpringTimingFunctionEnabled(store.getBoolValueForKey(WebPreferencesKey::springTimingFunctionEnabledKey()));
</span><span class="cx">
</span><span class="cx"> settings.setVisualViewportEnabled(store.getBoolValueForKey(WebPreferencesKey::visualViewportEnabledKey()));
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Tools/ChangeLog 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2016-12-05 Dean Jackson <dino@apple.com>
+
+ pointer lock needs to be feature detectable
+ https://bugs.webkit.org/show_bug.cgi?id=165426
+ <rdar://problem/29486715>
+
+ Reviewed by Antoine Quint.
+
+ Expose the comment line to turn on/off pointer lock.
+
+ * DumpRenderTree/TestOptions.h:
+ * DumpRenderTree/TestOptions.mm:
+ (TestOptions::TestOptions):
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+ (WTR::updateTestOptionsFromTestHeader):
+ * WebKitTestRunner/TestOptions.h:
+ * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
+ (WTR::PlatformWebView::viewSupportsOptions):
+ * WebKitTestRunner/mac/PlatformWebViewMac.mm:
+ (WTR::PlatformWebView::viewSupportsOptions):
+
</ins><span class="cx"> 2016-12-05 Jonathan Bedard <jbedard@apple.com>
</span><span class="cx">
</span><span class="cx"> Make it possible to use an existing simulator instance for one-off testing
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeTestOptionsh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/TestOptions.h (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/TestOptions.h 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Tools/DumpRenderTree/TestOptions.h 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx"> struct TestOptions {
</span><span class="cx"> bool enableIntersectionObserver { false };
</span><span class="cx"> bool enableModernMediaControls { false };
</span><ins>+ bool enablePointerLock { false };
</ins><span class="cx">
</span><span class="cx"> TestOptions(NSURL *testURL);
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeTestOptionsmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/TestOptions.mm (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/TestOptions.mm 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Tools/DumpRenderTree/TestOptions.mm 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -80,6 +80,8 @@
</span><span class="cx"> this->enableIntersectionObserver = parseBooleanTestHeaderValue(value);
</span><span class="cx"> else if (key == "enableModernMediaControls")
</span><span class="cx"> this->enableModernMediaControls = parseBooleanTestHeaderValue(value);
</span><ins>+ else if (key == "enablePointerLock")
+ this->enablePointerLock = parseBooleanTestHeaderValue(value);
</ins><span class="cx"> pairStart = pairEnd + 1;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacDumpRenderTreemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -1000,6 +1000,7 @@
</span><span class="cx">
</span><span class="cx"> preferences.intersectionObserverEnabled = options.enableIntersectionObserver;
</span><span class="cx"> preferences.modernMediaControlsEnabled = options.enableModernMediaControls;
</span><ins>+ preferences.pointerLockEnabled = options.enablePointerLock;
</ins><span class="cx">
</span><span class="cx"> [preferences setSubtleCryptoEnabled:YES];
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerTestControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/TestController.cpp 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -652,6 +652,7 @@
</span><span class="cx"> WKPreferencesSetNeedsSiteSpecificQuirks(preferences, options.needsSiteSpecificQuirks);
</span><span class="cx"> WKPreferencesSetIntersectionObserverEnabled(preferences, options.enableIntersectionObserver);
</span><span class="cx"> WKPreferencesSetModernMediaControlsEnabled(preferences, options.enableModernMediaControls);
</span><ins>+ WKPreferencesSetPointerLockEnabled(preferences, options.enablePointerLock);
</ins><span class="cx">
</span><span class="cx"> static WKStringRef defaultTextEncoding = WKStringCreateWithUTF8CString("ISO-8859-1");
</span><span class="cx"> WKPreferencesSetDefaultTextEncodingName(preferences, defaultTextEncoding);
</span><span class="lines">@@ -963,6 +964,8 @@
</span><span class="cx"> testOptions.enableIntersectionObserver = parseBooleanTestHeaderValue(value);
</span><span class="cx"> if (key == "enableModernMediaControls")
</span><span class="cx"> testOptions.enableModernMediaControls = parseBooleanTestHeaderValue(value);
</span><ins>+ if (key == "enablePointerLock")
+ testOptions.enablePointerLock = parseBooleanTestHeaderValue(value);
</ins><span class="cx"> pairStart = pairEnd + 1;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerTestOptionsh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/TestOptions.h (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/TestOptions.h 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Tools/WebKitTestRunner/TestOptions.h 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -45,6 +45,7 @@
</span><span class="cx"> bool useCharacterSelectionGranularity { false };
</span><span class="cx"> bool enableIntersectionObserver { false };
</span><span class="cx"> bool enableModernMediaControls { false };
</span><ins>+ bool enablePointerLock { false };
</ins><span class="cx">
</span><span class="cx"> float deviceScaleFactor { 1 };
</span><span class="cx"> Vector<String> overrideLanguages;
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunneriosPlatformWebViewIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -282,7 +282,8 @@
</span><span class="cx"> || m_options.needsSiteSpecificQuirks != options.needsSiteSpecificQuirks
</span><span class="cx"> || m_options.useCharacterSelectionGranularity != options.useCharacterSelectionGranularity
</span><span class="cx"> || m_options.enableIntersectionObserver != options.enableIntersectionObserver
</span><del>- || m_options.enableModernMediaControls != options.enableModernMediaControls)
</del><ins>+ || m_options.enableModernMediaControls != options.enableModernMediaControls
+ || m_options.enablePointerLock != options.enablePointerLock)
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnermacPlatformWebViewMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -278,7 +278,8 @@
</span><span class="cx"> || m_options.useMockScrollbars != options.useMockScrollbars
</span><span class="cx"> || m_options.needsSiteSpecificQuirks != options.needsSiteSpecificQuirks
</span><span class="cx"> || m_options.enableIntersectionObserver != options.enableIntersectionObserver
</span><del>- || m_options.enableModernMediaControls != options.enableModernMediaControls)
</del><ins>+ || m_options.enableModernMediaControls != options.enableModernMediaControls
+ || m_options.enablePointerLock != options.enablePointerLock)
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkWebsiteswebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/webkit.org/ChangeLog (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/webkit.org/ChangeLog 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Websites/webkit.org/ChangeLog 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-12-05 Dean Jackson <dino@apple.com>
+
+ pointer lock needs to be feature detectable
+ https://bugs.webkit.org/show_bug.cgi?id=165426
+ <rdar://problem/29486715>
+
+ Reviewed by Antoine Quint.
+
+ We can now accurately detect pointer-lock.
+
+ * experimental-features.html:
+
</ins><span class="cx"> 2016-12-02 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Make a public facing page to check for WebKit features
</span></span></pre></div>
<a id="trunkWebsiteswebkitorgexperimentalfeatureshtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/webkit.org/experimental-features.html (209363 => 209364)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/webkit.org/experimental-features.html 2016-12-05 23:39:59 UTC (rev 209363)
+++ trunk/Websites/webkit.org/experimental-features.html 2016-12-05 23:48:15 UTC (rev 209364)
</span><span class="lines">@@ -126,8 +126,7 @@
</span><span class="cx"> <div class="test" id="CSSGrid"><p>CSS Grid</p></div>
</span><span class="cx"> <div class="test" id="Gamepad"><p>Gamepad API</p></div>
</span><span class="cx"> <div class="test" id="VariationFonts"><p>Variation Fonts</p></div>
</span><del>- <!-- Remove "-unknown" when WebKit can do live feature detection for pointer lock -->
- <div class="test" id="PointerLock-unknown"><p>Mouse Pointer Lock</p></div>
</del><ins>+ <div class="test" id="PointerLock"><p>Mouse Pointer Lock</p></div>
</ins><span class="cx"> <div class="test" id="WebGL2"><p>WebGL 2.0</p></div>
</span><span class="cx"> <div class="test" id="FormValidation"><p>HTML Form Validation</p></div>
</span><span class="cx"> <div class="test" id="InputEvents"><p>HTML Input Events</p></div>
</span></span></pre>
</div>
</div>
</body>
</html>