<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209279] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209279">209279</a></dd>
<dt>Author</dt> <dd>hyatt@apple.com</dd>
<dt>Date</dt> <dd>2016-12-02 15:07:41 -0800 (Fri, 02 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Parser] Fix errors in numerous layout tests
https://bugs.webkit.org/show_bug.cgi?id=165343
Reviewed by Zalan Bujtas.
* fast/backgrounds/repeat/parsing-background-repeat-expected.txt:
* fast/backgrounds/repeat/script-tests/parsing-background-repeat.js:
The old parser partially applies shorthands, even if it rejects later on.
The new parser properly rejects the entire shorthand. Fix the test so that
the numbers at the end are not unitless so that the entire shorthand parses, allowing
the components to be obtained.
* fast/css/unknown-pseudo-element-matching-expected.txt:
* fast/css/unknown-pseudo-element-matching.html:
* fast/text/crash-complex-text-surrogate.html:
The old parser allows the tag name to be omitted following a namespace bar (|). This
is not legal according to the namespaces spec, and the new parser behaves correctly.
For the crash test, it's important that all the code still runs, so we know the crash
doesn't happen, so I patched the test to put in '*' for the tag names to keep everything
the same.
For the unknown-pseudo-element test, I just removed the five invalid cases.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastbackgroundsrepeatparsingbackgroundrepeatexpectedtxt">trunk/LayoutTests/fast/backgrounds/repeat/parsing-background-repeat-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastbackgroundsrepeatscripttestsparsingbackgroundrepeatjs">trunk/LayoutTests/fast/backgrounds/repeat/script-tests/parsing-background-repeat.js</a></li>
<li><a href="#trunkLayoutTestsfastcssunknownpseudoelementmatchingexpectedtxt">trunk/LayoutTests/fast/css/unknown-pseudo-element-matching-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssunknownpseudoelementmatchinghtml">trunk/LayoutTests/fast/css/unknown-pseudo-element-matching.html</a></li>
<li><a href="#trunkLayoutTestsfasttextcrashcomplextextsurrogatehtml">trunk/LayoutTests/fast/text/crash-complex-text-surrogate.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209278 => 209279)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-02 23:07:25 UTC (rev 209278)
+++ trunk/LayoutTests/ChangeLog 2016-12-02 23:07:41 UTC (rev 209279)
</span><span class="lines">@@ -1,5 +1,30 @@
</span><span class="cx"> 2016-12-02 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><ins>+ [CSS Parser] Fix errors in numerous layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=165343
+
+ Reviewed by Zalan Bujtas.
+
+ * fast/backgrounds/repeat/parsing-background-repeat-expected.txt:
+ * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js:
+ The old parser partially applies shorthands, even if it rejects later on.
+ The new parser properly rejects the entire shorthand. Fix the test so that
+ the numbers at the end are not unitless so that the entire shorthand parses, allowing
+ the components to be obtained.
+
+ * fast/css/unknown-pseudo-element-matching-expected.txt:
+ * fast/css/unknown-pseudo-element-matching.html:
+ * fast/text/crash-complex-text-surrogate.html:
+ The old parser allows the tag name to be omitted following a namespace bar (|). This
+ is not legal according to the namespaces spec, and the new parser behaves correctly.
+ For the crash test, it's important that all the code still runs, so we know the crash
+ doesn't happen, so I patched the test to put in '*' for the tag names to keep everything
+ the same.
+
+ For the unknown-pseudo-element test, I just removed the five invalid cases.
+
+2016-12-02 Dave Hyatt <hyatt@apple.com>
+
</ins><span class="cx"> [CSS Parser] Turn off the large value test, since clamping is not the same.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=165341
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsrepeatparsingbackgroundrepeatexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/backgrounds/repeat/parsing-background-repeat-expected.txt (209278 => 209279)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/repeat/parsing-background-repeat-expected.txt 2016-12-02 23:07:25 UTC (rev 209278)
+++ trunk/LayoutTests/fast/backgrounds/repeat/parsing-background-repeat-expected.txt 2016-12-02 23:07:41 UTC (rev 209279)
</span><span class="lines">@@ -17,8 +17,8 @@
</span><span class="cx"> PASS test("background: purple url(resources/gradient.gif) repeat-y 50% 50%") is "repeat-y"
</span><span class="cx"> PASS test("background: purple url(resources/gradient.gif) repeat center") is "repeat"
</span><span class="cx"> PASS test("background: purple url(resources/gradient.gif) no-repeat 12px") is "no-repeat"
</span><del>-PASS test("background: purple url(resources/gradient.gif) round left 50") is "round"
-PASS test("background: purple url(resources/gradient.gif) space 25 25") is "space"
</del><ins>+PASS test("background: purple url(resources/gradient.gif) round left 50px") is "round"
+PASS test("background: purple url(resources/gradient.gif) space 25px 25px") is "space"
</ins><span class="cx"> PASS test("background-repeat: 45;") is ""
</span><span class="cx"> PASS test("background-repeat: coconut;") is ""
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsrepeatscripttestsparsingbackgroundrepeatjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/backgrounds/repeat/script-tests/parsing-background-repeat.js (209278 => 209279)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/backgrounds/repeat/script-tests/parsing-background-repeat.js 2016-12-02 23:07:25 UTC (rev 209278)
+++ trunk/LayoutTests/fast/backgrounds/repeat/script-tests/parsing-background-repeat.js 2016-12-02 23:07:41 UTC (rev 209279)
</span><span class="lines">@@ -27,8 +27,8 @@
</span><span class="cx"> shouldBe('test("background: purple url(resources/gradient.gif) repeat-y 50% 50%")', '"repeat-y"');
</span><span class="cx"> shouldBe('test("background: purple url(resources/gradient.gif) repeat center")', '"repeat"');
</span><span class="cx"> shouldBe('test("background: purple url(resources/gradient.gif) no-repeat 12px")', '"no-repeat"');
</span><del>-shouldBe('test("background: purple url(resources/gradient.gif) round left 50")', '"round"');
-shouldBe('test("background: purple url(resources/gradient.gif) space 25 25")', '"space"');
</del><ins>+shouldBe('test("background: purple url(resources/gradient.gif) round left 50px")', '"round"');
+shouldBe('test("background: purple url(resources/gradient.gif) space 25px 25px")', '"space"');
</ins><span class="cx">
</span><span class="cx"> shouldBe('test("background-repeat: 45;")', '""');
</span><span class="cx"> shouldBe('test("background-repeat: coconut;")', '""');
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssunknownpseudoelementmatchingexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/unknown-pseudo-element-matching-expected.txt (209278 => 209279)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/unknown-pseudo-element-matching-expected.txt 2016-12-02 23:07:25 UTC (rev 209278)
+++ trunk/LayoutTests/fast/css/unknown-pseudo-element-matching-expected.txt 2016-12-02 23:07:41 UTC (rev 209279)
</span><span class="lines">@@ -4,17 +4,12 @@
</span><span class="cx"> ::-webkit-slider-thumb should match: PASS
</span><span class="cx"> *::-webkit-slider-thumb should match: PASS
</span><span class="cx"> ::-webkit-slider-thumb, where HTML is not default namespace should not match: PASS
</span><del>-*|::-webkit-slider-thumb, where HTML is not default namespace should match: PASS
</del><span class="cx"> *|*::-webkit-slider-thumb, where HTML is not default namespace should match: PASS
</span><del>-html|::-webkit-slider-thumb, where HTML is not default namespace should match: PASS
</del><span class="cx"> html|*::-webkit-slider-thumb, where HTML is not default namespace should match: PASS
</span><span class="cx"> #foo::-webkit-slider-thumb should match: PASS
</span><span class="cx"> .bar::-webkit-slider-thumb should match: PASS
</span><span class="cx"> #foo::-webkit-slider-thumb, where HTML is not default namespace should not match: PASS
</span><span class="cx"> .bar::-webkit-slider-thumb, where HTML is not default namespace should not match: PASS
</span><del>-html|#foo::-webkit-slider-thumb, where HTML is not default namespace should match: PASS
-html|.bar::-webkit-slider-thumb, where HTML is not default namespace should match: PASS
-*|#foo::-webkit-slider-thumb, where HTML is not default namespace should match: PASS
</del><span class="cx"> input::-webkit-slider-thumb should match: PASS
</span><span class="cx"> input#foo::-webkit-slider-thumb should match: PASS
</span><span class="cx"> input.bar::-webkit-slider-thumb should match: PASS
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssunknownpseudoelementmatchinghtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/unknown-pseudo-element-matching.html (209278 => 209279)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/unknown-pseudo-element-matching.html 2016-12-02 23:07:25 UTC (rev 209278)
+++ trunk/LayoutTests/fast/css/unknown-pseudo-element-matching.html 2016-12-02 23:07:41 UTC (rev 209279)
</span><span class="lines">@@ -75,17 +75,12 @@
</span><span class="cx"> runSelectorTest(MATCH, '::-webkit-slider-thumb');
</span><span class="cx"> runSelectorTest(MATCH, '*::-webkit-slider-thumb');
</span><span class="cx"> runSelectorTest(NO_MATCH, '::-webkit-slider-thumb', WITH_NAMESPACES);
</span><del>- runSelectorTest(MATCH, '*|::-webkit-slider-thumb', WITH_NAMESPACES);
</del><span class="cx"> runSelectorTest(MATCH, '*|*::-webkit-slider-thumb', WITH_NAMESPACES);
</span><del>- runSelectorTest(MATCH, 'html|::-webkit-slider-thumb', WITH_NAMESPACES);
</del><span class="cx"> runSelectorTest(MATCH, 'html|*::-webkit-slider-thumb', WITH_NAMESPACES);
</span><span class="cx"> runSelectorTest(MATCH, '#foo::-webkit-slider-thumb');
</span><span class="cx"> runSelectorTest(MATCH, '.bar::-webkit-slider-thumb');
</span><span class="cx"> runSelectorTest(NO_MATCH, '#foo::-webkit-slider-thumb', WITH_NAMESPACES);
</span><span class="cx"> runSelectorTest(NO_MATCH, '.bar::-webkit-slider-thumb', WITH_NAMESPACES);
</span><del>- runSelectorTest(MATCH, 'html|#foo::-webkit-slider-thumb', WITH_NAMESPACES);
- runSelectorTest(MATCH, 'html|.bar::-webkit-slider-thumb', WITH_NAMESPACES);
- runSelectorTest(MATCH, '*|#foo::-webkit-slider-thumb', WITH_NAMESPACES);
</del><span class="cx"> runSelectorTest(MATCH, 'input::-webkit-slider-thumb');
</span><span class="cx"> runSelectorTest(MATCH, 'input#foo::-webkit-slider-thumb');
</span><span class="cx"> runSelectorTest(MATCH, 'input.bar::-webkit-slider-thumb');
</span></span></pre></div>
<a id="trunkLayoutTestsfasttextcrashcomplextextsurrogatehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/text/crash-complex-text-surrogate.html (209278 => 209279)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/text/crash-complex-text-surrogate.html 2016-12-02 23:07:25 UTC (rev 209278)
+++ trunk/LayoutTests/fast/text/crash-complex-text-surrogate.html 2016-12-02 23:07:41 UTC (rev 209279)
</span><span class="lines">@@ -75,7 +75,7 @@
</span><span class="cx"> try {
</span><span class="cx"> var scroll_81 = document.createElement("bdo");
</span><span class="cx"> scroll_81.setAttribute("id", "webtest8");
</span><del>-document.querySelector("plaintext:first-of-type ~ *|:out-of-range").insertBefore(scroll_81, document.querySelector("plaintext:first-of-type ~ *|:out-of-range").childNodes[9]);
</del><ins>+document.querySelector("plaintext:first-of-type ~ *|*:out-of-range").insertBefore(scroll_81, document.querySelector("plaintext:first-of-type ~ *|*:out-of-range").childNodes[9]);
</ins><span class="cx"> scroll_81.setAttribute("style", "overflow: scroll");
</span><span class="cx"> scroll_81.scrollLeft = 0;
</span><span class="cx"> scroll_81.scrolltop = 0xffffffff;
</span></span></pre>
</div>
</div>
</body>
</html>