<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209215] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209215">209215</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-12-01 14:48:55 -0800 (Thu, 01 Dec 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Source/WebKit2:
[iOS][WK2] Tapping an element generates a 'click' event that has 0 as timeStamp
https://bugs.webkit.org/show_bug.cgi?id=165270
<rdar://problem/29224355>
Reviewed by Simon Fraser.
Tapping an element generates a 'click' event that has 0 as timeStamp
instead of having a proper timeStamp value. This is breaking some
sites.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::completeSyntheticClick):
LayoutTests:
[iOS] Tapping an element generates a 'click' event that has 0 as timeStamp
https://bugs.webkit.org/show_bug.cgi?id=165270
<rdar://problem/29224355>
Reviewed by Simon Fraser.
Add layout test coverage.
* fast/events/ios/click-event-timestamp-expected.txt: Added.
* fast/events/ios/click-event-timestamp.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageiosWebPageIOSmm">trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasteventsiosclickeventtimestampexpectedtxt">trunk/LayoutTests/fast/events/ios/click-event-timestamp-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsiosclickeventtimestamphtml">trunk/LayoutTests/fast/events/ios/click-event-timestamp.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209214 => 209215)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-12-01 22:36:22 UTC (rev 209214)
+++ trunk/LayoutTests/ChangeLog 2016-12-01 22:48:55 UTC (rev 209215)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-12-01 Chris Dumez <cdumez@apple.com>
+
+ [iOS] Tapping an element generates a 'click' event that has 0 as timeStamp
+ https://bugs.webkit.org/show_bug.cgi?id=165270
+ <rdar://problem/29224355>
+
+ Reviewed by Simon Fraser.
+
+ Add layout test coverage.
+
+ * fast/events/ios/click-event-timestamp-expected.txt: Added.
+ * fast/events/ios/click-event-timestamp.html: Added.
+
</ins><span class="cx"> 2016-12-01 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> [CSS Parser] Fix an invalid shadow DOM test
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsiosclickeventtimestampexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/ios/click-event-timestamp-expected.txt (0 => 209215)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/ios/click-event-timestamp-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/ios/click-event-timestamp-expected.txt 2016-12-01 22:48:55 UTC (rev 209215)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+PASS: click events had increasing timeStamps
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventsiosclickeventtimestamphtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/ios/click-event-timestamp.html (0 => 209215)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/ios/click-event-timestamp.html (rev 0)
+++ trunk/LayoutTests/fast/events/ios/click-event-timestamp.html 2016-12-01 22:48:55 UTC (rev 209215)
</span><span class="lines">@@ -0,0 +1,75 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
+
+<html>
+<head>
+ <meta name="viewport" content="width=device-width">
+ <script id="ui-script" type="text/plain">
+ (function() {
+ uiController.singleTapAtPoint(50, 50, function() {
+ uiController.uiScriptComplete();
+ });
+ })();
+ </script>
+ <script>
+ var uiScriptHasCompleted = false;
+ var boxClickCount = 0;
+ var firstClickEventTimeStamp = 0;
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
+
+ function getUIScript()
+ {
+ return document.getElementById('ui-script').text;
+ }
+
+ function runTest()
+ {
+ if (testRunner.runUIScript) {
+ testRunner.runUIScript(getUIScript(), function() {
+ setTimeout(function() {
+ testRunner.runUIScript(getUIScript(), function() {
+ uiScriptHasCompleted = true;
+ if (boxClickCount == 2)
+ testRunner.notifyDone();
+ });
+ }, 100);
+ });
+ }
+ }
+
+ function boxClicked(event)
+ {
+ boxClickCount++;
+ if (boxClickCount == 1) {
+ document.getElementById('target').textContent = 'FAIL: only received one click event';
+ firstClickEventTimeStamp = event.timeStamp;
+ return;
+ }
+ if (boxClickCount == 2) {
+ if (event.timeStamp > firstClickEventTimeStamp)
+ document.getElementById('target').textContent = 'PASS: click events had increasing timeStamps';
+ else
+ document.getElementById('target').textContent = 'FAIL: click events did not have increasing timeStamps';
+ if (uiScriptHasCompleted && window.testRunner)
+ testRunner.notifyDone();
+ }
+ }
+ </script>
+ <style>
+ #target {
+ height: 100px;
+ width: 100px;
+ background-color: silver;
+ }
+ </style>
+</head>
+<body onload="runTest()">
+
+<div id="target" onclick="boxClicked(event)">
+ FAIL: did not receive click event.
+</div>
+
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (209214 => 209215)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-12-01 22:36:22 UTC (rev 209214)
+++ trunk/Source/WebKit2/ChangeLog 2016-12-01 22:48:55 UTC (rev 209215)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-12-01 Chris Dumez <cdumez@apple.com>
+
+ [iOS][WK2] Tapping an element generates a 'click' event that has 0 as timeStamp
+ https://bugs.webkit.org/show_bug.cgi?id=165270
+ <rdar://problem/29224355>
+
+ Reviewed by Simon Fraser.
+
+ Tapping an element generates a 'click' event that has 0 as timeStamp
+ instead of having a proper timeStamp value. This is breaking some
+ sites.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::handleSyntheticClick):
+ (WebKit::WebPage::completeSyntheticClick):
+
</ins><span class="cx"> 2016-12-01 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Try to fix the EFL/Gtk build
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageiosWebPageIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (209214 => 209215)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2016-12-01 22:36:22 UTC (rev 209214)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2016-12-01 22:48:55 UTC (rev 209215)
</span><span class="lines">@@ -522,7 +522,7 @@
</span><span class="cx">
</span><span class="cx"> WKBeginObservingContentChanges(true);
</span><span class="cx">
</span><del>- mainframe.eventHandler().mouseMoved(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, NoButton, PlatformEvent::MouseMoved, 0, false, false, false, false, 0, WebCore::ForceAtClick, WebCore::NoTap));
</del><ins>+ mainframe.eventHandler().mouseMoved(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, NoButton, PlatformEvent::MouseMoved, 0, false, false, false, false, currentTime(), WebCore::ForceAtClick, WebCore::NoTap));
</ins><span class="cx"> mainframe.document()->updateStyleIfNeeded();
</span><span class="cx">
</span><span class="cx"> WKStopObservingContentChanges();
</span><span class="lines">@@ -569,8 +569,8 @@
</span><span class="cx">
</span><span class="cx"> bool tapWasHandled = false;
</span><span class="cx"> m_lastInteractionLocation = roundedAdjustedPoint;
</span><del>- tapWasHandled |= mainframe.eventHandler().handleMousePressEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MousePressed, 1, false, false, false, false, 0, WebCore::ForceAtClick, syntheticClickType));
- tapWasHandled |= mainframe.eventHandler().handleMouseReleaseEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MouseReleased, 1, false, false, false, false, 0, WebCore::ForceAtClick, syntheticClickType));
</del><ins>+ tapWasHandled |= mainframe.eventHandler().handleMousePressEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MousePressed, 1, false, false, false, false, currentTime(), WebCore::ForceAtClick, syntheticClickType));
+ tapWasHandled |= mainframe.eventHandler().handleMouseReleaseEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MouseReleased, 1, false, false, false, false, currentTime(), WebCore::ForceAtClick, syntheticClickType));
</ins><span class="cx">
</span><span class="cx"> RefPtr<Frame> newFocusedFrame = m_page->focusController().focusedFrame();
</span><span class="cx"> RefPtr<Element> newFocusedElement = newFocusedFrame ? newFocusedFrame->document()->focusedElement() : nullptr;
</span></span></pre>
</div>
</div>
</body>
</html>