<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[209130] trunk</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209130">209130</a></dd>

<dt>Author</dt> <dd>bfulgham@apple.com</dd>

<dt>Date</dt> <dd>2016-11-30 09:03:48 -0800 (Wed, 30 Nov 2016)</dd>

</dl>

<h3>Log Message</h3>

<pre>Use 'childOfType' template when retrieving Shadow DOM elements

https://bugs.webkit.org/show_bug.cgi?id=165145

&lt;rdar://problem/29331830&gt;

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/shadow-dom/color-input-element-shadow-manipulation.html

       fast/shadow-dom/file-input-element-shadow-manipulation.html

       fast/shadow-dom/keygen-shadow-manipulation.html

       fast/shadow-dom/media-shadow-manipulation.html

       fast/shadow-dom/range-input-element-shadow-manipulation.html

       fast/shadow-dom/textarea-shadow-manipulation.html

Switch to using 'childOfType' when retrieving Shadow DOM elements, rather

than relying on expected element positions, as these can be changed by

JavaScript.

Drive by fix: Make more use of is&lt;&gt; and downcast&lt;&gt; templates rather than blindly casting.

* dom/Element.h:

(WebCore::Element::isUploadButton): Added.

(WebCore::Element::isSliderContainerElement): Added.

* html/ColorInputType.cpp:

(WebCore::ColorInputType::shadowColorSwatch): Use 'childOfType' rather than assuming

the first child is the one we want.

* html/FileInputType.cpp:

(isType): Added.

(WebCore::FileInputType::disabledAttributeChanged): Use 'childOfType' rather than assuming

the first child is the one we want.

(WebCore::FileInputType::multipleAttributeChanged): Ditto.

* html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect): Ditto.

* html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaControls): Ditto.

(WebCore::HTMLMediaElement::hasMediaControls): Ditto.

* html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement): Ditto.

* html/RangeInputType.cpp:

(WebCore::RangeInputType::sliderTrackElement): Ditto.

* html/shadow/SliderThumbElement.h:

(isType): Added.

* svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::targetClone): Use 'childOfType' rather than assuming

the first child is the one we want.

LayoutTests:

* fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt: Added.

* fast/shadow-dom/color-input-element-shadow-manipulation.html: Added.

* fast/shadow-dom/file-input-element-shadow-manipulation-expected.txt: Added.

* fast/shadow-dom/file-input-element-shadow-manipulation.html: Added.

* fast/shadow-dom/keygen-shadow-manipulation-expected.txt: Added.

* fast/shadow-dom/keygen-shadow-manipulation.html: Added.

* fast/shadow-dom/media-shadow-manipulation-expected.txt: Added.

* fast/shadow-dom/media-shadow-manipulation.html: Added.

* fast/shadow-dom/range-input-element-shadow-manipulation-expected.txt: Added.

* fast/shadow-dom/range-input-element-shadow-manipulation.html: Added.

* fast/shadow-dom/textarea-shadow-manipulation-expected.txt: Added.

* fast/shadow-dom/textarea-shadow-manipulation.html: Added.</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>

<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>

<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>

<li><a href="#trunkSourceWebCorehtmlColorInputTypecpp">trunk/Source/WebCore/html/ColorInputType.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlFileInputTypecpp">trunk/Source/WebCore/html/FileInputType.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLKeygenElementcpp">trunk/Source/WebCore/html/HTMLKeygenElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementcpp">trunk/Source/WebCore/html/HTMLMediaElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlHTMLTextAreaElementcpp">trunk/Source/WebCore/html/HTMLTextAreaElement.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlRangeInputTypecpp">trunk/Source/WebCore/html/RangeInputType.cpp</a></li>

<li><a href="#trunkSourceWebCorehtmlshadowSliderThumbElementh">trunk/Source/WebCore/html/shadow/SliderThumbElement.h</a></li>

<li><a href="#trunkSourceWebCoresvgSVGUseElementcpp">trunk/Source/WebCore/svg/SVGUseElement.cpp</a></li>

</ul>

<h3>Added Paths</h3>

<ul>

<li><a href="#trunkLayoutTestsfastshadowdomcolorinputelementshadowmanipulationexpectedtxt">trunk/LayoutTests/fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastshadowdomcolorinputelementshadowmanipulationhtml">trunk/LayoutTests/fast/shadow-dom/color-input-element-shadow-manipulation.html</a></li>

<li><a href="#trunkLayoutTestsfastshadowdomfileinputelementshadowmanipulationexpectedtxt">trunk/LayoutTests/fast/shadow-dom/file-input-element-shadow-manipulation-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastshadowdomfileinputelementshadowmanipulationhtml">trunk/LayoutTests/fast/shadow-dom/file-input-element-shadow-manipulation.html</a></li>

<li><a href="#trunkLayoutTestsfastshadowdomkeygenshadowmanipulationexpectedtxt">trunk/LayoutTests/fast/shadow-dom/keygen-shadow-manipulation-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastshadowdomkeygenshadowmanipulationhtml">trunk/LayoutTests/fast/shadow-dom/keygen-shadow-manipulation.html</a></li>

<li><a href="#trunkLayoutTestsfastshadowdommediashadowmanipulationexpectedtxt">trunk/LayoutTests/fast/shadow-dom/media-shadow-manipulation-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastshadowdommediashadowmanipulationhtml">trunk/LayoutTests/fast/shadow-dom/media-shadow-manipulation.html</a></li>

<li><a href="#trunkLayoutTestsfastshadowdomrangeinputelementshadowmanipulationexpectedtxt">trunk/LayoutTests/fast/shadow-dom/range-input-element-shadow-manipulation-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastshadowdomrangeinputelementshadowmanipulationhtml">trunk/LayoutTests/fast/shadow-dom/range-input-element-shadow-manipulation.html</a></li>

<li><a href="#trunkLayoutTestsfastshadowdomtextareashadowmanipulationexpectedtxt">trunk/LayoutTests/fast/shadow-dom/textarea-shadow-manipulation-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastshadowdomtextareashadowmanipulationhtml">trunk/LayoutTests/fast/shadow-dom/textarea-shadow-manipulation.html</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkLayoutTestsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (209129 => 209130)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/ChangeLog        2016-11-30 16:59:11 UTC (rev 209129)

+++ trunk/LayoutTests/ChangeLog        2016-11-30 17:03:48 UTC (rev 209130)

</span><span class="lines">@@ -1,3 +1,24 @@

</span><ins>+2016-11-29  Brent Fulgham  &lt;bfulgham@apple.com&gt;

+

+        Use 'childOfType' template when retrieving Shadow DOM elements

+        https://bugs.webkit.org/show_bug.cgi?id=165145

+        &lt;rdar://problem/29331830&gt;

+

+        Reviewed by Antti Koivisto.

+

+        * fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt: Added.

+        * fast/shadow-dom/color-input-element-shadow-manipulation.html: Added.

+        * fast/shadow-dom/file-input-element-shadow-manipulation-expected.txt: Added.

+        * fast/shadow-dom/file-input-element-shadow-manipulation.html: Added.

+        * fast/shadow-dom/keygen-shadow-manipulation-expected.txt: Added.

+        * fast/shadow-dom/keygen-shadow-manipulation.html: Added.

+        * fast/shadow-dom/media-shadow-manipulation-expected.txt: Added.

+        * fast/shadow-dom/media-shadow-manipulation.html: Added.

+        * fast/shadow-dom/range-input-element-shadow-manipulation-expected.txt: Added.

+        * fast/shadow-dom/range-input-element-shadow-manipulation.html: Added.

+        * fast/shadow-dom/textarea-shadow-manipulation-expected.txt: Added.

+        * fast/shadow-dom/textarea-shadow-manipulation.html: Added.

+

</ins><span class="cx"> 2016-11-30  Dave Hyatt  &lt;hyatt@apple.com&gt;

</span><span class="cx"> 

</span><span class="cx">         [CSS Parser] Mark a bunch of tests as able to fail

</span></span></pre></div>

<a id="trunkLayoutTestsfastshadowdomcolorinputelementshadowmanipulationexpectedtxt"></a>

<div class="addfile"><h4>Added: trunk/LayoutTests/fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt (0 => 209130)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt                                (rev 0)

+++ trunk/LayoutTests/fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt        2016-11-30 17:03:48 UTC (rev 209130)

</span><span class="lines">@@ -0,0 +1,5 @@