<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209165] trunk/JSTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209165">209165</a></dd>
<dt>Author</dt> <dd>jfbastien@apple.com</dd>
<dt>Date</dt> <dd>2016-11-30 17:03:02 -0800 (Wed, 30 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>WebAssembly builder: don't throw when checker not implemented
https://bugs.webkit.org/show_bug.cgi?id=165219
Reviewed by Mark Lam.
We should perform whichever checks we've implemented, and assume the rest are OK until bug #163421 is fixed.
* wasm/Builder.js:
* wasm/README.md:
* wasm/function-tests/add-12.js:
* wasm/function-tests/br-if-loop-less-than.js:
* wasm/function-tests/brTableAsIf.js:
* wasm/function-tests/brTableManyValues.js:
* wasm/function-tests/brTableWithLoop.js:
* wasm/function-tests/dumb-eq-if-then-else.js:
* wasm/function-tests/dumb-less-than-fallthrough.js:
* wasm/function-tests/dumb-less-than-ite.js:
* wasm/function-tests/eqz.js:
* wasm/function-tests/factorial.js:
* wasm/function-tests/float-sub.js:
* wasm/function-tests/i32-load.js:
* wasm/function-tests/i32-load8-s.js:
* wasm/function-tests/if-then-else-fallthrough.js:
* wasm/function-tests/if-then-fallthrough.js:
* wasm/function-tests/loop-mult.js:
* wasm/function-tests/loop-sum.js:
* wasm/function-tests/max.js:
* wasm/function-tests/min.js:
* wasm/function-tests/ret5.js:
* wasm/function-tests/select.js:
* wasm/self-test/test_BuilderJSON.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkJSTestswasmBuilderjs">trunk/JSTests/wasm/Builder.js</a></li>
<li><a href="#trunkJSTestswasmREADMEmd">trunk/JSTests/wasm/README.md</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsadd12js">trunk/JSTests/wasm/function-tests/add-12.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsbriflooplessthanjs">trunk/JSTests/wasm/function-tests/br-if-loop-less-than.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsbrTableAsIfjs">trunk/JSTests/wasm/function-tests/brTableAsIf.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsbrTableManyValuesjs">trunk/JSTests/wasm/function-tests/brTableManyValues.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsbrTableWithLoopjs">trunk/JSTests/wasm/function-tests/brTableWithLoop.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsdumbeqifthenelsejs">trunk/JSTests/wasm/function-tests/dumb-eq-if-then-else.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsdumblessthanfallthroughjs">trunk/JSTests/wasm/function-tests/dumb-less-than-fallthrough.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsdumblessthanitejs">trunk/JSTests/wasm/function-tests/dumb-less-than-ite.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestseqzjs">trunk/JSTests/wasm/function-tests/eqz.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsfactorialjs">trunk/JSTests/wasm/function-tests/factorial.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsfloatsubjs">trunk/JSTests/wasm/function-tests/float-sub.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsi32loadjs">trunk/JSTests/wasm/function-tests/i32-load.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsi32load8sjs">trunk/JSTests/wasm/function-tests/i32-load8-s.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsifthenelsefallthroughjs">trunk/JSTests/wasm/function-tests/if-then-else-fallthrough.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsifthenfallthroughjs">trunk/JSTests/wasm/function-tests/if-then-fallthrough.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsloopmultjs">trunk/JSTests/wasm/function-tests/loop-mult.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsloopsumjs">trunk/JSTests/wasm/function-tests/loop-sum.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsmaxjs">trunk/JSTests/wasm/function-tests/max.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsminjs">trunk/JSTests/wasm/function-tests/min.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsret5js">trunk/JSTests/wasm/function-tests/ret5.js</a></li>
<li><a href="#trunkJSTestswasmfunctiontestsselectjs">trunk/JSTests/wasm/function-tests/select.js</a></li>
<li><a href="#trunkJSTestswasmselftesttest_BuilderJSONjs">trunk/JSTests/wasm/self-test/test_BuilderJSON.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/ChangeLog 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,3 +1,37 @@
</span><ins>+2016-11-30 JF Bastien <jfbastien@apple.com>
+
+ WebAssembly builder: don't throw when checker not implemented
+ https://bugs.webkit.org/show_bug.cgi?id=165219
+
+ Reviewed by Mark Lam.
+
+ We should perform whichever checks we've implemented, and assume the rest are OK until bug #163421 is fixed.
+
+ * wasm/Builder.js:
+ * wasm/README.md:
+ * wasm/function-tests/add-12.js:
+ * wasm/function-tests/br-if-loop-less-than.js:
+ * wasm/function-tests/brTableAsIf.js:
+ * wasm/function-tests/brTableManyValues.js:
+ * wasm/function-tests/brTableWithLoop.js:
+ * wasm/function-tests/dumb-eq-if-then-else.js:
+ * wasm/function-tests/dumb-less-than-fallthrough.js:
+ * wasm/function-tests/dumb-less-than-ite.js:
+ * wasm/function-tests/eqz.js:
+ * wasm/function-tests/factorial.js:
+ * wasm/function-tests/float-sub.js:
+ * wasm/function-tests/i32-load.js:
+ * wasm/function-tests/i32-load8-s.js:
+ * wasm/function-tests/if-then-else-fallthrough.js:
+ * wasm/function-tests/if-then-fallthrough.js:
+ * wasm/function-tests/loop-mult.js:
+ * wasm/function-tests/loop-sum.js:
+ * wasm/function-tests/max.js:
+ * wasm/function-tests/min.js:
+ * wasm/function-tests/ret5.js:
+ * wasm/function-tests/select.js:
+ * wasm/self-test/test_BuilderJSON.js:
+
</ins><span class="cx"> 2016-11-29 JF Bastien <jfbastien@apple.com>
</span><span class="cx">
</span><span class="cx"> WebAssembly JS API: improve Instance
</span></span></pre></div>
<a id="trunkJSTestswasmBuilderjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/Builder.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/Builder.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/Builder.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -190,13 +190,17 @@
</span><span class="cx"> case "prev": break; // FIXME implement prev, checking for whetever the parameter type was. https://bugs.webkit.org/show_bug.cgi?id=163421
</span><span class="cx"> case "size": break; // FIXME implement size. https://bugs.webkit.org/show_bug.cgi?id=163421
</span><span class="cx"> default: throw new Error(`Implementation problem: unhandled meta-type "${expect}" on "${op}"`);
</span><del>- }
</del><ins>+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> const _checkImms = (op, imms, expectedImms, ret) => {
</span><del>- assert.eq(imms.length, expectedImms.length, `"${op}" expects ${expectedImms.length} immediates, got ${imms.length}`);
</del><ins>+ const minExpectedImms = expectedImms.filter(i => i.type.slice(-1) !== '*').length;
+ if (minExpectedImms !== expectedImms.length)
+ assert.ge(imms.length, minExpectedImms, `"${op}" expects at least ${minExpectedImms} immediate${minExpectedImms !== 1 ? 's' : ''}, got ${imms.length}`);
+ else
+ assert.eq(imms.length, minExpectedImms, `"${op}" expects exactly ${minExpectedImms} immediate${minExpectedImms !== 1 ? 's' : ''}, got ${imms.length}`);
</ins><span class="cx"> for (let idx = 0; idx !== expectedImms.length; ++idx) {
</span><span class="cx"> const got = imms[idx];
</span><span class="cx"> const expect = expectedImms[idx];
</span><span class="lines">@@ -205,23 +209,23 @@
</span><span class="cx"> assert.truthy(_isValidValue(got, "i32"), `Invalid value on ${op}: got "${got}", expected i32`);
</span><span class="cx"> // FIXME check function indices. https://bugs.webkit.org/show_bug.cgi?id=163421
</span><span class="cx"> break;
</span><del>- case "local_index": throw new Error(`Unimplemented: "${expect.name}" on "${op}"`);
- case "global_index": throw new Error(`Unimplemented: "${expect.name}" on "${op}"`);
- case "type_index": throw new Error(`Unimplemented: "${expect.name}" on "${op}"`);
</del><ins>+ case "local_index": break; // improve checking https://bugs.webkit.org/show_bug.cgi?id=163421
+ case "global_index": break; // improve checking https://bugs.webkit.org/show_bug.cgi?id=163421
+ case "type_index": break; // improve checking https://bugs.webkit.org/show_bug.cgi?id=163421
</ins><span class="cx"> case "value":
</span><span class="cx"> assert.truthy(_isValidValue(got, ret[0]), `Invalid value on ${op}: got "${got}", expected ${ret[0]}`);
</span><span class="cx"> break;
</span><del>- case "flags": throw new Error(`Unimplemented: "${expect.name}" on "${op}"`);
- case "offset": throw new Error(`Unimplemented: "${expect.name}" on "${op}"`);
</del><ins>+ case "flags": break; // improve checking https://bugs.webkit.org/show_bug.cgi?id=163421
+ case "offset": break; // improve checking https://bugs.webkit.org/show_bug.cgi?id=163421
</ins><span class="cx"> // Control:
</span><del>- case "default_target": throw new Error(`Unimplemented: "${expect.name}" on "${op}"`);
- case "relative_depth": throw new Error(`Unimplemented: "${expect.name}" on "${op}"`);
</del><ins>+ case "default_target": break; // improve checking https://bugs.webkit.org/show_bug.cgi?id=163421
+ case "relative_depth": break; // improve checking https://bugs.webkit.org/show_bug.cgi?id=163421
</ins><span class="cx"> case "sig":
</span><span class="cx"> // FIXME this should be isValidBlockType https://bugs.webkit.org/show_bug.cgi?id=164724
</span><del>- assert.truthy(WASM.isValidValueType(imms[idx]), `Invalid block type on ${op}: "${imms[idx]}"`);
</del><ins>+ assert.truthy(imms[idx] === "void" || WASM.isValidValueType(imms[idx]), `Invalid block type on ${op}: "${imms[idx]}"`);
</ins><span class="cx"> break;
</span><del>- case "target_count": throw new Error(`Unimplemented: "${expect.name}" on "${op}"`);
- case "target_table": throw new Error(`Unimplemented: "${expect.name}" on "${op}"`);
</del><ins>+ case "target_count": break; // improve checking https://bugs.webkit.org/show_bug.cgi?id=163421
+ case "target_table": break; // improve checking https://bugs.webkit.org/show_bug.cgi?id=163421
</ins><span class="cx"> default: throw new Error(`Implementation problem: unhandled immediate "${expect.name}" on "${op}"`);
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkJSTestswasmREADMEmd"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/README.md (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/README.md 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/README.md 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -35,7 +35,6 @@
</span><span class="cx">
</span><span class="cx"> // Construct the equivalent of: (module (func "answer" (i32.const 42) (return)))
</span><span class="cx"> builder
</span><del>- .setChecked(false) // FIXME remove once checking is better implemented.
</del><span class="cx"> // Declare a Type section, which the builder will auto-fill as functions are defined.
</span><span class="cx"> .Type().End()
</span><span class="cx"> // Declare a Function section, which the builder will auto-fill as functions are defined.
</span></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsadd12js"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/add-12.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/add-12.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/add-12.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsbriflooplessthanjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/br-if-loop-less-than.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/br-if-loop-less-than.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/br-if-loop-less-than.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -48,4 +47,4 @@
</span><span class="cx"> [{type: "i32", value: 0 }, [{ type: "i32", value: 1 }, { type: "i32", value: 1 }]],
</span><span class="cx"> [{type: "i32", value: 1 }, [{ type: "i32", value: 2 }, { type: "i32", value: 6 }]],
</span><span class="cx"> [{type: "i32", value: 0 }, [{ type: "i32", value: 100 }, { type: "i32", value: 6 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsbrTableAsIfjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/brTableAsIf.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/brTableAsIf.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/brTableAsIf.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -23,4 +22,4 @@
</span><span class="cx"> [{type: "i32", value: 20 }, [{ type: "i32", value: 1 }]],
</span><span class="cx"> [{type: "i32", value: 20 }, [{ type: "i32", value: 11 }]],
</span><span class="cx"> [{type: "i32", value: 20 }, [{ type: "i32", value: -100 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsbrTableManyValuesjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/brTableManyValues.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/brTableManyValues.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/brTableManyValues.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -40,4 +39,4 @@
</span><span class="cx"> [{type: "i32", value: 214 }, [{ type: "i32", value: 5 }]],
</span><span class="cx"> [{type: "i32", value: 214 }, [{ type: "i32", value: -1 }]],
</span><span class="cx"> [{type: "i32", value: 214 }, [{ type: "i32", value: -1000 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsbrTableWithLoopjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/brTableWithLoop.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/brTableWithLoop.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/brTableWithLoop.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -27,4 +26,4 @@
</span><span class="cx"> bin.trim();
</span><span class="cx"> testWasmModuleFunctions(bin.get(), 1, [[{type: "i32", value: 1 }, [{ type: "i32", value: 0 }]],
</span><span class="cx"> [{type: "i32", value: 2 }, [{ type: "i32", value: 1 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsdumbeqifthenelsejs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/dumb-eq-if-then-else.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/dumb-eq-if-then-else.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/dumb-eq-if-then-else.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Memory().InitialMaxPages(1, 1).End()
</span><span class="lines">@@ -31,4 +30,4 @@
</span><span class="cx"> [{type: "i32", value: 0 }, [{ type: "i32", value: 0 }, { type: "i32", value: 0 }]],
</span><span class="cx"> [{type: "i32", value: 1 }, [{ type: "i32", value: 2 }, { type: "i32", value: 6 }]],
</span><span class="cx"> [{type: "i32", value: 1 }, [{ type: "i32", value: 100 }, { type: "i32", value: 6 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsdumblessthanfallthroughjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/dumb-less-than-fallthrough.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/dumb-less-than-fallthrough.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/dumb-less-than-fallthrough.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -36,4 +35,4 @@
</span><span class="cx"> [{type: "i32", value: 0 }, [{ type: "i32", value: 1 }, { type: "i32", value: 1 }]],
</span><span class="cx"> [{type: "i32", value: 1 }, [{ type: "i32", value: 2 }, { type: "i32", value: 6 }]],
</span><span class="cx"> [{type: "i32", value: 0 }, [{ type: "i32", value: 100 }, { type: "i32", value: 6 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsdumblessthanitejs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/dumb-less-than-ite.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/dumb-less-than-ite.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/dumb-less-than-ite.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -42,4 +41,4 @@
</span><span class="cx"> [{type: "i32", value: 0 }, [{ type: "i32", value: 0 }, { type: "i32", value: 0 }]],
</span><span class="cx"> [{type: "i32", value: 1 }, [{ type: "i32", value: 2 }, { type: "i32", value: 6 }]],
</span><span class="cx"> [{type: "i32", value: 0 }, [{ type: "i32", value: 100 }, { type: "i32", value: 6 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestseqzjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/eqz.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/eqz.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/eqz.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Memory().InitialMaxPages(1, 1).End()
</span></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsfactorialjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/factorial.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/factorial.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/factorial.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -28,4 +27,4 @@
</span><span class="cx"> [{type: "i32", value: 1 }, [{ type: "i32", value: 1 }]],
</span><span class="cx"> [{type: "i32", value: 2 }, [{ type: "i32", value: 2 }]],
</span><span class="cx"> [{type: "i32", value: 24 }, [{ type: "i32", value: 4 }]],
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsfloatsubjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/float-sub.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/float-sub.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/float-sub.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -28,4 +27,4 @@
</span><span class="cx"> [[{type: "f32", value: -1.5 }, [{ type: "f32", value: 0 }, { type: "f32", value: 1.5 }]],
</span><span class="cx"> [{type: "f32", value: 87.6234 }, [{ type: "f32", value: 100.1234 }, { type: "f32", value: 12.5 }]]
</span><span class="cx"> ]
</span><del>- );
</del><span class="cx">\ No newline at end of file
</span><ins>+ );
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsi32loadjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/i32-load.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/i32-load.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/i32-load.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Memory().InitialMaxPages(1, 1).End()
</span><span class="lines">@@ -20,4 +19,4 @@
</span><span class="cx"> testWasmModuleFunctions(bin.get(), 1, [[{type: "i32", value: 0 }, [{ type: "i32", value: 0 }, { type: "i32", value: 10 }]],
</span><span class="cx"> [{type: "i32", value: 100 }, [{ type: "i32", value: 100 }, { type: "i32", value: 112 }]],
</span><span class="cx"> [{type: "i32", value: 1000000 }, [{ type: "i32", value: 1000000 }, { type: "i32", value: 10 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsi32load8sjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/i32-load8-s.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/i32-load8-s.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/i32-load8-s.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Memory().InitialMaxPages(1, 1).End()
</span><span class="lines">@@ -20,4 +19,4 @@
</span><span class="cx"> testWasmModuleFunctions(bin.get(), 1, [[{type: "i32", value: 0 }, [{ type: "i32", value: 0 }, { type: "i32", value: 10 }]],
</span><span class="cx"> [{type: "i32", value: 100 }, [{ type: "i32", value: 100 }, { type: "i32", value: 112 }]],
</span><span class="cx"> [{type: "i32", value: 0x40 }, [{ type: "i32", value: 1000000 }, { type: "i32", value: 10 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsifthenelsefallthroughjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/if-then-else-fallthrough.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/if-then-else-fallthrough.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/if-then-else-fallthrough.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -22,4 +21,4 @@
</span><span class="cx"> bin.trim();
</span><span class="cx"> testWasmModuleFunctions(bin.get(), 1, [[{type: "i32", value: 1 }, [{ type: "i32", value: 0 }]],
</span><span class="cx"> [{type: "i32", value: 2 }, [{ type: "i32", value: 1 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsifthenfallthroughjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/if-then-fallthrough.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/if-then-fallthrough.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/if-then-fallthrough.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -22,4 +21,4 @@
</span><span class="cx"> bin.trim();
</span><span class="cx"> testWasmModuleFunctions(bin.get(), 1, [[{type: "i32", value: 1 }, [{ type: "i32", value: 0 }]],
</span><span class="cx"> [{type: "i32", value: 2 }, [{ type: "i32", value: 1 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsloopmultjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/loop-mult.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/loop-mult.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/loop-mult.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -35,4 +34,4 @@
</span><span class="cx"> [{type: "i32", value: 1 }, [{ type: "i32", value: 1 }]],
</span><span class="cx"> [{type: "i32", value: 3 }, [{ type: "i32", value: 2 }]],
</span><span class="cx"> [{type: "i32", value: 5050 }, [{ type: "i32", value: 100 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsloopsumjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/loop-sum.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/loop-sum.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/loop-sum.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span><span class="lines">@@ -35,4 +34,4 @@
</span><span class="cx"> [{type: "i32", value: 1 }, [{ type: "i32", value: 1 }]],
</span><span class="cx"> [{type: "i32", value: 3 }, [{ type: "i32", value: 2 }]],
</span><span class="cx"> [{type: "i32", value: 5050 }, [{ type: "i32", value: 100 }]]
</span><del>- ]);
</del><span class="cx">\ No newline at end of file
</span><ins>+ ]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsmaxjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/max.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/max.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/max.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Memory().InitialMaxPages(1, 1).End()
</span></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsminjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/min.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/min.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/min.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Memory().InitialMaxPages(1, 1).End()
</span></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsret5js"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/ret5.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/ret5.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/ret5.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> let code = b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code();
</span><span class="lines">@@ -13,4 +12,4 @@
</span><span class="cx"> .End();
</span><span class="cx"> const bin = b.WebAssembly();
</span><span class="cx"> bin.trim();
</span><del>-testWasmModuleFunctions(bin.get(), 1, [[{type: "i32", value: 5 }, []]]);
</del><span class="cx">\ No newline at end of file
</span><ins>+testWasmModuleFunctions(bin.get(), 1, [[{type: "i32", value: 5 }, []]]);
</ins></span></pre></div>
<a id="trunkJSTestswasmfunctiontestsselectjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/function-tests/select.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/function-tests/select.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/function-tests/select.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -1,7 +1,6 @@
</span><span class="cx"> import Builder from '../Builder.js'
</span><span class="cx">
</span><span class="cx"> const b = new Builder();
</span><del>-b.setChecked(false);
</del><span class="cx"> b.Type().End()
</span><span class="cx"> .Function().End()
</span><span class="cx"> .Code()
</span></span></pre></div>
<a id="trunkJSTestswasmselftesttest_BuilderJSONjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/wasm/self-test/test_BuilderJSON.js (209164 => 209165)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/wasm/self-test/test_BuilderJSON.js 2016-12-01 00:28:04 UTC (rev 209164)
+++ trunk/JSTests/wasm/self-test/test_BuilderJSON.js 2016-12-01 01:03:02 UTC (rev 209165)
</span><span class="lines">@@ -403,7 +403,7 @@
</span><span class="cx"> })();
</span><span class="cx">
</span><span class="cx"> (function CheckedOpcodeArgumentsTooMany() {
</span><del>- assertOpThrows(f => f.Nop("uh-oh!"), `Not the same: "1" and "0": "nop" expects 0 immediates, got 1`);
</del><ins>+ assertOpThrows(f => f.Nop("uh-oh!"), `Not the same: "1" and "0": "nop" expects exactly 0 immediates, got 1`);
</ins><span class="cx"> })();
</span><span class="cx">
</span><span class="cx"> (function UncheckedOpcodeArgumentsTooMany() {
</span><span class="lines">@@ -411,7 +411,7 @@
</span><span class="cx"> })();
</span><span class="cx">
</span><span class="cx"> (function CheckedOpcodeArgumentsNotEnough() {
</span><del>- assertOpThrows(f => f.I32Const(), `Not the same: "0" and "1": "i32.const" expects 1 immediates, got 0`);
</del><ins>+ assertOpThrows(f => f.I32Const(), `Not the same: "0" and "1": "i32.const" expects exactly 1 immediate, got 0`);
</ins><span class="cx"> })();
</span><span class="cx">
</span><span class="cx"> (function UncheckedOpcodeArgumentsNotEnough() {
</span></span></pre>
</div>
</div>
</body>
</html>