<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[209088] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/209088">209088</a></dd>
<dt>Author</dt> <dd>aestes@apple.com</dd>
<dt>Date</dt> <dd>2016-11-29 13:36:51 -0800 (Tue, 29 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Cocoa] Enable two clang warnings recommended by Xcode
https://bugs.webkit.org/show_bug.cgi?id=164498
Reviewed by Mark Lam.
Source/bmalloc:
* Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
Source/JavaScriptCore:
* Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
Source/WebCore:
* Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
Source/WebKit/mac:
* Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
Source/WebKit2:
* Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
Source/WTF:
* Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
Tools:
* DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
* MiniBrowser/Configurations/Base.xcconfig: Ditto.
* TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
* WebKitTestRunner/Configurations/Base.xcconfig: Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreConfigurationsBasexcconfig">trunk/Source/JavaScriptCore/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFConfigurationsBasexcconfig">trunk/Source/WTF/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreConfigurationsBasexcconfig">trunk/Source/WebCore/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacConfigurationsBasexcconfig">trunk/Source/WebKit/mac/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2ConfigurationsBasexcconfig">trunk/Source/WebKit2/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkSourcebmallocChangeLog">trunk/Source/bmalloc/ChangeLog</a></li>
<li><a href="#trunkSourcebmallocConfigurationsBasexcconfig">trunk/Source/bmalloc/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreemacConfigurationsBasexcconfig">trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkToolsMiniBrowserConfigurationsBasexcconfig">trunk/Tools/MiniBrowser/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkToolsTestWebKitAPIConfigurationsBasexcconfig">trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig</a></li>
<li><a href="#trunkToolsWebKitTestRunnerConfigurationsBasexcconfig">trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-11-29 Andy Estes <aestes@apple.com>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
</ins><span class="cx"> 2016-11-29 Keith Miller <keith_miller@apple.com>
</span><span class="cx">
</span><span class="cx"> Add simple way to implement Wasm ops that require more than one B3 opcode
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/Configurations/Base.xcconfig (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/JavaScriptCore/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -35,7 +35,9 @@
</span><span class="cx"> CLANG_WARN_CXX0X_EXTENSIONS = NO;
</span><span class="cx"> CLANG_WARN_EMPTY_BODY = YES;
</span><span class="cx"> CLANG_WARN_ENUM_CONVERSION = YES;
</span><ins>+CLANG_WARN_INFINITE_RECURSION = YES;
</ins><span class="cx"> CLANG_WARN_INT_CONVERSION = YES;
</span><ins>+CLANG_WARN_SUSPICIOUS_MOVE = YES;
</ins><span class="cx"> CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
</span><span class="cx"> COMBINE_HIDPI_IMAGES = NO;
</span><span class="cx"> DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WTF/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-11-29 Andy Estes <aestes@apple.com>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
</ins><span class="cx"> 2016-11-29 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r209058): API test StringBuilderTest.Equal crashing
</span></span></pre></div>
<a id="trunkSourceWTFConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/Configurations/Base.xcconfig (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WTF/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -35,7 +35,9 @@
</span><span class="cx"> CLANG_WARN_CXX0X_EXTENSIONS = NO;
</span><span class="cx"> CLANG_WARN_EMPTY_BODY = YES;
</span><span class="cx"> CLANG_WARN_ENUM_CONVERSION = YES;
</span><ins>+CLANG_WARN_INFINITE_RECURSION = YES;
</ins><span class="cx"> CLANG_WARN_INT_CONVERSION = YES;
</span><ins>+CLANG_WARN_SUSPICIOUS_MOVE = YES;
</ins><span class="cx"> CLANG_WARN_UNREACHABLE_CODE = YES;
</span><span class="cx"> CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
</span><span class="cx"> COMBINE_HIDPI_IMAGES = NO;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebCore/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-11-29 Andy Estes <aestes@apple.com>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
</ins><span class="cx"> 2016-11-29 Wenson Hsieh <wenson_hsieh@apple.com>
</span><span class="cx">
</span><span class="cx"> Address post-review feedback following r209070 (AppKit momentum scrolling adoption for scroll snapping)
</span></span></pre></div>
<a id="trunkSourceWebCoreConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -35,7 +35,9 @@
</span><span class="cx"> CLANG_WARN_CXX0X_EXTENSIONS = NO;
</span><span class="cx"> CLANG_WARN_EMPTY_BODY = YES;
</span><span class="cx"> CLANG_WARN_ENUM_CONVERSION = YES;
</span><ins>+CLANG_WARN_INFINITE_RECURSION = YES;
</ins><span class="cx"> CLANG_WARN_INT_CONVERSION = YES;
</span><ins>+CLANG_WARN_SUSPICIOUS_MOVE = YES;
</ins><span class="cx"> CLANG_WARN_UNREACHABLE_CODE = YES;
</span><span class="cx"> CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
</span><span class="cx"> GCC_WARN_UNDECLARED_SELECTOR = YES;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-11-29 Andy Estes <aestes@apple.com>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
</ins><span class="cx"> 2016-11-26 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [WTF] Import std::optional reference implementation as WTF::Optional
</span></span></pre></div>
<a id="trunkSourceWebKitmacConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/Configurations/Base.xcconfig (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebKit/mac/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -35,7 +35,9 @@
</span><span class="cx"> CLANG_WARN_CXX0X_EXTENSIONS = NO;
</span><span class="cx"> CLANG_WARN_EMPTY_BODY = YES;
</span><span class="cx"> CLANG_WARN_ENUM_CONVERSION = YES;
</span><ins>+CLANG_WARN_INFINITE_RECURSION = YES;
</ins><span class="cx"> CLANG_WARN_INT_CONVERSION = YES;
</span><ins>+CLANG_WARN_SUSPICIOUS_MOVE = YES;
</ins><span class="cx"> CLANG_WARN_UNREACHABLE_CODE = YES;
</span><span class="cx"> CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
</span><span class="cx"> GCC_WARN_UNDECLARED_SELECTOR = YES;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebKit2/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-11-29 Andy Estes <aestes@apple.com>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
</ins><span class="cx"> 2016-11-29 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
</span></span></pre></div>
<a id="trunkSourceWebKit2ConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Configurations/Base.xcconfig (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/WebKit2/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -35,7 +35,9 @@
</span><span class="cx"> CLANG_WARN_CXX0X_EXTENSIONS = NO;
</span><span class="cx"> CLANG_WARN_EMPTY_BODY = YES;
</span><span class="cx"> CLANG_WARN_ENUM_CONVERSION = YES;
</span><ins>+CLANG_WARN_INFINITE_RECURSION = YES;
</ins><span class="cx"> CLANG_WARN_INT_CONVERSION = YES;
</span><ins>+CLANG_WARN_SUSPICIOUS_MOVE = YES;
</ins><span class="cx"> CLANG_WARN_UNREACHABLE_CODE = YES;
</span><span class="cx"> CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
</span><span class="cx"> COMBINE_HIDPI_IMAGES = NO;
</span></span></pre></div>
<a id="trunkSourcebmallocChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/ChangeLog (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/bmalloc/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-11-29 Andy Estes <aestes@apple.com>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+
</ins><span class="cx"> 2016-11-10 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><span class="cx"> bmalloc threads should have a non-default QoS
</span></span></pre></div>
<a id="trunkSourcebmallocConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/Configurations/Base.xcconfig (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Source/bmalloc/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -35,7 +35,9 @@
</span><span class="cx"> CLANG_WARN_CXX0X_EXTENSIONS = NO;
</span><span class="cx"> CLANG_WARN_EMPTY_BODY = YES;
</span><span class="cx"> CLANG_WARN_ENUM_CONVERSION = YES;
</span><ins>+CLANG_WARN_INFINITE_RECURSION = YES;
</ins><span class="cx"> CLANG_WARN_INT_CONVERSION = YES;
</span><ins>+CLANG_WARN_SUSPICIOUS_MOVE = YES;
</ins><span class="cx"> CLANG_WARN_UNREACHABLE_CODE = YES;
</span><span class="cx"> CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
</span><span class="cx"> DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Tools/ChangeLog 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-11-29 Andy Estes <aestes@apple.com>
+
+ [Cocoa] Enable two clang warnings recommended by Xcode
+ https://bugs.webkit.org/show_bug.cgi?id=164498
+
+ Reviewed by Mark Lam.
+
+ * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
+ * MiniBrowser/Configurations/Base.xcconfig: Ditto.
+ * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
+ * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
+
</ins><span class="cx"> 2016-11-29 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -60,7 +60,9 @@
</span><span class="cx"> CLANG_WARN_CONSTANT_CONVERSION = YES;
</span><span class="cx"> CLANG_WARN_EMPTY_BODY = YES;
</span><span class="cx"> CLANG_WARN_ENUM_CONVERSION = YES;
</span><ins>+CLANG_WARN_INFINITE_RECURSION = YES;
</ins><span class="cx"> CLANG_WARN_INT_CONVERSION = YES;
</span><ins>+CLANG_WARN_SUSPICIOUS_MOVE = YES;
</ins><span class="cx"> CLANG_WARN_UNREACHABLE_CODE = YES;
</span><span class="cx"> GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
</span><span class="cx"> GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
</span></span></pre></div>
<a id="trunkToolsMiniBrowserConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/Configurations/Base.xcconfig (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Tools/MiniBrowser/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -41,7 +41,9 @@
</span><span class="cx"> CLANG_WARN_CONSTANT_CONVERSION = YES;
</span><span class="cx"> CLANG_WARN_EMPTY_BODY = YES;
</span><span class="cx"> CLANG_WARN_ENUM_CONVERSION = YES;
</span><ins>+CLANG_WARN_INFINITE_RECURSION = YES;
</ins><span class="cx"> CLANG_WARN_INT_CONVERSION = YES;
</span><ins>+CLANG_WARN_SUSPICIOUS_MOVE = YES;
</ins><span class="cx"> CLANG_WARN_UNREACHABLE_CODE = YES;
</span><span class="cx"> GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
</span><span class="cx"> GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPIConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -51,7 +51,9 @@
</span><span class="cx"> CLANG_WARN_CONSTANT_CONVERSION = YES;
</span><span class="cx"> CLANG_WARN_EMPTY_BODY = YES;
</span><span class="cx"> CLANG_WARN_ENUM_CONVERSION = YES;
</span><ins>+CLANG_WARN_INFINITE_RECURSION = YES;
</ins><span class="cx"> CLANG_WARN_INT_CONVERSION = YES;
</span><ins>+CLANG_WARN_SUSPICIOUS_MOVE = YES;
</ins><span class="cx"> CLANG_WARN_UNREACHABLE_CODE = YES;
</span><span class="cx"> GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
</span><span class="cx"> GCC_WARN_ABOUT_RETURN_TYPE = YES;
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerConfigurationsBasexcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig (209087 => 209088)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2016-11-29 21:12:26 UTC (rev 209087)
+++ trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2016-11-29 21:36:51 UTC (rev 209088)
</span><span class="lines">@@ -31,6 +31,8 @@
</span><span class="cx"> CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
</span><span class="cx"> CLANG_CXX_LIBRARY = libc++;
</span><span class="cx"> CLANG_WARN_CXX0X_EXTENSIONS = NO;
</span><ins>+CLANG_WARN_INFINITE_RECURSION = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
</ins><span class="cx"> HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include $(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders $(SRCROOT)/../../Source/JavaScriptCore/icu $(NEXT_ROOT)/usr/local/include/WebCoreTestSupport;
</span><span class="cx"> GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) ENABLE_DASHBOARD_SUPPORT;
</span><span class="cx"> DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
</span></span></pre>
</div>
</div>
</body>
</html>