<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208812] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208812">208812</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-11-16 14:28:33 -0800 (Wed, 16 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Micro-optimize AtomicHTMLToken::initializeAttributes()
https://bugs.webkit.org/show_bug.cgi?id=164826
Reviewed by Sam Weinig.
Micro-optimize AtomicHTMLToken::initializeAttributes():
- Use uncheckedAppend() instead of append() since we reserve capacity
before the loop.
- Use a more efficient findAttribute() that only checks the local names
since this function only adds attributes that have to namespace or
prefix.
No new tests, no Web-exposed behavior change.
* html/parser/AtomicHTMLToken.h:
(WebCore::hasAttribute):
(WebCore::AtomicHTMLToken::initializeAttributes):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlparserAtomicHTMLTokenh">trunk/Source/WebCore/html/parser/AtomicHTMLToken.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (208811 => 208812)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-11-16 22:24:45 UTC (rev 208811)
+++ trunk/Source/WebCore/ChangeLog 2016-11-16 22:28:33 UTC (rev 208812)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-11-16 Chris Dumez <cdumez@apple.com>
+
+ Micro-optimize AtomicHTMLToken::initializeAttributes()
+ https://bugs.webkit.org/show_bug.cgi?id=164826
+
+ Reviewed by Sam Weinig.
+
+ Micro-optimize AtomicHTMLToken::initializeAttributes():
+ - Use uncheckedAppend() instead of append() since we reserve capacity
+ before the loop.
+ - Use a more efficient findAttribute() that only checks the local names
+ since this function only adds attributes that have to namespace or
+ prefix.
+
+ No new tests, no Web-exposed behavior change.
+
+ * html/parser/AtomicHTMLToken.h:
+ (WebCore::hasAttribute):
+ (WebCore::AtomicHTMLToken::initializeAttributes):
+
</ins><span class="cx"> 2016-11-16 Beth Dakin <bdakin@apple.com>
</span><span class="cx">
</span><span class="cx"> Another build fix.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserAtomicHTMLTokenh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/AtomicHTMLToken.h (208811 => 208812)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/AtomicHTMLToken.h 2016-11-16 22:24:45 UTC (rev 208811)
+++ trunk/Source/WebCore/html/parser/AtomicHTMLToken.h 2016-11-16 22:28:33 UTC (rev 208812)
</span><span class="lines">@@ -92,6 +92,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> const Attribute* findAttribute(const Vector<Attribute>&, const QualifiedName&);
</span><ins>+bool hasAttribute(const Vector<Attribute>&, const AtomicString& localName);
</ins><span class="cx">
</span><span class="cx"> inline HTMLToken::Type AtomicHTMLToken::type() const
</span><span class="cx"> {
</span><span class="lines">@@ -181,6 +182,15 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+inline bool hasAttribute(const Vector<Attribute>& attributes, const AtomicString& localName)
+{
+ for (auto& attribute : attributes) {
+ if (attribute.localName() == localName)
+ return true;
+ }
+ return false;
+}
+
</ins><span class="cx"> inline void AtomicHTMLToken::initializeAttributes(const HTMLToken::AttributeList& attributes)
</span><span class="cx"> {
</span><span class="cx"> unsigned size = attributes.size();
</span><span class="lines">@@ -192,11 +202,11 @@
</span><span class="cx"> if (attribute.name.isEmpty())
</span><span class="cx"> continue;
</span><span class="cx">
</span><del>- QualifiedName name(nullAtom, AtomicString(attribute.name), nullAtom);
</del><ins>+ AtomicString localName(attribute.name);
</ins><span class="cx">
</span><span class="cx"> // FIXME: This is N^2 for the number of attributes.
</span><del>- if (!findAttribute(m_attributes, name))
- m_attributes.append(Attribute(name, AtomicString(attribute.value)));
</del><ins>+ if (!hasAttribute(m_attributes, localName))
+ m_attributes.uncheckedAppend(Attribute(QualifiedName(nullAtom, localName, nullAtom), AtomicString(attribute.value)));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>