<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208796] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208796">208796</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2016-11-16 10:07:25 -0800 (Wed, 16 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make test sandbox-should-not-persist-on-navigation.html more representative of real-world scenario
https://bugs.webkit.org/show_bug.cgi?id=164752
Reviewed by Brent Fulgham.
Modify the test http-0.9/sandbox-should-not-persist-on-navigation.html so that it loads
a document on a default port using HTTP 0.9 to trigger the HTTP 0.9 sandbox as this
is more representative of a real-world scenario where we want a sandbox to be applied
and is the scenario that is currently covered by our HTTP 0.9 sandbox machinery.
Currently this test makes use of the pre <a href="http://trac.webkit.org/projects/webkit/changeset/208549">r208549</a> behavior where the HTTP 0.9 sandbox
was applied to a document if one of its subresources loaded on a non-default port
using HTTP 0.9 in addition to the behavior where the sandbox is applied to a document
that loads on a default port using HTTP 0.9. Following <a href="http://trac.webkit.org/projects/webkit/changeset/208549">r208549</a> we no longer apply the
sandbox to the document for the former case as this did not improve security much, if
any. The latter case is more representative of a real-world scenario where we want to
apply the sandbox policy and reflects our behavior following <a href="http://trac.webkit.org/projects/webkit/changeset/208549">r208549</a>.
* http/tests/security/http-0.9/resources/nph-sandbox-should-not-persist-on-navigation.pl: Added.
* http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation-expected.txt:
* http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html:
* platform/wk2/TestExpectations: Skip the HTTP-0.9 tests in WebKit2 as it uses internals.registerDefaultPortForProtocol().</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestssecurityhttp09sandboxshouldnotpersistonnavigationexpectedtxt">trunk/LayoutTests/http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestssecurityhttp09sandboxshouldnotpersistonnavigationhtml">trunk/LayoutTests/http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html</a></li>
<li><a href="#trunkLayoutTestsplatformwk2TestExpectations">trunk/LayoutTests/platform/wk2/TestExpectations</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestshttptestssecurityhttp09resourcesnphsandboxshouldnotpersistonnavigationpl">trunk/LayoutTests/http/tests/security/http-0.9/resources/nph-sandbox-should-not-persist-on-navigation.pl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (208795 => 208796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-11-16 18:00:03 UTC (rev 208795)
+++ trunk/LayoutTests/ChangeLog 2016-11-16 18:07:25 UTC (rev 208796)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2016-11-16 Daniel Bates <dabates@apple.com>
+
+ Make test sandbox-should-not-persist-on-navigation.html more representative of real-world scenario
+ https://bugs.webkit.org/show_bug.cgi?id=164752
+
+ Reviewed by Brent Fulgham.
+
+ Modify the test http-0.9/sandbox-should-not-persist-on-navigation.html so that it loads
+ a document on a default port using HTTP 0.9 to trigger the HTTP 0.9 sandbox as this
+ is more representative of a real-world scenario where we want a sandbox to be applied
+ and is the scenario that is currently covered by our HTTP 0.9 sandbox machinery.
+
+ Currently this test makes use of the pre r208549 behavior where the HTTP 0.9 sandbox
+ was applied to a document if one of its subresources loaded on a non-default port
+ using HTTP 0.9 in addition to the behavior where the sandbox is applied to a document
+ that loads on a default port using HTTP 0.9. Following r208549 we no longer apply the
+ sandbox to the document for the former case as this did not improve security much, if
+ any. The latter case is more representative of a real-world scenario where we want to
+ apply the sandbox policy and reflects our behavior following r208549.
+
+ * http/tests/security/http-0.9/resources/nph-sandbox-should-not-persist-on-navigation.pl: Added.
+ * http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation-expected.txt:
+ * http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html:
+ * platform/wk2/TestExpectations: Skip the HTTP-0.9 tests in WebKit2 as it uses internals.registerDefaultPortForProtocol().
+
</ins><span class="cx"> 2016-11-16 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r208770.
</span></span></pre></div>
<a id="trunkLayoutTestshttptestssecurityhttp09resourcesnphsandboxshouldnotpersistonnavigationpl"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/http/tests/security/http-0.9/resources/nph-sandbox-should-not-persist-on-navigation.pl (0 => 208796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/security/http-0.9/resources/nph-sandbox-should-not-persist-on-navigation.pl (rev 0)
+++ trunk/LayoutTests/http/tests/security/http-0.9/resources/nph-sandbox-should-not-persist-on-navigation.pl 2016-11-16 18:07:25 UTC (rev 208796)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+#!/usr/bin/perl
+# This script relies on its nph- filename to invoke the CGI non-parsed-header facility.
+
+print <<'EOF';
+<!DOCTYPE html>
+<html>
+<head>
+<meta http-equiv="refresh" content="0; url=sandbox-should-not-persist-on-navigation.html">
+</head>
+</html>
+EOF
</ins><span class="cx">Property changes on: trunk/LayoutTests/http/tests/security/http-0.9/resources/nph-sandbox-should-not-persist-on-navigation.pl
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<ins>+*
</ins><span class="cx">\ No newline at end of property
</span><a id="trunkLayoutTestshttptestssecurityhttp09sandboxshouldnotpersistonnavigationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation-expected.txt (208795 => 208796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation-expected.txt 2016-11-16 18:00:03 UTC (rev 208795)
+++ trunk/LayoutTests/http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation-expected.txt 2016-11-16 18:07:25 UTC (rev 208796)
</span><span class="lines">@@ -1 +1,7 @@
</span><ins>+CONSOLE MESSAGE: Sandboxing 'http://127.0.0.1:8000/security/http-0.9/resources/nph-sandbox-should-not-persist-on-navigation.pl' because it is using HTTP/0.9.
+
+
+--------
+Frame: '<!--framePath //<!--frame0-->-->'
+--------
</ins><span class="cx"> PASS
</span></span></pre></div>
<a id="trunkLayoutTestshttptestssecurityhttp09sandboxshouldnotpersistonnavigationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html (208795 => 208796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html 2016-11-16 18:00:03 UTC (rev 208795)
+++ trunk/LayoutTests/http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html 2016-11-16 18:07:25 UTC (rev 208796)
</span><span class="lines">@@ -6,15 +6,12 @@
</span><span class="cx"> testRunner.dumpAsText();
</span><span class="cx"> testRunner.dumpChildFramesAsText();
</span><span class="cx"> testRunner.waitUntilDone();
</span><ins>+ if (window.internals)
+ internals.registerDefaultPortForProtocol(8000, "http");
</ins><span class="cx"> }
</span><del>-
-function runTest()
-{
- window.location.href = "resources/sandbox-should-not-persist-on-navigation.html";
-}
</del><span class="cx"> </script>
</span><span class="cx"> </head>
</span><span class="cx"> <body>
</span><del>-<img src="resources/nph-image.pl" onload="runTest()" onerror="runTest()"> <!-- Apply sandbox -->
</del><ins>+<iframe src="resources/nph-sandbox-should-not-persist-on-navigation.pl"></iframe>
</ins><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/wk2/TestExpectations (208795 => 208796)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/wk2/TestExpectations 2016-11-16 18:00:03 UTC (rev 208795)
+++ trunk/LayoutTests/platform/wk2/TestExpectations 2016-11-16 18:07:25 UTC (rev 208796)
</span><span class="lines">@@ -556,6 +556,7 @@
</span><span class="cx"> http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed-ref-test.html
</span><span class="cx"> http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed.html
</span><span class="cx"> http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked.html
</span><ins>+http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html
</ins><span class="cx">
</span><span class="cx"> # WebKitTestRunner doesn't have appleScriptController
</span><span class="cx"> platform/mac/fast/AppleScript/001.html
</span></span></pre>
</div>
</div>
</body>
</html>