<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208837] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208837">208837</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-11-16 20:32:49 -0800 (Wed, 16 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION(<a href="http://trac.webkit.org/projects/webkit/changeset/208082">r208082</a>): 1% Speedometer regression on iOS
https://bugs.webkit.org/show_bug.cgi?id=164852
Reviewed by Chris Dumez.
Source/WebCore:
Temporarily disable CEReactions entirely to recover the regression in Speedometer since
reverting <a href="http://trac.webkit.org/projects/webkit/changeset/208082">r208082</a> wouldn't remove CEReactions from other DOM APIs and if <a href="http://trac.webkit.org/projects/webkit/changeset/208082">r208082</a> was a regression,
then they're likely causing a regression on Speedometer as well.
* dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementReactionStack::ElementQueue::add): Removed the release assert added in <a href="http://trac.webkit.org/projects/webkit/changeset/208785">r208785</a>
since reactions can be inserted into the backup queue while the queue is running.
(WebCore::CustomElementReactionStack::ElementQueue::invokeAll): Ditto.
* dom/CustomElementReactionQueue.h:
(WebCore::CustomElementReactionStack::CustomElementReactionStack): Removed all the code so that this
constructor would be optimized away by clang.
(WebCore::CustomElementReactionStack::~CustomElementReactionStack): Ditto.
LayoutTests:
Add failing test expectations for various custom elements now that CEReactions is not working.
* TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomCustomElementReactionQueuecpp">trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp</a></li>
<li><a href="#trunkSourceWebCoredomCustomElementReactionQueueh">trunk/Source/WebCore/dom/CustomElementReactionQueue.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (208836 => 208837)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-11-17 03:30:09 UTC (rev 208836)
+++ trunk/LayoutTests/ChangeLog 2016-11-17 04:32:49 UTC (rev 208837)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-11-16 Ryosuke Niwa <rniwa@webkit.org>
+
+ REGRESSION(r208082): 1% Speedometer regression on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=164852
+
+ Reviewed by Chris Dumez.
+
+ Add failing test expectations for various custom elements now that CEReactions is not working.
+
+ * TestExpectations:
+
</ins><span class="cx"> 2016-11-16 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (208836 => 208837)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2016-11-17 03:30:09 UTC (rev 208836)
+++ trunk/LayoutTests/TestExpectations 2016-11-17 04:32:49 UTC (rev 208837)
</span><span class="lines">@@ -970,6 +970,46 @@
</span><span class="cx"> imported/blink/http/tests/security/shape-image-cors-disallow-origin.html [ ImageOnlyFailure ]
</span><span class="cx"> imported/blink/http/tests/security/shape-image-cors-port.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><ins>+# Many custom Elements tests are temporarily skipped per https://webkit.org/b/164852
+fast/custom-elements/defined-pseudo-class.html [ Failure ]
+fast/custom-elements/reactions-for-indieui.html [ Failure ]
+fast/custom-elements/reactions-for-webkit-extensions.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/adopted-callback.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/connected-callbacks.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/custom-element-reaction-queue.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/disconnected-callbacks.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reaction-timing.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/Attr.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/CSSStyleDeclaration.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/ChildNode.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/DOMTokenList.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/Document.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/Element.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/HTMLAnchorElement.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/HTMLOptionElement.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/HTMLOptionsCollection.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/HTMLOutputElement.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/HTMLSelectElement.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTableElement.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTableRowElement.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTableSectionElement.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTitleElement.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/NamedNodeMap.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/Node.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/ParentNode.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/Range.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/Selection.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/reactions/ShadowRoot.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/upgrading.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/upgrading/Node-cloneNode.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-enqueue-reactions.html [ Failure ]
+imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html [ Failure ]
+
</ins><span class="cx"> webkit.org/b/163636 media/modern-media-controls/media-controller/media-controller-resize.html [ Pass Failure Timeout ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/163887 svg/as-image/svg-image-with-data-uri-use-data-uri.svg [ Pass Crash ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (208836 => 208837)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-11-17 03:30:09 UTC (rev 208836)
+++ trunk/Source/WebCore/ChangeLog 2016-11-17 04:32:49 UTC (rev 208837)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2016-11-16 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ REGRESSION(r208082): 1% Speedometer regression on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=164852
+
+ Reviewed by Chris Dumez.
+
+ Temporarily disable CEReactions entirely to recover the regression in Speedometer since
+ reverting r208082 wouldn't remove CEReactions from other DOM APIs and if r208082 was a regression,
+ then they're likely causing a regression on Speedometer as well.
+
+ * dom/CustomElementReactionQueue.cpp:
+ (WebCore::CustomElementReactionStack::ElementQueue::add): Removed the release assert added in r208785
+ since reactions can be inserted into the backup queue while the queue is running.
+ (WebCore::CustomElementReactionStack::ElementQueue::invokeAll): Ditto.
+ * dom/CustomElementReactionQueue.h:
+ (WebCore::CustomElementReactionStack::CustomElementReactionStack): Removed all the code so that this
+ constructor would be optimized away by clang.
+ (WebCore::CustomElementReactionStack::~CustomElementReactionStack): Ditto.
+
+2016-11-16 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Fix build on macOS Sierra when WEB_PLAYBACK_CONTROLS_MANAGER is enabled
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=164845
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomCustomElementReactionQueuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp (208836 => 208837)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp 2016-11-17 03:30:09 UTC (rev 208836)
+++ trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp 2016-11-17 04:32:49 UTC (rev 208837)
</span><span class="lines">@@ -205,7 +205,6 @@
</span><span class="cx">
</span><span class="cx"> inline void CustomElementReactionStack::ElementQueue::add(Element& element)
</span><span class="cx"> {
</span><del>- RELEASE_ASSERT(!m_invoking);
</del><span class="cx"> // FIXME: Avoid inserting the same element multiple times.
</span><span class="cx"> m_elements.append(element);
</span><span class="cx"> }
</span><span class="lines">@@ -212,19 +211,13 @@
</span><span class="cx">
</span><span class="cx"> inline void CustomElementReactionStack::ElementQueue::invokeAll()
</span><span class="cx"> {
</span><del>-#if !ASSERT_DISABLED
- RELEASE_ASSERT(!m_invoking);
- TemporaryChange<bool> invoking(m_invoking, true);
-#endif
</del><span class="cx"> Vector<Ref<Element>> elements;
</span><span class="cx"> elements.swap(m_elements);
</span><del>- RELEASE_ASSERT(m_elements.isEmpty());
</del><span class="cx"> for (auto& element : elements) {
</span><span class="cx"> auto* queue = element->reactionQueue();
</span><span class="cx"> ASSERT(queue);
</span><span class="cx"> queue->invokeAll(element.get());
</span><span class="cx"> }
</span><del>- RELEASE_ASSERT(m_elements.isEmpty());
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> CustomElementReactionQueue& CustomElementReactionStack::ensureCurrentQueue(Element& element)
</span></span></pre></div>
<a id="trunkSourceWebCoredomCustomElementReactionQueueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/CustomElementReactionQueue.h (208836 => 208837)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/CustomElementReactionQueue.h 2016-11-17 03:30:09 UTC (rev 208836)
+++ trunk/Source/WebCore/dom/CustomElementReactionQueue.h 2016-11-17 04:32:49 UTC (rev 208837)
</span><span class="lines">@@ -63,16 +63,11 @@
</span><span class="cx"> class CustomElementReactionStack {
</span><span class="cx"> public:
</span><span class="cx"> CustomElementReactionStack()
</span><del>- : m_previousProcessingStack(s_currentProcessingStack)
</del><span class="cx"> {
</span><del>- s_currentProcessingStack = this;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ~CustomElementReactionStack()
</span><span class="cx"> {
</span><del>- if (UNLIKELY(m_queue))
- processQueue();
- s_currentProcessingStack = m_previousProcessingStack;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static CustomElementReactionQueue& ensureCurrentQueue(Element&);
</span><span class="lines">@@ -89,7 +84,6 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> Vector<Ref<Element>> m_elements;
</span><del>- bool m_invoking { false };
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void processQueue();
</span><span class="lines">@@ -98,7 +92,6 @@
</span><span class="cx"> static ElementQueue& backupElementQueue();
</span><span class="cx">
</span><span class="cx"> ElementQueue* m_queue { nullptr };
</span><del>- CustomElementReactionStack* m_previousProcessingStack;
</del><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT static CustomElementReactionStack* s_currentProcessingStack;
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>