<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208688] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208688">208688</a></dd>
<dt>Author</dt> <dd>darin@apple.com</dd>
<dt>Date</dt> <dd>2016-11-14 09:55:57 -0800 (Mon, 14 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove many includes of ExceptionCode.h
https://bugs.webkit.org/show_bug.cgi?id=164706
Reviewed by Alex Christensen.
Source/WebCore:
* Modules/encryptedmedia/CDMPrivateClearKey.cpp: Removed include of ExceptionCode.h.
* Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp: Ditto.
* Modules/fetch/FetchBodyOwner.cpp: Ditto.
* Modules/indexeddb/IDBDatabase.cpp: Added include of ExceptionCode.h.
* Modules/indexeddb/IDBDatabase.h: Removed include of ExceptionCode.h.
* Modules/indexeddb/IDBDatabaseException.cpp: Ditto.
* Modules/indexeddb/IDBIndex.cpp: Added include of ExceptionCode.h.
* Modules/indexeddb/IDBObjectStore.cpp: Ditto.
* Modules/mediastream/MediaConstraintsImpl.cpp: Removed include of ExceptionCode.h.
* Modules/mediastream/MediaDevicesEnumerationRequest.cpp: Ditto.
* Modules/mediastream/MediaDevicesRequest.cpp: Ditto.
* Modules/mediastream/MediaStream.cpp: Ditto.
* Modules/mediastream/MediaStreamTrack.cpp: Ditto.
* Modules/mediastream/RTCDTMFSender.cpp: Ditto.
* Modules/mediastream/RTCDataChannel.cpp: Ditto.
* Modules/mediastream/RTCPeerConnection.cpp: Ditto.
* Modules/notifications/Notification.h: Removed definition of ExceptionCode.
* Modules/streams/ReadableStreamSource.h: Ditto.
* Modules/webaudio/BiquadFilterNode.cpp: Ditto.
* Modules/webaudio/PannerNode.cpp: Removed inclde of ExceptionCode.h.
* Modules/webaudio/WaveShaperNode.cpp: Ditto.
* Modules/webdatabase/Database.cpp:
(WebCore::guidForOriginAndName): Reimplemented using HashMap::ensure.
* Modules/webdatabase/Database.h: Renamed DatabaseGuid to DatabaseGUID and defined
it here instead of a in DatabaseBasicTypes.h; removed that include.
* Modules/webdatabase/DatabaseBasicTypes.h: Removed.
* Modules/webdatabase/DatabaseManager.h: Removed include of DatabaseBasicTypes.h.
* Modules/webdatabase/DatabaseTask.h: Ditto.
* Modules/webdatabase/SQLTransactionBackend.cpp: Removed include of ExceptionCode.h.
* Modules/webdatabase/SQLTransactionBackend.h: Removed include of DatabaseBasicTypes.h.
* WebCore.xcodeproj/project.pbxproj: Removed DatabaseBasicTypes.h, also let Xcode
edit the file.
* bindings/js/ScriptModuleLoader.cpp: Removed include of ExceptionCode.h.
* bindings/js/SerializedScriptValue.cpp: Ditto.
* bindings/js/StructuredClone.cpp: Ditto.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck): Removed unnecessary include of ExceptionCode.h.
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
* bindings/scripts/test/JS/JSTestCEReactions.cpp:
* bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
* bindings/scripts/test/JS/JSTestDOMJIT.cpp:
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
* bindings/scripts/test/JS/JSTestGlobalObject.cpp:
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
* bindings/scripts/test/JS/JSTestNode.cpp:
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
* bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
Updated.
* css/CSSMediaRule.cpp: Removed include of ExceptionCode.h.
* css/CSSSupportsRule.cpp: Ditto.
* dom/ClientRectList.cpp: Ditto.
* dom/DOMCoreException.cpp: Added include of ExceptionCode.h.
* dom/DOMImplementation.cpp: Removed include of ExceptionCode.h.
* dom/ExceptionBase.h: Ditto.
* dom/Node.cpp: Added include of ExceptionCode.h.
* dom/NodeIterator.cpp: Removed include of ExceptionCode.h.
(WebCore::NodeIterator::NodePointer::NodePointer): Marked this inline.
(WebCore::NodeIterator::NodePointer::clear): Ditto.
(WebCore::NodeIterator::NodePointer::moveToNext): Ditto.
(WebCore::NodeIterator::NodePointer::moveToPrevious): Ditto.
(WebCore::NodeIterator::NodeIterator): Ditto.
(WebCore::NodeIterator::create): Moved this here from the header.
Now the constructor is inlined instead of this function.
(WebCore::NodeIterator::detach): Deleted. Moved to header.
* dom/NodeIterator.h: Removed definition of ExceptionCode, fixed indentation
of this file and made a few changes as mentioned above.
* dom/ProcessingInstruction.cpp: Removed include of ExceptionCode.h.
* dom/Text.cpp: Added include of ExceptionCode.h.
* dom/TreeWalker.cpp: Removed include of ExceptionCode.h.
* editing/FrameSelection.cpp: Ditto.
* fileapi/WebKitBlobBuilder.cpp: Ditto.
* history/CachedFrame.cpp: Ditto.
* html/HTMLDocument.cpp: Ditto.
* html/HTMLMeterElement.cpp: Ditto.
* html/HTMLObjectElement.cpp: Ditto.
* html/HTMLOptionElement.cpp: Ditto.
* html/HTMLOptionsCollection.cpp: Removed include of ExceptionCode.h.
(WebCore::HTMLOptionsCollection::add): Changed argument to const& to avoid a
little bit of reference count churn.
* html/HTMLOptionsCollection.h: Updated for above.
* html/HTMLProgressElement.cpp: Removed include of ExceptionCode.h.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::add): Changed argument to const& to avoid a
little bit of reference count churn.
* html/HTMLSelectElement.h: Updated for above.
* html/HTMLTextAreaElement.cpp: Removed include of ExceptionCode.h.
* html/canvas/CanvasPattern.cpp: Ditto.
* html/canvas/WebGLContextGroup.h: Removed definition of ExceptionCode.
* html/track/AudioTrack.h: Removed include of ExceptionCode.h.
* html/track/TextTrack.h: Ditto.
* html/track/VTTCue.cpp: Added include of ExceptionCode.h.
* html/track/VTTRegion.cpp: Ditto.
* html/track/VideoTrack.h: Removed include of ExceptionCode.h.
* inspector/DOMEditor.cpp: Ditto.
* inspector/InspectorDatabaseAgent.cpp: Removed include of ExceptionCode.h.
Tweaked the code in the file a bit, marking more things final and making them
private. ALso simplified a couple of the functions a bit.
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
(WebCore::InspectorDatabaseAgent::databaseForId):
* inspector/InspectorIndexedDBAgent.cpp: Removed include of ExceptionCode.h.
* inspector/InspectorStyleSheet.cpp: Added include of ExceptionCode.h.
* page/FocusController.cpp: Removed include of ExceptionCode.h.
* page/Location.h: Removed definition of ExceptionCode.
* page/Page.cpp: Removed include of ExceptionCode.h.
* platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm: Ditto.
* platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm: Ditto.
* platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm: Ditto.
* platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm: Ditto.
* storage/StorageArea.h: Removed definition of ExceptionCode.
* svg/SVGCircleElement.cpp: Removed include of ExceptionCode.h.
* svg/SVGColor.cpp: Added include of ExceptionCode.h.
* svg/SVGPaint.cpp: Ditto.
* svg/SVGStyleElement.cpp: Removed include of ExceptionCode.h.
* svg/properties/SVGListProperty.h: Added include of ExceptionCode.h.
* workers/Worker.cpp: Removed include of ExceptionCode.h.
* workers/WorkerMessagingProxy.cpp: Ditto.
* xml/XMLSerializer.cpp: Removed unneeded includes.
(WebCore::XMLSerializer::serializeToString): Use nullptr.
* xml/XMLSerializer.h: Removed definition of ExceptionCode, fixed indentation
of this file, and made a couple tweaks.
Source/WebKit2:
* WebProcess/Storage/StorageAreaImpl.cpp: Removed include of ExceptionCode.h.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesencryptedmediaCDMPrivateClearKeycpp">trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateClearKey.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesencryptedmediaCDMPrivateMediaPlayercpp">trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesfetchFetchBodyOwnercpp">trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBDatabasecpp">trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBDatabaseh">trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.h</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBDatabaseExceptioncpp">trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseException.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBIndexcpp">trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBObjectStorecpp">trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaConstraintsImplcpp">trunk/Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaDevicesEnumerationRequestcpp">trunk/Source/WebCore/Modules/mediastream/MediaDevicesEnumerationRequest.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaDevicesRequestcpp">trunk/Source/WebCore/Modules/mediastream/MediaDevicesRequest.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamcpp">trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamMediaStreamTrackcpp">trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCDTMFSendercpp">trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCDataChannelcpp">trunk/Source/WebCore/Modules/mediastream/RTCDataChannel.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCIceCandidatecpp">trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCPeerConnectioncpp">trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesnotificationsNotificationh">trunk/Source/WebCore/Modules/notifications/Notification.h</a></li>
<li><a href="#trunkSourceWebCoreModulesstreamsReadableStreamSourceh">trunk/Source/WebCore/Modules/streams/ReadableStreamSource.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioBiquadFilterNodecpp">trunk/Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioPannerNodecpp">trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioPannerNodeh">trunk/Source/WebCore/Modules/webaudio/PannerNode.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioWaveShaperNodecpp">trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabasecpp">trunk/Source/WebCore/Modules/webdatabase/Database.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseh">trunk/Source/WebCore/Modules/webdatabase/Database.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseManagerh">trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseTaskh">trunk/Source/WebCore/Modules/webdatabase/DatabaseTask.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLTransactionBackendcpp">trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLTransactionBackendh">trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCorebindingsjsScriptModuleLoadercpp">trunk/Source/WebCore/bindings/js/ScriptModuleLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsSerializedScriptValuecpp">trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsStructuredClonecpp">trunk/Source/WebCore/bindings/js/StructuredClone.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestActiveDOMObjectcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestCEReactionscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestCEReactionsStringifiercpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestCustomNamedGettercpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestDOMJITcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestEventConstructorcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestEventTargetcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestGlobalObjectcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestInterfacecpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestMediaQueryListListenercpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestNamedConstructorcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestNodecpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestNondeterministiccpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestOverloadedConstructorscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestOverloadedConstructorsWithSequencecpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestOverrideBuiltinscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestTypedefscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSMediaRulecpp">trunk/Source/WebCore/css/CSSMediaRule.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSSupportsRulecpp">trunk/Source/WebCore/css/CSSSupportsRule.cpp</a></li>
<li><a href="#trunkSourceWebCoredomClientRectListcpp">trunk/Source/WebCore/dom/ClientRectList.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDOMCoreExceptioncpp">trunk/Source/WebCore/dom/DOMCoreException.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDOMImplementationcpp">trunk/Source/WebCore/dom/DOMImplementation.cpp</a></li>
<li><a href="#trunkSourceWebCoredomExceptionBaseh">trunk/Source/WebCore/dom/ExceptionBase.h</a></li>
<li><a href="#trunkSourceWebCoredomNodeIteratorcpp">trunk/Source/WebCore/dom/NodeIterator.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNodeIteratorh">trunk/Source/WebCore/dom/NodeIterator.h</a></li>
<li><a href="#trunkSourceWebCoredomProcessingInstructioncpp">trunk/Source/WebCore/dom/ProcessingInstruction.cpp</a></li>
<li><a href="#trunkSourceWebCoredomTextcpp">trunk/Source/WebCore/dom/Text.cpp</a></li>
<li><a href="#trunkSourceWebCoredomTreeWalkercpp">trunk/Source/WebCore/dom/TreeWalker.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingFrameSelectioncpp">trunk/Source/WebCore/editing/FrameSelection.cpp</a></li>
<li><a href="#trunkSourceWebCorefileapiWebKitBlobBuildercpp">trunk/Source/WebCore/fileapi/WebKitBlobBuilder.cpp</a></li>
<li><a href="#trunkSourceWebCorehistoryCachedFramecpp">trunk/Source/WebCore/history/CachedFrame.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDocumentcpp">trunk/Source/WebCore/html/HTMLDocument.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMeterElementcpp">trunk/Source/WebCore/html/HTMLMeterElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLObjectElementcpp">trunk/Source/WebCore/html/HTMLObjectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionElementcpp">trunk/Source/WebCore/html/HTMLOptionElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionsCollectioncpp">trunk/Source/WebCore/html/HTMLOptionsCollection.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionsCollectionh">trunk/Source/WebCore/html/HTMLOptionsCollection.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLProgressElementcpp">trunk/Source/WebCore/html/HTMLProgressElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementcpp">trunk/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementh">trunk/Source/WebCore/html/HTMLSelectElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTextAreaElementcpp">trunk/Source/WebCore/html/HTMLTextAreaElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasCanvasPatterncpp">trunk/Source/WebCore/html/canvas/CanvasPattern.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLContextGrouph">trunk/Source/WebCore/html/canvas/WebGLContextGroup.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackAudioTrackh">trunk/Source/WebCore/html/track/AudioTrack.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackTextTrackh">trunk/Source/WebCore/html/track/TextTrack.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVTTCuecpp">trunk/Source/WebCore/html/track/VTTCue.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVTTRegioncpp">trunk/Source/WebCore/html/track/VTTRegion.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVideoTrackh">trunk/Source/WebCore/html/track/VideoTrack.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorDOMEditorcpp">trunk/Source/WebCore/inspector/DOMEditor.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDatabaseAgentcpp">trunk/Source/WebCore/inspector/InspectorDatabaseAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorIndexedDBAgentcpp">trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorStyleSheetcpp">trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFocusControllercpp">trunk/Source/WebCore/page/FocusController.cpp</a></li>
<li><a href="#trunkSourceWebCorepageLocationh">trunk/Source/WebCore/page/Location.h</a></li>
<li><a href="#trunkSourceWebCorepagePagecpp">trunk/Source/WebCore/page/Page.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationCDMPrivateMediaSourceAVFObjCmm">trunk/Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVContentKeySessionmm">trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVFoundationObjCmm">trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVStreamSessionmm">trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm</a></li>
<li><a href="#trunkSourceWebCorestorageStorageAreah">trunk/Source/WebCore/storage/StorageArea.h</a></li>
<li><a href="#trunkSourceWebCoresvgSVGCircleElementcpp">trunk/Source/WebCore/svg/SVGCircleElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGColorcpp">trunk/Source/WebCore/svg/SVGColor.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGPaintcpp">trunk/Source/WebCore/svg/SVGPaint.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGStyleElementcpp">trunk/Source/WebCore/svg/SVGStyleElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgpropertiesSVGListPropertyh">trunk/Source/WebCore/svg/properties/SVGListProperty.h</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkercpp">trunk/Source/WebCore/workers/Worker.cpp</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerMessagingProxycpp">trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXMLSerializercpp">trunk/Source/WebCore/xml/XMLSerializer.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXMLSerializerh">trunk/Source/WebCore/xml/XMLSerializer.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessStorageStorageAreaImplcpp">trunk/Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseBasicTypesh">trunk/Source/WebCore/Modules/webdatabase/DatabaseBasicTypes.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/ChangeLog 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -1,3 +1,185 @@
</span><ins>+2016-11-13 Darin Adler <darin@apple.com>
+
+ Remove many includes of ExceptionCode.h
+ https://bugs.webkit.org/show_bug.cgi?id=164706
+
+ Reviewed by Alex Christensen.
+
+ * Modules/encryptedmedia/CDMPrivateClearKey.cpp: Removed include of ExceptionCode.h.
+ * Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp: Ditto.
+ * Modules/fetch/FetchBodyOwner.cpp: Ditto.
+
+ * Modules/indexeddb/IDBDatabase.cpp: Added include of ExceptionCode.h.
+
+ * Modules/indexeddb/IDBDatabase.h: Removed include of ExceptionCode.h.
+ * Modules/indexeddb/IDBDatabaseException.cpp: Ditto.
+
+ * Modules/indexeddb/IDBIndex.cpp: Added include of ExceptionCode.h.
+ * Modules/indexeddb/IDBObjectStore.cpp: Ditto.
+
+ * Modules/mediastream/MediaConstraintsImpl.cpp: Removed include of ExceptionCode.h.
+ * Modules/mediastream/MediaDevicesEnumerationRequest.cpp: Ditto.
+ * Modules/mediastream/MediaDevicesRequest.cpp: Ditto.
+ * Modules/mediastream/MediaStream.cpp: Ditto.
+ * Modules/mediastream/MediaStreamTrack.cpp: Ditto.
+ * Modules/mediastream/RTCDTMFSender.cpp: Ditto.
+ * Modules/mediastream/RTCDataChannel.cpp: Ditto.
+ * Modules/mediastream/RTCPeerConnection.cpp: Ditto.
+
+ * Modules/notifications/Notification.h: Removed definition of ExceptionCode.
+ * Modules/streams/ReadableStreamSource.h: Ditto.
+ * Modules/webaudio/BiquadFilterNode.cpp: Ditto.
+
+ * Modules/webaudio/PannerNode.cpp: Removed inclde of ExceptionCode.h.
+ * Modules/webaudio/WaveShaperNode.cpp: Ditto.
+
+ * Modules/webdatabase/Database.cpp:
+ (WebCore::guidForOriginAndName): Reimplemented using HashMap::ensure.
+ * Modules/webdatabase/Database.h: Renamed DatabaseGuid to DatabaseGUID and defined
+ it here instead of a in DatabaseBasicTypes.h; removed that include.
+
+ * Modules/webdatabase/DatabaseBasicTypes.h: Removed.
+
+ * Modules/webdatabase/DatabaseManager.h: Removed include of DatabaseBasicTypes.h.
+ * Modules/webdatabase/DatabaseTask.h: Ditto.
+
+ * Modules/webdatabase/SQLTransactionBackend.cpp: Removed include of ExceptionCode.h.
+
+ * Modules/webdatabase/SQLTransactionBackend.h: Removed include of DatabaseBasicTypes.h.
+
+ * WebCore.xcodeproj/project.pbxproj: Removed DatabaseBasicTypes.h, also let Xcode
+ edit the file.
+
+ * bindings/js/ScriptModuleLoader.cpp: Removed include of ExceptionCode.h.
+ * bindings/js/SerializedScriptValue.cpp: Ditto.
+ * bindings/js/StructuredClone.cpp: Ditto.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateParametersCheck): Removed unnecessary include of ExceptionCode.h.
+
+ * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
+ * bindings/scripts/test/JS/JSTestCEReactions.cpp:
+ * bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
+ * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
+ * bindings/scripts/test/JS/JSTestDOMJIT.cpp:
+ * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+ * bindings/scripts/test/JS/JSTestEventTarget.cpp:
+ * bindings/scripts/test/JS/JSTestGlobalObject.cpp:
+ * bindings/scripts/test/JS/JSTestInterface.cpp:
+ * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
+ * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
+ * bindings/scripts/test/JS/JSTestNode.cpp:
+ * bindings/scripts/test/JS/JSTestNondeterministic.cpp:
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
+ * bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
+ * bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
+ * bindings/scripts/test/JS/JSTestTypedefs.cpp:
+ Updated.
+
+ * css/CSSMediaRule.cpp: Removed include of ExceptionCode.h.
+ * css/CSSSupportsRule.cpp: Ditto.
+ * dom/ClientRectList.cpp: Ditto.
+
+ * dom/DOMCoreException.cpp: Added include of ExceptionCode.h.
+
+ * dom/DOMImplementation.cpp: Removed include of ExceptionCode.h.
+ * dom/ExceptionBase.h: Ditto.
+
+ * dom/Node.cpp: Added include of ExceptionCode.h.
+
+ * dom/NodeIterator.cpp: Removed include of ExceptionCode.h.
+ (WebCore::NodeIterator::NodePointer::NodePointer): Marked this inline.
+ (WebCore::NodeIterator::NodePointer::clear): Ditto.
+ (WebCore::NodeIterator::NodePointer::moveToNext): Ditto.
+ (WebCore::NodeIterator::NodePointer::moveToPrevious): Ditto.
+ (WebCore::NodeIterator::NodeIterator): Ditto.
+ (WebCore::NodeIterator::create): Moved this here from the header.
+ Now the constructor is inlined instead of this function.
+ (WebCore::NodeIterator::detach): Deleted. Moved to header.
+ * dom/NodeIterator.h: Removed definition of ExceptionCode, fixed indentation
+ of this file and made a few changes as mentioned above.
+
+ * dom/ProcessingInstruction.cpp: Removed include of ExceptionCode.h.
+
+ * dom/Text.cpp: Added include of ExceptionCode.h.
+
+ * dom/TreeWalker.cpp: Removed include of ExceptionCode.h.
+ * editing/FrameSelection.cpp: Ditto.
+ * fileapi/WebKitBlobBuilder.cpp: Ditto.
+ * history/CachedFrame.cpp: Ditto.
+ * html/HTMLDocument.cpp: Ditto.
+ * html/HTMLMeterElement.cpp: Ditto.
+ * html/HTMLObjectElement.cpp: Ditto.
+ * html/HTMLOptionElement.cpp: Ditto.
+
+ * html/HTMLOptionsCollection.cpp: Removed include of ExceptionCode.h.
+ (WebCore::HTMLOptionsCollection::add): Changed argument to const& to avoid a
+ little bit of reference count churn.
+ * html/HTMLOptionsCollection.h: Updated for above.
+
+ * html/HTMLProgressElement.cpp: Removed include of ExceptionCode.h.
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::add): Changed argument to const& to avoid a
+ little bit of reference count churn.
+ * html/HTMLSelectElement.h: Updated for above.
+
+ * html/HTMLTextAreaElement.cpp: Removed include of ExceptionCode.h.
+ * html/canvas/CanvasPattern.cpp: Ditto.
+
+ * html/canvas/WebGLContextGroup.h: Removed definition of ExceptionCode.
+
+ * html/track/AudioTrack.h: Removed include of ExceptionCode.h.
+ * html/track/TextTrack.h: Ditto.
+
+ * html/track/VTTCue.cpp: Added include of ExceptionCode.h.
+ * html/track/VTTRegion.cpp: Ditto.
+
+ * html/track/VideoTrack.h: Removed include of ExceptionCode.h.
+ * inspector/DOMEditor.cpp: Ditto.
+
+ * inspector/InspectorDatabaseAgent.cpp: Removed include of ExceptionCode.h.
+ Tweaked the code in the file a bit, marking more things final and making them
+ private. ALso simplified a couple of the functions a bit.
+ (WebCore::InspectorDatabaseAgent::didOpenDatabase):
+ (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
+ (WebCore::InspectorDatabaseAgent::executeSQL):
+ (WebCore::InspectorDatabaseAgent::databaseForId):
+
+ * inspector/InspectorIndexedDBAgent.cpp: Removed include of ExceptionCode.h.
+
+ * inspector/InspectorStyleSheet.cpp: Added include of ExceptionCode.h.
+
+ * page/FocusController.cpp: Removed include of ExceptionCode.h.
+
+ * page/Location.h: Removed definition of ExceptionCode.
+
+ * page/Page.cpp: Removed include of ExceptionCode.h.
+ * platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm: Ditto.
+ * platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm: Ditto.
+ * platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm: Ditto.
+ * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm: Ditto.
+
+ * storage/StorageArea.h: Removed definition of ExceptionCode.
+
+ * svg/SVGCircleElement.cpp: Removed include of ExceptionCode.h.
+
+ * svg/SVGColor.cpp: Added include of ExceptionCode.h.
+ * svg/SVGPaint.cpp: Ditto.
+
+ * svg/SVGStyleElement.cpp: Removed include of ExceptionCode.h.
+
+ * svg/properties/SVGListProperty.h: Added include of ExceptionCode.h.
+
+ * workers/Worker.cpp: Removed include of ExceptionCode.h.
+ * workers/WorkerMessagingProxy.cpp: Ditto.
+
+ * xml/XMLSerializer.cpp: Removed unneeded includes.
+ (WebCore::XMLSerializer::serializeToString): Use nullptr.
+ * xml/XMLSerializer.h: Removed definition of ExceptionCode, fixed indentation
+ of this file, and made a couple tweaks.
+
</ins><span class="cx"> 2016-11-14 Youenn Fablet <youenn@apple.com>
</span><span class="cx">
</span><span class="cx"> MediaStreamPrivate::create should take vectors of Ref
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesencryptedmediaCDMPrivateClearKeycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateClearKey.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateClearKey.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateClearKey.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx"> #include "CDM.h"
</span><span class="cx"> #include "CDMSessionClearKey.h"
</span><span class="cx"> #include "ContentType.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "MediaPlayer.h"
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesencryptedmediaCDMPrivateMediaPlayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx"> #include "CDM.h"
</span><span class="cx"> #include "CDMSession.h"
</span><span class="cx"> #include "ContentType.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "MediaPlayer.h"
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesfetchFetchBodyOwnercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(FETCH_API)
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "FetchLoader.h"
</span><span class="cx"> #include "FetchResponseSource.h"
</span><span class="cx"> #include "HTTPParsers.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBDatabasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,6 +31,7 @@
</span><span class="cx"> #include "DOMStringList.h"
</span><span class="cx"> #include "EventNames.h"
</span><span class="cx"> #include "EventQueue.h"
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "IDBConnectionProxy.h"
</span><span class="cx"> #include "IDBConnectionToServer.h"
</span><span class="cx"> #include "IDBDatabaseException.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBDatabaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -29,7 +29,6 @@
</span><span class="cx">
</span><span class="cx"> #include "Dictionary.h"
</span><span class="cx"> #include "EventTarget.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "IDBActiveDOMObject.h"
</span><span class="cx"> #include "IDBConnectionProxy.h"
</span><span class="cx"> #include "IDBConnectionToServer.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBDatabaseExceptioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseException.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseException.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseException.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -27,10 +27,11 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> #include "config.h"
</span><ins>+#include "IDBDatabaseException.h"
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE)
</span><del>-#include "IDBDatabaseException.h"
</del><span class="cx">
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "ExceptionCodeDescription.h"
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBIndexcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(INDEXED_DATABASE)
</span><span class="cx">
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "IDBBindingUtilities.h"
</span><span class="cx"> #include "IDBCursor.h"
</span><span class="cx"> #include "IDBDatabase.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBObjectStorecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx">
</span><span class="cx"> #include "DOMStringList.h"
</span><span class="cx"> #include "Document.h"
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "IDBBindingUtilities.h"
</span><span class="cx"> #include "IDBCursor.h"
</span><span class="cx"> #include "IDBDatabase.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaConstraintsImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -35,10 +35,6 @@
</span><span class="cx">
</span><span class="cx"> #include "MediaConstraintsImpl.h"
</span><span class="cx">
</span><del>-#include "ArrayValue.h"
-#include "ExceptionCode.h"
-#include "Logging.h"
-
</del><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> Ref<MediaConstraintsImpl> MediaConstraintsImpl::create(MediaTrackConstraintSetMap&& mandatoryConstraints, Vector<MediaTrackConstraintSetMap>&& advancedConstraints, bool isValid)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaDevicesEnumerationRequestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaDevicesEnumerationRequest.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaDevicesEnumerationRequest.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/mediastream/MediaDevicesEnumerationRequest.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,8 +31,6 @@
</span><span class="cx">
</span><span class="cx"> #include "CaptureDevice.h"
</span><span class="cx"> #include "Document.h"
</span><del>-#include "ExceptionCode.h"
-#include "Frame.h"
</del><span class="cx"> #include "MainFrame.h"
</span><span class="cx"> #include "SecurityOrigin.h"
</span><span class="cx"> #include "UserMediaController.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaDevicesRequestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaDevicesRequest.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaDevicesRequest.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/mediastream/MediaDevicesRequest.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx">
</span><span class="cx"> #include "CaptureDevice.h"
</span><span class="cx"> #include "Document.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "JSMediaDeviceInfo.h"
</span><span class="cx"> #include "MediaDevicesEnumerationRequest.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -33,7 +33,6 @@
</span><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "Logging.h"
</span><span class="cx"> #include "MediaStreamRegistry.h"
</span><span class="cx"> #include "MediaStreamTrackEvent.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamMediaStreamTrackcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -33,7 +33,6 @@
</span><span class="cx"> #include "Dictionary.h"
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSOverconstrainedError.h"
</span><span class="cx"> #include "MediaConstraintsImpl.h"
</span><span class="cx"> #include "MediaSourceSettings.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCDTMFSendercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -29,7 +29,6 @@
</span><span class="cx">
</span><span class="cx"> #include "RTCDTMFSender.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "MediaStreamTrack.h"
</span><span class="cx"> #include "RTCDTMFSenderHandler.h"
</span><span class="cx"> #include "RTCDTMFToneChangeEvent.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCDataChannelcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCDataChannel.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCDataChannel.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDataChannel.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -32,7 +32,6 @@
</span><span class="cx"> #include "Dictionary.h"
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "MessageEvent.h"
</span><span class="cx"> #include "RTCDataChannelHandler.h"
</span><span class="cx"> #include "RTCPeerConnectionHandler.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCIceCandidatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,11 +31,10 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> #include "config.h"
</span><ins>+#include "RTCIceCandidate.h"
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(WEB_RTC)
</span><span class="cx">
</span><del>-#include "RTCIceCandidate.h"
-
</del><span class="cx"> #include "Dictionary.h"
</span><span class="cx"> #include "ExceptionCode.h"
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCPeerConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,15 +31,13 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> #include "config.h"
</span><ins>+#include "RTCPeerConnection.h"
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(WEB_RTC)
</span><span class="cx">
</span><del>-#include "RTCPeerConnection.h"
-
</del><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "MediaStream.h"
</span><span class="cx"> #include "MediaStreamTrack.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesnotificationsNotificationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/notifications/Notification.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/notifications/Notification.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/notifications/Notification.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -47,8 +47,6 @@
</span><span class="cx"> class NotificationCenter;
</span><span class="cx"> class NotificationPermissionCallback;
</span><span class="cx">
</span><del>-typedef int ExceptionCode;
-
</del><span class="cx"> class Notification final : public RefCounted<Notification>, public ActiveDOMObject, public EventTargetWithInlineData {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesstreamsReadableStreamSourceh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamSource.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/streams/ReadableStreamSource.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamSource.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -36,8 +36,6 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-typedef int ExceptionCode;
-
</del><span class="cx"> class ReadableStreamSource : public RefCounted<ReadableStreamSource> {
</span><span class="cx"> public:
</span><span class="cx"> virtual ~ReadableStreamSource() { }
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioBiquadFilterNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,8 +28,6 @@
</span><span class="cx">
</span><span class="cx"> #include "BiquadFilterNode.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
-
</del><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> BiquadFilterNode::BiquadFilterNode(AudioContext& context, float sampleRate)
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioPannerNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -23,17 +23,15 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> #include "config.h"
</span><ins>+#include "PannerNode.h"
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(WEB_AUDIO)
</span><span class="cx">
</span><del>-#include "PannerNode.h"
-
</del><span class="cx"> #include "AudioBufferSourceNode.h"
</span><span class="cx"> #include "AudioBus.h"
</span><span class="cx"> #include "AudioContext.h"
</span><span class="cx"> #include "AudioNodeInput.h"
</span><span class="cx"> #include "AudioNodeOutput.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "HRTFPanner.h"
</span><span class="cx"> #include "ScriptExecutionContext.h"
</span><span class="cx"> #include <wtf/MathExtras.h>
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioPannerNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/PannerNode.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/PannerNode.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webaudio/PannerNode.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -24,6 +24,8 @@
</span><span class="cx">
</span><span class="cx"> #pragma once
</span><span class="cx">
</span><ins>+#if ENABLE(WEB_AUDIO)
+
</ins><span class="cx"> #include "AudioBus.h"
</span><span class="cx"> #include "AudioListener.h"
</span><span class="cx"> #include "AudioNode.h"
</span><span class="lines">@@ -148,3 +150,5 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span><ins>+
+#endif
</ins></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioWaveShaperNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -23,13 +23,11 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> #include "config.h"
</span><ins>+#include "WaveShaperNode.h"
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(WEB_AUDIO)
</span><span class="cx">
</span><del>-#include "WaveShaperNode.h"
-
</del><span class="cx"> #include "AudioContext.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include <wtf/MainThread.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/Database.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/Database.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webdatabase/Database.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -159,15 +159,14 @@
</span><span class="cx"> // FIXME: move all guid-related functions to a DatabaseVersionTracker class.
</span><span class="cx"> static StaticLock guidMutex;
</span><span class="cx">
</span><del>-typedef HashMap<DatabaseGuid, String> GuidVersionMap;
-static GuidVersionMap& guidToVersionMap()
</del><ins>+static HashMap<DatabaseGUID, String>& guidToVersionMap()
</ins><span class="cx"> {
</span><del>- static NeverDestroyed<GuidVersionMap> map;
</del><ins>+ static NeverDestroyed<HashMap<DatabaseGUID, String>> map;
</ins><span class="cx"> return map;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // NOTE: Caller must lock guidMutex().
</span><del>-static inline void updateGuidVersionMap(DatabaseGuid guid, String newVersion)
</del><ins>+static inline void updateGUIDVersionMap(DatabaseGUID guid, const String& newVersion)
</ins><span class="cx"> {
</span><span class="cx"> // Note: It is not safe to put an empty string into the guidToVersionMap() map.
</span><span class="cx"> // That's because the map is cross-thread, but empty strings are per-thread.
</span><span class="lines">@@ -175,31 +174,23 @@
</span><span class="cx"> // thread, but we need a string we can keep in a cross-thread data structure.
</span><span class="cx"> // FIXME: This is a quite-awkward restriction to have to program with.
</span><span class="cx">
</span><del>- // Map null string to empty string (see comment above).
</del><ins>+ // Map empty string to null string (see comment above).
</ins><span class="cx"> guidToVersionMap().set(guid, newVersion.isEmpty() ? String() : newVersion.isolatedCopy());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-typedef HashMap<DatabaseGuid, std::unique_ptr<HashSet<Database*>>> GuidDatabaseMap;
-
-static GuidDatabaseMap& guidToDatabaseMap()
</del><ins>+static HashMap<DatabaseGUID, HashSet<Database*>>& guidToDatabaseMap()
</ins><span class="cx"> {
</span><del>- static NeverDestroyed<GuidDatabaseMap> map;
</del><ins>+ static NeverDestroyed<HashMap<DatabaseGUID, HashSet<Database*>>> map;
</ins><span class="cx"> return map;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static DatabaseGuid guidForOriginAndName(const String& origin, const String& name)
</del><ins>+static inline DatabaseGUID guidForOriginAndName(const String& origin, const String& name)
</ins><span class="cx"> {
</span><del>- String stringID = origin + "/" + name;
-
- static NeverDestroyed<HashMap<String, int>> map;
- DatabaseGuid guid = map.get().get(stringID);
- if (!guid) {
- static int currentNewGUID = 1;
- guid = currentNewGUID++;
- map.get().set(stringID, guid);
- }
-
- return guid;
</del><ins>+ static NeverDestroyed<HashMap<String, DatabaseGUID>> map;
+ return map.get().ensure(makeString(origin, '/', name), [] {
+ static DatabaseGUID lastUsedGUID;
+ return ++lastUsedGUID;
+ }).iterator->value;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Database::Database(DatabaseContext& context, const String& name, const String& expectedVersion, const String& displayName, unsigned estimatedSize)
</span><span class="lines">@@ -219,8 +210,8 @@
</span><span class="cx">
</span><span class="cx"> m_guid = guidForOriginAndName(securityOrigin().toString(), name);
</span><span class="cx"> guidToDatabaseMap().ensure(m_guid, [] {
</span><del>- return std::make_unique<HashSet<Database*>>();
- }).iterator->value->add(this);
</del><ins>+ return HashSet<Database*>();
+ }).iterator->value.add(this);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> m_databaseContext->databaseThread();
</span><span class="lines">@@ -371,7 +362,7 @@
</span><span class="cx">
</span><span class="cx"> auto entry = guidToVersionMap().find(m_guid);
</span><span class="cx"> if (entry != guidToVersionMap().end()) {
</span><del>- // Map null string to empty string (see updateGuidVersionMap()).
</del><ins>+ // Map null string to empty string (see updateGUIDVersionMap()).
</ins><span class="cx"> currentVersion = entry->value.isNull() ? emptyString() : entry->value.isolatedCopy();
</span><span class="cx"> LOG(StorageAPI, "Current cached version for guid %i is %s", m_guid, currentVersion.ascii().data());
</span><span class="cx"> } else {
</span><span class="lines">@@ -414,7 +405,7 @@
</span><span class="cx"> }
</span><span class="cx"> currentVersion = m_expectedVersion;
</span><span class="cx"> }
</span><del>- updateGuidVersionMap(m_guid, currentVersion);
</del><ins>+ updateGUIDVersionMap(m_guid, currentVersion);
</ins><span class="cx"> transaction.commit();
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -460,10 +451,9 @@
</span><span class="cx">
</span><span class="cx"> auto it = guidToDatabaseMap().find(m_guid);
</span><span class="cx"> ASSERT(it != guidToDatabaseMap().end());
</span><del>- ASSERT(it->value);
- ASSERT(it->value->contains(this));
- it->value->remove(this);
- if (it->value->isEmpty()) {
</del><ins>+ ASSERT(it->value.contains(this));
+ it->value.remove(this);
+ if (it->value.isEmpty()) {
</ins><span class="cx"> guidToDatabaseMap().remove(it);
</span><span class="cx"> guidToVersionMap().remove(m_guid);
</span><span class="cx"> }
</span><span class="lines">@@ -522,10 +512,9 @@
</span><span class="cx">
</span><span class="cx"> void Database::setCachedVersion(const String& actualVersion)
</span><span class="cx"> {
</span><del>- // Update the in memory database version map.
</del><span class="cx"> std::lock_guard<StaticLock> locker(guidMutex);
</span><span class="cx">
</span><del>- updateGuidVersionMap(m_guid, actualVersion);
</del><ins>+ updateGUIDVersionMap(m_guid, actualVersion);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool Database::getActualVersionForTransaction(String &actualVersion)
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/Database.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/Database.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webdatabase/Database.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx">
</span><span class="cx"> #pragma once
</span><span class="cx">
</span><del>-#include "DatabaseBasicTypes.h"
</del><span class="cx"> #include "ExceptionOr.h"
</span><span class="cx"> #include "SQLiteDatabase.h"
</span><span class="cx"> #include <wtf/Deque.h>
</span><span class="lines">@@ -50,6 +49,8 @@
</span><span class="cx"> class SQLTransactionWrapper;
</span><span class="cx"> class VoidCallback;
</span><span class="cx">
</span><ins>+using DatabaseGUID = int;
+
</ins><span class="cx"> class Database : public ThreadSafeRefCounted<Database> {
</span><span class="cx"> public:
</span><span class="cx"> ~Database();
</span><span class="lines">@@ -158,7 +159,7 @@
</span><span class="cx"> unsigned m_estimatedSize;
</span><span class="cx"> String m_filename;
</span><span class="cx">
</span><del>- DatabaseGuid m_guid;
</del><ins>+ DatabaseGUID m_guid;
</ins><span class="cx"> bool m_opened { false };
</span><span class="cx"> bool m_new { false };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseBasicTypesh"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/Modules/webdatabase/DatabaseBasicTypes.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseBasicTypes.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseBasicTypes.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -1,33 +0,0 @@
</span><del>-/*
- * Copyright (C) 2012 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#pragma once
-
-namespace WebCore {
-
-typedef int DatabaseGuid;
-typedef int ExceptionCode;
-
-} // namespace WebCore
</del></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseManagerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -25,7 +25,6 @@
</span><span class="cx">
</span><span class="cx"> #pragma once
</span><span class="cx">
</span><del>-#include "DatabaseBasicTypes.h"
</del><span class="cx"> #include "DatabaseDetails.h"
</span><span class="cx"> #include "ExceptionOr.h"
</span><span class="cx"> #include <wtf/Assertions.h>
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseTaskh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseTask.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseTask.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseTask.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx">
</span><span class="cx"> #pragma once
</span><span class="cx">
</span><del>-#include "DatabaseBasicTypes.h"
</del><span class="cx"> #include "ExceptionOr.h"
</span><span class="cx"> #include "SQLTransactionBackend.h"
</span><span class="cx"> #include <wtf/Condition.h>
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseSQLTransactionBackendcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -34,7 +34,6 @@
</span><span class="cx"> #include "DatabaseContext.h"
</span><span class="cx"> #include "DatabaseThread.h"
</span><span class="cx"> #include "DatabaseTracker.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "Logging.h"
</span><span class="cx"> #include "OriginLock.h"
</span><span class="cx"> #include "SQLError.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseSQLTransactionBackendh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx">
</span><span class="cx"> #pragma once
</span><span class="cx">
</span><del>-#include "DatabaseBasicTypes.h"
</del><span class="cx"> #include "SQLTransactionStateMachine.h"
</span><span class="cx"> #include <memory>
</span><span class="cx"> #include <wtf/Deque.h>
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -19192,7 +19192,6 @@
</span><span class="cx"> 97BC69E01505F081001B74AC /* Database.idl */,
</span><span class="cx"> 97BC69E11505F081001B74AC /* DatabaseAuthorizer.cpp */,
</span><span class="cx"> 97BC69E21505F081001B74AC /* DatabaseAuthorizer.h */,
</span><del>- FE3371A0167C11D400EDB752 /* DatabaseBasicTypes.h */,
</del><span class="cx"> 97BC69E31505F081001B74AC /* DatabaseCallback.h */,
</span><span class="cx"> 97BC69E41505F081001B74AC /* DatabaseCallback.idl */,
</span><span class="cx"> 97BC69E51505F081001B74AC /* DatabaseContext.cpp */,
</span><span class="lines">@@ -25138,7 +25137,6 @@
</span><span class="cx"> A80E6D0B0A1989CA007FB8C5 /* DashboardRegion.h in Headers */,
</span><span class="cx"> 97BC6A211505F081001B74AC /* Database.h in Headers */,
</span><span class="cx"> 97BC6A241505F081001B74AC /* DatabaseAuthorizer.h in Headers */,
</span><del>- FE3371A2167C11D400EDB752 /* DatabaseBasicTypes.h in Headers */,
</del><span class="cx"> 97BC6A251505F081001B74AC /* DatabaseCallback.h in Headers */,
</span><span class="cx"> 97BC6A281505F081001B74AC /* DatabaseContext.h in Headers */,
</span><span class="cx"> 97BC6A291505F081001B74AC /* DatabaseDetails.h in Headers */,
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsScriptModuleLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/ScriptModuleLoader.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/ScriptModuleLoader.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/js/ScriptModuleLoader.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> #include "ScriptModuleLoader.h"
</span><span class="cx">
</span><span class="cx"> #include "Document.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include <runtime/JSInternalPromiseDeferred.h>
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsSerializedScriptValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -34,7 +34,6 @@
</span><span class="cx"> #include "CryptoKeyDataRSAComponents.h"
</span><span class="cx"> #include "CryptoKeyHMAC.h"
</span><span class="cx"> #include "CryptoKeyRSA.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "File.h"
</span><span class="cx"> #include "FileList.h"
</span><span class="cx"> #include "IDBValue.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsStructuredClonecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/StructuredClone.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/StructuredClone.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/js/StructuredClone.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "StructuredClone.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include <runtime/JSTypedArrays.h>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -4388,7 +4388,6 @@
</span><span class="cx"> $quotedFunctionName = "nullptr";
</span><span class="cx"> }
</span><span class="cx">
</span><del>- $implIncludes{"ExceptionCode.h"} = 1;
</del><span class="cx"> $implIncludes{"JSDOMBinding.h"} = 1;
</span><span class="cx">
</span><span class="cx"> my $argumentIndex = 0;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestActiveDOMObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestActiveDOMObject.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestCEReactionscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -22,7 +22,6 @@
</span><span class="cx"> #include "JSTestCEReactions.h"
</span><span class="cx">
</span><span class="cx"> #include "CustomElementReactionQueue.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestCEReactionsStringifiercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -22,7 +22,6 @@
</span><span class="cx"> #include "JSTestCEReactionsStringifier.h"
</span><span class="cx">
</span><span class="cx"> #include "CustomElementReactionQueue.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestCustomNamedGettercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestCustomNamedGetter.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestDOMJITcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -26,7 +26,6 @@
</span><span class="cx"> #include "DOMJITIDLConvert.h"
</span><span class="cx"> #include "DOMJITIDLType.h"
</span><span class="cx"> #include "DOMJITIDLTypeFilter.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSByteString.h"
</span><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestEventConstructorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestEventConstructor.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include <runtime/Error.h>
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestEventTargetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestEventTarget.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestGlobalObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestGlobalObject.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestInterfacecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -24,7 +24,6 @@
</span><span class="cx">
</span><span class="cx"> #include "JSTestInterface.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestMediaQueryListListenercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestMediaQueryListListener.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSMediaQueryListListener.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestNamedConstructorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestNamedConstructor.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestNode.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestNondeterministiccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestNondeterministic.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -25,7 +25,6 @@
</span><span class="cx"> #include "Dictionary.h"
</span><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "JSBlob.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestOverloadedConstructorscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestOverloadedConstructors.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSBlob.h"
</span><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestOverloadedConstructorsWithSequencecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestOverloadedConstructorsWithSequence.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestOverrideBuiltinscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestOverrideBuiltins.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestTypedefscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "JSTestTypedefs.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "JSDOMBinding.h"
</span><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMConvert.h"
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSMediaRulecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSMediaRule.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSMediaRule.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/css/CSSMediaRule.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -26,7 +26,6 @@
</span><span class="cx"> #include "CSSParser.h"
</span><span class="cx"> #include "CSSRuleList.h"
</span><span class="cx"> #include "CSSStyleSheet.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "MediaList.h"
</span><span class="cx"> #include "StyleRule.h"
</span><span class="cx"> #include <wtf/text/StringBuilder.h>
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSSupportsRulecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSSupportsRule.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSSupportsRule.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/css/CSSSupportsRule.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -33,7 +33,6 @@
</span><span class="cx"> #include "CSSRule.h"
</span><span class="cx"> #include "CSSRuleList.h"
</span><span class="cx"> #include "CSSStyleSheet.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "StyleRule.h"
</span><span class="cx"> #include <wtf/text/StringBuilder.h>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomClientRectListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ClientRectList.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ClientRectList.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/dom/ClientRectList.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "ClientRectList.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "ClientRect.h"
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -55,11 +54,9 @@
</span><span class="cx"> ClientRect* ClientRectList::item(unsigned index)
</span><span class="cx"> {
</span><span class="cx"> if (index >= m_list.size()) {
</span><del>- // FIXME: this should throw an exception.
- // ec = INDEX_SIZE_ERR;
</del><ins>+ // FIXME: Should this throw an INDEX_SIZE_ERR exception?
</ins><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><del>-
</del><span class="cx"> return m_list[index].ptr();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMCoreExceptioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMCoreException.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMCoreException.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/dom/DOMCoreException.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -29,6 +29,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "DOMCoreException.h"
</span><span class="cx">
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "ExceptionCodeDescription.h"
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span></span></pre></div>
<a id="trunkSourceWebCoredomDOMImplementationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMImplementation.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DOMImplementation.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/dom/DOMImplementation.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -29,7 +29,6 @@
</span><span class="cx"> #include "ContentType.h"
</span><span class="cx"> #include "DocumentType.h"
</span><span class="cx"> #include "Element.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "FTPDirectoryDocument.h"
</span><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "FrameLoader.h"
</span></span></pre></div>
<a id="trunkSourceWebCoredomExceptionBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ExceptionBase.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ExceptionBase.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/dom/ExceptionBase.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,8 +28,6 @@
</span><span class="cx">
</span><span class="cx"> #pragma once
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
-#include <wtf/RefCounted.h>
</del><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="lines">@@ -36,6 +34,8 @@
</span><span class="cx">
</span><span class="cx"> struct ExceptionCodeDescription;
</span><span class="cx">
</span><ins>+using ExceptionCode = int;
+
</ins><span class="cx"> class ExceptionBase : public RefCounted<ExceptionBase> {
</span><span class="cx"> public:
</span><span class="cx"> unsigned short code() const { return m_code; }
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeIteratorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NodeIterator.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NodeIterator.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/dom/NodeIterator.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -26,25 +26,23 @@
</span><span class="cx"> #include "NodeIterator.h"
</span><span class="cx">
</span><span class="cx"> #include "Document.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "NodeTraversal.h"
</span><del>-
</del><span class="cx"> #include <runtime/JSCJSValueInlines.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-NodeIterator::NodePointer::NodePointer(Node& node, bool isPointerBeforeNode)
</del><ins>+inline NodeIterator::NodePointer::NodePointer(Node& node, bool isPointerBeforeNode)
</ins><span class="cx"> : node(&node)
</span><span class="cx"> , isPointerBeforeNode(isPointerBeforeNode)
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NodeIterator::NodePointer::clear()
</del><ins>+inline void NodeIterator::NodePointer::clear()
</ins><span class="cx"> {
</span><span class="cx"> node = nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool NodeIterator::NodePointer::moveToNext(Node& root)
</del><ins>+inline bool NodeIterator::NodePointer::moveToNext(Node& root)
</ins><span class="cx"> {
</span><span class="cx"> if (!node)
</span><span class="cx"> return false;
</span><span class="lines">@@ -56,7 +54,7 @@
</span><span class="cx"> return node;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool NodeIterator::NodePointer::moveToPrevious(Node& root)
</del><ins>+inline bool NodeIterator::NodePointer::moveToPrevious(Node& root)
</ins><span class="cx"> {
</span><span class="cx"> if (!node)
</span><span class="cx"> return false;
</span><span class="lines">@@ -72,13 +70,18 @@
</span><span class="cx"> return node;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-NodeIterator::NodeIterator(Node& rootNode, unsigned long whatToShow, RefPtr<NodeFilter>&& filter)
</del><ins>+inline NodeIterator::NodeIterator(Node& rootNode, unsigned whatToShow, RefPtr<NodeFilter>&& filter)
</ins><span class="cx"> : NodeIteratorBase(rootNode, whatToShow, WTFMove(filter))
</span><del>- , m_referenceNode(root(), true)
</del><ins>+ , m_referenceNode(rootNode, true)
</ins><span class="cx"> {
</span><span class="cx"> root().document().attachNodeIterator(this);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+Ref<NodeIterator> NodeIterator::create(Node& rootNode, unsigned whatToShow, RefPtr<NodeFilter>&& filter)
+{
+ return adoptRef(*new NodeIterator(rootNode, whatToShow, WTFMove(filter)));
+}
+
</ins><span class="cx"> NodeIterator::~NodeIterator()
</span><span class="cx"> {
</span><span class="cx"> root().document().detachNodeIterator(this);
</span><span class="lines">@@ -128,11 +131,6 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NodeIterator::detach()
-{
- // This is now a no-op as per the DOM specification.
-}
-
</del><span class="cx"> void NodeIterator::nodeWillBeRemoved(Node& removedNode)
</span><span class="cx"> {
</span><span class="cx"> updateForNodeRemoval(removedNode, m_candidateNode);
</span><span class="lines">@@ -205,5 +203,4 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-
</del><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeIteratorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NodeIterator.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NodeIterator.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/dom/NodeIterator.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -27,49 +27,43 @@
</span><span class="cx"> #include "NodeFilter.h"
</span><span class="cx"> #include "ScriptWrappable.h"
</span><span class="cx"> #include "Traversal.h"
</span><del>-#include <wtf/RefCounted.h>
</del><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>- typedef int ExceptionCode;
</del><ins>+class NodeIterator : public ScriptWrappable, public RefCounted<NodeIterator>, public NodeIteratorBase {
+public:
+ static Ref<NodeIterator> create(Node&, unsigned whatToShow, RefPtr<NodeFilter>&&);
+ WEBCORE_EXPORT ~NodeIterator();
</ins><span class="cx">
</span><del>- class NodeIterator : public ScriptWrappable, public RefCounted<NodeIterator>, public NodeIteratorBase {
- public:
- static Ref<NodeIterator> create(Node& rootNode, unsigned long whatToShow, RefPtr<NodeFilter>&& filter)
- {
- return adoptRef(*new NodeIterator(rootNode, whatToShow, WTFMove(filter)));
- }
- WEBCORE_EXPORT ~NodeIterator();
</del><ins>+ WEBCORE_EXPORT RefPtr<Node> nextNode();
+ WEBCORE_EXPORT RefPtr<Node> previousNode();
+ void detach() { } // This is now a no-op as per the DOM specification.
</ins><span class="cx">
</span><del>- WEBCORE_EXPORT RefPtr<Node> nextNode();
- WEBCORE_EXPORT RefPtr<Node> previousNode();
- WEBCORE_EXPORT void detach();
</del><ins>+ Node* referenceNode() const { return m_referenceNode.node.get(); }
+ bool pointerBeforeReferenceNode() const { return m_referenceNode.isPointerBeforeNode; }
</ins><span class="cx">
</span><del>- Node* referenceNode() const { return m_referenceNode.node.get(); }
- bool pointerBeforeReferenceNode() const { return m_referenceNode.isPointerBeforeNode; }
</del><ins>+ // This function is called before any node is removed from the document tree.
+ void nodeWillBeRemoved(Node&);
</ins><span class="cx">
</span><del>- // This function is called before any node is removed from the document tree.
- void nodeWillBeRemoved(Node&);
</del><ins>+private:
+ NodeIterator(Node&, unsigned whatToShow, RefPtr<NodeFilter>&&);
</ins><span class="cx">
</span><del>- private:
- NodeIterator(Node&, unsigned long whatToShow, RefPtr<NodeFilter>&&);
</del><ins>+ struct NodePointer {
+ RefPtr<Node> node;
+ bool isPointerBeforeNode { true };
</ins><span class="cx">
</span><del>- struct NodePointer {
- RefPtr<Node> node;
- bool isPointerBeforeNode { true };
</del><ins>+ NodePointer() = default;
+ NodePointer(Node&, bool);
</ins><span class="cx">
</span><del>- NodePointer() = default;
- NodePointer(Node&, bool);
</del><ins>+ void clear();
+ bool moveToNext(Node& root);
+ bool moveToPrevious(Node& root);
+ };
</ins><span class="cx">
</span><del>- void clear();
- bool moveToNext(Node& root);
- bool moveToPrevious(Node& root);
- };
</del><ins>+ void updateForNodeRemoval(Node& nodeToBeRemoved, NodePointer&) const;
</ins><span class="cx">
</span><del>- void updateForNodeRemoval(Node& nodeToBeRemoved, NodePointer&) const;
</del><ins>+ NodePointer m_referenceNode;
+ NodePointer m_candidateNode;
+};
</ins><span class="cx">
</span><del>- NodePointer m_referenceNode;
- NodePointer m_candidateNode;
- };
-
</del><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoredomProcessingInstructioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ProcessingInstruction.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ProcessingInstruction.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/dom/ProcessingInstruction.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,14 +28,13 @@
</span><span class="cx"> #include "CachedResourceRequest.h"
</span><span class="cx"> #include "CachedXSLStyleSheet.h"
</span><span class="cx"> #include "Document.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "FrameLoader.h"
</span><del>-#include "XSLStyleSheet.h"
-#include "XMLDocumentParser.h" // for parseAttributes()
</del><span class="cx"> #include "MediaList.h"
</span><span class="cx"> #include "StyleScope.h"
</span><span class="cx"> #include "StyleSheetContents.h"
</span><ins>+#include "XMLDocumentParser.h"
+#include "XSLStyleSheet.h"
</ins><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomTextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Text.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Text.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/dom/Text.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -23,6 +23,7 @@
</span><span class="cx"> #include "Text.h"
</span><span class="cx">
</span><span class="cx"> #include "Event.h"
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "RenderCombineText.h"
</span><span class="cx"> #include "RenderSVGInlineText.h"
</span><span class="cx"> #include "RenderText.h"
</span></span></pre></div>
<a id="trunkSourceWebCoredomTreeWalkercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/TreeWalker.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/TreeWalker.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/dom/TreeWalker.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -25,10 +25,8 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "TreeWalker.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "ContainerNode.h"
</span><span class="cx"> #include "NodeTraversal.h"
</span><del>-
</del><span class="cx"> #include <runtime/JSCJSValueInlines.h>
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingFrameSelectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/FrameSelection.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -37,7 +37,6 @@
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "EventHandler.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "FloatQuad.h"
</span><span class="cx"> #include "FocusController.h"
</span><span class="cx"> #include "Frame.h"
</span></span></pre></div>
<a id="trunkSourceWebCorefileapiWebKitBlobBuildercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/fileapi/WebKitBlobBuilder.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/fileapi/WebKitBlobBuilder.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/fileapi/WebKitBlobBuilder.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -33,7 +33,6 @@
</span><span class="cx">
</span><span class="cx"> #include "Blob.h"
</span><span class="cx"> #include "Document.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "File.h"
</span><span class="cx"> #include "LineEnding.h"
</span><span class="cx"> #include "TextEncoding.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehistoryCachedFramecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/history/CachedFrame.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/history/CachedFrame.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/history/CachedFrame.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -32,7 +32,6 @@
</span><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "DocumentLoader.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "FrameLoader.h"
</span><span class="cx"> #include "FrameLoaderClient.h"
</span><span class="cx"> #include "FrameView.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDocument.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDocument.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/HTMLDocument.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -58,7 +58,6 @@
</span><span class="cx"> #include "DocumentLoader.h"
</span><span class="cx"> #include "DocumentType.h"
</span><span class="cx"> #include "ElementChildIterator.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "FocusController.h"
</span><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "FrameLoader.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMeterElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMeterElement.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMeterElement.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/HTMLMeterElement.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -19,13 +19,13 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> #include "config.h"
</span><del>-#if ENABLE(METER_ELEMENT)
</del><span class="cx"> #include "HTMLMeterElement.h"
</span><span class="cx">
</span><ins>+#if ENABLE(METER_ELEMENT)
+
</ins><span class="cx"> #include "Attribute.h"
</span><span class="cx"> #include "ElementIterator.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "FormDataList.h"
</span><span class="cx"> #include "HTMLDivElement.h"
</span><span class="cx"> #include "HTMLFormElement.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLObjectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLObjectElement.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLObjectElement.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/HTMLObjectElement.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx"> #include "ChromeClient.h"
</span><span class="cx"> #include "ElementIterator.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "FormDataList.h"
</span><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "HTMLDocument.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionElement.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionElement.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/HTMLOptionElement.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx"> #include "HTMLOptionElement.h"
</span><span class="cx">
</span><span class="cx"> #include "Document.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "HTMLDataListElement.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "HTMLOptGroupElement.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionsCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionsCollection.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,9 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "HTMLOptionsCollection.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
-#include "HTMLOptionElement.h"
-
</del><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> HTMLOptionsCollection::HTMLOptionsCollection(HTMLSelectElement& select)
</span><span class="lines">@@ -36,7 +33,7 @@
</span><span class="cx"> return adoptRef(*new HTMLOptionsCollection(select));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-ExceptionOr<void> HTMLOptionsCollection::add(const OptionOrOptGroupElement& element, Optional<HTMLElementOrInt> before)
</del><ins>+ExceptionOr<void> HTMLOptionsCollection::add(const OptionOrOptGroupElement& element, const Optional<HTMLElementOrInt>& before)
</ins><span class="cx"> {
</span><span class="cx"> return selectElement().add(element, before);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionsCollectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionsCollection.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx">
</span><span class="cx"> using OptionOrOptGroupElement = Variant<RefPtr<HTMLOptionElement>, RefPtr<HTMLOptGroupElement>>;
</span><span class="cx"> using HTMLElementOrInt = Variant<RefPtr<HTMLElement>, int>;
</span><del>- WEBCORE_EXPORT ExceptionOr<void> add(const OptionOrOptGroupElement&, Optional<HTMLElementOrInt> before);
</del><ins>+ WEBCORE_EXPORT ExceptionOr<void> add(const OptionOrOptGroupElement&, const Optional<HTMLElementOrInt>& before);
</ins><span class="cx"> WEBCORE_EXPORT void remove(int index);
</span><span class="cx"> void remove(HTMLOptionElement&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLProgressElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLProgressElement.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLProgressElement.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/HTMLProgressElement.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -23,7 +23,6 @@
</span><span class="cx">
</span><span class="cx"> #include "ElementIterator.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "HTMLParserIdioms.h"
</span><span class="cx"> #include "ProgressShadowElement.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -218,7 +218,7 @@
</span><span class="cx"> return lastSelectedListIndex();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-ExceptionOr<void> HTMLSelectElement::add(const OptionOrOptGroupElement& element, Optional<HTMLElementOrInt> before)
</del><ins>+ExceptionOr<void> HTMLSelectElement::add(const OptionOrOptGroupElement& element, const Optional<HTMLElementOrInt>& before)
</ins><span class="cx"> {
</span><span class="cx"> HTMLElement* beforeElement = nullptr;
</span><span class="cx"> if (before) {
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/HTMLSelectElement.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx">
</span><span class="cx"> using OptionOrOptGroupElement = Variant<RefPtr<HTMLOptionElement>, RefPtr<HTMLOptGroupElement>>;
</span><span class="cx"> using HTMLElementOrInt = Variant<RefPtr<HTMLElement>, int>;
</span><del>- WEBCORE_EXPORT ExceptionOr<void> add(const OptionOrOptGroupElement&, Optional<HTMLElementOrInt> before);
</del><ins>+ WEBCORE_EXPORT ExceptionOr<void> add(const OptionOrOptGroupElement&, const Optional<HTMLElementOrInt>& before);
</ins><span class="cx">
</span><span class="cx"> using Node::remove;
</span><span class="cx"> ExceptionOr<void> remove(HTMLOptionElement&);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTextAreaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -33,7 +33,6 @@
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "EventHandler.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "FormController.h"
</span><span class="cx"> #include "FormDataList.h"
</span><span class="cx"> #include "Frame.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasCanvasPatterncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/CanvasPattern.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/CanvasPattern.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/canvas/CanvasPattern.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -26,7 +26,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "CanvasPattern.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "Image.h"
</span><span class="cx"> #include "Pattern.h"
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLContextGrouph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLContextGroup.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLContextGroup.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/canvas/WebGLContextGroup.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -36,8 +36,6 @@
</span><span class="cx"> class WebGLSharedObject;
</span><span class="cx"> class WebGLRenderingContextBase;
</span><span class="cx">
</span><del>-typedef int ExceptionCode;
-
</del><span class="cx"> class WebGLContextGroup final : public RefCounted<WebGLContextGroup> {
</span><span class="cx"> public:
</span><span class="cx"> static Ref<WebGLContextGroup> create();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackAudioTrackh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/AudioTrack.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/AudioTrack.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/track/AudioTrack.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -29,7 +29,6 @@
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx">
</span><span class="cx"> #include "AudioTrackPrivate.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "PlatformExportMacros.h"
</span><span class="cx"> #include "TrackBase.h"
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackTextTrackh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/TextTrack.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/TextTrack.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/track/TextTrack.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "TextTrackCue.h"
</span><span class="cx"> #include "TrackBase.h"
</span><span class="cx"> #include "VTTCue.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVTTCuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VTTCue.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VTTCue.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/track/VTTCue.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -38,6 +38,7 @@
</span><span class="cx"> #include "CSSValueKeywords.h"
</span><span class="cx"> #include "DocumentFragment.h"
</span><span class="cx"> #include "Event.h"
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "HTMLDivElement.h"
</span><span class="cx"> #include "HTMLSpanElement.h"
</span><span class="cx"> #include "Logging.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVTTRegioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VTTRegion.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VTTRegion.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/track/VTTRegion.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -37,6 +37,7 @@
</span><span class="cx"> #include "ClientRect.h"
</span><span class="cx"> #include "DOMTokenList.h"
</span><span class="cx"> #include "ElementChildIterator.h"
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "HTMLDivElement.h"
</span><span class="cx"> #include "HTMLParserIdioms.h"
</span><span class="cx"> #include "Logging.h"
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVideoTrackh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VideoTrack.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VideoTrack.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/html/track/VideoTrack.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,10 +28,8 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "TrackBase.h"
</span><span class="cx"> #include "VideoTrackPrivate.h"
</span><del>-#include <wtf/text/WTFString.h>
</del><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorDOMEditorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/DOMEditor.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/DOMEditor.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/inspector/DOMEditor.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -34,7 +34,6 @@
</span><span class="cx"> #include "DOMPatchSupport.h"
</span><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "Element.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "ExceptionCodeDescription.h"
</span><span class="cx"> #include "InspectorHistory.h"
</span><span class="cx"> #include "Node.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDatabaseAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDatabaseAgent.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDatabaseAgent.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/inspector/InspectorDatabaseAgent.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx"> #include "InspectorDatabaseAgent.h"
</span><span class="cx">
</span><span class="cx"> #include "Database.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "InspectorDatabaseResource.h"
</span><span class="cx"> #include "InstrumentingAgents.h"
</span><span class="cx"> #include "SQLError.h"
</span><span class="lines">@@ -48,12 +47,12 @@
</span><span class="cx"> #include <inspector/InspectorValues.h>
</span><span class="cx"> #include <wtf/Vector.h>
</span><span class="cx">
</span><del>-typedef Inspector::DatabaseBackendDispatcherHandler::ExecuteSQLCallback ExecuteSQLCallback;
-
</del><span class="cx"> using namespace Inspector;
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><ins>+using ExecuteSQLCallback = Inspector::DatabaseBackendDispatcherHandler::ExecuteSQLCallback;
+
</ins><span class="cx"> namespace {
</span><span class="cx">
</span><span class="cx"> void reportTransactionFailed(ExecuteSQLCallback& requestCallback, SQLError* error)
</span><span class="lines">@@ -65,7 +64,7 @@
</span><span class="cx"> requestCallback.sendSuccess(nullptr, nullptr, WTFMove(errorObject));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-class StatementCallback : public SQLStatementCallback {
</del><ins>+class StatementCallback final : public SQLStatementCallback {
</ins><span class="cx"> public:
</span><span class="cx"> static Ref<StatementCallback> create(Ref<ExecuteSQLCallback>&& requestCallback)
</span><span class="cx"> {
</span><span class="lines">@@ -72,9 +71,11 @@
</span><span class="cx"> return adoptRef(*new StatementCallback(WTFMove(requestCallback)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual ~StatementCallback() { }
</del><ins>+private:
+ StatementCallback(Ref<ExecuteSQLCallback>&& requestCallback)
+ : m_requestCallback(WTFMove(requestCallback)) { }
</ins><span class="cx">
</span><del>- bool handleEvent(SQLTransaction*, SQLResultSet* resultSet) override
</del><ins>+ bool handleEvent(SQLTransaction*, SQLResultSet* resultSet) final
</ins><span class="cx"> {
</span><span class="cx"> auto& rowList = resultSet->rows();
</span><span class="cx">
</span><span class="lines">@@ -90,7 +91,6 @@
</span><span class="cx"> case SQLValue::NumberValue: inspectorValue = InspectorValue::create(value.number()); break;
</span><span class="cx"> case SQLValue::NullValue: inspectorValue = InspectorValue::null(); break;
</span><span class="cx"> }
</span><del>-
</del><span class="cx"> values->addItem(WTFMove(inspectorValue));
</span><span class="cx"> }
</span><span class="cx"> m_requestCallback->sendSuccess(WTFMove(columnNames), WTFMove(values), nullptr);
</span><span class="lines">@@ -97,13 +97,10 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-private:
- StatementCallback(Ref<ExecuteSQLCallback>&& requestCallback)
- : m_requestCallback(WTFMove(requestCallback)) { }
</del><span class="cx"> Ref<ExecuteSQLCallback> m_requestCallback;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class StatementErrorCallback : public SQLStatementErrorCallback {
</del><ins>+class StatementErrorCallback final : public SQLStatementErrorCallback {
</ins><span class="cx"> public:
</span><span class="cx"> static Ref<StatementErrorCallback> create(Ref<ExecuteSQLCallback>&& requestCallback)
</span><span class="cx"> {
</span><span class="lines">@@ -110,21 +107,20 @@
</span><span class="cx"> return adoptRef(*new StatementErrorCallback(WTFMove(requestCallback)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual ~StatementErrorCallback() { }
</del><ins>+private:
+ StatementErrorCallback(Ref<ExecuteSQLCallback>&& requestCallback)
+ : m_requestCallback(WTFMove(requestCallback)) { }
</ins><span class="cx">
</span><del>- bool handleEvent(SQLTransaction*, SQLError* error) override
</del><ins>+ bool handleEvent(SQLTransaction*, SQLError* error) final
</ins><span class="cx"> {
</span><span class="cx"> reportTransactionFailed(m_requestCallback.copyRef(), error);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-private:
- StatementErrorCallback(Ref<ExecuteSQLCallback>&& requestCallback)
- : m_requestCallback(WTFMove(requestCallback)) { }
</del><span class="cx"> Ref<ExecuteSQLCallback> m_requestCallback;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class TransactionCallback : public SQLTransactionCallback {
</del><ins>+class TransactionCallback final : public SQLTransactionCallback {
</ins><span class="cx"> public:
</span><span class="cx"> static Ref<TransactionCallback> create(const String& sqlStatement, Ref<ExecuteSQLCallback>&& requestCallback)
</span><span class="cx"> {
</span><span class="lines">@@ -131,9 +127,12 @@
</span><span class="cx"> return adoptRef(*new TransactionCallback(sqlStatement, WTFMove(requestCallback)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual ~TransactionCallback() { }
</del><ins>+private:
+ TransactionCallback(const String& sqlStatement, Ref<ExecuteSQLCallback>&& requestCallback)
+ : m_sqlStatement(sqlStatement)
+ , m_requestCallback(WTFMove(requestCallback)) { }
</ins><span class="cx">
</span><del>- bool handleEvent(SQLTransaction* transaction) override
</del><ins>+ bool handleEvent(SQLTransaction* transaction) final
</ins><span class="cx"> {
</span><span class="cx"> if (!m_requestCallback->isActive())
</span><span class="cx"> return true;
</span><span class="lines">@@ -144,15 +143,12 @@
</span><span class="cx"> transaction->executeSQL(m_sqlStatement, sqlValues, WTFMove(callback), WTFMove(errorCallback));
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><del>-private:
- TransactionCallback(const String& sqlStatement, Ref<ExecuteSQLCallback>&& requestCallback)
- : m_sqlStatement(sqlStatement)
- , m_requestCallback(WTFMove(requestCallback)) { }
</del><ins>+
</ins><span class="cx"> String m_sqlStatement;
</span><span class="cx"> Ref<ExecuteSQLCallback> m_requestCallback;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class TransactionErrorCallback : public SQLTransactionErrorCallback {
</del><ins>+class TransactionErrorCallback final : public SQLTransactionErrorCallback {
</ins><span class="cx"> public:
</span><span class="cx"> static Ref<TransactionErrorCallback> create(Ref<ExecuteSQLCallback>&& requestCallback)
</span><span class="cx"> {
</span><span class="lines">@@ -159,20 +155,20 @@
</span><span class="cx"> return adoptRef(*new TransactionErrorCallback(WTFMove(requestCallback)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual ~TransactionErrorCallback() { }
</del><ins>+private:
+ TransactionErrorCallback(Ref<ExecuteSQLCallback>&& requestCallback)
+ : m_requestCallback(WTFMove(requestCallback)) { }
</ins><span class="cx">
</span><del>- bool handleEvent(SQLError* error) override
</del><ins>+ bool handleEvent(SQLError* error) final
</ins><span class="cx"> {
</span><span class="cx"> reportTransactionFailed(m_requestCallback.get(), error);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><del>-private:
- TransactionErrorCallback(Ref<ExecuteSQLCallback>&& requestCallback)
- : m_requestCallback(WTFMove(requestCallback)) { }
</del><ins>+
</ins><span class="cx"> Ref<ExecuteSQLCallback> m_requestCallback;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-class TransactionSuccessCallback : public VoidCallback {
</del><ins>+class TransactionSuccessCallback final : public VoidCallback {
</ins><span class="cx"> public:
</span><span class="cx"> static Ref<TransactionSuccessCallback> create()
</span><span class="cx"> {
</span><span class="lines">@@ -179,10 +175,8 @@
</span><span class="cx"> return adoptRef(*new TransactionSuccessCallback());
</span><span class="cx"> }
</span><span class="cx">
</span><del>- virtual ~TransactionSuccessCallback() { }
</del><ins>+ bool handleEvent() final { return false; }
</ins><span class="cx">
</span><del>- bool handleEvent() override { return false; }
-
</del><span class="cx"> private:
</span><span class="cx"> TransactionSuccessCallback() { }
</span><span class="cx"> };
</span><span class="lines">@@ -191,13 +185,13 @@
</span><span class="cx">
</span><span class="cx"> void InspectorDatabaseAgent::didOpenDatabase(RefPtr<Database>&& database, const String& domain, const String& name, const String& version)
</span><span class="cx"> {
</span><del>- if (InspectorDatabaseResource* resource = findByFileName(database->fileName())) {
</del><ins>+ if (auto* resource = findByFileName(database->fileName())) {
</ins><span class="cx"> resource->setDatabase(WTFMove(database));
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- RefPtr<InspectorDatabaseResource> resource = InspectorDatabaseResource::create(WTFMove(database), domain, name, version);
- m_resources.set(resource->id(), resource);
</del><ins>+ auto resource = InspectorDatabaseResource::create(WTFMove(database), domain, name, version);
+ m_resources.add(resource->id(), resource.ptr());
</ins><span class="cx"> // Resources are only bound while visible.
</span><span class="cx"> if (m_enabled)
</span><span class="cx"> resource->bind(m_frontendDispatcher.get());
</span><span class="lines">@@ -257,8 +251,7 @@
</span><span class="cx">
</span><span class="cx"> names = Inspector::Protocol::Array<String>::create();
</span><span class="cx">
</span><del>- Database* database = databaseForId(databaseId);
- if (database) {
</del><ins>+ if (auto* database = databaseForId(databaseId)) {
</ins><span class="cx"> for (auto& tableName : database->tableNames())
</span><span class="cx"> names->addItem(tableName);
</span><span class="cx"> }
</span><span class="lines">@@ -271,16 +264,15 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- Database* database = databaseForId(databaseId);
</del><ins>+ auto* database = databaseForId(databaseId);
</ins><span class="cx"> if (!database) {
</span><span class="cx"> requestCallback->sendFailure("Database not found");
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- Ref<SQLTransactionCallback> callback(TransactionCallback::create(query, requestCallback.get()));
- Ref<SQLTransactionErrorCallback> errorCallback(TransactionErrorCallback::create(requestCallback.get()));
- Ref<VoidCallback> successCallback(TransactionSuccessCallback::create());
- database->transaction(WTFMove(callback), WTFMove(errorCallback), WTFMove(successCallback));
</del><ins>+ database->transaction(TransactionCallback::create(query, requestCallback.copyRef()),
+ TransactionErrorCallback::create(requestCallback.copyRef()),
+ TransactionSuccessCallback::create());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String InspectorDatabaseAgent::databaseId(Database* database)
</span><span class="lines">@@ -303,10 +295,10 @@
</span><span class="cx">
</span><span class="cx"> Database* InspectorDatabaseAgent::databaseForId(const String& databaseId)
</span><span class="cx"> {
</span><del>- DatabaseResourcesMap::iterator it = m_resources.find(databaseId);
- if (it == m_resources.end())
</del><ins>+ auto* resource = m_resources.get(databaseId);
+ if (!resource)
</ins><span class="cx"> return nullptr;
</span><del>- return it->value->database();
</del><ins>+ return resource->database();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorIndexedDBAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -43,7 +43,6 @@
</span><span class="cx"> #include "EventListener.h"
</span><span class="cx"> #include "EventNames.h"
</span><span class="cx"> #include "EventTarget.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "IDBBindingUtilities.h"
</span><span class="cx"> #include "IDBCursor.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorStyleSheetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -39,6 +39,7 @@
</span><span class="cx"> #include "ContentSecurityPolicy.h"
</span><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "Element.h"
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "HTMLHeadElement.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "HTMLParserIdioms.h"
</span></span></pre></div>
<a id="trunkSourceWebCorepageFocusControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FocusController.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FocusController.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/page/FocusController.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -37,7 +37,6 @@
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "EventHandler.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "FrameSelection.h"
</span><span class="cx"> #include "FrameTree.h"
</span><span class="cx"> #include "FrameView.h"
</span></span></pre></div>
<a id="trunkSourceWebCorepageLocationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Location.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Location.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/page/Location.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -39,8 +39,6 @@
</span><span class="cx"> class Frame;
</span><span class="cx"> class URL;
</span><span class="cx">
</span><del>-typedef int ExceptionCode;
-
</del><span class="cx"> class Location : public ScriptWrappable, public RefCounted<Location>, public DOMWindowProperty {
</span><span class="cx"> public:
</span><span class="cx"> static Ref<Location> create(Frame* frame) { return adoptRef(*new Location(frame)); }
</span></span></pre></div>
<a id="trunkSourceWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/page/Page.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -41,7 +41,6 @@
</span><span class="cx"> #include "EmptyClients.h"
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "ExtensionStyleSheets.h"
</span><span class="cx"> #include "FileSystem.h"
</span><span class="cx"> #include "FocusController.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationCDMPrivateMediaSourceAVFObjCmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -32,7 +32,6 @@
</span><span class="cx"> #import "CDMSessionAVContentKeySession.h"
</span><span class="cx"> #import "CDMSessionAVStreamSession.h"
</span><span class="cx"> #import "ContentType.h"
</span><del>-#import "ExceptionCode.h"
</del><span class="cx"> #import "MediaPlayerPrivateMediaSourceAVFObjC.h"
</span><span class="cx"> #import "WebCoreSystemInterface.h"
</span><span class="cx"> #import <wtf/NeverDestroyed.h>
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVContentKeySessionmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -30,7 +30,6 @@
</span><span class="cx">
</span><span class="cx"> #import "CDM.h"
</span><span class="cx"> #import "CDMPrivateMediaSourceAVFObjC.h"
</span><del>-#import "ExceptionCode.h"
</del><span class="cx"> #import "FileSystem.h"
</span><span class="cx"> #import "Logging.h"
</span><span class="cx"> #import "MediaPlayer.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVFoundationObjCmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -30,7 +30,6 @@
</span><span class="cx">
</span><span class="cx"> #import "CDM.h"
</span><span class="cx"> #import "CDMSession.h"
</span><del>-#import "ExceptionCode.h"
</del><span class="cx"> #import "MediaPlayer.h"
</span><span class="cx"> #import "MediaPlayerPrivateAVFoundationObjC.h"
</span><span class="cx"> #import "SoftLinking.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationobjcCDMSessionAVStreamSessionmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx"> #import "AVFoundationSPI.h"
</span><span class="cx"> #import "CDM.h"
</span><span class="cx"> #import "CDMPrivateMediaSourceAVFObjC.h"
</span><del>-#import "ExceptionCode.h"
</del><span class="cx"> #import "FileSystem.h"
</span><span class="cx"> #import "Logging.h"
</span><span class="cx"> #import "MediaPlayer.h"
</span></span></pre></div>
<a id="trunkSourceWebCorestorageStorageAreah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/storage/StorageArea.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/storage/StorageArea.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/storage/StorageArea.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> class Frame;
</span><span class="cx"> class SecurityOrigin;
</span><span class="cx"> class StorageSyncManager;
</span><del>-typedef int ExceptionCode;
</del><ins>+
</ins><span class="cx"> enum StorageType { LocalStorage, SessionStorage };
</span><span class="cx">
</span><span class="cx"> class StorageArea : public RefCounted<StorageArea> {
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGCircleElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGCircleElement.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGCircleElement.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/svg/SVGCircleElement.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "SVGCircleElement.h"
</span><span class="cx">
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "FloatPoint.h"
</span><span class="cx"> #include "RenderSVGEllipse.h"
</span><span class="cx"> #include "RenderSVGPath.h"
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGColorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGColor.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGColor.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/svg/SVGColor.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -23,6 +23,7 @@
</span><span class="cx"> #include "SVGColor.h"
</span><span class="cx">
</span><span class="cx"> #include "CSSParser.h"
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "RGBColor.h"
</span><span class="cx"> #include "SVGException.h"
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGPaintcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGPaint.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGPaint.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/svg/SVGPaint.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -22,6 +22,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "SVGPaint.h"
</span><span class="cx">
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "SVGException.h"
</span><span class="cx"> #include "SVGURIReference.h"
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGStyleElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGStyleElement.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGStyleElement.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/svg/SVGStyleElement.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -25,7 +25,6 @@
</span><span class="cx">
</span><span class="cx"> #include "CSSStyleSheet.h"
</span><span class="cx"> #include "Document.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "SVGNames.h"
</span><span class="cx"> #include <wtf/StdLibExtras.h>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgpropertiesSVGListPropertyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/properties/SVGListProperty.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/properties/SVGListProperty.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/svg/properties/SVGListProperty.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -19,6 +19,7 @@
</span><span class="cx">
</span><span class="cx"> #pragma once
</span><span class="cx">
</span><ins>+#include "ExceptionCode.h"
</ins><span class="cx"> #include "SVGException.h"
</span><span class="cx"> #include "SVGPropertyTearOff.h"
</span><span class="cx"> #include "SVGPropertyTraits.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/Worker.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/Worker.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/workers/Worker.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -30,7 +30,6 @@
</span><span class="cx"> #include "ContentSecurityPolicy.h"
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "InspectorInstrumentation.h"
</span><span class="cx"> #include "NetworkStateNotifier.h"
</span><span class="cx"> #include "ResourceResponse.h"
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerMessagingProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -36,7 +36,6 @@
</span><span class="cx"> #include "ErrorEvent.h"
</span><span class="cx"> #include "Event.h"
</span><span class="cx"> #include "EventNames.h"
</span><del>-#include "ExceptionCode.h"
</del><span class="cx"> #include "MessageEvent.h"
</span><span class="cx"> #include "PageGroup.h"
</span><span class="cx"> #include "ScriptExecutionContext.h"
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXMLSerializercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XMLSerializer.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XMLSerializer.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/xml/XMLSerializer.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -20,16 +20,13 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "XMLSerializer.h"
</span><span class="cx">
</span><del>-#include "Document.h"
-#include "ExceptionCode.h"
</del><span class="cx"> #include "markup.h"
</span><del>-#include <wtf/text/WTFString.h>
</del><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> String XMLSerializer::serializeToString(Node& node)
</span><span class="cx"> {
</span><del>- return createMarkup(node, IncludeNode, 0, DoNotResolveURLs, 0, XMLFragmentSerialization);
</del><ins>+ return createMarkup(node, IncludeNode, nullptr, DoNotResolveURLs, nullptr, XMLFragmentSerialization);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXMLSerializerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XMLSerializer.h (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XMLSerializer.h 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebCore/xml/XMLSerializer.h 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -25,18 +25,17 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>- typedef int ExceptionCode;
</del><ins>+class Node;
</ins><span class="cx">
</span><del>- class Node;
</del><ins>+// FIXME: This object has no state, so it seems a waste to allocate and reference count it.
+class XMLSerializer : public RefCounted<XMLSerializer> {
+public:
+ static Ref<XMLSerializer> create() { return adoptRef(*new XMLSerializer); }
</ins><span class="cx">
</span><del>- class XMLSerializer : public RefCounted<XMLSerializer> {
- public:
- static Ref<XMLSerializer> create() { return adoptRef(*new XMLSerializer); }
-
- String serializeToString(Node&);
-
- private:
- XMLSerializer() { }
- };
</del><ins>+ static String serializeToString(Node&);
</ins><span class="cx">
</span><ins>+private:
+ XMLSerializer() = default;
+};
+
</ins><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebKit2/ChangeLog 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -1,5 +1,14 @@
</span><span class="cx"> 2016-11-13 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><ins>+ Remove many includes of ExceptionCode.h
+ https://bugs.webkit.org/show_bug.cgi?id=164706
+
+ Reviewed by Alex Christensen.
+
+ * WebProcess/Storage/StorageAreaImpl.cpp: Removed include of ExceptionCode.h.
+
+2016-11-13 Darin Adler <darin@apple.com>
+
</ins><span class="cx"> Fix exception handling in SQL database code, streamline and update code
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=164685
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessStorageStorageAreaImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp (208687 => 208688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp 2016-11-14 17:46:10 UTC (rev 208687)
+++ trunk/Source/WebKit2/WebProcess/Storage/StorageAreaImpl.cpp 2016-11-14 17:55:57 UTC (rev 208688)
</span><span class="lines">@@ -28,7 +28,6 @@
</span><span class="cx">
</span><span class="cx"> #include "StorageAreaMap.h"
</span><span class="cx"> #include <WebCore/Document.h>
</span><del>-#include <WebCore/ExceptionCode.h>
</del><span class="cx"> #include <WebCore/Frame.h>
</span><span class="cx"> #include <WebCore/Page.h>
</span><span class="cx"> #include <WebCore/SchemeRegistry.h>
</span></span></pre>
</div>
</div>
</body>
</html>