<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208611] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208611">208611</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2016-11-11 14:16:40 -0800 (Fri, 11 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Get rid of old sandbox rules for OS's we no longer support
https://bugs.webkit.org/show_bug.cgi?id=164638
Reviewed by Simon Fraser.
Clean up the various sandbox profiles to get rid of rules that applied to operating system
versions we no longer support, or were added in support of bugs that have long since been
fixed.
This should introduce no change in behavior.
* DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
* Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
* WebProcess/com.apple.WebProcess.sb.in:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2DatabaseProcessmaccomappleWebKitDatabasessbin">trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessmaccomappleWebKitNetworkProcesssbin">trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in</a></li>
<li><a href="#trunkSourceWebKit2PluginProcessmaccomappleWebKitplugincommonsbin">trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in</a></li>
<li><a href="#trunkSourceWebKit2ResourcesPlugInSandboxProfilescomoraclejavaJavaAppletPluginsb">trunk/Source/WebKit2/Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb</a></li>
<li><a href="#trunkSourceWebKit2WebProcesscomappleWebProcesssbin">trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (208610 => 208611)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-11-11 21:59:33 UTC (rev 208610)
+++ trunk/Source/WebKit2/ChangeLog 2016-11-11 22:16:40 UTC (rev 208611)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-11-11 Brent Fulgham <bfulgham@apple.com>
+
+ Get rid of old sandbox rules for OS's we no longer support
+ https://bugs.webkit.org/show_bug.cgi?id=164638
+
+ Reviewed by Simon Fraser.
+
+ Clean up the various sandbox profiles to get rid of rules that applied to operating system
+ versions we no longer support, or were added in support of bugs that have long since been
+ fixed.
+
+ This should introduce no change in behavior.
+
+ * DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
+ * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
+ * PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
+ * Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
+ * WebProcess/com.apple.WebProcess.sb.in:
+
</ins><span class="cx"> 2016-11-11 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> IndexedDB 2.0: "close pending flag" and firing blocked events all need fixing.
</span></span></pre></div>
<a id="trunkSourceWebKit2DatabaseProcessmaccomappleWebKitDatabasessbin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in (208610 => 208611)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in 2016-11-11 21:59:33 UTC (rev 208610)
+++ trunk/Source/WebKit2/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in 2016-11-11 22:16:40 UTC (rev 208611)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><del>-; Copyright (C) 2014 Apple Inc. All rights reserved.
</del><ins>+; Copyright (C) 2014-2016 Apple Inc. All rights reserved.
</ins><span class="cx"> ;
</span><span class="cx"> ; Redistribution and use in source and binary forms, with or without
</span><span class="cx"> ; modification, are permitted provided that the following conditions
</span><span class="lines">@@ -88,8 +88,5 @@
</span><span class="cx"> (if (defined? 'vnode-type)
</span><span class="cx"> (deny file-write-create (vnode-type SYMLINK)))
</span><span class="cx">
</span><del>-;; FIXME: Should be removed once <rdar://problem/16329087> is fixed.
-(deny file-write-xattr (xattr "com.apple.quarantine") (with no-log))
-
</del><span class="cx"> ;; Reserve a namespace for additional protected extended attributes.
</span><span class="cx"> (deny file-read-xattr file-write-xattr (xattr-regex #"^com\.apple\.security\.private\."))
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessmaccomappleWebKitNetworkProcesssbin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (208610 => 208611)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2016-11-11 21:59:33 UTC (rev 208610)
+++ trunk/Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2016-11-11 22:16:40 UTC (rev 208611)
</span><span class="lines">@@ -154,9 +154,6 @@
</span><span class="cx"> (if (defined? 'vnode-type)
</span><span class="cx"> (deny file-write-create (vnode-type SYMLINK)))
</span><span class="cx">
</span><del>-;; FIXME: Should be removed once <rdar://problem/16329087> is fixed.
-(deny file-write-xattr (xattr "com.apple.quarantine") (with no-log))
-
</del><span class="cx"> ;; Reserve a namespace for additional protected extended attributes.
</span><span class="cx"> (deny file-read-xattr file-write-xattr (xattr-regex #"^com\.apple\.security\.private\."))
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2PluginProcessmaccomappleWebKitplugincommonsbin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in (208610 => 208611)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in 2016-11-11 21:59:33 UTC (rev 208610)
+++ trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in 2016-11-11 22:16:40 UTC (rev 208611)
</span><span class="lines">@@ -78,14 +78,6 @@
</span><span class="cx"> (if (not (defined? 'os-version))
</span><span class="cx"> (define os-version (param "_OS_VERSION")))
</span><span class="cx">
</span><del>-;; OS X 10.7 (Lion) compatibility
-(if (not (defined? 'ipc-posix-shm*))
- (define ipc-posix-shm* ipc-posix-shm))
-(if (not (defined? 'ipc-posix-shm-read*))
- (define ipc-posix-shm-read* ipc-posix-shm))
-(if (not (defined? 'ipc-posix-shm-write-data))
- (define ipc-posix-shm-write-data ipc-posix-shm))
-
</del><span class="cx"> ;; Graphics
</span><span class="cx"> (if (defined? 'system-graphics)
</span><span class="cx"> (system-graphics)
</span><span class="lines">@@ -247,10 +239,6 @@
</span><span class="cx"> (local-name "com.apple.tsm.portname")
</span><span class="cx"> (global-name-regex #"_OpenStep$"))
</span><span class="cx">
</span><del>-(if (equal? os-version "10.7")
- (allow mach-lookup
- (global-name "com.apple.system.DirectoryService.membership_v1")))
-
</del><span class="cx"> ;; Configuration directories
</span><span class="cx"> (allow file-read* (subpath (param "PLUGIN_PATH")))
</span><span class="cx"> (allow file-read* (subpath (param "WEBKIT2_FRAMEWORK_DIR")))
</span><span class="lines">@@ -354,29 +342,6 @@
</span><span class="cx"> (define (webkit-microphone)
</span><span class="cx"> (allow device-microphone))
</span><span class="cx">
</span><del>-(if (equal? os-version "10.7")
- (allow ipc-posix-shm)
- (begin
- (if (equal? os-version "10.8")
- (allow ipc-posix-shm*
- (ipc-posix-name "_CS_GSHMEMLOCK")
- (ipc-posix-name "_CS_DSHMEMLOCK")))
- (allow ipc-posix-shm*
- (ipc-posix-name-regex #"^AudioIO")
- (ipc-posix-name-regex #"^CFPBS:")
- (ipc-posix-name "com.apple.ColorSync.Gen.lock")
- (ipc-posix-name "com.apple.ColorSync.Disp.lock")
- (ipc-posix-name "com.apple.ColorSync.Gray2.2")
- (ipc-posix-name "com.apple.ColorSync.sRGB")
- (ipc-posix-name "com.apple.ColorSync.GenGray")
- (ipc-posix-name "com.apple.ColorSync.GenRGB")
- (ipc-posix-name-regex #"^com\.apple\.cs\.")
- (ipc-posix-name-regex #"^ls\."))
- (allow ipc-posix-shm-read*
- (ipc-posix-name-regex #"^/tmp/com\.apple\.csseed\.")
- (ipc-posix-name "FNetwork.defaultStorageSession")
- (ipc-posix-name "apple.shm.notification_center"))))
-
</del><span class="cx"> ;; Silently block access to some resources
</span><span class="cx"> (deny file-read* file-write* (with no-log)
</span><span class="cx"> (subpath "/Network/Library")
</span><span class="lines">@@ -383,9 +348,6 @@
</span><span class="cx"> (subpath "/Network/Applications")
</span><span class="cx"> (home-library-preferences-regex #"/com\.apple\.internetconfig(priv)?\.plist")
</span><span class="cx">
</span><del>- ;; FIXME: Should be removed after <rdar://problem/9422957> is fixed.
- (home-library-literal "/Caches/Cache.db")
-
</del><span class="cx"> ;; FIXME: Should be removed after <rdar://problem/10463881> is fixed.
</span><span class="cx"> (home-library-preferences-literal "/com.apple.LaunchServices.QuarantineEventsV2")
</span><span class="cx"> (home-library-preferences-literal "/com.apple.LaunchServices.QuarantineEventsV2-journal"))
</span></span></pre></div>
<a id="trunkSourceWebKit2ResourcesPlugInSandboxProfilescomoraclejavaJavaAppletPluginsb"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb (208610 => 208611)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb 2016-11-11 21:59:33 UTC (rev 208610)
+++ trunk/Source/WebKit2/Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb 2016-11-11 22:16:40 UTC (rev 208611)
</span><span class="lines">@@ -33,13 +33,6 @@
</span><span class="cx"> (global-name "com.apple.coreservices.launchservicesd")
</span><span class="cx"> (global-name-regex #"^PlaceHolderServerName-"))
</span><span class="cx">
</span><del>-(if (equal? os-version "10.7")
- (begin
- (allow mach-lookup
- (global-name-regex #"^com\.apple\.java\.jrs\.carenderserver"))
- (allow file-read* file-write*
- (home-library-subpath "/Caches/net.java.openjdk.cmd"))))
-
</del><span class="cx"> (allow file-read*
</span><span class="cx"> (literal "/dev/fd")
</span><span class="cx"> (literal "/usr/bin")
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcesscomappleWebProcesssbin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in (208610 => 208611)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in 2016-11-11 21:59:33 UTC (rev 208610)
+++ trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in 2016-11-11 22:16:40 UTC (rev 208611)
</span><span class="lines">@@ -146,14 +146,7 @@
</span><span class="cx"> (ipc-posix-name-regex #"^WebKit Test-"))
</span><span class="cx">
</span><span class="cx"> ;; ColorSync
</span><del>-;; FIXME: Remove names with underscores when possible (see <rdar://problem/13072721>).
</del><span class="cx"> (allow ipc-posix-shm*
</span><del>- (ipc-posix-name "_CS_GSHMEMLOCK")
- (ipc-posix-name "_CS_DSHMEMLOCK")
- (ipc-posix-name "_CSGRAYPROFILE")
- (ipc-posix-name "_CSRGBPROFILE")
- (ipc-posix-name "_CSGENGPROFILE")
- (ipc-posix-name "_CSGENRPROFILE")
</del><span class="cx"> (ipc-posix-name "com.apple.ColorSync.Gen.lock")
</span><span class="cx"> (ipc-posix-name "com.apple.ColorSync.Disp.lock")
</span><span class="cx"> (ipc-posix-name "com.apple.ColorSync.Gray2.2")
</span><span class="lines">@@ -281,9 +274,6 @@
</span><span class="cx"> (if (defined? 'vnode-type)
</span><span class="cx"> (deny file-write-create (vnode-type SYMLINK)))
</span><span class="cx">
</span><del>-;; FIXME: Should be removed once <rdar://problem/16329087> is fixed.
-(deny file-write-xattr (xattr "com.apple.quarantine") (with no-log))
-
</del><span class="cx"> ;; Reserve a namespace for additional protected extended attributes.
</span><span class="cx"> (deny file-read-xattr file-write-xattr (xattr-regex #"^com\.apple\.security\.private\."))
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>