<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[208392] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/208392">208392</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2016-11-04 12:16:31 -0700 (Fri, 04 Nov 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add new 'other' Apple Pay button style
https://bugs.webkit.org/show_bug.cgi?id=164384
rdar://problem/28302528
Reviewed by Dean Jackson.
* DerivedSources.make:
* WebCorePrefix.h:
Add extension points.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Add ApplePayButtonType::Other.
(WebCore::CSSPrimitiveValue::operator ApplePayButtonType):
Add CSSValueOther.
* css/CSSValueKeywords.in:
Add other.
* css/parser/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
Add CSSValueOther.
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
Add CSSValueOther.
* rendering/RenderThemeCocoa.mm:
(WebCore::toPKPaymentButtonType):
Handle ApplePayButtonType::Other.
* rendering/style/RenderStyleConstants.h:
Add ApplePayButtonType::Other.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreDerivedSourcesmake">trunk/Source/WebCore/DerivedSources.make</a></li>
<li><a href="#trunkSourceWebCoreWebCorePrefixh">trunk/Source/WebCore/WebCorePrefix.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSPrimitiveValueMappingsh">trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSValueKeywordsin">trunk/Source/WebCore/css/CSSValueKeywords.in</a></li>
<li><a href="#trunkSourceWebCorecssparserCSSParsercpp">trunk/Source/WebCore/css/parser/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCorecssparserCSSParserFastPathscpp">trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeCocoamm">trunk/Source/WebCore/rendering/RenderThemeCocoa.mm</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStyleConstantsh">trunk/Source/WebCore/rendering/style/RenderStyleConstants.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (208391 => 208392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-11-04 19:16:21 UTC (rev 208391)
+++ trunk/Source/WebCore/ChangeLog 2016-11-04 19:16:31 UTC (rev 208392)
</span><span class="lines">@@ -1,3 +1,40 @@
</span><ins>+2016-11-03 Anders Carlsson <andersca@apple.com>
+
+ Add new 'other' Apple Pay button style
+ https://bugs.webkit.org/show_bug.cgi?id=164384
+ rdar://problem/28302528
+
+ Reviewed by Dean Jackson.
+
+ * DerivedSources.make:
+ * WebCorePrefix.h:
+ Add extension points.
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ Add ApplePayButtonType::Other.
+
+ (WebCore::CSSPrimitiveValue::operator ApplePayButtonType):
+ Add CSSValueOther.
+
+ * css/CSSValueKeywords.in:
+ Add other.
+
+ * css/parser/CSSParser.cpp:
+ (WebCore::isValidKeywordPropertyAndValue):
+ Add CSSValueOther.
+
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ Add CSSValueOther.
+
+ * rendering/RenderThemeCocoa.mm:
+ (WebCore::toPKPaymentButtonType):
+ Handle ApplePayButtonType::Other.
+
+ * rendering/style/RenderStyleConstants.h:
+ Add ApplePayButtonType::Other.
+
</ins><span class="cx"> 2016-11-04 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> slotted() pseudo does not work with ID selector
</span></span></pre></div>
<a id="trunkSourceWebCoreDerivedSourcesmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/DerivedSources.make (208391 => 208392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/DerivedSources.make 2016-11-04 19:16:21 UTC (rev 208391)
+++ trunk/Source/WebCore/DerivedSources.make 2016-11-04 19:16:31 UTC (rev 208392)
</span><span class="lines">@@ -815,6 +815,8 @@
</span><span class="cx">
</span><span class="cx"> -include WebCoreDerivedSourcesAdditions.make
</span><span class="cx">
</span><ins>+-include ApplePayWebCoreDerivedSourcesAdditions.make
+
</ins><span class="cx"> JS_BINDING_IDLS += $(ADDITIONAL_BINDING_IDLS)
</span><span class="cx">
</span><span class="cx"> all : $(ADDITIONAL_BINDING_IDLS:%.idl=JS%.h)
</span><span class="lines">@@ -919,6 +921,7 @@
</span><span class="cx"> WEBCORE_CSS_PROPERTY_NAMES := $(WebCore)/css/CSSPropertyNames.in
</span><span class="cx"> WEBCORE_CSS_VALUE_KEYWORDS := $(WebCore)/css/CSSValueKeywords.in
</span><span class="cx"> WEBCORE_CSS_VALUE_KEYWORDS := $(WEBCORE_CSS_VALUE_KEYWORDS) $(WebCore)/css/SVGCSSValueKeywords.in
</span><ins>+WEBCORE_CSS_VALUE_KEYWORDS_DEFINES := $(FEATURE_DEFINES) $(ADDITIONAL_CSS_VALUE_KEYWORDS_DEFINES)
</ins><span class="cx">
</span><span class="cx"> CSSPropertyNames.h CSSPropertyNames.cpp StyleBuilder.cpp StylePropertyShorthandFunctions.h StylePropertyShorthandFunctions.cpp : makeprop.intermediate
</span><span class="cx"> .INTERMEDIATE : makeprop.intermediate
</span><span class="lines">@@ -930,7 +933,7 @@
</span><span class="cx"> .INTERMEDIATE : makevalues.intermediate
</span><span class="cx"> makevalues.intermediate : $(WEBCORE_CSS_VALUE_KEYWORDS) css/makevalues.pl bindings/scripts/preprocessor.pm $(PLATFORM_FEATURE_DEFINES)
</span><span class="cx"> $(PERL) -pe '' $(WEBCORE_CSS_VALUE_KEYWORDS) > CSSValueKeywords.in
</span><del>- $(PERL) "$(WebCore)/css/makevalues.pl" --defines "$(FEATURE_DEFINES)"
</del><ins>+ $(PERL) "$(WebCore)/css/makevalues.pl" --defines "$(WEBCORE_CSS_VALUE_KEYWORDS_DEFINES)"
</ins><span class="cx">
</span><span class="cx"> # --------
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorePrefixh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCorePrefix.h (208391 => 208392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCorePrefix.h 2016-11-04 19:16:21 UTC (rev 208391)
+++ trunk/Source/WebCore/WebCorePrefix.h 2016-11-04 19:16:31 UTC (rev 208392)
</span><span class="lines">@@ -172,6 +172,10 @@
</span><span class="cx"> #define delete ("if you use new/delete make sure to include config.h at the top of the file"())
</span><span class="cx"> #endif
</span><span class="cx">
</span><ins>+#if USE(APPLE_INTERNAL_SDK)
+#include <WebKitAdditions/ApplePayWebCorePrefixAdditions.h>
+#endif
+
</ins><span class="cx"> /* When C++ exceptions are disabled, the C++ library defines |try| and |catch|
</span><span class="cx"> * to allow C++ code that expects exceptions to build. These definitions
</span><span class="cx"> * interfere with Objective-C++ uses of Objective-C exception handlers, which
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPrimitiveValueMappingsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (208391 => 208392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2016-11-04 19:16:21 UTC (rev 208391)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2016-11-04 19:16:31 UTC (rev 208392)
</span><span class="lines">@@ -5488,6 +5488,10 @@
</span><span class="cx"> case ApplePayButtonType::SetUp:
</span><span class="cx"> m_value.valueID = CSSValueSetUp;
</span><span class="cx"> break;
</span><ins>+ case ApplePayButtonType::Other:
+ m_value.valueID = CSSValueOther;
+ break;
+
</ins><span class="cx"> default:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> break;
</span><span class="lines">@@ -5504,6 +5508,8 @@
</span><span class="cx"> return ApplePayButtonType::Buy;
</span><span class="cx"> case CSSValueSetUp:
</span><span class="cx"> return ApplePayButtonType::SetUp;
</span><ins>+ case CSSValueOther:
+ return ApplePayButtonType::Other;
</ins><span class="cx"> default:
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSValueKeywordsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (208391 => 208392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSValueKeywords.in 2016-11-04 19:16:21 UTC (rev 208391)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in 2016-11-04 19:16:31 UTC (rev 208392)
</span><span class="lines">@@ -1288,6 +1288,7 @@
</span><span class="cx"> plain
</span><span class="cx"> buy
</span><span class="cx"> set-up
</span><ins>+other
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> // font-synthesis
</span></span></pre></div>
<a id="trunkSourceWebCorecssparserCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (208391 => 208392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/parser/CSSParser.cpp 2016-11-04 19:16:21 UTC (rev 208391)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp 2016-11-04 19:16:31 UTC (rev 208392)
</span><span class="lines">@@ -1038,8 +1038,8 @@
</span><span class="cx"> if (valueID == CSSValueWhite || valueID == CSSValueWhiteOutline || valueID == CSSValueBlack)
</span><span class="cx"> return true;
</span><span class="cx"> break;
</span><del>- case CSSPropertyApplePayButtonType: // plain | buy | set-up
- if (valueID == CSSValuePlain || valueID == CSSValueBuy || valueID == CSSValueSetUp)
</del><ins>+ case CSSPropertyApplePayButtonType: // plain | buy | set-up | other
+ if (valueID == CSSValuePlain || valueID == CSSValueBuy || valueID == CSSValueSetUp || valueID == CSSValueOther)
</ins><span class="cx"> return true;
</span><span class="cx"> break;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorecssparserCSSParserFastPathscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (208391 => 208392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2016-11-04 19:16:21 UTC (rev 208391)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2016-11-04 19:16:31 UTC (rev 208392)
</span><span class="lines">@@ -777,8 +777,8 @@
</span><span class="cx"> #if ENABLE(APPLE_PAY)
</span><span class="cx"> case CSSPropertyApplePayButtonStyle: // white | white-outline | black
</span><span class="cx"> return valueID == CSSValueWhite || valueID == CSSValueWhiteOutline || valueID == CSSValueBlack;
</span><del>- case CSSPropertyApplePayButtonType: // plain | buy | set-up
- return valueID == CSSValuePlain || valueID == CSSValueBuy || valueID == CSSValueSetUp;
</del><ins>+ case CSSPropertyApplePayButtonType: // plain | buy | set-up | other
+ return valueID == CSSValuePlain || valueID == CSSValueBuy || valueID == CSSValueSetUp || valueID == CSSValueOther;
</ins><span class="cx"> #endif
</span><span class="cx"> case CSSPropertyWebkitNbspMode: // normal | space
</span><span class="cx"> return valueID == CSSValueNormal || valueID == CSSValueSpace;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeCocoa.mm (208391 => 208392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeCocoa.mm 2016-11-04 19:16:21 UTC (rev 208391)
+++ trunk/Source/WebCore/rendering/RenderThemeCocoa.mm 2016-11-04 19:16:31 UTC (rev 208392)
</span><span class="lines">@@ -78,6 +78,9 @@
</span><span class="cx"> return PKPaymentButtonTypeBuy;
</span><span class="cx"> case ApplePayButtonType::SetUp:
</span><span class="cx"> return PKPaymentButtonTypeSetUp;
</span><ins>+ case ApplePayButtonType::Other:
+ // FIXME: Use a named constant here.
+ return (PKPaymentButtonType)4;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStyleConstantsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyleConstants.h (208391 => 208392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyleConstants.h 2016-11-04 19:16:21 UTC (rev 208391)
+++ trunk/Source/WebCore/rendering/style/RenderStyleConstants.h 2016-11-04 19:16:31 UTC (rev 208392)
</span><span class="lines">@@ -707,6 +707,7 @@
</span><span class="cx"> Plain,
</span><span class="cx"> Buy,
</span><span class="cx"> SetUp,
</span><ins>+ Other,
</ins><span class="cx"> };
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>